Re: [edk2] [PATCH] ShellPkg: Fix type mismatch with GCC

2017-10-29 Thread Gao, Liming
That's good. >-Original Message- >From: Ni, Ruiyu >Sent: Monday, October 30, 2017 1:25 PM >To: Gao, Liming <liming@intel.com>; Alcantara, Paulo <pa...@hp.com>; >Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org >Subject: RE: [PATCH]

Re: [edk2] [PATCH] ShellPkg: Fix type mismatch with GCC

2017-10-29 Thread Gao, Liming
I suggest to rename it and add its implementation in ShellPkg. We don't expect to use the internal function from another library or driver. Another way is to propose adding StrniCmp() API into BaseLib. Thanks Liming >-Original Message- >From: edk2-devel

Re: [edk2] [PATCH] MdePkg/Include: fix incorrect structure definition

2017-10-26 Thread Gao, Liming
Chris: Ni, Ruiyu has sent this patch yesterday. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Chris Ruffin >Sent: Friday, October 27, 2017 9:04 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [PATCH] MdePkg/Include: fix incorrect

Re: [edk2] [PATCH] MdePkg/PciExpress21.h: Fix typo in PCI_REG_PCIE_SLOT_CONTROL

2017-10-26 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Ni, Ruiyu >Sent: Thursday, October 26, 2017 4:08 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [PATCH] MdePkg/PciExpress21.h: Fix typo

Re: [edk2] [PATCH v2] BaseTools/tools_def AARCH64 ARM: disable PIE linking

2017-10-25 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Thursday, October 26, 2017 4:08 AM >To: edk2-devel@lists.01.org >Cc: leif.lindh...@linaro.org; Gao, Liming <liming@intel.com>

Re: [edk2] [PATCH] BaseTools/tools_def AARCH64: disable PIE linking

2017-10-25 Thread Gao, Liming
7 5:55 PM > To: edk2-devel@lists.01.org > Cc: leif.lindh...@linaro.org; Gao, Liming <liming@intel.com>; Zhu, > Yonghong <yonghong@intel.com>; Ard Biesheuvel > <ard.biesheu...@linaro.org> > Subject: [PATCH] BaseTools/tools_def AARCH64: disable PIE linking > >

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: seed temporary stack before entering PEI core

2017-10-23 Thread Gao, Liming
This is for debug purpose. I think UINT32 is OK if AARCH64 can operate 32bit value. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, October 21, 2017 1:19 AM > To: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: seed temporary stack before entering PEI core

2017-10-20 Thread Gao, Liming
Ard: This case is to share the same value between PeiCore and SecCore. I also think it will be better to define one fixed PCD in MdeModulePkg.dec for this value. Could you submit bugzillar to catch this issue first? Thanks Liming > -Original Message- > From: edk2-devel

Re: [edk2] Visual Studio 2017 support

2017-10-18 Thread Gao, Liming
Yes. I have worked out one patch to support VS2017. I will expose it for user evaluation. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Terry Chen >Sent: Wednesday, October 18, 2017 4:32 PM >To: edk2-devel@lists.01.org

Re: [edk2] [PATCH] BaseTools/BuildEnv: override "set -C" (noclobber) in sourcing shell env

2017-10-18 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Wednesday, October 18, 2017 5:13 AM >To: edk2-devel-01 <edk2-devel@lists.01.org> >Cc: Gao, Liming <liming@intel.com>; Thomas Huth &

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: remove ReportStatusCodeLib resolutions

2017-10-17 Thread Gao, Liming
. Thanks Liming > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, October 17, 2017 4:44 PM > To: Gao, Liming <liming@intel.com> > Cc: edk2-devel@lists.01.org; leif.lindh...@linaro.org; sudeep.ho...@arm.com > Subject

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: remove ReportStatusCodeLib resolutions

2017-10-16 Thread Gao, Liming
Ard: MdeModulePkg\Library\RuntimeDxeReportStatusCodeLib\RuntimeDxeReportStatusCodeLib.inf is designed for Runtime driver. If you require StatusCode at runtime, you can use this library instance. Thanks Liming > -Original Message- > From: edk2-devel

Re: [edk2] [Patch] BaseTools: Fix a bug Build directory should relative to WORKSPACE

2017-10-16 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Friday, October 13, 2017 4:32 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: Fix a bug Build directory

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

2017-10-15 Thread Gao, Liming
y, October 13, 2017 2:07 PM >To: Ard Biesheuvel <ard.biesheu...@linaro.org>; Kinney, Michael D ><michael.d.kin...@intel.com>; edk2-devel@lists.01.org; Gao, Liming ><liming@intel.com> >Subject: RE: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian >MMI

Re: [edk2] [Patch 1/3] BaseTools: GenFfs support to get alignment value from SectionFile

2017-10-10 Thread Gao, Liming
PeFileBuffer should free in the end of the function. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, September 29, 2017 9:23 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel

Re: [edk2] [Patch] BaseTools: Fix the Keyword error for in FDF File

2017-10-10 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Monday, October 09, 2017 9:37 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: Fix the Keyword error for in &g

Re: [edk2] [Patch] BaseTools: Fix the bug 'DSC DEFAULT' in report wrongly use FDF value

2017-10-10 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Monday, October 09, 2017 9:37 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: Fix the bug 'DSC DEFAULT' in

Re: [edk2] [Patch] BaseTools: Fix a bug to use module's Name attribute as compare

2017-10-09 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Monday, October 09, 2017 4:14 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: Fix a bug to use module's Nam

Re: [edk2] [PATCH] MdePkg: Add definitions for ACPI 6.2

2017-10-09 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zeng, Star >Sent: Saturday, September 30, 2017 11:11 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com>; >Gao, Liming <

Re: [edk2] [PATCH 0/5] Propagate PEI-phase FV authentication status to DXE

2017-10-09 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zeng, Star >Sent: Wednesday, October 04, 2017 10:21 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star <star.z...@intel.com>; Gao, Liming <liming@intel.com> >Subject

Re: [edk2] Fwd: StartImage with Secure Boot on Self-Signed App

2017-10-09 Thread Gao, Liming
age- >From: David F. [mailto:df7...@gmail.com] >Sent: Friday, October 06, 2017 8:28 AM >To: Gao, Liming <liming@intel.com> >Cc: Gary Lin <g...@suse.com>; edk2-devel@lists.01.org >Subject: Re: [edk2] Fwd: StartImage with Secure Boot on Self-Signed App > >Is t

Re: [edk2] [Patch] FDF Spec: Per PI 1.6 to support FV extended header contain FV used size

2017-09-29 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Thursday, September 28, 2017 2:22 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com>; Kinney, Michael D ><michael.d.kin...@intel.com>; S

Re: [edk2] [Patch V4] BaseTools: PI 1.6 to support FV extended header contain FV used size

2017-09-29 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Saturday, September 30, 2017 1:12 PM >To: edk2-devel@lists.01.org >Cc: Feng, YunhuaX <yunhuax.f...@intel.com>; Gao, Liming ><liming@intel.com> &g

Re: [edk2] [Patch V2] Build spec: add description for build with binary cache

2017-09-29 Thread Gao, Liming
ng <yonghong@intel.com>; edk2-devel@lists.01.org >Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Shaw, Kevin W ><kevin.w.s...@intel.com>; Gao, Liming <liming@intel.com> >Subject: Re: [edk2] [Patch V2] Build spec: add description for build with >binary >cach

Re: [edk2] [Patch V2] Build spec: add description for build with binary cache

2017-09-29 Thread Gao, Liming
Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Shaw, Kevin W ><kevin.w.s...@intel.com>; Gao, Liming <liming@intel.com> >Subject: Re: [edk2] [Patch V2] Build spec: add description for build with >binary >cache > >On 09/19/17 08:48, Yonghong Zhu wrote:

Re: [edk2] [Patch V2] BaseTools: PI 1.6 to support FV extended header contain FV used size

2017-09-29 Thread Gao, Liming
)) ==> (((EFI_FIRMWARE_VOLUME_EXT_ENTRY *)((UIN8 *) ExtHeader + Index)) Thanks Liming >-Original Message- >From: Zhu, Yonghong >Sent: Friday, September 29, 2017 1:20 PM >To: edk2-devel@lists.01.org >Cc: Feng, YunhuaX <yunhuax.f...@intel.com>; Gao, Liming ><liming@intel.com> &

Re: [edk2] [PATCH] MdeModulePkg PeiCore: More debug messages for pre-memory allocations

2017-09-29 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star >Zeng >Sent: Friday, September 29, 2017 2:44 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@int

Re: [edk2] [Patch V2] Build spec: add description for build with binary cache

2017-09-28 Thread Gao, Liming
. Thanks Liming >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, September 28, 2017 7:15 PM >To: Gao, Liming <liming@intel.com>; Zhu, Yonghong ><yonghong@intel.com>; edk2-devel@lists.01.org >Cc: Kinney, Michael D <michael

Re: [edk2] [Patch] BaseTools: PI 1.6 to support FV extended header contain FV used size

2017-09-28 Thread Gao, Liming
directly use value instead of the local variable. >-Original Message- >From: Zhu, Yonghong >Sent: Thursday, September 28, 2017 4:22 PM >To: edk2-devel@lists.01.org >Cc: Feng, YunhuaX <yunhuax.f...@intel.com>; Gao, Liming ><liming@intel.com> >S

Re: [edk2] [Patch V2] Build spec: add description for build with binary cache

2017-09-28 Thread Gao, Liming
age- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, September 28, 2017 4:19 PM >To: Zhu, Yonghong <yonghong@intel.com>; edk2-devel@lists.01.org >Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Shaw, Kevin W ><kevin.w.s...@intel.com>

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/PrintLib: Fix possible negative value left shift

2017-09-27 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Wu, Hao A >Sent: Thursday, September 21, 2017 2:46 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A <hao.a...@intel.com>; Shi, Steven <steven@intel.com>; >Kinney, Michael

Re: [edk2] [PATCH v2 1/6] MdePkg/PrintLib: Fix possible negative value left shift

2017-09-27 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Wu, Hao A >Sent: Thursday, September 21, 2017 2:46 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A <hao.a...@intel.com>; Shi, Steven <steven@intel.com>; >Kinney, Michael

Re: [edk2] [PATCH v2 6/6] MdeModulePkg/AtaAtapiPassThru: Fix possible out of range left shift

2017-09-27 Thread Gao, Liming
devel@lists.01.org >Cc: Wu, Hao A <hao.a...@intel.com>; Dong, Eric <eric.d...@intel.com>; Gao, >Liming <liming@intel.com>; Zeng, Star <star.z...@intel.com> >Subject: RE: [edk2] [PATCH v2 6/6] MdeModulePkg/AtaAtapiPassThru: Fix >possible out of range left

Re: [edk2] [PATCH v2 5/6] MdeModulePkg/Crc32: Fix possible out of range left shift

2017-09-27 Thread Gao, Liming
Hao: I sent another patch to introduce CacluateCrc32() API in BaseLib. It will update MdeModulePkg Crc32 to depend on BaseLib. And, BaseLib CacluateCrc32() has no such logic. So, I think this patch is not necessary. Thanks Liming >-Original Message- >From: edk2-devel

Re: [edk2] [PATCH] [edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek

2017-09-27 Thread Gao, Liming
Yeonsil: Please send the patch by git send-email way. We don't use attachment for patch review. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wei, > David > Sent: Thursday, September 28, 2017 9:50 AM > To: Yoon, Yeon Sil

Re: [edk2] [Patch] BaseTools: Fix the regression bug to build single module

2017-09-27 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zhu, Yonghong > Sent: Wednesday, September 27, 2017 9:22 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject: [Patch] BaseTools: Fix the regress

Re: [edk2] [Patch V2] Build spec: add description for build with binary cache

2017-09-27 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, September 19, 2017 2:48 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com>; Kinney, Michael D ><michael.d.kin...@intel.com>; S

Re: [edk2] [PATCH 1/7] MdePkg/IndustryStandard/Pci23: add vendor-specific capability header

2017-09-27 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, September 26, 2017 3:58 AM > To: edk2-devel-01 <edk2-devel@lists.01.org> > Cc: Justen, Jordan L <jordan.l.jus...@inte

Re: [edk2] [Patch] Build Spec: Build report to display every module's build time

2017-09-25 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zhu, Yonghong > Sent: Monday, September 25, 2017 10:34 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; Kinney, Michael D > <michael.d.kin...@int

Re: [edk2] [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic

2017-09-25 Thread Gao, Liming
Ray: There is no such key. OK, I will keep its usage to TO_START. Thanks Liming > -Original Message- > From: Ni, Ruiyu > Sent: Monday, September 25, 2017 8:44 PM > To: Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org > Subject: RE: [Patch 02/11] FatPkg

Re: [edk2] [PATCH] IntelFrameworkModulePkg FwVolDxe: Support FFS_ATTRIB_DATA_ALIGNMENT_2

2017-09-25 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zeng, Star >Sent: Monday, September 25, 2017 6:15 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star <star.z...@intel.com>; Gao, Liming <liming@intel.com> >Subject: [PATCH] Intel

Re: [edk2] [PATCH 0/2] Follow PI 1.6 to support FFS_ATTRIB_DATA_ALIGNMENT_2

2017-09-25 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zeng, Star >Sent: Friday, September 22, 2017 6:22 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star <star.z...@intel.com>; Gao, Liming <liming@intel.com>; >Zhu, Yonghong <yon

Re: [edk2] [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 toolchain

2017-09-25 Thread Gao, Liming
Ersek [mailto:ler...@redhat.com] >Sent: Monday, September 25, 2017 4:13 PM >To: Gao, Liming <liming@intel.com>; Marvin Häuser ><marvin.haeu...@outlook.com>; edk2-devel@lists.01.org >Subject: Re: [edk2] [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in >CLANG38 toolchain

Re: [edk2] [RFC 0/6] Create central repository for boilerplate configuration

2017-09-24 Thread Gao, Liming
September 24, 2017 12:58 AM >To: Laszlo Ersek <ler...@redhat.com> >Cc: edk2-devel@lists.01.org; Kinney, Michael D ><michael.d.kin...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; >Andrew Fish <af...@apple.com>; Ard Biesheuvel ><ard.biesheu...@l

Re: [edk2] [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 toolchain

2017-09-24 Thread Gao, Liming
, we can return back and figure out the solution. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Marvin H?user >Sent: Friday, September 22, 2017 11:53 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming...

Re: [edk2] [Patch] BaseTools: report build time measured by module of EDKII Build

2017-09-21 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Thursday, September 21, 2017 1:52 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: report build time meas

Re: [edk2] [Patch] BaseTools: extend FFS alignment to 16M

2017-09-21 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Thursday, September 21, 2017 2:01 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: extend FFS alignment to 16

Re: [edk2] [PATCH V5 0/6] Support bitfield in storage of vfr

2017-09-21 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Bi, Dandan >Sent: Wednesday, September 20, 2017 4:39 PM >To: edk2-devel@lists.01.org >Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com> >Subject: [PATCH

Re: [edk2] [PATCH] MdePkg: add ARM/AARCH64 support to BaseCacheMaintenanceLib

2017-09-20 Thread Gao, Liming
; From: Kinney, Michael D > Sent: Thursday, September 21, 2017 1:32 AM > To: Leif Lindholm <leif.lindh...@linaro.org>; Gao, Liming > <liming@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> > Cc: edk2-devel@lists.01.org; Ard Biesheuvel <ard.biesheu...@l

Re: [edk2] [PATCH v2] PeiLib : Inform UEFI memory to Linux

2017-09-20 Thread Gao, Liming
To reserve the memory resource in boot phase and open them for OS phase, after create system resource hob, we can create memory allocation hob to take some range in PEI phase. Then, these ranges will not be allocated in DXE phase, but they will still be reported in UEFI memory map. So, for this

Re: [edk2] [PATCH] MdePkg: add ARM/AARCH64 support to BaseCacheMaintenanceLib

2017-09-20 Thread Gao, Liming
; From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, September 20, 2017 9:23 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > <liming@intel.com>; Ard Biesheuvel > <ard.biesheu...@linaro.org

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

2017-09-20 Thread Gao, Liming
Laszlo: ECC depends on antlr V3.0.1. It can be downloaded from http://www.antlr3.org/download/Python/ After download it, use python setup.py install to install it. I try this way on Windows OS, it can work. Thanks Liming > -Original Message- > From: edk2-devel

Re: [edk2] [Patch V2] BaseTools: Fix a bug to correct SourceFileList

2017-09-19 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Monday, September 18, 2017 12:24 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch V2] BaseTools: Fix a bug to correct S

Re: [edk2] [PATCH] BaseTools/tools_def AARCH64: enable frame pointers for RELEASE builds

2017-09-17 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Saturday, September 16, 2017 3:34 PM >To: Ard Biesheuvel <ard.biesheu...@linaro.org> >Cc: edk2-devel@lists.01.org; Gao, Liming

Re: [edk2] PI 1.6 vs. edk2 - EfiGcdMemoryTypePersistent (EFI_GCD_MEMORY_TYPE)

2017-09-15 Thread Gao, Liming
Rebecca: Thanks for your catch issue. I will provide the patch to fix it. To be compatible, I will keep EfiGcdMemoryTypePersistent and EfiGcdMemoryTypePersistentMemory both. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >

Re: [edk2] [edk2-VfrSpecification PATCH V2] Add union data type and bit fields in VFR Data Struct Definition

2017-09-15 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Bi, Dandan >Sent: Friday, September 15, 2017 3:04 PM >To: edk2-devel@lists.01.org >Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com> >Subject: [edk2-VfrSp

Re: [edk2] StartImage() return value an error or return code ?

2017-09-13 Thread Gao, Liming
Right. UEFI spec defines ExitData format that null terminated string + optional binary data. > -Original Message- > From: David F. [mailto:df7...@gmail.com] > Sent: Wednesday, September 13, 2017 12:07 PM > To: Gao, Liming <liming@intel.com> > Cc: edk2-devel@l

Re: [edk2] [PATCH 2/2] MdeModulePkg/UdfDxe: suppress incorrect compiler warning in ReadFile()

2017-09-13 Thread Gao, Liming
compiler to disable it, like -Wno-unused-but-set-variable. > -Original Message- > From: Zeng, Star > Sent: Thursday, September 14, 2017 9:21 AM > To: Ard Biesheuvel <ard.biesheu...@linaro.org>; Laszlo Ersek > <ler...@redhat.com>; Gao, Liming <liming@in

Re: [edk2] [Patch] BaseTools: add support for BIOS build with binary cache

2017-09-12 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Monday, September 04, 2017 4:44 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: add support for BIOS build with

Re: [edk2] [Patch] Build spec: add description for build with binary cache

2017-09-12 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Monday, September 04, 2017 4:43 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com>; Kinney, Michael D ><michael.d.kin...@intel.com>; S

Re: [edk2] Fwd: StartImage with Secure Boot on Self-Signed App

2017-09-12 Thread Gao, Liming
You can load and start the image based on PeCoffLib APIs in BasePeCoffLib instead of LoadImage() and StartImage() service. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >David F. >Sent: Friday, September 08, 2017 11:34 PM >To: Gary Lin

Re: [edk2] Can't load Refind boot loader inside Secmain UGA Window

2017-09-11 Thread Gao, Liming
NT32 boot to UEFI Shell only. It can't boot to any OS. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >david moheban >Sent: Sunday, September 10, 2017 8:35 AM >To: edk2-devel@lists.01.org >Subject: [edk2] Can't load Refind boot

Re: [edk2] StartImage() return value an error or return code ?

2017-09-11 Thread Gao, Liming
Per UEFI spec, StartImage() has the optional output ExitData. If ExitData is not NULL, the exit status will be from the image. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >David F. >Sent: Friday, September 08, 2017 2:53 PM >To:

Re: [edk2] WARNING: No source level debug

2017-09-10 Thread Gao, Liming
MdeModulePkg.dsc is for package build test, no functionality verification. If you want to verify some module in this Package, you can add it into the platform, such as Nt32 or Ovmf, then see its functionality. >-Original Message- >From: edk2-devel

Re: [edk2] [Patch] BaseTools: Fix a bug for Mixed Pcd value display in the report

2017-09-10 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Sunday, September 10, 2017 4:26 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: Fix a bug for Mixed P

Re: [edk2] [PATCH v2] BaseTools/GCC: set -Wno-unused-const-variables on RELEASE builds

2017-09-08 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Thomas Lamprecht >Sent: Friday, September 08, 2017 3:02 PM >To: edk2-devel@lists.01.org >Cc: Laszlo Ersek <ler...@redha

Re: [edk2] [Patch] BaseTools: correct to use specific arch to generate DSC database

2017-09-07 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Thursday, September 07, 2017 9:29 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.c

Re: [edk2] WARNING: No source level debug

2017-09-07 Thread Gao, Liming
Please check the debuglib instance. MdeModulePkg.dsc sets DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf. This library instance prints the debug message to Console. Nt32.dsc sets

Re: [edk2] [PATCH] BaseTools/GCC5: set -Wno-unused-const-variables on RELEASE builds

2017-09-07 Thread Gao, Liming
ht > Sent: Thursday, September 7, 2017 10:55 PM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek <ler...@redhat.com>; Gao, Liming <liming@intel.com> > Subject: [edk2] [PATCH] BaseTools/GCC5: set -Wno-unused-const-variables on > RELEASE builds > > TianoCore BZ#700 <h

Re: [edk2] [Patch] BaseTools: Not show *B when Pcd value in build option same with DEC

2017-09-07 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, September 04, 2017 4:42 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.c

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-06 Thread Gao, Liming
Laszlo: > * Independently: if the CSM too conflicts with the null detection > feature, then we should probably report an "unsupported configuration" > error for the following case: > > -D NULL_DETECT_ENABLE -D CSM_ENABLE > > But, I don't know if triggering build errors, with custom error >

Re: [edk2] [Patch] MdePkg/PiMmCis.h: Fix build failure.

2017-09-05 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric >Dong >Sent: Wednesday, September 06, 2017 1:54 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.c

Re: [edk2] [Patch] BaseTools: Fix the bug that same region print twice in the build log

2017-09-05 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, September 05, 2017 4:43 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: Fix the bug that same region

Re: [edk2] [Patch] DSC Spec: Hii type Pcd VariableName is NOT allowed to be empty string

2017-09-04 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zhu, Yonghong > Sent: Tuesday, September 5, 2017 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; Kinney, Michael D > <michael.d.kin...@int

Re: [edk2] [PATCH 1/2] MdePkg/BaseIoLibIntrinsic: fix SEV (=unrolled) variants of IoWriteFifoXX()

2017-09-04 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Monday, September 04, 2017 11:57 PM >To: edk2-devel-01 <edk2-devel@lists.01.org> >Cc: Ki

Re: [edk2] [Patch] Build Spec: Add multi-arg support to PREBUILD/POSTBUILD

2017-09-03 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Wednesday, August 30, 2017 5:01 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com>; Kinney, Michael D ><michael.d.kin...@intel.com>; S

Re: [edk2] [Patch] DSC Spec: Add multi-arg support to PREBUILD/POSTBUILD

2017-09-03 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Wednesday, August 30, 2017 5:01 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com>; Kinney, Michael D ><michael.d.kin...@intel.com>; S

Re: [edk2] [Patch] BaseTools: update help info for -Y option to include 'HASH'

2017-09-03 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Monday, September 04, 2017 11:41 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: update help info for -Y o

Re: [edk2] [PATCH] BaseTools/Gcc ARM AARCH64: add support for building device tree binaries

2017-08-31 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >Biesheuvel >Sent: Tuesday, August 29, 2017 9:37 PM >To: edk2-devel@lists.01.org; leif.lindh...@linaro.org; Zhu, Yonghong >

Re: [edk2] [Patch] BaseTools: Enable --whole-archive in GCC tool chain as the default option

2017-08-29 Thread Gao, Liming
Ard: This is the compiler check option, not debug option. I suggest to add it for all configuration. Thanks Liming >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Tuesday, August 29, 2017 12:59 AM >To: Gao, Liming <liming@intel.c

Re: [edk2] [Patch v2 0/2] Add Management Mode infrastructure support.

2017-08-28 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric >Dong >Sent: Monday, August 28, 2017 2:41 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch v2 0/2] Add Manage

Re: [edk2] [PATCH v2 0/5] Add multiple PCI segments configuration access support

2017-08-28 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Ruiyu Ni >Sent: Friday, August 25, 2017 4:57 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [PATCH v2 0/5] Add multiple PC

Re: [edk2] [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 toolchain

2017-08-28 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Shi, Steven >Sent: Wednesday, August 23, 2017 3:01 PM >To: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com> >Cc: Zhu, Yonghong <yonghong@intel.com>; Shi, Steven

Re: [edk2] [Patch] BaseTools: Enable --whole-archive in GCC tool chain as the default option

2017-08-27 Thread Gao, Liming
f >Laszlo Ersek >Sent: Friday, August 25, 2017 7:48 PM >To: Ard Biesheuvel <ard.biesheu...@linaro.org> >Cc: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com> >Subject: Re: [edk2] [Patch] BaseTools: Enable --whole-archive in GCC tool >chain as the default opti

Re: [edk2] [Patch 1/2] MdePkg: Add new definitions for Management Mode.

2017-08-25 Thread Gao, Liming
2017 4:33 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming ><liming@intel.com> >Subject: [Patch 1/2] MdePkg: Add new definitions for Management Mode. > >In PI 1.5 version, system management mode name(SMM) has been chan

Re: [edk2] [Patch] BaseTools/EfiRom: Add multiple device id support

2017-08-24 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, August 22, 2017 3:27 PM >To: edk2-devel@lists.01.org >Cc: Verkamp, Daniel <daniel.verk...@intel.com>; Gao, Liming ><liming@intel.com>; Tomas Pi

Re: [edk2] [Patch] BaseTools: Add the missing -pie link option in GCC tool chain

2017-08-23 Thread Gao, Liming
Laszlo: Thanks for your quick test. I will add Bugzilla in commit log. And, I will let you know once I push this patch. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, August 23, 2017 6:27 PM > To: Gao, Liming <limin

Re: [edk2] [PATCH 0/5] PeiCore: Support pre memory page allocation

2017-08-23 Thread Gao, Liming
Reviewed-by: Star Zeng <star.z...@intel.com> >-Original Message- >From: Zeng, Star >Sent: Saturday, August 19, 2017 12:01 AM >To: edk2-devel@lists.01.org >Cc: Zeng, Star <star.z...@intel.com>; Gao, Liming <liming@intel.com>; Ni, >Ruiyu <r

Re: [edk2] FeatureFlagExpression

2017-08-22 Thread Gao, Liming
Frank: This is unsupported feature. Now, FeatureFlagExpression is ignored. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Wednesday, August 23, 2017 7:55 AM >To: frank@dell.com; edk2-devel@lists.01.org

Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-22 Thread Gao, Liming
Mike: TempRamInitApi() is referred in Library\SecFspSecPlatformLibNull\Ia32\Flat32.nasm. FspSecCoreM, FspSecCoreS and FspSecCoreT all link this library. How about describe this function as the empty implementation? Thanks Liming >-Original Message- >From: edk2-devel

Re: [edk2] [PATCH 1/1] BaseTools/tools_def.template: revert to large code model for X64/GCC5/LTO

2017-08-22 Thread Gao, Liming
sheu...@linaro.org> > Cc: edk2-devel-01 <edk2-devel@lists.01.org>; Alex Williamson > <alex.william...@redhat.com>; Justen, Jordan L > <jordan.l.jus...@intel.com>; Gao, Liming <liming@intel.com>; Kinney, > Michael D <michael.d.kin...@intel.com>; P

Re: [edk2] [PATCH V4 0/3] Add HII Popup Protocol

2017-08-22 Thread Gao, Liming
s and refine > related codes. > > V2: > Updates in pacth 2: > Addstring "ERROR", "WARNING", "INFO" at the top of the message box > to implement the different appearances for different styles of Popup. > Updates in pacth 3: > Update the date info

Re: [edk2] fail to build OVMF with GCC62 in Ubuntu

2017-08-22 Thread Gao, Liming
You can check OvmfPkg\build.sh. The default tool chain is GCC5, not GCC46. Your build uses GCC46 tool chain with GCC62, which is wrong. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >wang xiaofeng >Sent: Tuesday, August 22, 2017 4:26 PM

Re: [edk2] latest basetools build pdb cannot be load by IDA6.95

2017-08-21 Thread Gao, Liming
clude IMAGE_DEBUG_TYPE_ILTCG (= 14) through >the undocumented linker flag /NOCOFFGRPINFO. This means the space is >saved >even in uncompressed images. I'm not aware of any such solution for >IMAGE_DEBUG_TYPE_POGO (= 13) however, so that will still have to be >zeroed. > >On Tue, Aug 22,

Re: [edk2] latest basetools build pdb cannot be load by IDA6.95

2017-08-21 Thread Gao, Liming
, 2017 9:12 AM To: wang xiaofeng <winggundu...@163.com> Cc: Yao, Jiewen <jiewen@intel.com>; Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org Subject: Re:Re:Re: [edk2] latest basetools build pdb cannot be load by IDA6.95 Liming, Do you think we should roll bac

Re: [edk2] latest basetools build pdb cannot be load by IDA6.95

2017-08-21 Thread Gao, Liming
: e4129b0e5897d76885170bec9da996b266f185f9 * BaseTools: Update GenFw to clear unused debug entry generated by VS tool chain https://bugzilla.tianocore.org/show_bug.cgi?id=600 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao <liming@intel.com> Reviewed-by: Yonghong Zhu <yonghong@

Re: [edk2] [PATCH v2 0/6] read-only UDF file system support

2017-08-20 Thread Gao, Liming
l@lists.01.org >Cc: Laszlo Ersek <ler...@redhat.com>; Justen, Jordan L ><jordan.l.jus...@intel.com>; Andrew Fish <af...@apple.com>; Kinney, >Michael D <michael.d.kin...@intel.com>; Gao, Liming ><liming@intel.com>; Zeng, Star <star.z...@intel.com>; Do

Re: [edk2] [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi API

2017-08-17 Thread Gao, Liming
Yes. This way does work. We will update the patch for it. From: Yao, Jiewen Sent: Thursday, August 17, 2017 3:53 PM To: Gao, Liming <liming@intel.com>; Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org Subject: RE: [PATCH] IntelFsp2Pkg: Delete useless external TempRa

Re: [edk2] [Patch 0/2] Add comments for two new added Pcds.

2017-08-16 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric >Dong >Sent: Monday, August 14, 2017 3:23 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch 0/2] Add comments for t

Re: [edk2] [Patch] BaseTools: Fix Segmentation fault: 11 when build AppPkg with XCODE5

2017-08-14 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Monday, August 07, 2017 12:00 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com>; Kinney, Michael D ><michael.d.kin...@intel.com>; An

<    5   6   7   8   9   10   11   12   13   14   >