[edk2] [Patch v5 02/21] FmpDevicePkg: Add library instances

2018-08-01 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg Add library instances for FmpDeviceLib, CapsuleUpdatePolicyLib, and FmpPayloadHeaderLib. Library Classes

[edk2] [Patch v3 08/10] BaseTools/Capsule: Update file header with tool limitations

2018-08-01 Thread Kinney, Michael D
Update file header to state that the tool does not support: * Multiple payloads * Drivers * Vendor code bytes https://bugzilla.tianocore.org/show_bug.cgi?id=1031 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [Patch v3 04/10] BaseTools/Capsule: Remove support for PopulateSystemTable

2018-08-01 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1030 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney Reviewed-by: Yonghong Zhu --- BaseTools/Source/Python/Capsule/GenerateCapsule.py | 8

[edk2] [Patch v3 01/10] BaseTools/Capsule: Add Capsule Generation Tools

2018-08-01 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=945 Based on content from the following branch https://github.com/Microsoft/MS_UEFI/tree/share/beta/CapsuleTools * Convert C tools to Python * Add common python modules to: BaseTools/Source/Python/Common/Uefi/Capsule

[edk2] [Patch v3 06/10] BaseTools/Capsule: Do not support -o with --dump-info

2018-08-01 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1025 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney Reviewed-by: Yonghong Zhu --- BaseTools/Source/Python/Capsule/GenerateCapsule.py | 4

[edk2] [Patch v3 09/10] BaseTools/Capsule: Prevent traceback during signing operations

2018-08-01 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1046 https://bugzilla.tianocore.org/show_bug.cgi?id=1048 https://bugzilla.tianocore.org/show_bug.cgi?id=1050 Remove raise statements that generate Tracebacks that were only intended for development/debug. With the raise statements removed proper

[edk2] [Patch v3 02/10] BaseTools GenerateCapsule: Change property to executable for Linux

2018-08-01 Thread Kinney, Michael D
From: Star Zeng Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by: Michael D Kinney --- BaseTools/BinWrappers/PosixLike/GenerateCapsule | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755

[edk2] [Patch v3 00/10] Add Capsule Generation Tools

2018-08-01 Thread Kinney, Michael D
Signed-off-by: Michael D Kinney Kinney, Michael D (9): BaseTools/Capsule: Add Capsule Generation Tools BaseTools/Capsule: Add max value checks to Capsule Generation tools BaseTools/Capsule: Remove support for PopulateSystemTable BaseTools/Capsule: Fix CertType GUID byte order BaseTools

[edk2] [Patch v3 07/10] BaseTools/Capsule: Update help for --fw-version and --lsv

2018-08-01 Thread Kinney, Michael D
Update help to state that --fw-version and -=-lsv are required for encode operations that sign a payload. https://bugzilla.tianocore.org/show_bug.cgi?id=1029 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [Patch v3 05/10] BaseTools/Capsule: Fix CertType GUID byte order

2018-08-01 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1024 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney Reviewed-by: Yonghong Zhu ---

[edk2] [Patch v3 03/10] BaseTools/Capsule: Add max value checks to Capsule Generation tools

2018-08-01 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1021 https://bugzilla.tianocore.org/show_bug.cgi?id=1022 https://bugzilla.tianocore.org/show_bug.cgi?id=1026 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [Patch v3 10/10] BaseTools/Capsule: Support capsules without a payload header

2018-08-01 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1028 Update --dump-info and --decode to show auth header information even if a payload header is not present. The --decode operation still fails if a payload header is not present. Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao

[edk2] [Patch] BaseTools/BinToPcd: Fix Python 2.7.x compatibility issue

2018-07-31 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1042 Convert Buffer to type bytearray before converting to a string of hex byte values so the type of items in Buffer is consistent for both Python 2.7.x and Python 3.x. Cc: YanYan Sun Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Use local variable to store test key digest size

2018-07-30 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Monday, July 30, 2018 7:27 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg FmpDxe: Use loca

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg: Fix code style issue

2018-07-30 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Monday, July 30, 2018 3:02 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg: Fix code style

Re: [edk2] [PATCH] MdePkg FirmwareManagement.h: Fix code style issue

2018-07-30 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Star Zeng > Sent: Monday, July 30, 2018 2:45 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Bi, > Dandan ; Gao, Liming &g

Re: [edk2] [staging/FmpDevicePkg-master][PATCH V2] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

2018-07-30 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Sunday, July 29, 2018 11:02 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH V2] > FmpDevi

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

2018-07-29 Thread Kinney, Michael D
That proposal looks better. Mike > -Original Message- > From: Zeng, Star > Sent: Sunday, July 29, 2018 10:42 PM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [staging/FmpDevicePkg-master][PATCH] > FmpDevi

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

2018-07-29 Thread Kinney, Michael D
vel@lists.01.org > Cc: Kinney, Michael D ; > Zeng, Star > Subject: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg FmpDxe: Initialize > DeviceLibLowestSupportedVersion > > Update the title to include "[staging/FmpDevicePkg- > master]". > > Thanks, &g

[edk2] [staging/FmpDevicePkg-master 6/8] BaseTools/Capsule: Update file header with tool limitations

2018-07-29 Thread Kinney, Michael D
Update file header to state that the tool does not support: * Multiple payloads * Drivers * Vendor code bytes https://bugzilla.tianocore.org/show_bug.cgi?id=1031 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [staging/FmpDevicePkg-master 7/8] BaseTools/Capsule: Prevent traceback during signing operations

2018-07-29 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1046 https://bugzilla.tianocore.org/show_bug.cgi?id=1048 https://bugzilla.tianocore.org/show_bug.cgi?id=1050 Remove raise statements that generate Tracebacks that were only intended for development/debug. With the raise statements removed proper

[edk2] [staging/FmpDevicePkg-master 4/8] BaseTools/Capsule: Do not support -o with --dump-info

2018-07-29 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1025 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- BaseTools/Source/Python/Capsule/GenerateCapsule.py | 4 1 file changed, 4

[edk2] [staging/FmpDevicePkg-master 8/8] BaseTools/Capsule: Support capsules without a payload header

2018-07-29 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1028 Update --dump-info and --decode to show auth header infomation even if a payload header is not present. The --decode operation still fails if a payload header is not present. Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao

[edk2] [staging/FmpDevicePkg-master 5/8] BaseTools/Capsule: Update help for --fw-version and --lsv

2018-07-29 Thread Kinney, Michael D
Update help to state that --fw-version and -=-lsv are required for encode operations that sign a payload. https://bugzilla.tianocore.org/show_bug.cgi?id=1029 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [staging/FmpDevicePkg-master 3/8] BaseTools/Capsule: Fix CertType GUID byte order

2018-07-29 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1024 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- BaseTools/Source/Python/Common/Uefi/Capsule/FmpAuthHeader.py | 2 +- 1 file changed,

[edk2] [staging/FmpDevicePkg-master 2/8] BaseTools/Capsule: Remove support for PopulateSystemTable

2018-07-29 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1030 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- BaseTools/Source/Python/Capsule/GenerateCapsule.py | 8 +++- 1 file changed, 3

[edk2] [staging/FmpDevicePkg-master 0/8] Fix GenerateCapsule issues

2018-07-29 Thread Kinney, Michael D
://bugzilla.tianocore.org/show_bug.cgi?id=1028 Fix issues found during validation tests of the GenerateCapsule tool Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney Kinney, Michael D (8): BaseTools/Capsule

[edk2] [staging/FmpDevicePkg-master 1/8] BaseTools/Capsule: Add max value checks to Capsule Generation tools

2018-07-29 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1021 https://bugzilla.tianocore.org/show_bug.cgi?id=1022 https://bugzilla.tianocore.org/show_bug.cgi?id=1026 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [staging/FmpDevicePkg-master][PATCH V2] FmpDevicePkg FmpDxe: Add comment in mFmpDeviceLocked's declaration

2018-07-29 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Star Zeng > Sent: Saturday, July 28, 2018 6:51 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Zeng, Star >

Re: [edk2] [staging/FmpDevicePkg-master][PATCH V2 2/2] FmpDevicePkg FmpDxe: Use Attributes to know whether reset is required

2018-07-28 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Friday, July 20, 2018 12:16 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH V2 2/2] > FmpDevicePkg FmpDxe

Re: [edk2] [PATCH] FmpDevicePkg: Remove IPF

2018-07-28 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Friday, July 20, 2018 2:23 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [PATCH] FmpDevicePkg: Remove IPF > > Cc: Michael D Kinney >

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Add comment in mFmpDeviceLocked's declaration

2018-07-28 Thread Kinney, Michael D
if FmpDeviceLock() // returns an error. // Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Star Zeng > Sent: Friday, July 27, 2018 6:59 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Zeng, S

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Check ImageIndex first before Image/ImageSize

2018-07-27 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Friday, July 27, 2018 6:26 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg FmpDxe: Check

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Add NULL check to return Value from GetVariable2

2018-07-27 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Friday, July 27, 2018 6:19 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg FmpDxe: Add NU

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg: Remove DisplayUpdateProgressLib mapping for FmpDxe

2018-07-27 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Friday, July 27, 2018 6:14 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg: Remove DisplayU

Re: [edk2] [PATCH] MdeModulePkg DxeCapsuleLibFmp: Fix typo "EsrtSyncFmp" to "SyncEsrtFmp"

2018-07-27 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Star Zeng > Sent: Friday, July 27, 2018 4:09 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Yao, Jiewen ; Zeng, Sta

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Fix typo "EFI_SECURITY_VIOLATIO"

2018-07-27 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Friday, July 27, 2018 4:14 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg FmpDxe: Fix typ

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg: Add DISABLE_NEW_DEPRECATED_INTERFACES build options

2018-07-27 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Wednesday, July 25, 2018 3:31 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg: Add DISABLE_N

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Add EFI_ABORTED in retval of CheckTheImage()

2018-07-27 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Star Zeng > Sent: Wednesday, July 25, 2018 3:31 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Zeng, Star >

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Check Progress!= NULL before calling Progress(100)

2018-07-27 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Wednesday, July 25, 2018 3:30 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg FmpDxe: Chec

Re: [edk2] [PATCH] FmpDevicePkg: Remove IPF

2018-07-20 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Friday, July 20, 2018 2:23 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [PATCH] FmpDevicePkg: Remove IPF > > Cc: Michael D Kinney >

Re: [edk2] [staging/FmpDevicePkg-master][PATCH 2/2] FmpDevicePkg FmpDxe: Use Attributes to know whether reset is required

2018-07-20 Thread Kinney, Michael D
01.org] > On Behalf Of Star Zeng > Sent: Thursday, July 19, 2018 11:55 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Zeng, > Star > Subject: [edk2] [staging/FmpDevicePkg-master][PATCH 2/2] > FmpDevicePkg FmpDxe: Use Attributes to know whether reset > is requir

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Return 0 when LSV check is not required

2018-07-19 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Thursday, July 19, 2018 3:32 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg > FmpDxe:

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Update function comment for FmpDxeEntryPoint

2018-07-19 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > On Behalf Of Star Zeng > Sent: Thursday, July 19, 2018 3:19 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Zeng, > Star >

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] BaseTools GenerateCapsule: Change property to executable for Linux

2018-07-16 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Star Zeng > Sent: Monday, July 16, 2018 3:42 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Zeng, Star >

[edk2] [staging/FmpDevicePkg-UDK2018] staging/FmpDevicePkg-UDK2018: Update Readme.MD for new branch

2018-07-16 Thread Kinney, Michael D
Update Readme.MD for the FmpDevicePkg-UDK2018 branch in the edk2-staging repository. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- CryptoPkg/Library/OpensslLib/openssl | 2 +- Readme.md| 159

[edk2] [staging/FmpDevicePkg-master] staging/FmpDevicePkg-master: Update Readme.MD for new branch

2018-07-15 Thread Kinney, Michael D
Update Readme.MD for the FmpDevicePkg-master branch in the edk2-staging repository. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- Readme.md | 159 ++ 1 file changed, 159 insertions(+) diff

[edk2] [RFC] EDK II stable tag releases

2018-06-24 Thread Kinney, Michael D
Hello, This is a proposal for periodic stable tags on edk2 repositories. The goal is to produce a stable tag for edk2 repositories every 3 months with the initial proposed dates of 8/10/2018 and 11/16/2018. Each release is preceded by a 2 week quiet period where only commits for critical bug

Re: [edk2] [PATCH v2 1/5] MdeModulePkg/CapsulePei: clean Dcache before consuming capsule data

2018-06-12 Thread Kinney, Michael D
iesheu...@linaro.org] > Sent: Tuesday, June 12, 2018 3:32 AM > To: Kinney, Michael D > Cc: Yao, Jiewen ; edk2- > de...@lists.01.org; Leif Lindholm > ; Zeng, Star > > Subject: Re: [PATCH v2 1/5] MdeModulePkg/CapsulePei: > clean Dcache before consuming capsule data >

Re: [edk2] [Patch] BaseTools: Fix one bug of nest !include parser

2018-06-11 Thread Kinney, Michael D
Tested-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Yonghong Zhu > Sent: Monday, June 11, 2018 6:01 PM > To: edk2-devel@lists.01.org > Cc: Feng, YunhuaX ; Gao, Liming > > Subject: [edk2] [Patch] BaseTools:

Re: [edk2] [PATCH v2 1/5] MdeModulePkg/CapsulePei: clean Dcache before consuming capsule data

2018-06-11 Thread Kinney, Michael D
could be done as added. Mike > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, June 11, 2018 3:01 PM > To: Kinney, Michael D > Cc: Yao, Jiewen ; edk2- > de...@lists.01.org; Leif Lindholm > ; Zeng, Star > >

Re: [edk2] [PATCH v2 1/5] MdeModulePkg/CapsulePei: clean Dcache before consuming capsule data

2018-06-11 Thread Kinney, Michael D
age- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, June 11, 2018 2:29 PM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org; Leif Lindholm > ; Zeng, Star > ; Kinney, Michael D > > Subject: Re: [PATCH v2 1/5] MdeModulePkg/CapsulePei: clean > D

[edk2] [Patch] Vlv2TbltDevicePkg: Set SMM Stack size to 16 KB

2018-06-11 Thread Kinney, Michael D
From: Michael D Kinney Stack overflows were observed at the default SMM stack size of 8 KB. Increase stack size to 16 KB to prevent SMM stack overflows. Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney ---

Re: [edk2] [PATCH v2 2/5] MdeModulePkg/DxeCapsuleLibFmp: permit ProcessCapsules () to be called once

2018-06-11 Thread Kinney, Michael D
t: Monday, June 11, 2018 6:56 AM > To: Ard Biesheuvel > Cc: Kinney, Michael D ; > edk2-devel@lists.01.org; Zeng, Star > ; leif.lindh...@linaro.org > Subject: RE: [edk2] [PATCH v2 2/5] > MdeModulePkg/DxeCapsuleLibFmp: permit ProcessCapsules > () to be called once > > Ah. G

Re: [edk2] [PATCH v2 2/5] MdeModulePkg/DxeCapsuleLibFmp: permit ProcessCapsules () to be called once

2018-06-10 Thread Kinney, Michael D
apsule before EndOfDxe? > > > >> -Original Message----- > >> From: Ard Biesheuvel > [mailto:ard.biesheu...@linaro.org] > >> Sent: Friday, June 8, 2018 8:38 AM > >> To: Yao, Jiewen > >> Cc: edk2-devel@lists.01.org; Kinney, Michael D >

[edk2] [Patch 4/5] BaseTools/BinToPcd: Update for Python 3 compatibility

2018-06-09 Thread Kinney, Michael D
Update to be compatible with both Python 2.x and Python 3.x. Also return error code 1 when an error is detected to support use of this tool in scripts. Cc: Yanyan Sun Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 ---

[edk2] [Patch 2/5] BaseTools/BinToPcd: Clarify error message for --type HII

2018-06-09 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=963 Update error message for --type HII. If either --variable-guid or --variable-name is missing, then print an error message that states that both --variable-guid and --variable-name are required. Cc: Yanyan Sun Cc: Yonghong Zhu Cc: Liming Gao

[edk2] [Patch 0/5] BaseTools/BinToPcd: Multiple clean up tasks

2018-06-09 Thread Kinney, Michael D
Follow PEP-8 indent of 4 spaces. https://www.python.org/dev/peps/pep-0008/ Cc: Yanyan Sun Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Kinney, Michael D (5): BaseTools/BinToPcd: Fix typo in error messages BaseToo

[edk2] [Patch 3/5] BaseTools/BinToPcd: --offset must be 8-byte aligned

2018-06-09 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=974 https://bugzilla.tianocore.org/show_bug.cgi?id=965 Update help to state that --offset must be 8-byte aligned. Verify that --offset is 8-byte aligned and print an error message if it is not 8-byte aligned. Cc: Yanyan Sun Cc: Yonghong Zhu Cc:

[edk2] [Patch 5/5] BaseTools/BinToPcd: Follow PEP-8 indent of 4 spaces

2018-06-09 Thread Kinney, Michael D
https://www.python.org/dev/peps/pep-0008/ Cc: Yanyan Sun Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 --- BaseTools/Scripts/BinToPcd.py | 356 +- 1 file changed, 178

[edk2] [Patch 1/5] BaseTools/BinToPcd: Fix typo in error messages

2018-06-09 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=962 Change "PcdToBin" to "BinToPcd" Cc: Yanyan Sun Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 --- BaseTools/Scripts/BinToPcd.py | 8 1 file changed, 4

Re: [edk2] [PATCH] MdeModulePkg/CapsulePei: clean Dcache before consuming capsule data

2018-06-06 Thread Kinney, Michael D
by capsules. Thanks, Mike > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, June 6, 2018 5:10 AM > To: edk2-devel@lists.01.org > Cc: Leif Lindholm ; Yao, Jiewen > ; Ni, Ruiyu ; > Zeng, Star ; Kinney, Michael D > ; Gao, L

Re: [edk2] [RFC v3 2/4] FmpDevicePkg: Add library instances

2018-06-04 Thread Kinney, Michael D
Jiewen, Good suggestion. I will add then in next version. Mike > -Original Message- > From: Yao, Jiewen > Sent: Monday, June 4, 2018 4:09 PM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Sean Brogan > Subject: RE: [RFC v3 2/4] FmpDevicePkg: Ad

Re: [edk2] [PATCH 0/2] UefiLib: Free HandleBuffer for error path in EfiLocateProtocolBuffer().

2018-06-04 Thread Kinney, Michael D
Series Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Monday, June 4, 2018 3:11 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Gao, Liming > > Subject: [PATCH 0/2] UefiLib: Free Handl

Re: [edk2] [Patch v3 2/3] MdeModulePkg: Add DisplayUpdateProgressLib instances

2018-06-04 Thread Kinney, Michael D
31, 2018 4:09 AM > To: Kinney, Michael D ; Leif > Lindholm > Cc: edk2-devel@lists.01.org; Dong, Eric > ; Zeng, Star > Subject: Re: [edk2] [Patch v3 2/3] MdeModulePkg: Add > DisplayUpdateProgressLib instances > > (+ Leif) > > On 25 May 2018 at 08:1

Re: [edk2] [Patch 1/5] Build Spec: Add !error statement support

2018-06-04 Thread Kinney, Michael D
hu > Sent: Wednesday, May 30, 2018 5:56 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Shaw, Kevin W ; Gao, Liming > > Subject: [edk2] [Patch 1/5] Build Spec: Add !error > statement support > > Cc: Liming Gao > Cc: Michael Kinney > Cc: Kevin W Shaw &

Re: [edk2] [RFC 1/1] BaseTools/Capsule: Add Capsule Generation Tools

2018-05-31 Thread Kinney, Michael D
Liming, The C code was in the original content from MS_UEFI. It may be possible to update GenFds to use the new python modules. I have not investigated this yet. Mike > -Original Message- > From: Gao, Liming > Sent: Thursday, May 31, 2018 7:26 AM > To: Kinney, Michael D ;

Re: [edk2] [RFC v3 0/4] Add FmpDevicePkg

2018-05-30 Thread Kinney, Michael D
into a platform. Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Ard Biesheuvel > Sent: Wednesday, May 30, 2018 12:08 AM > To: Kinney, Michael D > Cc: edk2-devel@lists.01.org; Yao, Jiewen > > Subject: Re:

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue

2018-05-30 Thread Kinney, Michael D
Guo, Can you please provide the old size and the new size in the commit message? Also, what changed that required a larger stack? Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Guo, Mang > Sent: Wednesday, May 30, 2018

Re: [edk2] [PATCH v3 3/5] MdePkg/DxeServicesLib: introduce AllocatePeiAccessiblePages routine

2018-05-29 Thread Kinney, Michael D
that PCD when PEI and DXE are both X64? Thanks, Mike > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, May 29, 2018 8:36 AM > To: Kinney, Michael D ; > Zeng, Star ; Ard Biesheuvel > ; edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > > Subjec

Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

2018-05-29 Thread Kinney, Michael D
. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Ard Biesheuvel > Sent: Tuesday, May 29, 2018 6:08 AM > To: Gao, Liming > Cc: Dong, Eric ; edk2- > de...@lists.01.org; Yao, Jiewen ; > Kinney, Michael D ; Z

Re: [edk2] [Patch 0/5] Remove X86 ASM and S files

2018-05-28 Thread Kinney, Michael D
Liming, This patch series includes removal of ASM and S files from libraries. Should those be removes from this series until NASM is updated? I also see updates to INF files without updates to the Copyright. Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- >

Re: [edk2] [PATCH v2 0/5] Abstract allocation of PEI accessible memory

2018-05-24 Thread Kinney, Michael D
vel@lists.01.org > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Laszlo > Ersek <ler...@redhat.com>; Leif Lindholm > <leif.lindh...@linaro.org>; Kinney, Michael D > <michael.d.kin...@intel.com>; Gao, Liming > <liming@intel.com>; Zeng, Star > &

Re: [edk2] [PATCH 3/6] MdePkg/UefiLib: introduce EfiAllocatePeiAccessiblePages routine

2018-05-22 Thread Kinney, Michael D
el <ard.biesheu...@linaro.org>; Laszlo > Ersek <ler...@redhat.com>; Leif Lindholm > <leif.lindh...@linaro.org>; Kinney, Michael D > <michael.d.kin...@intel.com>; Gao, Liming > <liming@intel.com>; Zeng, Star > <star.z...@intel.com>; Dong, Eric <eric.d...

Re: [edk2] [RFC] Formalize source files to follow DOS format

2018-05-21 Thread Kinney, Michael D
Jaben, Yes. With default behavior is default set and specifying one or more extensions overrides the default set. Mike > -Original Message- > From: Carsey, Jaben > Sent: Monday, May 21, 2018 3:43 PM > To: Kinney, Michael D <michael.d.kin...@intel.com> > Cc

Re: [edk2] [RFC] Formalize source files to follow DOS format

2018-05-21 Thread Kinney, Michael D
Liming, We have a set of standard flags for tools that should always be present. --help -v -q --debug We should also always have the program name, description, version, and copyright. Please see BaseTools/Scripts/BinToPcd.py as an example. It might be useful to have a way to run this tool

Re: [edk2] [PATCH v1 1/1] BaseTools: loop to retry remove when it fails.

2018-05-09 Thread Kinney, Michael D
Jaben, Instead of while TRUE, a timeout count be added so the loop can exit if the file is not released in a reasonable period of time. Perhaps 5 seconds. Timeout = 0.0 while Timeout < 5.0: try: return os.remove(LongFilePath(path)) except:

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-20 Thread Kinney, Michael D
FMP consumers on the same handle as the FMP Protocol so the rules for usage are clear from a consumer perspective. Mike > -Original Message- > From: Zeng, Star > Sent: Thursday, April 19, 2018 9:51 PM > To: Yao, Jiewen <jiewen....@intel.com>; Kinney, Michael

Re: [edk2] [RFC v2 0/4] Add FmpDevicePkg

2018-04-20 Thread Kinney, Michael D
was built and is only used when the LowestSupportedVersion value is not available from any other source. Mike > -Original Message- > From: Zeng, Star > Sent: Thursday, April 19, 2018 9:53 PM > To: Yao, Jiewen <jiewen@intel.com>; Kinney, Michael > D <michael.d.kin.

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-20 Thread Kinney, Michael D
Jiewen, Thanks for the reminder. I will add a 32-bit Version field. Mike > -Original Message- > From: Yao, Jiewen > Sent: Thursday, April 19, 2018 9:23 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; > edk2-devel@lists.01.org > Cc: Sean Brogan &l

Re: [edk2] [RFC v2 0/4] Add FmpDevicePkg

2018-04-20 Thread Kinney, Michael D
How about: LowestSupportedVersionCheckRequired() LockFmpDeviceAtLockEventGuidRequired() Mike > -Original Message- > From: Yao, Jiewen > Sent: Thursday, April 19, 2018 9:18 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; > edk2-devel@lists.01.org > C

[edk2] [RFC v2 3/4] FmpDevicePkg: Add FmpDxe module

2018-04-17 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg The FmpDxe directory contains 2 INF files. FmpDxe.inf is a DXE driver that is used in a platform to add a Firmware

[edk2] [RFC v2 2/4] FmpDevicePkg: Add library instances

2018-04-17 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg Add library instances for FmpDeviceLib, CapsuleUpdatePolicyLib, and FmpPayloadHeaderLib. Library Classes

[edk2] [RFC v2 0/4] Add FmpDevicePkg

2018-04-17 Thread Kinney, Michael D
Protocol instance is customized using libraries and PCDs. Cc: Sean Brogan <sean.bro...@microsoft.com> Cc: Jiewen Yao <jiewen@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> Kinney, Michael D (4):

[edk2] [RFC v2 4/4] FmpDevicePkg: Add DSC file to build all package components

2018-04-17 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg Adds a DSC file that is used to verify that all of the FmpDevicePkg libraries and modules build without error. Cc:

[edk2] [RFC v2 1/4] FmpDevicePkg: Add package, library classes, and PCDs

2018-04-17 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg Create FmpDevicePkg with library classes and PCDs used to customize the behavior of a Firmware Management Protocol

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

2018-04-17 Thread Kinney, Michael D
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, April 17, 2018 6:27 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; > Gao, Liming <liming@intel.com>; Laszlo Ersek > <ler...@redhat.com> > Cc: edk2-devel@li

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

2018-04-16 Thread Kinney, Michael D
I/O. Use BaseIoLib * BE CPU, BE I/O. Use BaseIoLib * LE CPU, BE I/O. Use BaseIoSwapLib * BE CPU, LE I/O. Use BaseIoSwapLib Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, April 16, 2018 3:07 AM > To: Kinney, Michael D <m

Re: [edk2] [PATCH] SignedCapsulePkg SystemFirmwareUpdateDxe: Fix failure caused by d69d922

2018-04-15 Thread Kinney, Michael D
Star, Thanks for fixing these issues. Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> Mike > -Original Message- > From: Yao, Jiewen > Sent: Sunday, April 15, 2018 6:49 PM > To: Zeng, Star <star.z...@intel.com>; edk2- > de...@lists.01.

Re: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek to stewards

2018-04-14 Thread Kinney, Michael D
om>; Laszlo Ersek > <ler...@redhat.com>; Kinney, Michael D > <michael.d.kin...@intel.com> > Subject: [PATCH] Maintainers.txt: add Laszlo Ersek to > stewards > > Cc: Andrew Fish <af...@apple.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: M

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

2018-04-13 Thread Kinney, Michael D
when built for that CPU would perform big endian operations. Am I missing something? Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Leif Lindholm > Sent: Friday, April 13, 2018 12:32 PM > To: Kinney, Michael D

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

2018-04-13 Thread Kinney, Michael D
To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; > Gao, Liming <liming@intel.com>; Laszlo Ersek > <ler...@redhat.com>; udit.ku...@nxp.com > Subject: [PATCH] MdePkg: add big-endian MMIO > BaseBeIoLib > > When performing MMIO to

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

2018-04-12 Thread Kinney, Michael D
Laszlo, I think I would rather see the ECC tool fixed. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Thursday, April 12, 2018 2:34 AM > To: Bi, Dandan ; edk2- > de...@lists.01.org > Cc:

Re: [edk2] [edk2-platforms Patch V2 3/6] SynQuacer/PlatformFlashAccessLib: Add progress API

2018-04-12 Thread Kinney, Michael D
Ard, I agree. I mentioned it in the patch summary. I will add it to the commit log for each patch. Thanks, Mike > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, April 11, 2018 11:18 PM > To: Kinney, Michael D &l

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Kinney, Michael D
Dandan Bi, Is it possible to move the enter/exit event signaling into the FormBrowwer SendForm() function? The current patch set adds these signal calls in all the places that SendForm() is called and if one of these is missed, a notification will be missed. Mike > -Original Message-

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-11 Thread Kinney, Michael D
I have also posted a branch for review. https://github.com/mdkinney/edk2/tree/Bug_801_DisplayUpdateProgressLib_V2 Mike > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, April 11, 2018 5:48 PM > To: edk2-devel@lists.01.org > Cc: Sean Brogan <sean.br

[edk2] [edk2-platforms Patch V2 4/6] AMD/OverdriveBoard: Add DisplayUpdateProgressLib mapping

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney

[edk2] [edk2-platforms Patch V2 2/6] Hisilicon/PlatformFlashAccessLib: Add progress API

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: Ard Biesheuvel

[edk2] [edk2-platforms Patch V2 1/6] Styx/PlatformFlashAccessLib: Add progress API

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: Ard Biesheuvel

[edk2] [edk2-platforms Patch V2 5/6] Socionext/DeveloperBox: Add DisplayUpdateProgressLib mapping

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney

<    1   2   3   4   5   6   7   8   9   10   >