Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

Hello Jiewen, On 01/29/16 13:12, jiewen yao wrote: > This series patches add UEFI2.6 MemoryAttributesTable support. > This table is used to retire old PropertiesTable. > This is standalone table published by DxeCore, so there is no > compatibility issue. > > The patch is validated with or

Re: [edk2] [Patch] BaseTools: Fix the bug for VOID* Patchable PCD declaration in Library

On 01/28/16 00:10, Andrew Fish wrote: > >> On Jan 27, 2016, at 9:33 AM, Laszlo Ersek <ler...@redhat.com> wrote: >> >> On 01/27/16 10:18, Yonghong Zhu wrote: >>> VOID* Patchable PCD in Library has the different declaration from the >>> one in Dri

Re: [edk2] [Patch] BaseTools: Fix the bug for VOID* Patchable PCD declaration in Library

On 01/27/16 10:18, Yonghong Zhu wrote: > VOID* Patchable PCD in Library has the different declaration from the > one in Driver, this issue that will cause GCC LTO build failure. Wow, you managed to build edk2 modules with -flto? How? Is that going to be added to BaseTools? Thanks! Laszlo > >

Re: [edk2] [PATCH] OvmfPkg: Increase default RELEASE build image size to 2MB

Looks good; two nits: On 01/28/16 02:15, Jordan Justen wrote: > Fixes: https://github.com/tianocore/edk2/issues/47 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Bruce Cran <br...@cran.org.uk>

Re: [edk2] [Patch] BaseTools: Fix the bug for VOID* Patchable PCD declaration in Library

age- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, January 28, 2016 1:34 AM > To: Zhu, Yonghong > Cc: edk2-de...@ml01.01.org; Scott Duplichan > Subject: Re: [edk2] [Patch] BaseTools: Fix the bug for VOID* Patchable PCD &g

Re: [edk2] [PATCH 1/3] MdeModulePkg: NvmExpressDxe: clean up NvmeRead() / NvmeWrite() debug msgs

ral, independently of the OVMF feature I'm aiming at in this small series, I'll go ahead and commit this one patch at once. ... SVN r19763. Thank you! Laszlo > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, January 27, 2016 21:40 >

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

rate lives. Thanks Laszlo > > Regards, > Ray > > > -----Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, January 22, 2016 3:56 AM > To: Ryan Harkin <ryan.har...@linaro.org> > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Leif Lindho

Re: [edk2] How to I get access to the "Project Tracker"?

On 02/03/16 00:33, Andrew Fish wrote: > It looks like Laszlo is doing maintenance on bugs, but I can't seem to find > the location of the database? Ooops, been caught red-handed! :) The issue tracker summary page is: https://github.com/tianocore/edk2/issues/ The result list can be filtered in

Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

0ce3cc008ec0.) Would you like me to submit a patch for the dsc include file? Thanks Laszlo > Regards, > Ard. > > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Saturday, January 30, 2016 10:24 AM >> To: Yao, Jiewen >> Cc: edk2

Re: [edk2] Variable length PcdRsa2048Sha256PublicKeyBuffer PCD

Hi Mike, On 01/30/16 17:59, Kinney, Michael D wrote: > Eugene, > > I can address the general PCD question. > > Dynamic PCDs can be stored in 3 different locations. VPD which is > read-only, so the value can not be changed. UEFI Variable which is > non-volatile and read-write, so the value and

Re: [edk2] EFI_IP4_CONFIG2_PROTOCOL [was: Re: [PATCH v2] MdeModulePkg: Update MNP driver to recycle TX buffer asynchronously.]

On 02/01/16 05:11, Josh Triplett wrote: > On Wed, Jan 13, 2016 at 10:24:00AM -0800, Josh Triplett wrote: >> On Wed, Jan 13, 2016 at 01:43:38PM +0100, Laszlo Ersek wrote: >>> I just noticed that the most recent release of BITS provides a >>> standalone HTTP client! >&

Re: [edk2] [patch] SecurityPkg:Use FileExplorerLib in SecureBootConfigDxe

On 02/01/16 10:06, Dandan Bi wrote: > Using existing library FileExplorerLib to replace the same > logic in SecureBootConfigDxe to make the code clear. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- >

Re: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

On 02/01/16 03:51, Fu Siyuan wrote: > This patch update the default MNP TX buffer increasement to 32, so the default > TX pool length is same as the maximum recycled buffer numbers in one UNDI > GetStatus command. Is that MAX_XMIT_BUFFERS in PxeGetStatus()? > Contributed-under: TianoCore

Re: [edk2] [Patch v2 0/3] Fix several issues related to TX buffer recycle

/Universal/Network/SnpDxe/Transmit.c | 3 ++- > 3 files changed, 4 insertions(+), 3 deletions(-) > With the comment in the context of patch #2 cleaned up, as suggested by Sriram (this can occur right before you commit): Series Reviewed-by: Laszlo Er

Re: [edk2] [PATCH v3 2/6] ArmVirPkg: Add FileExplorerLib.inf to the dsc file

ConfigDxe. Now add it to pass build. > > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Eric Dong <eric.d...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <dan

Re: [edk2] [PATCH v3 3/6] OvmfPkg: Add FileExplorerLib.inf to the dsc file

ConfigDxe. Now add it to pass build. > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Eric Dong <eric.d...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <dan

Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

On 01/30/16 01:31, Yao, Jiewen wrote: > Comment below: > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, January 30, 2016 1:13 AM > To: Yao, Jiewen > Cc: edk2-de...@ml01.01.org; Gao, Liming > Subject: Re: [edk2]

Re: [edk2] [PATCH v2] OvmfPkg: Increase default RELEASE build image size to 2MB

On 01/29/16 19:11, Jordan Justen wrote: > Fixes: https://github.com/tianocore/edk2/issues/47 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Bruce Cran <br...@cran.org.uk> > Cc: Lasz

Re: [edk2] [PATCH 3/3] OvmfPkg: QemuBootOrderLib: recognize NVMe devices

y in both this edk2 thread, and the QEMU thread? Thanks! Laszlo > On 2016-01-26 18:36:02, Laszlo Ersek wrote: >> This patch enables QemuBootOrderLib to parse OFW device paths formatted by >> the QEMU patch >> >> nvme: generate OpenFirmware device path in the

Re: [edk2] [patch 6/6] SecurityPkg:Use FileExplorerLib in SecureBootConfigDxe

tom > Secure Boot Options form and ESC will return to PK options form. Sounds good. I recall struggling with the old UI behavior in the OVMF build: enrolling one PK, one KEK, and three DB entries took a *lot* of menu navigation. Acked-by: Laszlo Ersek <ler...@redhat.com> Thanks! La

Re: [edk2] [patch 2/6] ArmVirPkg:Add FileExplorerLib.inf to the dsc file

brary/FileExplorerLib/FileExplorerLib.inf" instance is explicitly restricted: LIBRARY_CLASS = FileExplorerLib|DXE_DRIVER UEFI_APPLICATION and in "ArmVirtQemu.dsc", there are no explicit library class sections for either DXE_DRIVER or UEFI_APPLICATION. So I agree this

Re: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

sis? ** In summary: - "[Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool." --> I propose to drop this patch. Sriram, do you agree? - [edk2] [Patch 2/3] MdeModulePkg: Update DBsize in SNP GetStatus command. --> please explain in the commit message *bo

Re: [edk2] [patch 3/6] OvmfPkg:Add FileExplorerLib.inf to the dsc file

CC'ing Jordan On 02/02/16 03:18, Dandan Bi wrote: > Because SecureBootConfigDxe use FileExplorerLib now,but > FileExplorerLib is not in the dsc file of the package > which use SecureBootConfigDxe.Now add it to pass build. > > Contributed-under: TianoCore Contribution Agreement 1.0 >

Re: [edk2] [patch 0/6] Use FileExplorerLib in SecureBootConfigDxe

On 02/02/16 03:17, Dandan Bi wrote: > Using existing library FileExplorerLib to replace the same > logic in SecureBootConfigDxe.And add FileExplorerLib to > dsc files of related packages which use SecureBootConfigDxe. > > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by:

Re: [edk2] [patch 1/6] ArmPlatformPkg:Add FileExplorerLib.inf to the dsc file

Ard, Leif, can you please review this? Thanks Laszlo On 02/02/16 03:17, Dandan Bi wrote: > Because SecureBootConfigDxe use FileExplorerLib now,but > FileExplorerLib is not in the dsc file of the package > which use SecureBootConfigDxe.Now add it to pass build. > > Contributed-under: TianoCore

Re: [edk2] UEFI Shell: Backspace doesn't work

On 02/02/16 10:09, Bhupesh Sharma wrote: >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Tuesday, February 02, 2016 1:44 PM > >> On 2 February 2016 at 09:05, Bhupesh Sharma >> wrote: >>> Hi, >>> >>> I think some of the edk2 shell users might have

Re: [edk2] [PATCH v2 3/6] OvmfPkg: Add FileExplorerLib.inf to the dsc file

ction > instead of [LibraryClasses] in V1. > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <dandan...@intel.com> > --- > OvmfPkg/Ovm

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

odulePkg's PciHostBridgeDxe, plus an OVMF-specific PciHostBridgeLib instance. The problem is of course patch MdeModulePkg: PciHostBridgeDxe: allow PciHostBridgeLib to prime the GCD map which we've been discussing in this thread. Thanks Laszlo >> -Original Message- >> From:

Re: [edk2] [patch 1/6] ArmPlatformPkg:Add FileExplorerLib.inf to the dsc file

On 02/02/16 16:38, Ryan Harkin wrote: > On 2 February 2016 at 15:06, Laszlo Ersek <ler...@redhat.com> wrote: >> On 02/02/16 15:54, Ryan Harkin wrote: >>> On 2 February 2016 at 08:33, Ard Biesheuvel <ard.biesheu...@linaro.org> >>> wrote: >>>

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

On 02/23/16 16:09, Yao, Jiewen wrote: > Ok, thanks for clarification. > > > > I just answer the last question below: > > -How does the Conclusion follow from Premises 1 through 4? What > guarantees it? > > > > - Premise 1: > OVMF installs memory that is >= 4GB as an untested

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

On 02/23/16 17:47, Ard Biesheuvel wrote: > On 23 February 2016 at 17:06, Laszlo Ersek <ler...@redhat.com> wrote: > [supersnip] >> By that I don't mean *another* new PCD, beyond the ACPI version PCD that >> Ard's patch series already contains -- I mean a more generic PCD tha

Re: [edk2] How to enable SMM in OVMF?

On 02/24/16 07:00, Ni, Ruiyu wrote: > Hi all, > could anyone tell me how to enable SMM in OVMF? > I tried to set the flag SMM_REQUIRE to TRUE but SmmAccessPei > module thinks my HostBridgeDevId cannot support SMM. (Note in advance: the error message is valid; by default QEMU emulates an

[edk2] [PATCH 4/4] MdeModulePkg: RegularExpressionDxe: support free(NULL)

Dong <eric.d...@intel.com> Cc: Qiu Shumin <shumin@intel.com> Cc: Samer El-Haj-Mahmoud <el...@hpe.com> Cc: Yao Jiewen <jiewen@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- Notes: B

[edk2] [PATCH 3/4] CryptoPkg: RuntimeCryptLib: support realloc(NULL, size)

;dw...@infradead.org> Cc: Qin Long <qin.l...@intel.com> Cc: Ting Ye <ting...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- CryptoPkg/Library/BaseCryptLib/SysCall/RuntimeMemAllocation.c | 4 1 file changed, 4 i

[edk2] [PATCH 0/4] free(NULL) and realloc(NULL, size) conformance improvements

;shumin@intel.com> Cc: Samer El-Haj-Mahmoud <el...@hpe.com> Cc: Ting Ye <ting...@intel.com> Cc: Yao Jiewen <jiewen....@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Laszlo Ersek (4): CryptoPkg: BaseCryptLib: support free(NULL) CryptoPkg: RuntimeCryptLi

[edk2] [PATCH 2/4] CryptoPkg: RuntimeCryptLib: support free(NULL)

n Long <qin.l...@intel.com> Cc: Ting Ye <ting...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- CryptoPkg/Library/BaseCryptLib/SysCall/RuntimeMemAllocation.c | 8 +++- 1 file changed, 7 insertions(+), 1

Re: [edk2] How to enable SMM in OVMF?

On 02/24/16 17:06, Laszlo Ersek wrote: > (2) Build OVMF as you always do, but pass "-D SMM_REQUIRE". > (4) The QEMU command line you want (on Windows, i.e., for software > emulation) is: > > qemu-system-x86_64 \ > -machine pc-q35-2.5,smm=on,accel=tcg \

Re: [edk2] [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2f

On 02/24/16 17:26, David Woodhouse wrote: > On Wed, 2016-02-24 at 15:46 +0100, Laszlo Ersek wrote: >> Interestingly, the failure reproduces even when I build OVMF at your >> commit a35e4359d; with identical symptoms. > > Also useful to know; thanks. The first commit that

Re: [edk2] [PATCH v3 1/3] OvmfPkg: VirtioFlush(): return the number of bytes written by the host

Jordan, On 02/22/16 09:00, Ard Biesheuvel wrote: > From: Laszlo Ersek <ler...@redhat.com> > > VirtioLib provides an API for simple, synchronous (request/response-style) > virtio communication. The guest driver builds one descriptor chain, link > for lin

Re: [edk2] [PATCH v3 3/3] ArmVirtPkg: ArmVirtQemu: add driver for Virtio-RNG device

VirtQemu.fdf > @@ -160,6 +160,7 @@ [FV.FvMain] >INF OvmfPkg/VirtioBlkDxe/VirtioBlk.inf >INF OvmfPkg/VirtioNetDxe/VirtioNet.inf >INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf > + INF OvmfPkg/VirtioRngDxe/VirtioRng.inf > ># ># UEFI application (Shell Embedded B

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

DS in MdeModulePkg. Then hopefully we'll have learned enough to migrate ArmVirtPkg too.) Thanks! Laszlo > > Thanks, > Ray > > From: edk2-devel [edk2-devel-boun...@lists.01.org] on behalf of Laszlo Ersek > [ler...@redhat.com] > Sent: Fr

Re: [edk2] [PATCH v2] MdeModulePkg: HiiDatabaseDxe: HiiStringToImage() should not overwrite BltX

ming@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <dandan...@intel.com> > --- > MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 5 ++-

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

essage----- >> From: Marcel Apfelbaum [mailto:marcel.apfelb...@gmail.com] >> Sent: Monday, February 8, 2016 6:56 PM >> To: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek <ler...@redhat.com> >> Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-de...@ml01.

Re: [edk2] [Patch V2 1/2] MdeModulePkg/PciBus: Refine to reduce code lines.

On 02/22/16 03:52, Ni, Ruiyu wrote: > OK.OK.JI will generate V3. > > A improper patch can never escape from your eyes. :) Thank you for making the extra effort! Laszlo > > > > Regards, > > Ray > > > > *From:*edk2-devel [mailto:edk2-devel-boun..

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

de, > EntireRange, > 0x, // Granularity > 0xC000, // Range Minimum > 0x, // Range Maximum > 0x, // Translation Offset >

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

On 02/22/16 12:45, Ard Biesheuvel wrote: > On 22 February 2016 at 11:24, Laszlo Ersek <ler...@redhat.com> wrote: >> On 02/22/16 04:35, Ni, Ruiyu wrote: >>> Ard, >>> So the final decision between you and Jiewen is a new PCD is still needed? >>> If so, could

Re: [edk2] [PATCH] IntelFrameworkModulePkg/Bds: Correct the total RAM calculation

On 02/22/16 13:10, Ryan Harkin wrote: > On 18 February 2016 at 21:07, Jeremy Linton wrote: >> Update the BDS frontpage to pull the RAM ranges from the >> smbios extended size fields when applicable. The RAM calculation >> also needs to take into account all the RAM ranges

Re: [edk2] [PATCH v3 2/3] OvmfPkg: implement UEFI driver for Virtio RNG devices

) says "Both a and b must be the same numerical types". So, just to comply with the letter of the comment, MAX_UINT32 should be cast to UINTN too. No need to post a v4 for this; I think the above change is small enough for you to squash just before you push the series. With the above BufferSize

Re: [edk2] [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2f

On 02/19/16 10:43, Laszlo Ersek wrote: > On 02/19/16 09:59, David Woodhouse wrote: >> On Fri, 2016-02-19 at 07:59 +, Long, Qin wrote: >>> I agree those changes really make sense for better alignment, under >>> both 1.0.2xx and 1.1 HEAD. The final out-of-box su

Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Don't assume resources are added already

I have some code comments as well: > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > .../Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 186 >

Re: [edk2] [PATCH v4 1/2] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

On 02/25/16 18:04, David Woodhouse wrote: > On Thu, 2016-02-25 at 17:16 +0100, Ard Biesheuvel wrote: >> >>> This appears to break the build with VS2008 for me: >>> >>> e:\edk2\mdemodulepkg\universal\acpi\acpitabledxe\acpitableprotocol.c(98 >>> 4) : warning C4701: potentially uninitialized local

Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Don't assume resources are added already

On 02/25/16 10:13, Ruiyu Ni wrote: > + DEBUG_CODE ( > +// > +// Make sure there is a descriptor covering [Base, Base + Length). > +// > +EFI_GCD_MEMORY_SPACE_DESCRIPTOR Descriptor; > +Status = gDS->GetMemorySpaceDescriptor (Base, ); > +ASSERT_EFI_ERROR (Status); > +

Re: [edk2] [Patch V4 3/3] MdeModuelPkg/PciBus: Return AddrTranslationOffset in GetBarAttributes

schmidt <b...@au1.ibm.com> > Cc: Andrew Fish <af...@apple.com> > Cc: Jeff Fan <jeff@intel.com> > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 62 > ++++++ > 1 file changed, 62 insertions(+) Reviewed-by: Laszlo Ersek <ler...@re

Re: [edk2] [patch] ArmVirPkg: Add FileExplorerLib.inf to the dsc file

Dandan, On 02/25/16 08:26, Dandan Bi wrote: > Because SecureBootConfigDxe use FileExplorerLib now, but > FileExplorerLib is not in the dsc file of the package > that use SecureBootConfigDxe. Now add it to pass build. > > > Cc: Laszlo Ersek <ler...@redhat.com> > Cc:

Re: [edk2] [PATCH v4 1/5] ArmVirPkg: Add FileExplorerLib.inf to the QEMU dsc files

dsc has been added, so add the FileExplorerLib.inf > to it. > > > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Eric Dong <eric.d...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed

Re: [edk2] [PATCH 4/4] MdeModulePkg: RegularExpressionDxe: support free(NULL)

On 02/25/16 09:56, Shia, Cinnamon wrote: > Reviewed-By: Cinnamon Shia <cinnamon.s...@hpe.com> Thanks, but actually I noticed an error in this patch: > -Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 25, 2016 5:14 AM > T

[edk2] [PATCH v2] MdeModulePkg: RegularExpressionDxe: support free(NULL)

Dong <eric.d...@intel.com> Cc: Qiu Shumin <shumin@intel.com> Cc: Samer El-Haj-Mahmoud <el...@hpe.com> Cc: Yao Jiewen <jiewen@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- Notes: v2:

Re: [edk2] [PATCH 0/4] free(NULL) and realloc(NULL, size) conformance improvements

On 02/25/16 03:04, David Woodhouse wrote: > On Wed, 2016-02-24 at 22:13 +0100, Laszlo Ersek wrote: >> The free() wrapper in BaseCryptLib has a bug that has been triggered >> by David's recent OpenSSL work. The series fixes the bug, plus >> more instances of the same. >

[edk2] [PATCH v3] MdeModulePkg/PciHostBridge: Don't assume resources are fully NonExistent

ources. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> [ler...@redhat.com: intersection-based implementation] Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> Cc: Ruiyu Ni <ruiyu...@

Re: [edk2] [PATCH v2] MdeModulePkg: RegularExpressionDxe: support free(NULL)

Cinnamon, can you please R-b this version as well? It is trivial, I just wanted to be real clean in this fix. Thanks Laszlo On 02/25/16 11:22, Laszlo Ersek wrote: > The ISO C standard says about free(), > > If ptr is a null pointer, no action occurs. > > This is not true

Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Refine function header comments.

On 02/25/16 04:13, Qiu, Shumin wrote: > Reviewed-by: Qiu Shumin Committed as 63b90643afb19f84e4cd3681a9a402ec65b1cf8d. Thanks Laszlo > > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, February 25, 2016 9:14 AM > To: edk2-devel@lists.01.org > Cc: Ni,

[edk2] [PATCH 01/17] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

iHostBridgeDxe driver about the platform's config space boundaries, so that the driver can recognize and reject out-of-bounds accesses in time. Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Jordan Justen <jordan.l.jus...@intel.com> Cc: Marcel Apfelbaum <mar...@redhat.com> Contributed-un

[edk2] [PATCH 15/17] OvmfPkg: PciHostBridgeLib: initialize RootBus->DevicePath

. Cc: Jordan Justen <jordan.l.jus...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Marcel Apfelbaum <mar...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/Library/PciHostBridgeLib/PciHostBridg

[edk2] [PATCH 13/17] OvmfPkg: PciHostBridgeLib: set bus, IO and 32-bit MMIO windows in RootBus

jus...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Marcel Apfelbaum <mar...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 6 ++ OvmfPkg/

[edk2] [PATCH 17/17] OvmfPkg: switch to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

iam...@redhat.com> Cc: Gerd Hoffmann <kra...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/OvmfPkgIa32.dsc| 8 OvmfPkg/OvmfPkgIa32X64.dsc | 8 OvmfPkg/OvmfPkgX64.dsc | 8 OvmfPkg

[edk2] [PATCH 09/17] OvmfPkg: PciHostBridgeLib: set RootBus->Segment

gt; Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Marcel Apfelbaum <mar...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 + OvmfPkg/Library/PciHostBridgeLib/

[edk2] [PATCH 08/17] OvmfPkg: PciHostBridgeLib: implement PciHostBridgeFreeRootBridges()

ent 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridge

[edk2] [PATCH 06/17] OvmfPkg: clone PciHostBridgeLib from MdeModulePkg's Null instance

ion Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.inf => OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 10 +- MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.c => OvmfPkg/Lib

[edk2] [PATCH 02/17] MdeModulePkg: PciHostBridgeLibNull: rewrap source to 79 characters

Cc: Jordan Justen <jordan.l.jus...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Marcel Apfelbaum <mar...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- MdeModulePkg/Library/PciHostBridgeLibNull/

[edk2] [PATCH 14/17] OvmfPkg: PciHostBridgeLib: set PCI config space boundaries

Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeL

[edk2] [PATCH 11/17] OvmfPkg: PciHostBridgeLib: clear RootBus->DmaAbove4G

: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c b/OvmfPkg/Library/PciHostBridgeLib/PciHost

[edk2] [PATCH 12/17] OvmfPkg: PciHostBridgeLib: set RootBus->AllocationAttributes

m> Cc: Marcel Apfelbaum <mar...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 9 + 1 file changed, 9 insertions(+) diff --git a/OvmfPkg/Libra

[edk2] [PATCH 10/17] OvmfPkg: PciHostBridgeLib: set supported and initial attributes in RootBus

e Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c b/OvmfPkg/Library/PciHostBridgeLib/Pci

[edk2] [PATCH 05/17] OvmfPkg: factor the MMIO aperture shared by all PCI root bridges into PCDs

aperture, hence one pair of PCDs suffices. Cc: Jordan Justen <jordan.l.jus...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Marcel Apfelbaum <mar...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com>

Re: [edk2] [PATCH 01/17] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

On 02/27/16 03:13, Ni, Ruiyu wrote: > Basically I don't agree to add a CFG space range field. > See embedded reply in below. > > Regards, > Ray > >> -Original Message----- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Saturday, February 27, 201

Re: [edk2] [PATCH 00/17] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

latform, as proven by my GPU and sound card assignment test. Thanks! Laszlo > > Regards, > Ray > > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Saturday, February 27, 2016 8:23 AM >> To: edk2-devel-01 <edk2-

Re: [edk2] [PATCH] ArmVirtPkg: ArmVirtQemu: make ACPI support AARCH64 only

cpiPlatformDxe.inf > +!endif Yes, according to the FDF spec, "The [FD], [FV], [Capsule] and [OptionRom] sections cannot specify architectural modifiers" -- and it is shorter this way too. Reviewed-by: Laszlo Ersek <ler...@redhat.com> > ># ># PCI support > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

Wed Jun 3 16:11:47 2015 + ArmVirtPkg: increase memory preallocations to reduce region count I got inspired to do something similar for OvmfPkg myself. Ultimately I never posted the patch for OvmfPkg, because it didn't help much. Here's the commit message, from my local repo: > From b357e

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

ewen > > > > > > *From:*edk2-devel [mailto:edk2-devel-boun...@lists.01.org] *On Behalf Of > *Laszlo Ersek > *Sent:* Tuesday, February 23, 2016 9:41 PM > *To:* Ard Biesheuvel > *Cc:* Ni, Ruiyu; Tian, Feng; graeme.greg...@linaro.org; Justen, Jordan > L; edk2-de...@

Re: [edk2] [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2f

David, On 02/19/16 21:24, David Woodhouse wrote: > On Fri, 2016-02-19 at 14:26 +0100, Laszlo Ersek wrote: >> >> In file included from >> .../CryptoPkg/Library/OpensslLib/openssl/crypto/bn/bn_add.c:59:0: >> .../CryptoPkg/Library/OpensslLib/openssl/crypto/bn/bn_l

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

> >> > >> > Regards, >> > Ray >> > >> > >> >> -Original Message- >> >> From: Marcel Apfelbaum [mailto:marcel.apfelb...@gmail.com] >> >> Sent: Monday, February 8, 2016 6:56 PM >> >> To: Ni, Ruiyu

Re: [edk2] [PATCH v2] MdeModulePkg: RegularExpressionDxe: support free(NULL)

t; -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, February 27, 2016 1:00 AM > To: Shia, Cinnamon > Cc: edk2-devel-01; Eric Dong; Sheng, Cecil (HPS SW); Qiu Shumin; Yao Jiewen; > El-Haj-Mahmoud, Samer > Subject: Re: [edk2] [PATCH v2] Md

Re: [edk2] [PATCH v2] MdeModulePkg: RegularExpressionDxe: support free(NULL)

elements. (Side note: since free() is a standard C function, I used a coding style in the above example that is closer to standard C than to edk2.) Thanks Laszlo > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, February 26, 2016 11:03 PM &g

[edk2] [RFC PATCH v2] MdeModulePkg/PciHostBridge: Don't assume resources are completely missing

ources. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> [ler...@redhat.com: intersection-based implementation] Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> Cc: Ruiyu Ni <ruiyu...@

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

flict(). Unfortunately, the allocation failure in (iv) would be a bug in the driver -- the two root bridges want to *share* the [3.0GB, 3.5GB) MMIO range between them, and the driver should permit it. It is not a resource conflict between the root bridges, but a valid configuration on QEMU. Thanks Laszlo

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

On 02/24/16 11:06, Ni, Ruiyu wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, February 24, 2016 5:40 PM >> To: Ni, Ruiyu <ruiyu...@intel.com>; Marcel Apfelbaum <mar...@redhat.com> >> Cc: Justen, Jor

Re: [edk2] [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2f

On 02/24/16 18:20, Laszlo Ersek wrote: > On 02/24/16 18:12, Laszlo Ersek wrote: > >>> #4 0x7fdf0917 in CRYPTO_free (str=0x0) >>> at CryptoPkg/Library/OpensslLib/openssl-1.0.2f/crypto/mem.c:442 >>> #5 0x7fe20b47 in PKCS7_verify (p7=0x7ee6ff98,

Re: [edk2] [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2f

On 02/24/16 20:30, David Woodhouse wrote: > On Wed, 2016-02-24 at 18:20 +0100, Laszlo Ersek wrote: >> >> Now, in the edk2 build, OPENSSL_free() boils down to a FreePool(). >> However, *unlike* the free() function of the standard C library, >> FreePool() does *

[edk2] [PATCH 13/13] ShellPkg: UefiShellBcfgCommandLib: print optional data with DumpHex()

The DumpHex() function produces very friendly output (known from DMPSTORE, for example); let's use it with "BCFG -v" as well. Cc: Jaben Carsey <jaben.car...@intel.com> Cc: Ryan Harkin <ryan.har...@linaro.org> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off

[edk2] [PATCH 03/13] ShellPkg: UefiShellBcfgCommandLib: hoist NULL-init of DevPath[String]

0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c b/ShellPkg/Library/UefiS

[edk2] [PATCH 05/13] ShellPkg: UefiShellBcfgCommandLib: enforce minimum size for Boot#### and co.

e contents. This patch is meant as a safety improvement. Cc: Jaben Carsey <jaben.car...@intel.com> Cc: Ryan Harkin <ryan.har...@linaro.org> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- ShellPkg/Library/UefiShellBcfgCommandL

[edk2] [PATCH 04/13] ShellPkg: UefiShellBcfgCommandLib: accumulate errors

Harkin <ryan.har...@linaro.org> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [edk2] [PATCH 00/13] ShellPkg: BCFG dump improvements

he subject line, but alas there isn't any room left for that.) Thank you! Laszlo > > -Jaben > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >> Ersek >> Sent: Wednesday, January 20, 2016 5:12 PM &g

[edk2] [PATCH 10/13] ShellPkg: UefiShellBcfgCommandLib: fix reporting of OptionalData

Cc: Ryan Harkin <ryan.har...@linaro.org> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/She

[edk2] [PATCH 12/13] ShellPkg: elevate DumpHex() from Debug1-internal to generic-internal

TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- ShellPkg/Include/Library/ShellCommandLib.h | 16 + ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.h | 16 - ShellPkg/Library/Uef

[edk2] [PATCH 06/13] ShellPkg: UefiShellBcfgCommandLib: address FilePathListLength by name

Harkin <ryan.har...@linaro.org> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) d

[edk2] [PATCH 09/13] ShellPkg: UefiShellBcfgCommandLib: calculate OptionalDataOffset explicitly

Eliminate some more repeated pointer arithmetic. This patch too is only refactoring. Cc: Jaben Carsey <jaben.car...@intel.com> Cc: Ryan Harkin <ryan.har...@linaro.org> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> ---

[edk2] [PATCH 11/13] ShellPkg: UefiShellBcfgCommandLib: fix ShellPrintEx() call site

BCFG, and optional data exist. Cc: Jaben Carsey <jaben.car...@intel.com> Cc: Ryan Harkin <ryan.har...@linaro.org> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgComm

[edk2] [PATCH 01/13] ShellPkg: UefiShellBcfgCommandLib: update whitespace & layout

Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellB

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

_TTY in the above menu option, in the Intel BDS. After that (possibly after a reboot), F9 should also start to work. Can you test this? Thanks Laszlo > > >> Regards, >> Ray >> >> >> -Original Message- >> From: Ryan Harkin [mailto:ryan.har...

<    4   5   6   7   8   9   10   11   12   13   >