Re: [edk2] [PATCH edk2-non-osi v1 0/1] Fix invoke SetMemorySpaceAttributes error bug

2018-08-15 Thread Leif Lindholm
: > > Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug > > > > Reviewed-by: Ard Biesheuvel > > Pushed to edk2-non-osi as 2c4d662506bd..a34ea15dbf31 *scratches head* This push appears to not have taken place. Anyway, Reviewed-by: Leif Lindholm Pushed as 5bc

Re: [edk2] [PATCH edk2-platforms v2 07/43] Hisilicon/D0x: Move IpmiCmdLib to common path of Hisilicon

2018-08-15 Thread Leif Lindholm
For patches 6-7 of this set: Reviewed-by: Leif Lindholm Pushed as 478282ea28..28b685af6e. On Tue, Aug 14, 2018 at 04:08:27PM +0800, Ming Huang wrote: > The IpmiCmdLib is moved to Silicon/Hisilicon in edk2-non-osi, > so update D0x dsc to reflect this. > > Contributed-unde

Re: [edk2] [PATCH edk2-non-osi v2 2/4] Hisilicon/D0x: Move IpmiCmdLib to common path of Hisilicon

2018-08-15 Thread Leif Lindholm
For 1-2 of this set: Reviewed-by: Leif Lindholm Pushed as b9d09208..5bce5602. On Tue, Aug 14, 2018 at 04:04:49PM +0800, Ming Huang wrote: > IpmiCmdLib is used by D0x, so move it to common > path of Hisilicon. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Sign

Re: [edk2] [PATCH v1 edk-platforms 1/3] Silicon/Hi3660: fix LDO9_VSET register definition

2018-08-15 Thread Leif Lindholm
ust a hypothetical one? / Leif > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang > --- > Silicon/Hisilicon/Hi3660/Include/Hi3660.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-15 Thread Leif Lindholm
On Wed, Aug 15, 2018 at 07:08:33PM +0800, Ming wrote: > >>> Yes please. > >>> It would be good if we could have some (common) code to handle the > >>> fluke situation where you end up without your own MAC address. > >>> (So that the node can boot up and report that it is broken.) > >>> But it

Re: [edk2] [PATCH edk2-platforms v1 07/38] Silicon/Hisilicon/D06: Wait for all disk ready

2018-08-15 Thread Leif Lindholm
On Wed, Aug 15, 2018 at 12:01:25PM +0800, Ming wrote: > > > 在 8/14/2018 11:26 PM, Leif Lindholm 写道: > > On Fri, Aug 10, 2018 at 09:44:29AM +0800, Ming wrote: > >>> Which is exactly what an event is for. > >>> At the point where the SAS controller driver i

Re: [edk2] [PATCH edk2/MdePkg v1 1/1] MdePkg Cper.h: Add generic error macros for ARM platform

2018-08-14 Thread Leif Lindholm
RROR_PROC_ISA_ARM_A64 which gives some form of glorious symmetry against the EFI_GENERIC_ERROR_PROC_TYPE_IA32_X64 above :) With either change, as preferred by the package maintainers: Reviewed-by: Leif Lindholm > ///@} > > /// > -- > 2.17.0 > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 0/2] add DwMmcHcDxe driver

2018-08-14 Thread Leif Lindholm
e.c > create mode 100644 > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.c > create mode 100644 > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.c > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > -- > 2.7.4 > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 edk-platforms 0/2] Fix missing PL011UartClockLib

2018-08-14 Thread Leif Lindholm
| 1 + > Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 + > 2 files changed, 2 insertions(+) > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > -- > 2.7.4 > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-14 Thread Leif Lindholm
On Tue, Aug 14, 2018 at 10:38:14AM +0800, Ming wrote: > > > 在 8/9/2018 6:19 PM, Leif Lindholm 写道: > > On Thu, Aug 09, 2018 at 02:16:49PM +0800, Ming wrote: > >>>> +UINT16 crc_tab[256] = { > >>> > >>> CrcTable. > >> > >> Modi

Re: [edk2] [PATCH edk2-platforms v1 27/38] Platform/Hisilicon/D06: Add EarlyConfigPeim peim

2018-08-14 Thread Leif Lindholm
On Tue, Aug 14, 2018 at 10:31:02AM +0800, Ming wrote: > >>> That { goes at the end of the previous line. > >>> > +StartupAp (); > >>> > >>> Hmm. At some point, we want to rename that function, to align with my > >>> comments above. > >> > > As this function is use in several platforms,

Re: [edk2] [PATCH edk2-platforms v1 30/38] Hisilicon/D06: add apei driver

2018-08-14 Thread Leif Lindholm
On Fri, Aug 10, 2018 at 10:46:34AM +0800, Ming wrote: > >> --- /dev/null > >> +++ b/Silicon/Hisilicon/Hi1620/Drivers/Apei/Apei.inf > >> +[sources.common] > >> + Apei.c > > > > Apei.h? > > As Apei.h is included by Apei.c, so I think Apei.h > is no need to add here. Will the build system still

Re: [edk2] [PATCH edk2-platforms v1 07/38] Silicon/Hisilicon/D06: Wait for all disk ready

2018-08-14 Thread Leif Lindholm
On Fri, Aug 10, 2018 at 09:44:29AM +0800, Ming wrote: > > Which is exactly what an event is for. > > At the point where the SAS controller driver is currently updating the > > variable, it can instead call SignalEvent (). > > > > The WaitForDiskReady () function can be changed to wait/check for

Re: [edk2] [PATCH edk2-platforms v1 35/38] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-09 Thread Leif Lindholm
On Thu, Aug 09, 2018 at 11:40:12PM +0800, Ming wrote: > > > 在 8/9/2018 10:44 PM, Leif Lindholm 写道: > > On Thu, Aug 09, 2018 at 10:17:43PM +0800, Ming wrote: > >> > >> > >> 在 8/4/2018 11:20 PM, Leif Lindholm 写道: > >>> On Tue, Jul 24, 2018 at

Re: [edk2] [PATCH edk2-platforms v1 35/38] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-09 Thread Leif Lindholm
On Thu, Aug 09, 2018 at 10:17:43PM +0800, Ming wrote: > > > 在 8/4/2018 11:20 PM, Leif Lindholm 写道: > > On Tue, Jul 24, 2018 at 03:09:19PM +0800, Ming Huang wrote: > >> If install SPCR table, KVM will not output while install or boot > >> some OS, like ubuntu, >

Re: [edk2] [PATCH edk2-platforms v1 33/38] Silicon/Hisilicon/D06: Modify for close slave core clock.

2018-08-09 Thread Leif Lindholm
On Thu, Aug 09, 2018 at 08:15:27PM +0800, Ming wrote: > 在 8/4/2018 11:14 PM, Leif Lindholm 写道: > > On Tue, Jul 24, 2018 at 03:09:17PM +0800, Ming Huang wrote: > >> From: ZhenYao > >> > >> When BIOS booting, the power consumption is too high, so need close >

Re: [edk2] [PATCH edk2-platforms v1 12/38] Silicon/Hisilicon/D06: Stop watchdog

2018-08-09 Thread Leif Lindholm
On Thu, Aug 09, 2018 at 07:40:27PM +0800, Ming wrote: > > > 在 8/3/2018 6:31 PM, Ard Biesheuvel 写道: > > On 24 July 2018 at 09:08, Ming Huang wrote: > >> From: Sun Yuanchen > >> > >> according as watchdog design on D06, watchdog should be > >> stoped befor boot a option. > >> > > > > Why? The

Re: [edk2] [PATCH edk2-platforms v1 27/38] Platform/Hisilicon/D06: Add EarlyConfigPeim peim

2018-08-09 Thread Leif Lindholm
On Thu, Aug 09, 2018 at 03:07:07PM +0800, Ming wrote: > 在 8/4/2018 5:59 PM, Leif Lindholm 写道: > > On Tue, Jul 24, 2018 at 03:09:11PM +0800, Ming Huang wrote: > >> This peim configuare SMMU,AP,MN. > > > > configuare -> configure > > > > I k

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-09 Thread Leif Lindholm
On Thu, Aug 09, 2018 at 02:16:49PM +0800, Ming wrote: > >> +UINT16 crc_tab[256] = { > > > > CrcTable. > > Modify it in v2. > > > Hmm. > > This might be useful to add to a core library/driver/protocol. We > > don't appear to have it yet. This is another note to the universe. > > Do you suggest

Re: [edk2] [PATCH edk2-platforms 1/4] Platform/Solidrun: Add Hummingboard SmBios

2018-08-09 Thread Leif Lindholm
On Thu, Aug 09, 2018 at 05:42:02AM +, Chris Co wrote: > Hi Leif, > > > -Original Message- > > From: Leif Lindholm > > Sent: Tuesday, August 7, 2018 5:50 AM > > To: Chris Co > > Cc: edk2-devel@lists.01.org; Michael D Kinney > > ; Ard Biesheuv

Re: [edk2] [PATCH 00/26] MdeModulePkg Remove redundant functions

2018-08-08 Thread Leif Lindholm
Eric, Star, On Wed, Aug 08, 2018 at 04:46:46PM +0800, shenglei wrote: > A lot of redundant functions which are never calld have been removed.I > manually > search these fuctions in source files to make sure that they are not used > elsewhere. > Also the MdeModulePkg was built to ensure that.

Re: [edk2] [PATCH edk2-platforms v1 13/38] Silicon/Hisilicon/Acpi: Move some macro to PlatformArch.h

2018-08-08 Thread Leif Lindholm
On Wed, Aug 08, 2018 at 08:22:27PM +0800, Ming wrote: > 在 8/3/2018 6:37 PM, Leif Lindholm 写道: > > On Tue, Jul 24, 2018 at 03:08:57PM +0800, Ming Huang wrote: > >> From: Sun Yuanchen > >> > >> ARM_ACPI_HEADER is used by a unify module in other Pkg, > > &

Re: [edk2] [PATCH edk2-platforms v1 07/38] Silicon/Hisilicon/D06: Wait for all disk ready

2018-08-08 Thread Leif Lindholm
On Wed, Aug 08, 2018 at 07:44:36PM +0800, Ming wrote: > > > 在 8/8/2018 5:59 PM, Leif Lindholm 写道: > > On Wed, Aug 08, 2018 at 05:02:15PM +0800, Ming wrote: > >> 在 8/3/2018 1:36 AM, Leif Lindholm 写道: > >>> On Tue, Jul 24, 2018 at 03:08:51PM +0800, Ming Huang

Re: [edk2] [PATCH edk2-platforms v1 09/38] Hisilicon/D06: Add Debug Serial Port Init Driver

2018-08-08 Thread Leif Lindholm
On Wed, Aug 08, 2018 at 03:37:23PM +0800, Ming wrote: > > > 在 8/3/2018 2:10 AM, Leif Lindholm 写道: > > On Tue, Jul 24, 2018 at 03:08:53PM +0800, Ming Huang wrote: > >> From: Yan Zhang > >> > >> Debug serial port init driver is added to initilize debug

Re: [edk2] [PATCH edk2-platforms v1 07/38] Silicon/Hisilicon/D06: Wait for all disk ready

2018-08-08 Thread Leif Lindholm
On Wed, Aug 08, 2018 at 05:02:15PM +0800, Ming wrote: > 在 8/3/2018 1:36 AM, Leif Lindholm 写道: > > On Tue, Jul 24, 2018 at 03:08:51PM +0800, Ming Huang wrote: > >> This patch is relative to D06 SasDxe driver. The SasDxe set a > >> variable to notice this libray. H

Re: [edk2] [PATCH edk2-platforms v1 06/38] Hisilicon/D06: Add OemMiscLibD06

2018-08-08 Thread Leif Lindholm
On Wed, Aug 08, 2018 at 11:49:41AM +0800, Ming wrote: > > 在 8/3/2018 1:22 AM, Leif Lindholm 写道: > > On Tue, Jul 24, 2018 at 03:08:50PM +0800, Ming Huang wrote: > >> This library include BoardFeatureD06.c and OemMiscLibD06.c c file, > >> use for several modules li

Re: [edk2] [PATCH edk2-platforms v1 04/38] Platform/Hisilicon/D06: Add M41T83RealTimeClockLib

2018-08-08 Thread Leif Lindholm
On Wed, Aug 08, 2018 at 04:02:56PM +0800, Ming wrote: > >> diff --git > >> a/Platform/Hisilicon/D06/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c > >> > >> b/Platform/Hisilicon/D06/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c > >> new file mode 100644 > >> index

Re: [edk2] [PATCH edk2-non-osi v1 1/1] Hisilicon/D02: Remove D02 platform

2018-08-08 Thread Leif Lindholm
On Tue, Aug 07, 2018 at 10:25:26PM +0800, Ming Huang wrote: > D02 is no need to maintain now, so remove D02 platform binary. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm Pushed as b9d09208. Thanks!

Re: [edk2] [PATCH edk2-platforms v1 0/2] Modify following Switch generic PciHostBridge

2018-08-08 Thread Leif Lindholm
ap-width of the instructions from https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 as well please :) For the series: Reviewed-by: Leif Lindholm Pushed as d346a222df..478282ea28. NOTE: I changed the order of the patc

Re: [edk2] [PATCH edk2-platforms] Silicon/Hisilicon: add PlatformBootManagerUnableToBoot() to PlatformBm

2018-08-08 Thread Leif Lindholm
On Tue, Aug 07, 2018 at 10:52:59PM +0200, Ard Biesheuvel wrote: > On 7 August 2018 at 22:51, Leif Lindholm wrote: > > edk2 commit 1010873becc5, > > ("MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()") broke the > > d0x build, since they use their own Pl

Re: [edk2] [PATCH edk2-non-osi v1 1/1] Hisilicon/D06: Add binary modules

2018-08-08 Thread Leif Lindholm
On Wed, Aug 08, 2018 at 09:58:41AM +0800, Ming wrote: > > > 在 8/6/2018 6:21 PM, Leif Lindholm 写道: > > On Tue, Jul 24, 2018 at 03:28:16PM +0800, Ming Huang wrote: > >> Add initial binary for D06. > >> Build commit infomation: > >> edk2: e73f499 > &

[edk2] [PATCH edk2-platforms] Silicon/Hisilicon: add PlatformBootManagerUnableToBoot() to PlatformBm

2018-08-07 Thread Leif Lindholm
eement 1.1 Signed-off-by: Leif Lindholm --- NOTE: The upstream build is currently broken. This failure needs to be addressed before d02 deletion and d03 fix can go in. Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c | 16 1 file changed, 16 insertions(+)

Re: [edk2] [platforms: PATCH 7/9] Marvell/Armada70x0Db: Enable ACPI support

2018-08-06 Thread Leif Lindholm
On Mon, 6 Aug 2018, 17:09 Ard Biesheuvel, wrote: > On 6 August 2018 at 18:08, Marcin Wojtas wrote: > > HI Ard, > > > > pon., 6 sie 2018 o 13:54 Ard Biesheuvel > napisał(a): > >> > >> On 6 August 2018 at 01:28, Marcin Wojtas wrote: > >> > This patch introduces DSDT table and adds necessary >

Re: [edk2] [PATCH edk2-platforms v1 0/2] Modify following Switch generic PciHostBridge

2018-08-06 Thread Leif Lindholm
On Sun, Aug 05, 2018 at 10:38:53AM +0800, Ming Huang wrote: > The major features of this patchset include: > 1. Remove D02 platform; > 2. Fix a D03 issue about switch generic PciHostBridge; > > Code can also be found in github: > https://github.com/hisilicon/OpenPlatformPkg.git > branch: rm-D02

Re: [edk2] [PATCH edk2-non-osi v1 1/1] Hisilicon/D06: Add binary modules

2018-08-06 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:28:16PM +0800, Ming Huang wrote: > Add initial binary for D06. > Build commit infomation: > edk2: e73f499 > edk2-platforms: 7f223e6 > HwPkg: e0bf35e > TrusedFirmware: 4eda1d1 > Tools: 6b286b1 The above information is all good, but can you add a summary specifying what

Re: [edk2] [PATCH edk2-platforms v1 38/38] Platform/Hisilicon/D0x: Update version string to 18.08

2018-08-06 Thread Leif Lindholm
f $(FIRMWARE_VER) > > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" >!else > -gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D06 > UEFI RC0 - B308 (V0.38)" > +gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L""De

Re: [edk2] [PATCH edk2-platforms v1 37/38] Hisilicon/D06: Add PciPlatformLib

2018-08-06 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:21PM +0800, Ming Huang wrote: > Add a Null PciPlatformLib for build D06. Why? (Add some more detail to commit message, please.) > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- >

Re: [edk2] [PATCH edk2-platforms v1 36/38] Silicon/Hisilicon/setup: Support SMMU switch

2018-08-06 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:20PM +0800, Ming Huang wrote: > Select without SMMU iort while SMMU item is disable, > Select with SMMU iort while SMMU item is enable. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- >

Re: [edk2] [PATCH edk2-platforms v1 03/38] Hisilicon/D06: Add several basal file for D06

2018-08-06 Thread Leif Lindholm
On Mon, Aug 06, 2018 at 11:01:04AM +0800, Ming wrote: > >>> + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME) > >>> + SUPPORTED_ARCHITECTURES= AARCH64 > >>> + BUILD_TARGETS = DEBUG|RELEASE > >> > >> Can you also add NOOPT please? > >> Between DEBUG and RELEASE.

Re: [edk2] [PATCH edk2-platforms v1 35/38] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-04 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:19PM +0800, Ming Huang wrote: > If install SPCR table, KVM will not output while install or boot > some OS, like ubuntu, Will not output? Do you mean it disables the graphical output of the OS? / Leif > so add SPCR switch setup item and set it > disable by

Re: [edk2] [PATCH edk2-platforms v1 34/38] Silicon/Hisilicon/D06: Add I2C Bus Exception deal function

2018-08-04 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:18PM +0800, Ming Huang wrote: > From: shaochangliang > > During the period of I2c accessing, if the board is reset > unexpectedly, and because the I2c client can not reset, > the SDA will be always pull down, then it cause I2C bus > Exception. > > Follow the Hi1620

Re: [edk2] [PATCH edk2-platforms v1 33/38] Silicon/Hisilicon/D06: Modify for close slave core clock.

2018-08-04 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:17PM +0800, Ming Huang wrote: > From: ZhenYao > > When BIOS booting, the power consumption is too high, so need close > some clusters clock that don't work to reduce power consumption. On the one hand: should this not be handled in ARM-TF? What if (during

Re: [edk2] [PATCH edk2-platforms v1 32/38] Platform/Hisilicon/D06: Add capsule upgrade support

2018-08-04 Thread Leif Lindholm
Ard: a sanity check? For my part: Reviewed-by: Leif Lindholm On Tue, Jul 24, 2018 at 03:09:16PM +0800, Ming Huang wrote: > From: xulinwei > > This module support updating the boot CPU firmware only. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-

Re: [edk2] [PATCH edk2-platforms v1 31/38] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h

2018-08-04 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:15PM +0800, Ming Huang wrote: > Add soem Lpc macro to LpcLib.h for D06. soem -> some I have no issue with this patch, but can you explain when these macros are intended to be used? And if in this set, move this patch immediately before the patch than needs it? /

Re: [edk2] [PATCH edk2-platforms v1 30/38] Hisilicon/D06: add apei driver

2018-08-04 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:14PM +0800, Ming Huang wrote: > From: Luqi Jiang > > This driver provide a means for the platform to > convey error information to OSPM. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Luqi Jiang > Signed-off-by: Ming Huang >

Re: [edk2] [PATCH edk2-platforms v1 29/38] Platform/Hisilicon/D06: Add PciHostBridgeLib

2018-08-04 Thread Leif Lindholm
Ard: could you give this one an additional sanity check? Some (mostly style) comments inline below. On Tue, Jul 24, 2018 at 03:09:13PM +0800, Ming Huang wrote: > PciHostBridgeLib which is need by PciHostBridgeDxe,provide > root bridges and deal with resource conflict. > > Contributed-under:

Re: [edk2] [PATCH edk2-platforms v1 28/38] Hisilicon/D0x: Unify FlashFvbDxe driver

2018-08-04 Thread Leif Lindholm
ochangliang > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo Reviewed-by: Leif Lindholm If you reorder this patch earlier in the set, I can push this change before the rest. (But I do need it rebased, since I don't think it will apply to curren HEAD, due to other changes to d03/d05

Re: [edk2] [PATCH edk2-platforms v1 27/38] Platform/Hisilicon/D06: Add EarlyConfigPeim peim

2018-08-04 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:11PM +0800, Ming Huang wrote: > This peim configuare SMMU,AP,MN. configuare -> configure I know SMMU and AP, but I don't know MN. Hmm, also, 'AP' is a bit unfortunate to use in EDK2 context. PI specifies 'BSP' for Boot-strap Processor, as the one executing all of

Re: [edk2] [PATCH edk2-platforms v1 26/38] Silicon/Hisilicon/D0x: Move macro definition to PlatformArch.h

2018-08-04 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:10PM +0800, Ming Huang wrote: > From: Sun Yuanchen > > Move some RAS macros definition to PlatformArch.h for > unifying D0x Minor comments below. However, I would still prefer for this to be split up into a refactoring patch for d03/d05, and then simpley introduced

Re: [edk2] [PATCH edk2-platforms v1 25/38] Hisilicon/D0x: Update SMBIOS type9 info

2018-08-04 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:09PM +0800, Ming Huang wrote: > From: Sun Yuanchen > > Move board level code to OemMiscLibD0x for unifying D0x. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sun Yuanchen > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > ---

Re: [edk2] [PATCH edk2-platforms v1 24/38] Platform/Hisilicon/D06: Add OemNicConfig2P Driver

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:08PM +0800, Ming Huang wrote: > From: shaochangliang > > This Driver provide Get/Set Mac function. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shaochangliang > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- >

Re: [edk2] [PATCH edk2-platforms v1 23/38] Hisilicon/D0X: Rename the global variable gDS3231RtcDevice

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:07PM +0800, Ming Huang wrote: > The global variable gDS3231RtcDevice is used by several > modules included common module in other Pkg. Renaming it > with a general name is proper. Ah, this was why the variable name did not match the patch set. Good. MEans I can trust

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:06PM +0800, Ming Huang wrote: > OemNicLib provide nic related api like GetMac,SetMac. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > Platform/Hisilicon/D06/D06.dsc |

Re: [edk2] [PATCH edk2-platforms v1 21/38] Silicon/Hisilicon/D0x: Move macro definition to PlatformArch.h

2018-08-03 Thread Leif Lindholm
Ming Huang > Signed-off-by: Heyi Guo Reviewed-by: Leif Lindholm (If you drop the extra Signed-off-by:s) / Leif > --- > Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h | 2 -- > Silicon/Hisilicon/Hi1610/Include/PlatformArch.h | 1 +

Re: [edk2] [PATCH edk2-platforms v1 20/38] Platform/Hisilicon/D06: Enable ACPI PPTT

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:04PM +0800, Ming Huang wrote: > From: Heyi Guo > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm (if you drop Heyi's Signed-off-by) / Leif &g

Re: [edk2] [PATCH edk2-platforms v1 19/38] Hisilicon/Hi1620: Add ACPI PPTT table

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:03PM +0800, Ming Huang wrote: > From: Heyi Guo > > This driver fetches information from MADT, so it is adaptable for > partial good and 1P/2P, since MADT is updated for different > configurations by certain mechanism. > > Since L2 cache is also private resource of

Re: [edk2] [PATCH edk2-platforms v1 18/38] Silicon/Hisilicon/Setup: Add Setup Item "EnableGOP"

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:02PM +0800, Ming Huang wrote: > From: Yang XinYi > > Add Setup Item "EnableGOP" for D06, This Item only takes > effect on SM750 What is SM750? Please add more detail to commit message. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by:

Re: [edk2] [PATCH edk2-platforms v1 17/38] Silicon/Hisilicon/D06: Optimize HNS config CDR post time

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:01PM +0800, Ming Huang wrote: > From: shaochangliang > > Use I2C 400KB speed for config CDR > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shaochangliang > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- >

Re: [edk2] [PATCH edk2-platforms v1 15/38] Silicon/Hisilicon/I2C: Optimize I2C library

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:59PM +0800, Ming Huang wrote: > The hunt of waiting TX/TX finish is used by ten times, > so move there hunts to a function CheckI2CTimeOut. I approve of this change, but the subject is inaccurate. Please change 'optimize' to 'refactor'. Some style comments below.

Re: [edk2] [PATCH edk2-platforms v1 14/38] Silicon/Hisilicon/D06: Fix I2C enable fail issue for D06

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:58PM +0800, Ming Huang wrote: > From: shaochangliang > > I2C may enable failed in D06, so retry I2C enable while > enable failed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shaochangliang > Signed-off-by: Ming Huang >

Re: [edk2] [PATCH edk2-platforms v1 13/38] Silicon/Hisilicon/Acpi: Move some macro to PlatformArch.h

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:57PM +0800, Ming Huang wrote: > From: Sun Yuanchen > > ARM_ACPI_HEADER is used by a unify module in other Pkg, What other Pkg? > so move some macro to PlatformArch.h for unify D0x. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sun

Re: [edk2] [PATCH edk2-platforms v1 12/38] Silicon/Hisilicon/D06: Stop watchdog

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:56PM +0800, Ming Huang wrote: > From: Sun Yuanchen > > according as watchdog design on D06, watchdog should be > stoped befor boot a option. stopped before > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wang Yue > Signed-off-by:

Re: [edk2] [PATCH edk2-platforms v1 11/38] Hisilicon/D06: Add Hi1620OemConfigUiLib

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:55PM +0800, Ming Huang wrote: > From: Yang XinYi > > This library is added for oem setup menu item. Please add some detail about what settings are made available here. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yang XinYi >

Re: [edk2] [PATCH] ArmPkg/GenericWatchdogDxe: Split 64bit register write to 2x32bit

2018-08-02 Thread Leif Lindholm
> > so I guess it is implied that any implementation should tolerate this > value being written as 2 32-bit quantities. > > Leif? Yep, the way the SBSA describes it, these are two separate 32-bit registers, making accessing them with a single transaction ends up being implementation defined

Re: [edk2] [PATCH edk2-platforms v1 10/38] Hisilicon/D06: Add ACPI Tables for D06

2018-08-02 Thread Leif Lindholm
= Hi1620AcpiTables > + FILE_GUID = 7E374E25-8E01-4FEE-87F2-390C23C606CD > + MODULE_TYPE = USER_DEFINED > + VERSION_STRING = 1.0 > + > +[Sources] > + Dsdt/DsdtHi1620.asl > + Facs.aslc > + Fadt.aslc > + Gtdt.aslc > + Ma

Re: [edk2] [PATCH edk2-platforms v1 09/38] Hisilicon/D06: Add Debug Serial Port Init Driver

2018-08-02 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:53PM +0800, Ming Huang wrote: > From: Yan Zhang > > Debug serial port init driver is added to initilize debug > serial port. What is special about this platform that makes it require a separate initialization function for the PL011? / Leif >

Re: [edk2] [PATCH edk2-platforms v1 08/38] Silicon/Hisilicon/Acpi: Unify HisiAcipPlatformDxe

2018-08-02 Thread Leif Lindholm
re Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo Drop Heyi's Signed-off-by and this one can have: Reviewed-by: Leif Lindholm / Leif > --- > Silicon/Hisilicon/Drivers/HisiAcpiPlatformDxe/UpdateAcpiTable.c | 2 -- > Silicon/Hisilicon

Re: [edk2] [PATCH edk2-platforms v1 07/38] Silicon/Hisilicon/D06: Wait for all disk ready

2018-08-02 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:51PM +0800, Ming Huang wrote: > This patch is relative to D06 SasDxe driver. The SasDxe set a > variable to notice this libray. Here Wait for all disk ready > for 30S at most. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang >

Re: [edk2] [PATCH edk2-platforms v1 06/38] Hisilicon/D06: Add OemMiscLibD06

2018-08-02 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:50PM +0800, Ming Huang wrote: > This library include BoardFeatureD06.c and OemMiscLibD06.c c file, > use for several modules like PciHostBridgeLib and Smbios. > Enlarge macro PCIEDEVICE_REPORT_MAX for D06. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH edk2-platforms v1 05/38] Platform/Hisilicon/D06: Add binary file for D06

2018-08-02 Thread Leif Lindholm
Could the subject be changed to "add edk2-non-osi components for D06"? I should point out that I really like how this is done as a separate patch. On Tue, Jul 24, 2018 at 03:08:49PM +0800, Ming Huang wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang >

Re: [edk2] [PATCH edk2-platforms v1 04/38] Platform/Hisilicon/D06: Add M41T83RealTimeClockLib

2018-08-02 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:48PM +0800, Ming Huang wrote: > Add M41T83RealTimeClockLib for RTC. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > Platform/Hisilicon/D06/D06.dsc

Re: [edk2] [PATCH edk2-platforms v1 03/38] Hisilicon/D06: Add several basal file for D06

2018-08-02 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:47PM +0800, Ming Huang wrote: > Add several basal head file and add several build configuration basal -> base > for D06. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo Ah, yes - please drop the

Re: [edk2] [PATCH edk2-platforms v1 02/38] Silicon/Hisilicon: Separate PlatformArch.h

2018-08-02 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:46PM +0800, Ming Huang wrote: > As the mocro of PlatformArch.h is platform special, so Separate mocro -> macro (typo) special -> specific (subtleties of English language :) Separate -> separate (case) > PlatformArch.h to Hi1610,Hi1616,Hi1620 for unifying D0x. > >

Re: [edk2] [PATCH edk2-platforms v1 01/38] Silicon/Hisilicon: Modify the MRC interface for other module

2018-08-02 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:45PM +0800, Ming Huang wrote: > This patch is to unify D0x. Add pGBL_INTERFACE struct define > and remove useless interfece. Replace DMRC pGblData with pGblInterface; > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhou You >

Re: [edk2] [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver

2018-08-02 Thread Leif Lindholm
On Thu, Aug 02, 2018 at 12:05:38AM +, Chris Co wrote: > > Hmm, I'm already slightly unhappy that we have duplication between > > EmbeddedPkg and MdeModulePkg (not to mention the extra fork for > > Marvell's XenonDxe). > > > > I'm obviously keen for the added functionality to be available to

Re: [edk2] [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library

2018-08-02 Thread Leif Lindholm
On Thu, Aug 02, 2018 at 01:27:16AM +, Chris Co wrote: > > > The 'data.load.elf' statement in > > > PeCoffLoaderRelocateImageExtraAction() is particular to Lauterbach > > > > Oh, right. > > > > That (original) code badly needs reformatting. > > > > Still, if that's the only difference - and

Re: [edk2] [PATCH edk2-platforms v1 00/38] Upload for D06 platform

2018-08-02 Thread Leif Lindholm
On Thu, Aug 02, 2018 at 09:46:13AM +0800, Ming wrote: > I am sorry for the first issue, the modify FIRMWARE_VER patch is add > alone just befor send out the patchset. > > For generating acpi table, I use acpica-tools 20180508 version and it works. > I think acpica-tools are not backward

Re: [edk2] [PATCH edk2-platforms v1 00/38] Upload for D06 platform

2018-08-01 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:44PM +0800, Ming Huang wrote: > The major features of this patchset include: > 1 D06 source code; > 2 Unify some D0x modules; > > This patch set is base on pcihostbridage-v2. > For compiling D06, add below hunk to edk2-platforms.config > [d06] > LONGNAME=HiSilicon

Re: [edk2] [PATCH edk2-platforms 1/7] Silicon/NXP: Add support for iMX SDHC

2018-08-01 Thread Leif Lindholm
On Thu, Jul 19, 2018 at 04:11:18AM +, Chris Co wrote: > This adds support for using the SD host controller on > NXP i.MX platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > Cc: Leif Lindholm &

Re: [edk2] [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library

2018-08-01 Thread Leif Lindholm
On Tue, Jul 31, 2018 at 10:59:22PM +0200, Ard Biesheuvel wrote: > On 31 July 2018 at 22:56, Leif Lindholm wrote: > > On Tue, Jul 17, 2018 at 02:05:45AM +, Chris Co wrote: > >> This debug library provides support for importing symbols to > >> debug using Lauterb

Re: [edk2] [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library

2018-07-31 Thread Leif Lindholm
the addition of the Microsoft copyright statement and updating of the debug printouts to modern style. I would be happy to take this as a patch to the original, but I don't see what benefit this copy brings. What prevents you from using the original? / Leif > Cc: Ard Biesheuvel > Cc: L

Re: [edk2] [PATCH edk2-platforms 2/3] Platform/Microsoft: Add MsPkg

2018-07-31 Thread Leif Lindholm
On Tue, Jul 17, 2018 at 02:05:43AM +, Chris Co wrote: > MsPkg is a collection of libraries and drivers that are specific > to supporting Windows IoT Core but are not Platform/Silicon specific. Minor comments inline. > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: M

Re: [edk2] [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver

2018-07-31 Thread Leif Lindholm
e added functionality to be available to more platforms. Is there any way for this support to be added into either the EmbeddedPkg or the MdeModulePkg driver? (Deferring comments on specific content.) / Leif > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > Contribu

Re: [edk2] [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors

2018-07-13 Thread Leif Lindholm
+ Jaben, Ruiyu. On Fri, Jul 13, 2018 at 11:07:21AM +0100, AlexeiFedorov wrote: > This patch fixes VS2017 compilation errors for > UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c > and > UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c > reported in >

Re: [edk2] [platforms: PATCH v3 5/6] Marvell/Library: Implement common ArmadaIcuLib

2018-07-13 Thread Leif Lindholm
in the > GIC are generated. > > This patch adds a basic version of the library, that > allows to configure a static mapping between CP110 > interfaces and GICv2 of the Armada7k8k SoC family. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Woj

Re: [edk2] [platforms: PATCH v2 5/6] Marvell/Library: Implement common ArmadaIcuLib

2018-07-13 Thread Leif Lindholm
On Fri, Jul 13, 2018 at 10:12:12AM +0200, Marcin Wojtas wrote: > ICU (Interrupt Consolidation Unit) is a mechanism, > that allows to send-message based interrupts from the > CP110 unit (South Bridge) to the Application Processor > hardware block. After dispatching the interrupts in the > GIC are

Re: [edk2] [platforms: PATCH 5/6] Marvell/Library: Implement common ArmadaIcuLib

2018-07-12 Thread Leif Lindholm
On Thu, Jul 12, 2018 at 12:59:16PM +0200, Marcin Wojtas wrote: > Hi Leif, > > > > 2018-07-12 12:35 GMT+02:00 Leif Lindholm : > > On Thu, Jul 12, 2018 at 09:40:00AM +0200, Marcin Wojtas wrote: > >> ICU (Interrupt Consolidation Unit) is a mechanism, > >

Re: [edk2] [platforms: PATCH 5/6] Marvell/Library: Implement common ArmadaIcuLib

2018-07-12 Thread Leif Lindholm
On Thu, Jul 12, 2018 at 09:40:00AM +0200, Marcin Wojtas wrote: > ICU (Interrupt Consolidation Unit) is a mechanism, > that allows to send-message based interrupts from the > CP110 unit (South Bridge) to the Application Processor > hardware block. After dispatching the interrupts in the > GIC are

Re: [edk2] [PATCH 2/6] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2018-07-09 Thread Leif Lindholm
On Mon, Jul 09, 2018 at 02:05:32PM +0530, Sughosh Ganu wrote: > hi Leif, > > On Tue, Jul 3, 2018 at 7:42 PM, Leif Lindholm > wrote: > > On Tue, Jul 03, 2018 at 03:25:11PM +0530, Supreeth Venkatesh wrote: > >> PI v1.5 Specification Volume 4 defines Management Mode Core

Re: [edk2] [PATCH 6/6] ArmPkg: Extra action to update permissions for S-ELO MM Image.

2018-07-03 Thread Leif Lindholm
F Image section parsing, this patch implements extra action > "UpdatePeCoffPermissions" to request the privileged firmware in EL3 to > update the permissions. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreet

Re: [edk2] [PATCH 4/6] ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.

2018-07-03 Thread Leif Lindholm
t; > This patch adds a simple MMU library suitable for execution in S-EL0 and > requesting memory permissions change operations from Arm Trusted Firmware. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: S

Re: [edk2] [PATCH 2/6] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2018-07-03 Thread Leif Lindholm
ile > related information the driver needs. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh Oh, and only one Signed-off-by per patch please. If authorship is to be indicated, ensure that's correct in git befo

Re: [edk2] [PATCH 1/6] ArmPkg: Add PCDs needed for MM communication driver.

2018-07-03 Thread Leif Lindholm
more than individual (or completely trivial) patches. Is this set intended for the master branch, and how would I exercise this new code? > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > Cc: Leif Lindholm

Re: [edk2] [PATCH 3/6] ArmPkg/Include: Add MM interface SVC return codes.

2018-07-03 Thread Leif Lindholm
of a longer explanation, so probably worth breaking out as a separate patch. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > Cc: Leif Lindholm > Cc: Ard Biesheuvel > --- > ArmPkg/Include/IndustryStand

Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

2018-07-02 Thread Leif Lindholm
On Wed, Jun 27, 2018 at 05:48:42PM +0100, Sami Mujawar wrote: > This patch series fixes the issues reported by the ecc tool. > > The changes can be seen at > https://github.com/samimujawar/edk2-platforms/tree/290_fix_ecc_issues_v1 For series: Reviewed-by: Leif Lindholm Pushed a

Re: [edk2] [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool

2018-07-02 Thread Leif Lindholm
On Wed, Jun 27, 2018 at 05:47:41PM +0100, Sami Mujawar wrote: > This patch series fixes the issues reported by the ecc tool. > > The changes can be seen at > https://github.com/samimujawar/edk2-staging/tree/290_fix_ecc_issues_v1 For series: Reviewed-by: Leif Lindholm Pushed a

Re: [edk2] [PATCH edk2-platforms v1 1/1] Readme: Add instructions to build in a Windows Environment

2018-06-29 Thread Leif Lindholm
you've added/modified and which remain unchanged. / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Readme.md | 614 > 1 file c

Re: [edk2] [staging/dynamictables PATCH v1 4/5] DynamicTablesPkg: Fix macro to prevent side effect

2018-06-29 Thread Leif Lindholm
s, > > Sami Mujawar > -----Original Message- > From: Leif Lindholm > Sent: 28 June 2018 05:51 PM > To: Sami Mujawar > Cc: edk2-devel@lists.01.org; Evan Lloyd ; Matteo Carlini > ; Stephanie Hughes-Fitt > ; nd > Subject: Re: [staging/dynamictables PATCH v1 4/5] Dyna

Re: [edk2] [staging/dynamictables PATCH v1 4/5] DynamicTablesPkg: Fix macro to prevent side effect

2018-06-28 Thread Leif Lindholm
On Wed, Jun 27, 2018 at 05:47:45PM +0100, Sami Mujawar wrote: > The ALIGN32 macro had undesired side effects when used with binary > operators and was generating compilation errors. > > Added brackets to fix this issue. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by:

Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

2018-06-28 Thread Leif Lindholm
On Wed, Jun 27, 2018 at 04:58:04PM +, Evan Lloyd wrote: > > Signed-off-by: Evan Lloyd Should I take this one (and the one on the other accompanying set) as Reviewed-by? / Leif > > -Original Message- > > From: Sami Mujawar > > Sent: 27 June 2018 17:49 > > To:

<    2   3   4   5   6   7   8   9   10   11   >