Re: [edk2] [PATCH v1 1/2] MdePkg: Add NORETURN attribute and UNREACHABLE() macro.

om: af...@apple.com [mailto:af...@apple.com] > Sent: Sunday, June 12, 2016 7:45 PM > To: Marvin Häuser <marvin.haeu...@outlook.com> > Cc: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com> > Subject: Re: [edk2] [PATCH v1 1/2] MdePkg: Add NORETURN attribute and > UNREACHABLE()

Re: [edk2] [PATCH v1 1/2] MdePkg: Add NORETURN attribute and UNREACHABLE() macro.

of input from anyone! Thanks, Marvin. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Sunday, June 12, 2016 5:22 AM > To: af...@apple.com > Cc: Marvin Häuser <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org; Kinney, Michael D <

[edk2] [PATCH v1 2/2] MdePkg/BaseLib: Flag CpuDeadLoop() and CpuBreakpoint() as ANALYZER_NORETURN.

Add the ANALYZER_NORETURN attribute to CpuDeadLoop() and CpuBreakpoint() to avoid false 'possible NULL-dereference' warnings when dereferencing pointers after having validated them with ASSERT(). As the ANALYZER-prefixed versions are being used, the code following the calls will not be optimized

[edk2] [PATCH v1 1/2] MdePkg: Add NORETURN attribute and UNREACHABLE() macro.

The NORETURN attribute informs compilers and analyzers that the flagged function cannot return. This may improve the quality of the optimizations. The UNREACHABLE() macro informs compilers and analyzers that its position cannot be reached, for example eliminating implicit returns. It is

Re: [edk2] [PATCH v1 2/2] MdePkg/BaseLib: Flag CpuDeadLoop() and CpuBreakpoint() as ANALYZER_NORETURN.

. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Monday, June 13, 2016 4:33 AM > To: Marvin Häuser <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > Subject: RE: [P

Re: [edk2] Q: Which module type fits my library?

Sorry, I forgot to add edk2-devel to the sender list. :) > -Original Message- > From: Marvin Häuser > Sent: Wednesday, June 1, 2016 6:39 PM > To: 'Peter Kirmeier' <topet...@freenet.de> > Subject: RE: [edk2] Q: Which module type fits my library? > > Hey Peter, &

Re: [edk2] [PATCH v1 1/1] MdePkg/DebugLib: Ignore DEBUG variables in RELEASE builds.

t: Monday, May 30, 2016 8:54 PM > To: Marvin Häuser <marvin.haeu...@outlook.com> > Cc: edk2-devel@lists.01.org <edk2-de...@ml01.01.org> > Subject: Re: [edk2] [PATCH v1 1/1] MdePkg/DebugLib: Ignore DEBUG > variables in RELEASE builds. > > On 05/30/16 20:13, Marvin Häuse

Re: [edk2] [PATCH v1 1/1] MdePkg/DebugLib: Ignore DEBUG variables in RELEASE builds.

30, 2016 6:03 PM > To: Marvin Häuser <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org <edk2-de...@ml01.01.org> > Cc: michael.d.kin...@intel.com; liming@intel.com; Ard Biesheuvel > <ard.biesheu...@linaro.org> > Subject: Re: [edk2] [PATCH v1 1/1] MdePkg/Deb

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

calls ExitBootServices(). This is done by passing in the > current > memory map's MapKey value as returned by > EFI_BOOT_SERVICES.GetMemoryMap()." > > Thanks, > Star > -Original Message- > From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] > Sent: M

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/Core: Decorate phase-transition functions with NORETURN.

with a return value not always returning. Thanks, Marvin. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Monday, June 20, 2016 10:22 AM > To: Marvin Häuser <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org > Cc: Tian, Feng <feng.

Re: [edk2] [PATCH v2 2/4] MdePkg/DebugLib: Flag post-_ASSERT() as unreachable for analyzers.

, Marvin. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Monday, June 20, 2016 10:20 AM > To: Marvin Häuser <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > S

[edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

During exiting Boot Services, there should be no changes made to the Memory Map. This patch eliminates calls to FreePool() and CloseEvent() (which calls FreePool()) and instead zero's the memory. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser

[edk2] [PATCH v1 2/2] NetworkPkg: Minimize usage of FreePool() during ExitBS().

During exiting Boot Services, there should be no changes made to the Memory Map. This patch eliminates calls to FreePool() and CloseEvent() (which calls FreePool()) and instead zero's the memory. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser

[edk2] [PATCH v2 3/4] MdeModulePkg/Core: Decorate phase-transition functions with NORETURN.

This patch adds the NORETURN attribute to functions that transfer to other phases, along with an UNREACHABLE() call at the end to avoid false warnings. DxeIpl has been excluded as its main function returns a status. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin

[edk2] [PATCH v2 2/4] MdePkg/DebugLib: Flag post-_ASSERT() as unreachable for analyzers.

When a variable is compared to NULL as part of an ASSERT() call, the code implies that the variable may be NULL. Certain Static Analyzers, such as the Clang Static Analyzer, then issue false warnings for any untested access of that pointer, even though that defeats the intention behind ASSERT().

[edk2] [PATCH v2 4/4] UefiCpuPkg/SecMain: Decorate phase-transition function with NORETURN.

This patch adds the NORETURN attribute to the function that transfers to the PEI phase, along with an UNREACHABLE() call at the end to avoid false warnings. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser ---

[edk2] [PATCH v2 1/4] MdePkg: Add NORETURN attribute and UNREACHABLE() macro.

The NORETURN attribute informs compilers and analyzers that the flagged function cannot return. This may improve the quality of the optimizations. The UNREACHABLE() macro informs compilers and analyzers that its position cannot be reached, for example eliminating implicit returns. It is

Re: [edk2] StdLib usage for drivers?

Hey Michael, Thank you for your input! This looks interesting. Maybe it would be a good idea to provide the libraries that depend on Shell (in master) with functions that call ASSERT (FALSE); for drivers? I do not need file I/O, so I think your modifications might work out well for me. Would be

Re: [edk2] [PATCH] MdePkg: Update Base.h to fix compilation issues with ICC.

Dear Mike, Am I supposed to perform any changes to this patch or is it considered ready for merge? > To: michael.d.kin...@intel.com; marvin.haeu...@outlook.com; > edk2-devel@lists.01.org; michael.d.kin...@intel.com > From: jordan.l.jus...@intel.com > Subject: RE: [edk2] [PATCH] MdePkg:

[edk2] BaseTools: Refinded Multiple Workspaces support.

Dear edk2-devel subscribers, A few moments ago, I have published a patch to the EDK2 BaseTools with the subject "BaseTools: Add Multiple Workspaces support for custom Makefiles.", which is aimed at providing Custom Makefile modules support for Multiple Workspaces. Writing the patch, I

Re: [edk2] BaseTools: Refinded Multiple Workspaces support.

<edk2-devel-boun...@lists.01.org> im Auftrag von Marvin Häuser <marvin.haeu...@outlook.com> Gesendet: Sonntag, 21. Februar 2016 02:00 An: edk2-devel@lists.01.org Betreff: [edk2] BaseTools: Refinded Multiple Workspaces support. Dear edk2-devel subscribers, A few moments ago, I have

Re: [edk2] BaseTools: Refinded Multiple Workspaces support.

is in use. I appreciate any kind of feedback. Best regards, Marvin. Von: edk2-devel <edk2-devel-boun...@lists.01.org> im Auftrag von Marvin Häuser <marvin.haeu...@outlook.com> Gesendet: Sonntag, 21. Februar 2016 02:00 An: edk2-devel@lists.01.org Be

Re: [edk2] [RFC] MdePkg: add ARG_UNUSED notation to Base.h

I think this question on StackOverflow might be helpful: https://stackoverflow.com/questions/7090998/portable-unused-parameter-macro-used-on-function-signature-for-c-and-c The comment by 'the swine' suggests '__pragma(warning(suppress:4100))' to be used for MSVC. I also believe the answer by

[edk2] [PATCH v1 1/1] MdePkg: Move SMBIOS data into the IndustryStandard header.

As the SMBIOS table types belong to the SMBIOS standard, they were moved from the SMBIOS Protocol header into the SMBIOS IndustryStandard header without the EFI_-prefix. Defines with the EFI_-prefix have been kept in the Protocol header for backwards-compatibility, resolving to the

Re: [edk2] Question about Chipset initialization

Hello Rafael, Chipset initialization should be done in the PEI phase, along with the initialization of any critical hardware (DRAM, etc.). In DXE, usually the optional devices are initialized (controllers like USB and such). Here is a nice picture of the boot flow from the TianoCore Wiki:

[edk2] [PATCH v2 1/1] MdePkg: Move SMBIOS data into the IndustryStandard header.

As the SMBIOS table types belong to the SMBIOS standard, they were moved from the SMBIOS Protocol header into the SMBIOS IndustryStandard header without the EFI_-prefix. Defines with the EFI_-prefix have been kept in the Protocol header for backwards-compatibility, resolving to the

Re: [edk2] [PATCH v1 1/1] MdePkg: Move SMBIOS data into the IndustryStandard header.

Star, Thank you for your remark. Patch v2 has been sent to the mailing list with the changes you proposed. Regards, Marvin. Von: Zeng, Star<mailto:star.z...@intel.com> Gesendet: Dienstag, 22. März 2016 06:32 An: Marvin Häuser<mailto:marvin.haeu...@outlook.com>; edk2-devel@

Re: [edk2] [PATCH] corrections to use of VA_LIST

Hey, I think Laszlo means the detailed description should be in the commit message(s) for documentational reasons. It’s quite frustrating stumbling over a change made months or years ago you do not understand and which is undocumented. :) Regards, Marvin. Von:

[edk2] [PATCH v1] ShellPkg: Also accept gEfiUnicodeCollation2ProtocolGuid for parsing.

The EFI_UNICODE_COLLATION_PROTOCOL can have two different GUIDs. Look for both to support more UEFI implementations. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- ShellPkg/Application/Shell/Shell.c | 11 +-- 1 file

[edk2] [PATCH v1] ShellPkg/Bcfg: Add support for 'addp' command.

Until now the 'addp' command has been handled in the same way as 'add'. Just copy the DevicePath starting from the Hard Drive node when 'addp' is used. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser ---

[edk2] [PATCH v1 1/1] ShellPkg/App: Fix memory leak and save resources.

1) RunSplitCommand() allocates the initial SplitStdOut via CreateFileInterfaceMem(). Free SplitStdIn after the swap to fix the memory leak. 2) In RunSplitCommand(), SplitStdOut is checked for equality with StdIn. This cannot happen due to the if-check within the swap. Hence remove it.

[edk2] [PATCH v1 2/2] EdkCompatibilityPkg: Fix a typo.

Fix a typo and a spacing mistake in EfiCommonLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- EdkCompatibilityPkg/Foundation/Library/EfiCommonLib/ReportStatusCode.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2] [PATCH v1 1/2] EdkCompatibilityPkg: Do not cast VA_LIST to a pointer for AARCH64.

Do not cast VA_LIST to a pointer for the AARCH64 architecture in EfiCommonLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- EdkCompatibilityPkg/Foundation/Library/EfiCommonLib/ReportStatusCode.c | 2 +- 1 file changed, 1

Re: [edk2] GenFds fails with MWS.

reproduce steps ? thanks in advance. Best Regards, Zhu Yonghong From: Zhu, Yonghong Sent: Friday, April 15, 2016 8:38 AM To: 'Marvin Häuser' <marvin.haeu...@outlook.com>; edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com>

Re: [edk2] GenFds fails with MWS.

PS: I think it might work on Windows because GenFds checks the first character of \ or /. Though Windows paths start with the drive letter. :) Von: Marvin Häuser<mailto:marvin.haeu...@outlook.com> Gesendet: Freitag, 15. April 2016 22:51 An: edk2-devel@lists.01.org<mailto:edk2-devel

[edk2] GenFds fails with MWS.

Hello dear TianoCore developers, Liming, Yonghong, Today I wanted to try out the changes intoduced with the ‚BaseTools: fix PLATFORM_DIR variable value for multiple workspace‘ commit. After having fixed the ‚brace-mismatched‘ I sent as a patch earlier today, the build process works fine until

[edk2] [PATCH v1 1/1] BaseTools: Fix PLATFORM_DIR variable value.

In commit 017fb1cd4c5e3c8b914eb217ac1760223687dad7, the PLATFORM_DIR macro has been updated to resolve to the correct path. However, it is incorrectly accessed via curved rather than curly braces by GenMake. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser

Re: [edk2] Intel FSP Firmware Volume content

Hey Rafael and Giri, Thanks for your information. I really appreciate your answers and time, though the answers have been quite general. But I think I finally got the hang of FSP. The following is how I understand it by looking at FSP binaries and IntelFspPkg and by now means a verified

[edk2] [PATCH v1 1/1] MdeModulePkg/PeiCore: Fix ConverSinglePpiPointer () typo.

Rename ConverSinglePpiPointer () to ConvertSinglePpiPointer (). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- MdeModulePkg/Core/Pei/Ppi/Ppi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[edk2] [PATCH v1 1/1] BaseTools/toolsetup: Do not set CONF_PATH when already set.

When CONF_PATH is already set, toolsetup.bat overwrites its value. This is not the case on Linux platforms (BuildEnv) and contra-productive when using the same Workspace across multiple Operating Systems. With this patch, a check is performed prior to setting the variable. Furthermore, it will not

Re: [edk2] StdLib usage for drivers?

offered alternative solutions, but I prefer to keep it ‚clean‘ and have the libraries shipping with EDK2 work. :) Regards, Marvin. From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] Sent: Thursday, June 23, 2016 5:32 AM To: Marvin Häuser <marvin.haeu...@outlook.com> Cc: edk2-devel

Re: [edk2] [PATCH v2 1/2] MdeModulePkg: Do not free memory during ExitBootServices ().

lists.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: RE: [PATCH v2 1/2] MdeModulePkg: Do not free memory during > ExitBootServices (). > > Reviewed-by: Star Zeng <star.z...@intel.com> > > -Original Mes

[edk2] [PATCH v1 1/1] OvmfPkg/ResetVector: Depend on PCD values of the page tables.

Currently, the values of the page tables' address and size are hard-coded in the ResetVector. This patch replaces this with a PCD dependency for the NASM Reset Vector. The ASM Reset Vector remains using a hard-coded value due to the lack of C preprocessing. Contributed-under: TianoCore

Re: [edk2] [PATCH v1 1/1] OvmfPkg/ResetVector: Depend on PCD values of the page tables.

it to be present? Should I clarify the commit message, such as using 'NASM ResetVector'? Thanks for your input! Regards, Marvin. > -Original Message- > From: Jordan Justen [mailto:jordan.l.jus...@intel.com] > Sent: Wednesday, November 2, 2016 11:31 PM > To: Marvin Häuser <marvin.haeu

[edk2] [PATCH v2] OvmfPkg/ResetVector: Depend on PCD values of the page tables.

Currently, the values of the page tables' address and size are hard-coded in the ResetVector. This patch replaces this with a PCD dependency for the NASM Reset Vector. The ASM Reset Vector remains using a hard-coded value due to the lack of C preprocessing. Checks for the size have been added to

[edk2] [PATCH] OvmfPkg/ResetVector: Remove the unused ASM ResetVector.

Remove the ResetVector.asm file as it is no longer referenced since the switch to ResetVector.nasmb. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- OvmfPkg/ResetVector/ResetVectorCode.asm | 53 1 file

[edk2] [PATCH v3] OvmfPkg/ResetVector: Depend on PCD values of the page tables.

Currently, the value of the page tables' address is hard-coded in the ResetVector. This patch replaces these values with a PCD dependency. A check for the size has been added to alert the developer to rewrite the ASM according to the new size, if it has been changed. Contributed-under: TianoCore

Re: [edk2] [PATCH v2] OvmfPkg/ResetVector: Depend on PCD values of the page tables.

6 9:59 PM > To: Marvin Häuser <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org > Cc: ler...@redhat.com > Subject: Re: [PATCH v2] OvmfPkg/ResetVector: Depend on PCD values of the > page tables. > > On 2016-11-03 12:18:56, Marvin Häuser wrote: > > Current

[edk2] [PATCH v2 1/2] MdeModulePkg: Do not free memory during ExitBootServices ().

During exiting Boot Services, there should be no changes made to the Memory Map. This patch eliminates explicit and implicit calls to the Memory Allocation Services and, where applicable, zeros the memory instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin

[edk2] [PATCH v2 2/2] NetworkPkg: Do not free memory during ExitBootServices ().

During exiting Boot Services, there should be no changes made to the Memory Map. This patch eliminates explicit and implicit calls to the Memory Allocation Services and, where applicable, zeros the memory instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin

Re: [edk2] [PATCH v2] OvmfPkg/ResetVector: Depend on PCD values of the page tables.

, in that case I must have overread it. Thanks for 'fixing' the patches! Regards, Marvin. > -Original Message- > From: Jordan Justen [mailto:jordan.l.jus...@intel.com] > Sent: Friday, November 4, 2016 12:10 AM > To: Laszlo Ersek <ler...@redhat.com>; Marvin Häuser > <ma

[edk2] [PATCH v4] OvmfPkg/ResetVector: Depend on PCD values of the page tables.

Currently, the value of the page tables' address is hard-coded in the ResetVector. This patch replaces these values with a PCD dependency. A check for the size has been added to alert the developer to rewrite the ASM according to the new size, if it has been changed. Contributed-under: TianoCore

Re: [edk2] [PATCH v3] OvmfPkg/ResetVector: Depend on PCD values of the page tables.

for your input! Regards, Marvin. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, November 4, 2016 12:56 AM > To: Marvin Häuser <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org <edk2-de...@ml01.01.org> > Cc: jordan.l.

[edk2] [PATCH] ArmPkg: Fix modsi3.S compilation across toolchains.

modsi3.S references the symbol '__divsi3' by '___divsi3' which assumes the prefix is always required and supported. Use ASM_PFX() instead to support all compilers. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser ---

Re: [edk2] [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on RELEASE builds

7 3:27 AM > To: marvin.haeu...@outlook.com; edk2-devel@lists.01.org > Cc: Zhu, Yonghong <yonghong@intel.com> > Subject: RE: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable > on RELEASE builds > > Reviewed-by: Liming Gao <liming@intel.com> > > >-

Re: [edk2] [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on RELEASE builds

Sorry, the reason for the commit was caused by a misconfiguration of my workspace. The commit can be discarded, no V2 needed. Sorry for any inconvenience. Regards, Marvin. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marv

[edk2] [PATCH] BaseTools/tools_def: Use armv7-a for CLANG35 ARM compilations.

Define "-march=armv7-a" - which is used by the GCC toolchains - for ARM CLAMNG35 builds to fix compilation of the MemoryFence ASM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- BaseTools/Conf/tools_def.template | 2 +- 1

[edk2] [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on RELEASE builds

Set -Wno-unused-but-set-variable on RELEASE builds so variables only verified in DEBUG code (e.g. ASSERT()) do not trigger build errors. This is done to align with GCC compilation: https://github.com/tianocore/edk2/commit/20d00edf21d2f2144921622891d8b59a1553cd83 Contributed-under: TianoCore

Re: [edk2] [MAC HELP] Does Mac has a grubx64.efi ?

Run '/System/Library/CoreServices/boot.efi' (without the quotes) on the macOS root partition, not the ESP. Regards, Marvin. -Ursprüngliche Nachricht- Von: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] Im Auftrag von Amit kumar Gesendet: Montag, 24. April 2017 14:27 An:

Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

its links set to dummys, is freed, the dummy values may be > >> > overwriten and the check would pass despite the node being invalid. > >> > This can, for example, be > >> used in OpenKabylake's PchSmiDispatcher, which does the described > >> check again

[edk2] [PATCH v2 2/2] MdePkg/BaseLib: Update internal LinkedList verifications.

1) Replace InternalBaseLibIsNodeInList() with InternalBaseLibIsListValid(). - The verification whether Node is within the doubly-linked List is now done by IsNodeInList(). - Whether the list is valid is returned. 2) The comments within InsertHeadList() and InsertTailList() stated

[edk2] [PATCH v2 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

This patch adds IsNodeInList() to BaseLib, which verifies the given Node is part of the doubly-linked List provided. V2: - Rename "List" to "FirstEntry" and "Node" to "SecondEntry" to clarify that "FirstEntry" does not need to be the doubly-linked list's head node. Contributed-under:

[edk2] [PATCH v3 2/2] MdePkg/BaseLib: Update internal LinkedList verifications.

1) Replace InternalBaseLibIsNodeInList() with InternalBaseLibIsListValid(). - The verification whether Node is within the doubly-linked List is now done by IsNodeInList(). - Whether the list is valid is returned. 2) The comments within InsertHeadList() and InsertTailList() stated

[edk2] [PATCH v3 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

This patch adds IsNodeInList() to BaseLib, which verifies the given Node is part of the doubly-linked List provided. V2: - Rename "List" to "FirstEntry" and "Node" to "SecondEntry" to clarify that "FirstEntry" does not need to be the doubly-linked list's head node. V3: - Remove ASSERTs

[edk2] [PATCH] QuarkSocPkg/QNCSmmDispatcher: Fix use after free issue #2

As part of commit 5f82e02, ActiveRecordInDb was introduced as a copy of RecordInDb as latter may be freed by the callback function. This commit replaces an access of RecordInDb after the callback function has been executed with an access to ActiveRecordInDb. Contributed-under: TianoCore

[edk2] [PATCH] UefiCpuPkg/CpuCommonFeaturesLib: Fix the documentation of PpinSupport().

The documentation of PpinSupport() refers to 'Enhanced Intel SpeedStep'. This patch fixes these referneces. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c | 4 ++--

[edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Cast the return value of GetPageTableBase().

The value returned by GetPageTableBase() is of type UINT64, which is implicitely casted to UINTN by the return statement. To purge the 'possible loss of data' warning on 32-bit platforms, with this patch, the value is casted to UINTN before returning. Contributed-under: TianoCore Contribution

[edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

Old versions of the Visual Studio C compiler return a value of type 'int' for comparisons, which is what the C99 standard defines in the sections 6.5.8 and 6.5.9. When the result of a comparison is returned, int is implicitely casted to BOOLEAN, which is smaller, and hence a warning about a

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

. Is it? Regards, Marvin. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marvin Häuser > Sent: Sunday, July 23, 2017 12:12 PM > To: edk2-devel@lists.01.org > Cc: michael.d.kin...@intel.com; liming@intel.com > Subject:

[edk2] [PATCH 2/2] MdePkg/BaseLib: Update internal LinkedList verifications.

1) Replace InternalBaseLibIsNodeInList() with InternalBaseLibIsListValid(). - The verification whether Node is within the doubly-linked List is now done by IsNodeInList(). - Whether the list is valid is returned. 2) The comments within InsertHeadList() and InsertTailList() stated

[edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

This patch adds IsNodeInList() to BaseLib, which verifies the given Node is part of the doubly-linked List provided. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- MdePkg/Library/BaseLib/LinkedList.c | 70

[edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

X86TimerLib is changed to use UefiCpuPkg LAPIC register definitions and LocalApicLib to remove duplicated code. An implicite change is the value returned by InternalX86GetApicBase() as it now returns the result of GetLocalApicBaseAddress(), which is the full LAPIC address. This also implicitely

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

, implicitely casted to UINT32 (UINTN), resulting in the appropiate data loss warning. Thanks for your answer! Regards, Marvin. > -Original Message- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Monday, July 24, 2017 6:40 PM > To: Marvin Häuser

Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

hael D [mailto:michael.d.kin...@intel.com] > Sent: Monday, July 24, 2017 6:31 PM > To: Marvin Häuser <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> > Cc: Gao, Liming <liming@intel.com> > Subject: RE: [PATCH 1/2] MdePkg/BaseLi

Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

t is too old to compile > > using EDK2. Maybe it should be deprecated?) is the version generating > those errors, all newer versions are fine. > > > > Thanks and regards, > > Marvin. > > > > > -Original Message- > > > From: Fan, Jeff [mailto

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

ApicBase and for > > 64-bit > platforms, it's ApicBase and ApicBaseHi? > > If yes, maybe ~(UINTN)0xFFF should be used to play safe? > > > > Thanks, > > Marvin. > > > > > -Original Message- > > > From: Fan, Jeff [mailto:jeff@intel.c

Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

ist() can be used to > determine whether it was previously removed. > > > > Thanks for your response! > > > > Regards, > > Marvin. > > > > > -Original Message- > > > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > > >

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

.@intel.com> > > > > Subject: Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume > > > UefiCpuPkg LAPIC code. > > > > > > > > Hey Jeff, > > > > > > > > That would definitely fix the compilation issue. > > > > Do I see it ri

Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

el.com] > Sent: Wednesday, July 26, 2017 4:45 AM > To: Marvin Häuser <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org > Subject: RE: [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements. > > Marvin, > > Could you tell what VS version you are using?

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

m: Fan, Jeff [mailto:jeff@intel.com] > Sent: Wednesday, July 26, 2017 4:28 AM > To: Marvin Häuser <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > Subject: RE: [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume Uef

Re: [edk2] writing EDK compatible application.

Well, if EFI Shell 1.0 works, why not use it? Mac EFI exposes the ConsoleControl protocol, which lets you switch between text and graphics mode. That might be the reason your text outputs don't show, because graphics is the default mode on Mac EFI, though I could never test this myself as I lack

Re: [edk2] [PATCH 2/2] ShellPkg/Shell: eliminate double-free in RunSplitCommand()

Please excuse the mistake, I suppose I was running a search for "FreePool", which of course did not find "SHELL_FREE_NON_NULL". Thanks for fixing it up! Reviewed-by: Marvin Häuser <marvin.haeu...@outlook.com> -Ursprüngliche Nachricht- Von: Laszlo Ersek

Re: [edk2] PciLib/PciExpressLib: 64-bit r/w functions

Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Sunday, August 6, 2017 1:35 PM > To: Marvin Häuser <marvin.haeu...@outlook.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] PciLib/PciExpressLib: 64-bit r/w functions > > On 08/05/17 23:38, Marvin H?user wrote: > > Dea

Re: [edk2] Regarding UefiDriverEntryPoint unload handler

Hey Mike, "if UnloadImage() is called and the Unload field is NULL, it returns an EFI_UNSUPPORTED." This is the part I missed, my example is impossible in this case. Thanks, Marvin. -Ursprüngliche Nachricht- Von: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Gesendet:

Re: [edk2] [PATCH v1] MdePkg: Add definitions for the SPI protocols introduced in UEFI PI 1.6.

tember 15, 2017 10:22 AM > To: Ni, Ruiyu <ruiyu...@intel.com>; Marvin Häuser > <marvin.haeu...@outlook.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > <liming@intel.com> > Subject: RE: [PATCH v1] MdePkg: Ad

Re: [edk2] [PATCH v1] MdePkg: Add definitions for the SPI protocols introduced in UEFI PI 1.6.

s, as well as the Standalone MM Core, which can expose them to the MM Standalone Drivers. Any comments? Did I maybe overlook something? Thanks, Marvin. > -Original Message- > From: Zimmer, Vincent [mailto:vincent.zim...@intel.com] > Sent: Wednesday, September 20, 2017 10:24 PM > To: Marv

[edk2] [PATCH v1] MdePkg: Add definitions for the SPI protocols introduced in UEFI PI 1.6.

This commit adds header files for the SPI protocols introduced in the UEFI PI 1.6 specification, as well as their GUIDs to MdePkg.dec. EFI_SPI_TRANSACTION_TYPE assumes an enum with its members ordered the way they are listed in the specification, as there are no values given explicitely.

Re: [edk2] PI 1.6: Issues within the SPI sections.

Thank you very much Andrew, hadn't seen it yet. Sorry for spamming here. Best regards, Marvin. From: af...@apple.com [mailto:af...@apple.com] Sent: Wednesday, September 6, 2017 5:31 PM To: Marvin H?user Cc: edk2-devel@lists.01.org Subject: Re: [edk2] PI 1.6: Issues

Re: [edk2] Curious question regarding lack of debug in MdeModulePkg

Hey, Did you make sure you use the proper DebugLib instance in your .dsc (or if you build MdeModulePkg directly, adapted its)? You likely want UefiDebugLibConOut. Also make sure you enabled the necessary debug levels via PCD. Regards, Marvin. > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 toolchain

PI. I am not sure whether they are similar cases in edk2. > If have, we had better fix them together. > > Thanks > Liming > >-Original Message- > >From: Laszlo Ersek [mailto:ler...@redhat.com] > >Sent: Monday, September 25, 2017 4:13 PM > >To: Gao, Limi

Re: [edk2] [PATCH] MdePkg: resolve bug 741

I prefer my route because it preserves BOOLEAN (descriptive) and fixes the issue obviously (the last named parameter is what is passed). It's your choice of course. By the way, all of your other patch e-mails do not CC the package maintainer. They may not see them this way, so I suggest

[edk2] [PATCH v2] MdePkg: Add definitions for the SPI protocols introduced in PI 1.6.

This commit adds header files for the SPI protocols introduced in the UEFI PI 1.6 specification, as well as their GUIDs to MdePkg.dec. EFI_SPI_TRANSACTION_TYPE assumes an enum with its members ordered the way they are listed in the specification, as there are no values given explicitely.

[edk2] [PATCH v2] MdeModulePkg/AcpiPlatformDxe: Unload after execution.

AcpiPlatformDxe solely performs one-time tasks and does not expose any services or create any events. Hence it can safely be unloaded after the Entry Point execution by returning an error code. V2: Return EFI_REQUEST_UNLOAD_IMAGE. Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH] MdeModulePkg/AcpiPlatformDxe: Unload after execution.

comment. How about using EFI_REQUEST_UNLOAD_IMAGE > instead? > > > /// > /// If this value is returned by an EFI image, then the image should be > unloaded. > /// > #define EFI_REQUEST_UNLOAD_IMAGE DXE_ERROR (1) > > > Thanks, > Star > -Original Message- > Fro

[edk2] FW: [PATCH] UefiCpuPkg/SecMain: Add NORETURN decorator to SecStartup().

; > Gesendet: Dienstag, 27. Februar 2018 18:41 > An: Marvin Häuser <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org > Cc: eric.d...@intel.com > Betreff: Re: [PATCH] UefiCpuPkg/SecMain: Add NORETURN decorator to > SecStartup(). > > On 02/27/18 17:50, Marvin

[edk2] [PATCH v2 1/2] MdePkg/UefiLib: Add 'OUT' decorator where necessary.

The functions AddUnicodeString() and AddUnicodeString2() might return a new value into their parameter UnicodeStringTable, hence add the appropiate 'OUT' decorator. V2: Update FrameworkUefiLib as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser

[edk2] [PATCH] MdePkg/PeiServicesLib: Decorate 'PpiDescriptor' as OPTIONAL for LocatePpi().

The UEFI PI specification defines PpiDescriptor to be OPTIONAL for the LocatePpi PEI Service. This patch reflects this in the function declaration and definition of the corresponding PeiServices library function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin

[edk2] [PATCH 1/2] MdeModulePkg: Add PlatformAcpiLib LibraryClass.

PlatformAcpiLib can be consumed by the generic ACPI Platform driver to allow platform specific updates to the ACPI tables loaded from the configured Firmware Volume. This allows for more platforms to incorporate the generic ACPI Platform driver. This commit also provides a NULL implementation of

[edk2] [PATCH 2/2] MdeModulePkg/AcpiPlatformDxe: Consume PlatformAcpiLib.

This patch updates the generic ACPI Platform driver to consume PlatformAcpiLib to allow platform specific updates to the ACPI tables loaded from the configured Firmware Volume. This allows for more platforms to incorporate the generic ACPI Platform driver. Contributed-under: TianoCore

[edk2] [PATCH] MdePkg: Update MmSwDispatch.h's references to SmmSw2Dispatch.

MmSwDispatch.h current refers to the deprecated SmmSw2Dispatch protocol. Replace those references with the new MmSwDispatch name. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- MdePkg/Include/Protocol/MmSwDispatch.h | 8

  1   2   3   >