Re: [edk2] [edk2-announce] Mailing List Move Day Set: April 4th

[Rebecca Cran via edk2-devel]

On 3/25/19 10:21 AM, stephano wrote:


This is a good point and shows the level of detail that is preserved 
by the mailing list if maintained properly. I would assume this is 
part of the reason that the Linux kernel has continued to use mailing 
lists for patch review as this level of detail is highly desired in 
their case.



Talking of such things, I noticed a couple weeks ago that the Gmane link 
at https://lists.01.org/mailman/listinfo/edk2-devel doesn't work .


From https://en.wikipedia.org/wiki/Gmane :

"In July 2016, Ingebrigtsen announced that he was considering shutting 
Gmane down, and the web interface was taken offline.^[2] 
 ^[3] 
 In August 2016 Gmane 
was acquired by Yomura Holdings. Only the message spool was transferred, 
with the software behind the site having to be redeveloped.^[4] 
 ^[5] 
 On the 6 September 
2016, it was announced that the Gmane web interface would be coming 
online again.^[6]  
However, by February 2018 a LWN.net 
 article observed that the web 
interface did "never [...] return, breaking thousands of links across 
the net. The front page still says 'some things are very broken' and 
links to a blog page that was last updated in September 2016."^[7] 
"



--
Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror

[Rebecca Cran via edk2-devel]

On 3/25/19 5:49 AM, Laszlo Ersek wrote:


Any particular reason for dropping the website URL update?
 still redirects to
, and your
previous patch (correctly) included that new URL.



Stephano recently posted a message with a link 
tohttps://www.tianocore.org/monthly-meeting/  which redirects to 
https://github.com/tianocore/tianocore.github.io/wiki/Monthly-Meeting, so I 
think it makes sense to keep the shorter/nicer URLs since there are redirects 
in place.

--
Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror

[Rebecca Cran via edk2-devel]

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran 
---
 Maintainers.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index be77898ee2..4c9adf802b 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -40,10 +40,9 @@ Descriptions of section entries:
 EDK II
 --
 W: http://www.tianocore.org/edk2/
-L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
+L: https://lists.01.org/mailman/listinfo/edk2-devel
 T: git - https://github.com/tianocore/edk2.git
 T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
-T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
 T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
 
 Tianocore Stewards
-- 
2.21.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] March Community Meeting Minutes

[Rebecca Cran via edk2-devel]

On 3/11/19 4:20 PM, stephano wrote:


On 3/11/2019 1:55 PM, Rebecca Cran wrote:

You can't see without following the pull request *who* committed the 
change.  There are almost 1000 open pull requests, which is something 
we probably want to try and avoid. They also seem to have _lots_ of 
labels. I wonder if there's a cleaner way of handling them?


Agreed. We spoke about some of the downsides of pull requests in the 
last stewards meeting. Linus did a fair job of detailing some of these 
here:


https://github.com/torvalds/linux/pull/17

I'm going to work with EDK II maintainers to be sure that we do not 
move to a model that makes their life harder (e.g. 1000 open pull 
requests).





Also, about groups.io, I wonder if I might want to investigate their 
support for using our own domain, so people don't have to remember 
that the mailing list and documents are on groups.io and not 
tianocore.org?




Yes, I'm hoping to use our own domain with groups.io. Once we've 
completed the testing phase I'll bring this up to my boss(es) to get 
approval for an enterprise account ($200/month). That will allow us to 
use something more friendly with tianocore.org.



Thanks! Sorry for the skepticism, I've just had experiences in the past 
with new systems being introduced which made work more difficult (e.g. a 
commercial code review tool: several teams avoided it by using Review 
Board or Gerrit instead).



--
Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] March Community Meeting Minutes

[Rebecca Cran via edk2-devel]

On 3/11/19 10:33 AM, stephano wrote:



Stephano has taken an action item to work with the Kubernetes 
community to see what trade-offs and benefits they experience using 
GitHub. Kubernetes is one of the largest open source projects 
currently using GitHub for patch reviews. It is notable that a git 
module "request-pull" exists, and the kernel gives directions on how 
to use these "git style" of pull requests:



I took a look at the Kubernetes project a few days ago, and there are a 
couple of things we might _not_ want to copy, since they look to me to 
obfuscate things.


For example, the git log:


commit 50bf223a0545a121dc202de8fad673402b8ebde6 (HEAD -> master, 
origin/master, origin/HEAD)

Merge: 4ea48886df c5c4cd2580
Author: Kubernetes Prow Robot 
Date:   Mon Mar 11 12:00:15 2019 -0700

    Merge pull request #75224 from neolit123/certs-print-key-on-phase

    kubeadm: print key inside the upload-certs phase of init

commit 4ea48886df2e0830daa2384f6fe57dd55b8dbb51
Merge: 8477c486a8 58c7b5de9c
Author: Kubernetes Prow Robot 
Date:   Mon Mar 11 09:39:40 2019 -0700

    Merge pull request #75008 from nikopen/patch-4

    rebase audit-proxy image to distroless/static

commit 8477c486a81c1094440cf7c78d6be5c52b0828c4
Merge: 6ec5a7d337 fa926ed6e0
Author: Kubernetes Prow Robot 
Date:   Mon Mar 11 09:39:27 2019 -0700

    Merge pull request #74652 from cofyc/fix72500

    Delay CSI client initialization


You can't see without following the pull request *who* committed the 
change.  There are almost 1000 open pull requests, which is something we 
probably want to try and avoid. They also seem to have _lots_ of labels. 
I wonder if there's a cleaner way of handling them?



Also, about groups.io, I wonder if I might want to investigate their 
support for using our own domain, so people don't have to remember that 
the mailing list and documents are on groups.io and not tianocore.org?



--

Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

[Rebecca Cran via edk2-devel]

On 2/26/19 5:31 AM, Laszlo Ersek wrote:



Sorry for missing this earlier, but the patch misses the
Contributed-under and Signed-off-by lines, from the end of the commit
message.

Please repost like that, and then please also include the Reviewed-by
tags from Jaben and myself.



I'm just catching up on edk2 work again. I've just sent out a new patch.


--
Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS servers

[Rebecca Cran via edk2-devel]

The current servers listed appear to be unusable. I suspect most
people will get correct DNS servers via DHCP, but the defaults
should work for anyone.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran 
Reviewed-by: Jaben Carsey 
Reviewed-by: Laszlo Ersek 
---
 StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/StdLib/Efi/StdLib/etc/resolv.conf 
b/StdLib/Efi/StdLib/etc/resolv.conf
index 3ac16ac230..724e6297b2 100644
--- a/StdLib/Efi/StdLib/etc/resolv.conf
+++ b/StdLib/Efi/StdLib/etc/resolv.conf
@@ -1,13 +1,13 @@
 #
 #   Domain name
 #
-domain  intel.com
+domain  example.com
 
 ;
 ;   Name Servers
 ;
-nameserver  206.63.63.61
-nameserver  216.251.100.1
+nameserver  8.8.8.8
+nameserver  8.8.4.4
 
 ; nameserver  10.248.2.1
 ; nameserver  10.22.224.204
-- 
2.21.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Hang when calling ExitBootServices on IA32 firmware v1.0 on MinnowBoard Turbot

[Rebecca Cran via edk2-devel]

On 2/25/19 5:08 PM, Rebecca Cran via edk2-devel wrote:
I've been trying to test a boot loader on my MinnowBoard Turbot board. 
It's running the latest 1.0 firmware from firmware.intel.com, and I'm 
seeing a hang at the point when gBS->ExitBootServices is called.



I did more debugging using OVMF and found that the i386 boot loader code 
was trying to call printf (which allocates memory) after 
ExitBootServices. And that booting an i386 kernel isn't actually 
supported. So there's not a problem with the MinnowBoard firmware.



--
Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] Convert PosixLike scripts to sh, reduce duplication and fix some bugs

[Rebecca Cran via edk2-devel]

Thanks for the review. I have a macOS system, so I'll verify future 
changes work there too.


The problem I'm trying to solve is to make it easier to get started 
building EDK2 under FreeBSD. Currently it needs symlinks in 
BaseTools/Bin/FreeBSD-amd64 for gcc, ld, make, objcopy and python, and 
obviously needs bash installed. Since there seems to be relatively 
little shell code in the repo, I was thinking that avoiding the 
dependency on bash might be a relatively easy way to reduce the steps 
needed to get things working.



I'll try and remember about PatchCheck.py too.


--

Rebecca


On 2/25/19 8:11 PM, Feng, Bob C wrote:

Hi Rebecca,

I like the change of moving duplicated code into common files and the bug fix 
looks good.

I tested this patch on our CI system, it break the build on MacOS. There is no 
realpath command on MacOs shell.

For the patch itself, it need to pass the check of 
BaseTools/Scripts/PatchCheck.py.

Is there actual problem that need to be resolved by using sh instead of bash?

Thanks,
Bob

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Rebecca 
Cran via edk2-devel
Sent: Friday, February 22, 2019 1:13 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH] Convert PosixLike scripts to sh, reduce duplication and 
fix some bugs

Since the scripts in the PosixLike directory are very simple, convert them to 
use /bin/sh, and move duplicated code into common files (one for python 
scripts, one for C binaries).

Fix some bugs in edksetup.sh and BuildEnv: `test` uses single equals instead of 
double equals, and should have a space before the ending bracket. Fix some 
indentation, and if the user runs edksetup.sh with --help etc., quit after 
displaying the help message.
---
  BaseTools/BinWrappers/PosixLike/BPDG  | 15 ++
  BaseTools/BinWrappers/PosixLike/Brotli| 30 ++-
  .../BinWrappers/PosixLike/BrotliCompress  | 12 
  BaseTools/BinWrappers/PosixLike/DevicePath| 30 ++-
  BaseTools/BinWrappers/PosixLike/Ecc   | 15 ++
  BaseTools/BinWrappers/PosixLike/EfiRom| 30 ++-
  BaseTools/BinWrappers/PosixLike/GenCrc32  | 30 ++-
  BaseTools/BinWrappers/PosixLike/GenDepex  | 15 ++
  BaseTools/BinWrappers/PosixLike/GenFds| 15 ++
  BaseTools/BinWrappers/PosixLike/GenFfs| 30 ++-
  BaseTools/BinWrappers/PosixLike/GenFv | 30 ++-
  BaseTools/BinWrappers/PosixLike/GenFw | 30 ++-
  .../BinWrappers/PosixLike/GenPatchPcdTable| 15 ++
  BaseTools/BinWrappers/PosixLike/GenSec| 30 ++-
  .../BinWrappers/PosixLike/GenerateCapsule | 15 ++
  BaseTools/BinWrappers/PosixLike/LzmaCompress  | 30 ++-
  .../BinWrappers/PosixLike/LzmaF86Compress |  2 +-
  BaseTools/BinWrappers/PosixLike/PatchPcdValue | 15 ++
  BaseTools/BinWrappers/PosixLike/Pkcs7Sign | 15 ++
  .../PosixLike/Rsa2048Sha256GenerateKeys   | 15 ++
  .../BinWrappers/PosixLike/Rsa2048Sha256Sign   | 15 ++
  BaseTools/BinWrappers/PosixLike/Split | 30 ++-
  BaseTools/BinWrappers/PosixLike/TargetTool| 15 ++
  BaseTools/BinWrappers/PosixLike/TianoCompress | 30 ++-
  BaseTools/BinWrappers/PosixLike/Trim  | 15 ++
  BaseTools/BinWrappers/PosixLike/UPT   | 15 ++
  BaseTools/BinWrappers/PosixLike/VfrCompile| 30 ++-
  BaseTools/BinWrappers/PosixLike/VolInfo   | 30 ++-
  BaseTools/BinWrappers/PosixLike/build | 15 ++
  BaseTools/BinWrappers/PosixLike/common.sh | 12 
  BaseTools/BinWrappers/PosixLike/commonbin.sh  | 28 +
  BaseTools/BuildEnv|  3 +-
  edksetup.sh   | 12 
  33 files changed, 110 insertions(+), 559 deletions(-)  create mode 100644 
BaseTools/BinWrappers/PosixLike/common.sh
  create mode 100644 BaseTools/BinWrappers/PosixLike/commonbin.sh

diff --git a/BaseTools/BinWrappers/PosixLike/BPDG 
b/BaseTools/BinWrappers/PosixLike/BPDG
index c894384908..a9da3afb4b 100755
--- a/BaseTools/BinWrappers/PosixLike/BPDG
+++ b/BaseTools/BinWrappers/PosixLike/BPDG
@@ -1,14 +1,3 @@
-#!/usr/bin/env bash
-#python `dirname $0`/RunToolFromSource.py `basename $0` $*
+#!/bin/sh
  
-# If a ${PYTHON_COMMAND} command is available, use it in preference to python -if command -v ${PYTHON_COMMAND} >/dev/null 2>&1; then

-python_exe=${PYTHON_COMMAND}
-fi
-
-full_cmd=${BASH_SOURCE:-$0} # see http://mywiki.wooledge.org/BashFAQ/028 for a 
discussion of why $0 is not a good choice here -dir=$(dirname "$full_cmd") 
-cmd=${full_cmd##*/}
-
-export PYTHONPATH="$dir/../../Source/Python${PYTHONPATH:+:"$PYTHONPATH"}"
-exec "${python_

[edk2] Hang when calling ExitBootServices on IA32 firmware v1.0 on MinnowBoard Turbot

[Rebecca Cran via edk2-devel]

I've been trying to test a boot loader on my MinnowBoard Turbot board. 
It's running the latest 1.0 firmware from firmware.intel.com, and I'm 
seeing a hang at the point when gBS->ExitBootServices is called.


The last debug output is:

ConfigSccBootableDevicesAtExitBootService() End
SetUefiImageMemoryAttributes - 0x787EB000 - 0x4000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787E8000 - 0x3000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787E5000 - 0x3000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787E1000 - 0x4000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787DB000 - 0x6000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787D5000 - 0x6000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787CC000 - 0x9000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787C6000 - 0x6000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787C3000 - 0x3000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787BD000 - 0x6000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787B8000 - 0x5000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787B2000 - 0x6000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787AC000 - 0x6000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787A9000 - 0x3000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787A5000 - 0x4000 
(0x0008)
SetUefiImageMemoryAttributes - 0x787A2000 - 0x3000 
(0x0008)
SetUefiImageMemoryAttributes - 0x7879F000 - 0x3000 
(0x0008)



The X64 firmware works fine: the boot loader finishes and the kernel 
starts running.


I looked to see where ConfigSccBootableDevicesAtExitBootService might 
be, and unfortunately it seems it's in one of the binary modules.


The code for the boot loader is in 
https://svnweb.freebsd.org/base/head/stand/efi/loader/bootinfo.c?revision=338022=markup 
.



--
Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

[Rebecca Cran via edk2-devel]

The current servers listed appear to be unusable. I suspect most
people will get correct DNS servers via DHCP, but the defaults
should work for anyone.

Change the entries to be Google's public DNS servers.
Also, change the domain name to be example.com, to be more applicable
to consumers outside Intel.
---
 StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/StdLib/Efi/StdLib/etc/resolv.conf 
b/StdLib/Efi/StdLib/etc/resolv.conf
index 3ac16ac230..724e6297b2 100644
--- a/StdLib/Efi/StdLib/etc/resolv.conf
+++ b/StdLib/Efi/StdLib/etc/resolv.conf
@@ -1,13 +1,13 @@
 #
 #   Domain name
 #
-domain  intel.com
+domain  example.com
 
 ;
 ;   Name Servers
 ;
-nameserver  206.63.63.61
-nameserver  216.251.100.1
+nameserver  8.8.8.8
+nameserver  8.8.4.4
 
 ; nameserver  10.248.2.1
 ; nameserver  10.22.224.204
-- 
2.20.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.

[Rebecca Cran via edk2-devel]

On February 25, 2019 at 3:11:16 AM, Laszlo Ersek 
(ler...@redhat.com(mailto:ler...@redhat.com)) wrote: 

> 
> Can you please repost the patch with an updated subject line / commit
> message? That way we can apply it with git-am without tweaking on the
> maintainer side. 





Sure!






Rebecca





___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror

[Rebecca Cran via edk2-devel]

On 2/22/19 10:18 PM, Rebecca Cran wrote:


-T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2



I removed the sourceforge git mirror because the latest changeset is 
from a couple of weeks ago. We already have Github and Bitbucket, so I'm 
not sure of the value of having a third mirror that's relatively slow to 
clone and gets outdated?



--

Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror

[Rebecca Cran via edk2-devel]

---
 Maintainers.txt | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 7f1061d6c1..d9d3d840c5 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -31,11 +31,10 @@ Descriptions of section entries:
 
 EDK II
 --
-W: http://www.tianocore.org/edk2/
-L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
+W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
+L: https://lists.01.org/mailman/listinfo/edk2-devel
 T: git - https://github.com/tianocore/edk2.git
 T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
-T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
 T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
 
 Tianocore Stewards
@@ -203,7 +202,7 @@ W: 
https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg
 M: Ruiyu Ni 
 
 OvmfPkg
-W: http://www.tianocore.org/ovmf/
+W: https://github.com/tianocore/tianocore.github.io/wiki/OVMF
 M: Jordan Justen 
 M: Laszlo Ersek 
 M: Ard Biesheuvel 
-- 
2.20.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.

[Rebecca Cran via edk2-devel]

Sorry, I've fixed the subject line and added maintainers to the Cc list.

This patch also changes the domain from intel.com to example.com, to be 
more applicable to consumers outside Intel.



--

Rebecca Cran


On 2/22/19 8:38 PM, Rebecca Cran wrote:

The current servers listed appear to be unusable. I suspect most
people will get correct DNS servers via DHCP, but the defaults
should work for anyone.
---
  StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/StdLib/Efi/StdLib/etc/resolv.conf 
b/StdLib/Efi/StdLib/etc/resolv.conf
index 3ac16ac230..724e6297b2 100644
--- a/StdLib/Efi/StdLib/etc/resolv.conf
+++ b/StdLib/Efi/StdLib/etc/resolv.conf
@@ -1,13 +1,13 @@
  #
  #   Domain name
  #
-domain  intel.com
+domain  example.com
  
  ;

  ;   Name Servers
  ;
-nameserver  206.63.63.61
-nameserver  216.251.100.1
+nameserver  8.8.8.8
+nameserver  8.8.4.4
  
  ; nameserver  10.248.2.1

  ; nameserver  10.22.224.204

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] Update resolv.conf to use Google's DNS servers.

[Rebecca Cran via edk2-devel]

The current servers listed appear to be unusable. I suspect most
people will get correct DNS servers via DHCP, but the defaults
should work for anyone.
---
 StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/StdLib/Efi/StdLib/etc/resolv.conf 
b/StdLib/Efi/StdLib/etc/resolv.conf
index 3ac16ac230..724e6297b2 100644
--- a/StdLib/Efi/StdLib/etc/resolv.conf
+++ b/StdLib/Efi/StdLib/etc/resolv.conf
@@ -1,13 +1,13 @@
 #
 #   Domain name
 #
-domain  intel.com
+domain  example.com
 
 ;
 ;   Name Servers
 ;
-nameserver  206.63.63.61
-nameserver  216.251.100.1
+nameserver  8.8.8.8
+nameserver  8.8.4.4
 
 ; nameserver  10.248.2.1
 ; nameserver  10.22.224.204
-- 
2.20.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Community Meeting Minutes

[Rebecca Cran via edk2-devel]

On 2/8/19 10:52 AM, Andrew Fish wrote:


I think the patch workflow is kind of like a coding standards. Some folks 
advocate for lots of small patches (common in open source projects), and some 
folks advocate for a patch per bug. I think the biggest upside to the patch 
granularity is it is much easier to bisect a failure.

So I've used Bitbucket with a branch per commit (you name your branch with a 
standard pattern and the bugzilla  ) model and if your branch has a patch 
series (set of commits) you can view each commit independently from the UI and 
the default view is the entire patch series. So you can see both.



I think I see the difference now: I've used several review systems, most 
recently including Bitbucket, and with Review Board, Phabricator, and I 
think Gerrit people tend to post several patches against the same bug, 
often not labeling them as patch 1/3, 2/3 etc. but just using the same 
bug number.


Seeing the entire series clearly as an email thread on here is rather nice.


--

Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] Convert PosixLike scripts to sh, reduce duplication and fix some bugs

[Rebecca Cran via edk2-devel]

Since the scripts in the PosixLike directory are very simple, convert
them to use /bin/sh, and move duplicated code into common files (one for
python scripts, one for C binaries).

Fix some bugs in edksetup.sh and BuildEnv: `test` uses single equals instead
of double equals, and should have a space before the ending bracket. Fix
some indentation, and if the user runs edksetup.sh with --help etc., quit
after displaying the help message.
---
 BaseTools/BinWrappers/PosixLike/BPDG  | 15 ++
 BaseTools/BinWrappers/PosixLike/Brotli| 30 ++-
 .../BinWrappers/PosixLike/BrotliCompress  | 12 
 BaseTools/BinWrappers/PosixLike/DevicePath| 30 ++-
 BaseTools/BinWrappers/PosixLike/Ecc   | 15 ++
 BaseTools/BinWrappers/PosixLike/EfiRom| 30 ++-
 BaseTools/BinWrappers/PosixLike/GenCrc32  | 30 ++-
 BaseTools/BinWrappers/PosixLike/GenDepex  | 15 ++
 BaseTools/BinWrappers/PosixLike/GenFds| 15 ++
 BaseTools/BinWrappers/PosixLike/GenFfs| 30 ++-
 BaseTools/BinWrappers/PosixLike/GenFv | 30 ++-
 BaseTools/BinWrappers/PosixLike/GenFw | 30 ++-
 .../BinWrappers/PosixLike/GenPatchPcdTable| 15 ++
 BaseTools/BinWrappers/PosixLike/GenSec| 30 ++-
 .../BinWrappers/PosixLike/GenerateCapsule | 15 ++
 BaseTools/BinWrappers/PosixLike/LzmaCompress  | 30 ++-
 .../BinWrappers/PosixLike/LzmaF86Compress |  2 +-
 BaseTools/BinWrappers/PosixLike/PatchPcdValue | 15 ++
 BaseTools/BinWrappers/PosixLike/Pkcs7Sign | 15 ++
 .../PosixLike/Rsa2048Sha256GenerateKeys   | 15 ++
 .../BinWrappers/PosixLike/Rsa2048Sha256Sign   | 15 ++
 BaseTools/BinWrappers/PosixLike/Split | 30 ++-
 BaseTools/BinWrappers/PosixLike/TargetTool| 15 ++
 BaseTools/BinWrappers/PosixLike/TianoCompress | 30 ++-
 BaseTools/BinWrappers/PosixLike/Trim  | 15 ++
 BaseTools/BinWrappers/PosixLike/UPT   | 15 ++
 BaseTools/BinWrappers/PosixLike/VfrCompile| 30 ++-
 BaseTools/BinWrappers/PosixLike/VolInfo   | 30 ++-
 BaseTools/BinWrappers/PosixLike/build | 15 ++
 BaseTools/BinWrappers/PosixLike/common.sh | 12 
 BaseTools/BinWrappers/PosixLike/commonbin.sh  | 28 +
 BaseTools/BuildEnv|  3 +-
 edksetup.sh   | 12 
 33 files changed, 110 insertions(+), 559 deletions(-)
 create mode 100644 BaseTools/BinWrappers/PosixLike/common.sh
 create mode 100644 BaseTools/BinWrappers/PosixLike/commonbin.sh

diff --git a/BaseTools/BinWrappers/PosixLike/BPDG 
b/BaseTools/BinWrappers/PosixLike/BPDG
index c894384908..a9da3afb4b 100755
--- a/BaseTools/BinWrappers/PosixLike/BPDG
+++ b/BaseTools/BinWrappers/PosixLike/BPDG
@@ -1,14 +1,3 @@
-#!/usr/bin/env bash
-#python `dirname $0`/RunToolFromSource.py `basename $0` $*
+#!/bin/sh
 
-# If a ${PYTHON_COMMAND} command is available, use it in preference to python
-if command -v ${PYTHON_COMMAND} >/dev/null 2>&1; then
-python_exe=${PYTHON_COMMAND}
-fi
-
-full_cmd=${BASH_SOURCE:-$0} # see http://mywiki.wooledge.org/BashFAQ/028 for a 
discussion of why $0 is not a good choice here
-dir=$(dirname "$full_cmd")
-cmd=${full_cmd##*/}
-
-export PYTHONPATH="$dir/../../Source/Python${PYTHONPATH:+:"$PYTHONPATH"}"
-exec "${python_exe:-python}" -m $cmd.$cmd "$@"
+. "$(dirname "$(realpath "$0")")/common.sh"
diff --git a/BaseTools/BinWrappers/PosixLike/Brotli 
b/BaseTools/BinWrappers/PosixLike/Brotli
index 0945d86d92..3dfa26e517 100755
--- a/BaseTools/BinWrappers/PosixLike/Brotli
+++ b/BaseTools/BinWrappers/PosixLike/Brotli
@@ -1,29 +1,3 @@
-#!/usr/bin/env bash
-
-full_cmd=${BASH_SOURCE:-$0} # see http://mywiki.wooledge.org/BashFAQ/028 for a 
discussion of why $0 is not a good choice here
-dir=$(dirname "$full_cmd")
-cmd=${full_cmd##*/}
-
-if [ -n "$WORKSPACE" ] && [ -e "$WORKSPACE/Conf/BaseToolsCBinaries" ]
-then
-  exec "$WORKSPACE/Conf/BaseToolsCBinaries/$cmd"
-elif [ -n "$WORKSPACE" ] && [ -e "$EDK_TOOLS_PATH/Source/C" ]
-then
-  if [ ! -e "$EDK_TOOLS_PATH/Source/C/bin/$cmd" ]
-  then
-echo "BaseTools C Tool binary was not found ($cmd)"
-echo "You may need to run:"
-echo "  make -C $EDK_TOOLS_PATH/Source/C"
-  else
-exec "$EDK_TOOLS_PATH/Source/C/bin/$cmd" "$@"
-  fi
-elif [ -e "$dir/../../Source/C/bin/$cmd" ]
-then
-  exec "$dir/../../Source/C/bin/$cmd" "$@"
-else
-  echo "Unable to find the real '$cmd' to run"
-  echo "This message was printed by"
-  echo "  $0"
-  exit 127
-fi
+#!/bin/sh
 
+. "$(dirname "$(realpath "$0")")/commonbin.sh"
diff --git a/BaseTools/BinWrappers/PosixLike/BrotliCompress 
b/BaseTools/BinWrappers/PosixLike/BrotliCompress
index ea86705a28..7cb26a3659 100755
--- 

[edk2] [PATCH] BaseTools: Convert PosixLike scripts to sh, reduce duplication and fix some bugs in edksetup.sh and BuildEnv

[Rebecca Cran via edk2-devel]

To make it easier to use EDK2 on systems other than Linux, where the default 
shell might
not be bash, I'd like to convert the shell scripts to use POSIX sh where 
possible.

edksetup.sh and BuildEnv remain bash scripts, but I hope to convert them to sh 
in a future
changeset.

I did see the argument against using $0 in 
http://mywiki.wooledge.org/BashFAQ/028, but I'm
not sure anyone using EDK2 will run into problems the article describes.

I checked the scripts with shellcheck.


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Configure bugs.tianocore.org as an alias for bugzilla.tianocore.org?

[Rebecca Cran via edk2-devel]

Could we allow people to access the Bugzilla tracker via 
bugs.tianocore.org (in addition to bugzilla.tianocore.org) please?


It looks like .tianocore.org (except www, bugzilla etc.) is 
configured as address 54.245.252.80, which just times out trying to 
access via http or https.



--
Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Community Meeting Minutes

[Rebecca Cran via edk2-devel]

On Tuesday, 19 February 2019 23:23:59 MST stephano wrote:

> Github Pull Requests
> -
> We are still considering Github as a possible platform for patch review.

One thing I've not seen mentioned here is that there's an official command line 
tool for GitHub, named 'hub': https://hub.github.com/

>From the output of 'hub --help':

These GitHub commands are provided by hub:

   browse Open a GitHub page in the default browser
   ci-status  Show the status of GitHub checks for a commit
   compareOpen a compare page on GitHub
   create Create this repository on GitHub and add GitHub as origin
   delete Delete a repository on GitHub
   fork   Make a fork of a remote repository on GitHub and add as 
remote
   issue  List or create GitHub issues
   pr List or checkout GitHub pull requests
   pull-request   Open a pull request on GitHub
   releaseList or create GitHub releases
   sync   Fetch git objects from upstream and update branches


-- 
Rebecca Cran


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Issues with EDK-II-Debugging wiki page, and how to submit a pull request for wiki pages

[Rebecca Cran via edk2-devel]

On Thursday, 14 February 2019 12:23:05 MST Laszlo Ersek wrote:

> The wikis on github are non-intuitive, if you intend to edit them in a
> normal text editor, locally. I struggled a lot until I came up with the
> list on top. (It's possible I relied on others' advice in that; I no
> longer remember.) I hope it helps.

Yeah, thanks but no thanks. I'm not _that_ keen on making my changes if it's 
going to involve all that work!

-- 
Rebecca Cran


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Community Meeting Minutes

[Rebecca Cran via edk2-devel]

On 2/14/19 3:13 PM, Kinney, Michael D wrote:

You can review the groups.io features.  I think what you
want is available.  Stephano has also setup an edk2 area
in groups.io for community member to try out.

https://groups.io/static/help#features

There are a number of CI services that are integrated with
GitHub.

https://github.com/marketplace/category/continuous-integration

There is work to be done to enable one of these CI services
for edk2.  Stephano has a community task to evaluate and
select a CI service.



Thanks, I'm cautiously optimistic that groups.io will maintain a nice 
email interface to the list(s). However I don't see any messages/topics 
(in https://edk2.groups.io/g/main), and it appears my test posts are 
being moderated: are there plans to start active testing at some point?



I'm not sure I'll ever be a fan of Github but hopefully it's something 
we can move forward with - and I'll continue providing other services I 
feel are missing, from the server in my basement :)



--
Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Community Meeting Minutes

[Rebecca Cran via edk2-devel]

As a casual contributor, for me the biggest complaint I have is how busy 
the mailing list gets. I don't think a new 'announce' list is what's 
needed, perhaps a 'reviews' or 'discussion' list to split out 
discussions (from anyone) from day-to-day patches? Also, I'd be anxious 
about jumping to a new service like groups.io: most open source 
developers understand plain email, and personally I'd like that to stay. 
For example FreeBSD set up web forums, but most contributors continue to 
use the existing mailman based lists, and I suspect tend to forget the 
web interface exists.



One thing I feel that's missing from the current Github-based 
infrastructure of the web site and wiki is that as far as I know there's 
no API documentation built regularly, or automated builds etc. I'm 
hosting the API documentation at e.g. 
https://code.bluestop.org/edk2/docs/master/ . Also, one thing a review 
system like Gerrit, Github, Phabricator, Review Board etc. would give us 
is the ability to run tests (lint, build/run OVMF etc.) against patches 
and have it comment on the review about its status to give committers 
more confidence in it.



--

Rebecca Cran


On 2/14/19 12:07 PM, Jeremiah Cox via edk2-devel wrote:

Hi Ard,
My apologies as no insult was intended.  The suggestion is that, similar to 
today, folks encountering difficulties with our systems could reach out to the 
TianoCore discussion venue (our mailing list or groups.io), and our friendly 
community members (we have many) will surely assist them.

You are correct that my focus is not casual contributors, rather I want to 
encourage a large number of UEFI developers who are currently closed to stop 
their fork-modify-ship model, which is inefficient to service, go open to share 
their learnings, get current, stay current, upstream their changes (where it 
makes sense to the community), but not throw garbage over the wall.   I think 
there is some value in this endeavor.

Kind Regards,
Jeremiah


From: Ard Biesheuvel 
Sent: Friday, February 8, 2019 5:58 AM
To: Jeremiah Cox
Cc: stephano; edk2-devel@lists.01.org; Kinney, Michael D; Laszlo Ersek
Subject: Re: [edk2] [edk2-announce] Community Meeting Minutes

On Thu, 7 Feb 2019 at 18:52, Jeremiah Cox via edk2-devel
 wrote:

Apologies on the late reply, I was on vacation for several weeks and just got 
back to this.

Regarding "Patch Review System Evaluation", on the call, I disagreed with your 
conclusion, but that note is not captured below.  My reading of the email and call discussions, I 
did not hear our community reject GitHub, rather observations that it was not "perfect", 
that it does not transparently interact with folks who prefer mailing list patch systems, but it 
would be acceptable to try.  On the call you mentioned a second justification for staying with the 
mailing list system, that GitHub (really all modern patch management systems) exclude folks who 
have limited internet connectivity.  I hypothesize that this theoretical group of Tianocore 
contributors would be a very small group of folks.  Should our community optimize our systems for a 
very small, theoretical group, penalizing the overwhelming majority?  I would propose that we try a 
modern patch management system, GitHub had the best reviews in my reading, and folks with limited 
internet connectivity find a friend to act as a go between translating their email diffs into 
GitHub PRs.

I find this unnecessarily condescending. Finding a friend, seriously?

Very serious concerns have been raised about the lack of transparency
with the various systems, and the fact that I am able to consult my
own local copy of the entire review history, including all email
exchanges is a very important aspect of the current model to me, as
opposed to GitHub deciding what is important enough to keep and what
is not. In an open source project, the code base is *not* the HEAD
commit, it is the entire repository, including history, and logged
email threads with technical discussions, since they are usually not
captured in other ways.

The push to GitHub is being sold to us as a way to attract more
contributors, but it seems to me (and I have stated this multiple
times) that the mailing list is not the steep part of the learning
curve when contributing to TianoCore. So is this really about getting
outsiders to contribute to Tianocore? Or is it about reducing the
impedance mismatch with what internal teams at MicroSoft (and Intel?)
are doing, which probably already went through the learning curve when
it comes to other aspects of Tianocore.

 From a high level, it might seem that using a mailing list is the
impediment here. But in reality, contributing to open source in
general is not about whether you use GitHub or a mailing list to throw
your stuff over the fence. It is about collaborating with the
community to find common ground between the various sometimes
conflicting interests, and permitting your engineers to engage 

[edk2] Issues with EDK-II-Debugging wiki page, and how to submit a pull request for wiki pages

[Rebecca Cran via edk2-devel]

I noticed a couple of issues with the page 
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Debugging - 
'SNI' should be 'SNP', and the |PcdDebugPrintErrorLevel is missing some 
entries.

|


How do I fork the wiki repo to make a pull request? On each page there's 
a "Clone this wiki locally" box where I can clone 
https://github.com/tianocore/tianocore.github.io.wiki.git, but when I 
try and fork it I instead fork 
https://github.com/tianocore/tianocore.github.io which doesn't have the 
same files either on the master or gh-pages branches - it looks like 
https://github.com/tianocore/tianocore.github.io has the files for 
www.tianocore.org, not the wiki?



--
Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] OVMF and TCP4, HTTP protocols

[Rebecca Cran via edk2-devel]

On 2/12/19 10:44 PM, Laszlo Ersek wrote:


In your case, I think it should suffice to call ConnectController() with
Recursive=FALSE, on the controller that already has SNP. The
HttpServiceBinding, Tcp6ServiceBinding and TCPv4ServiceBinding protocols
seem to be installed on the same handle. (The device path on this handle
ends with the MAC() node.)



Thanks again. Calling CloseProtocol, DisconnectController and then 
ConnectController got things working.



--

Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] OVMF and TCP4, HTTP protocols

[Rebecca Cran via edk2-devel]

On February 6, 2019 at 4:08:03 PM, Rebecca Cran via edk2-devel 
(edk2-devel@lists.01.org) wrote:

Oh, that makes sense! Thanks, after disabling the existing code that was 
opening SNP exclusively, things started working much better. 


I have a follow-up question. After opening the EFI_SIMPLE_NETWORK protocol 
exclusively, should code be able to later call gBS->CloseProtocol on the handle 
and subsequently start using TCP/HTTP? 

From what I’ve seen, closing the protocol (I’m also calling net->Shutdown(), 
and the CloseProtocol succeeds) has no effect and the TCP and HTTP protocols 
still can’t be found/used.



— 

Rebecca Cran

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Community Meeting Minutes

[Rebecca Cran via edk2-devel]

On February 8, 2019 at 2:01:59 AM, Laszlo Ersek 
(ler...@redhat.com(mailto:ler...@redhat.com)) wrote:

> I don't see the workflow modification as viable. The "patch series"
> concept is integral to every single open source project that I've ever
> worked with. The evolution of a feature or a bug fix over a series of
> patches is a core facet of programming and reviewing. It communicates a
> thinking process, and that's what programming is about.  

I don’t recall coming across the patch series (e.g. the 1/5 email patches) in 
other projects. In other projects people post a single patch and then update it 
following feedback on the same review. This can be either in a single, rebased 
commit, or new commits on a bug/feature branch - review systems deal with both.

> So how long do we wait?
>  


Good point!  

>  
>  
> What I find practical at this moment is what Stephano has been working
> on (thank you for all that Stephano) -- collect & file official
> improvement requests with GitHub, and then see how those things are
> addressed. In my opinion (not having seen Gerrit anyway, which remains
> to be evaluated, but not by me), GitHub is the direct runner up to the
> mailing list, so improving GitHub would be the most practical. In
> particular I envision the context improvements for the GitHub email
> notifications as something very doable for GitHub.  





I’d certainly be happy to use Github, but I do worry about tieing ourselves to 
such a closed system.






Rebecca

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Community Meeting Minutes

[Rebecca Cran via edk2-devel]

On Thursday, 7 February 2019 11:30:38 MST stephano wrote:

> My apologies if I was not clear in the minutes. We are not rejecting 
> Github, but rather taking time to evaluate how we can supplement 
> Github's features to emulate our current patch review requirements. We 
> do not want to rush into change and risk losing data or causing 
> frustration for those developers currently contributing on a regular basis.
> 
> I am currently working off this list of issues that Laszlo brought up:
> 
> https://lists.01.org/pipermail/edk2-devel/2018-December/033509.html
> 
> To be clear, Laszlo is not the only package maintainer that has voiced 
> these concerns. The longevity of pull request branches and the fact that 
> email notifications lack context are top on my list. There are several 
> ways to overcome these obstacles, and finding the best solution will 
> ensure that if we transition to Github, that transition is successful.
> 
> The ability to allow developers to work offline (or with intermittent 
> connections) is an important aspect as well. We cannot practice 
> exclusionary or ostracizing behaviors if we expect to grow and maintain 
> a community. I cannot imagine that Github has become as popular as it is 
> if it cannot facilitate ease of offline use.

I wonder if Phabricator could be considered again, since I believe it supports 
all the features mentioned: the only thing it doesn't support as a first-class 
feature is mutli-patch reviews, which need to be done by linking separate 
reviews together using the dependency feature. I wonder if it could either be 
enhanced to support that, or people's workflow modified?

-- 
Rebecca Cran


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] OVMF and TCP4, HTTP protocols

[Rebecca Cran via edk2-devel]

On Wednesday, 6 February 2019 12:05:08 MST Laszlo Ersek wrote:

> Is "loader.efi" opaque, or do we know what it does?

It's the FreeBSD loader, so I have the complete source code for it and can 
rebuild it.

> For example, if it opens SNP with BY_DRIVER|EXCLUSIVE attributes, then
> everything on top will be disconnected.

Oh, that makes sense! Thanks, after disabling the existing code that was 
opening SNP exclusively, things started working much better.


-- 
Rebecca Cran


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] OVMF and TCP4, HTTP protocols

[Rebecca Cran via edk2-devel]

On Wednesday, 6 February 2019 09:36:43 MST Laszlo Ersek wrote:

> please refer to the HTTP_BOOT_ENABLE define in the OVMF DSC files; the
> default value is FALSE.
> 
> If you'd like HTTP over IPv6, then please pass -D NETWORK_IP6_ENABLE on
> the "build" cmdline as well.

Thanks. I'm already building with HTTP_BOOT_ENABLE though, and successfully 
fetching loader.efi from the web server. However once loader.efi runs, my code 
can't find the HTTP or TCPv4 protocols.

>>Start HTTP Boot over IPv4.
  Station IP address is 192.168.0.119

  URI: http://192.168.0.1/boot/loader.efi
  File Size: 480256 Bytes
  Downloading...100%

-- 
Rebecca Cran


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] OVMF and TCP4, HTTP protocols

[Rebecca Cran via edk2-devel]

I'm trying to fetch a file over HTTP in a boot loader, but gBS-
>LocateHandleBuffer doesn't find either of the EFI_TCP4_SERVICE_BINDING_PROTCOL 
or EFI_HTTP_SERVICE_BINDING_PROTOCOL.

I'm running a build of OVMF from git master from a few weeks ago.
Should they exist and be usable, or does OVMF only support the 
EFI_SIMPLE_NETWORK_PROTOCOL?

-- 
Rebecca Cran


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] February Community Meeting

[Rebecca Cran via edk2-devel]

On Thursday, 31 January 2019 09:49:23 MST stephano wrote:
> We will be holding our February Community Meeting on the *2nd* Thursday
> of February to accommodate holiday schedules. Details are posted here:
> 
> https://www.tianocore.org/community-meeting/

That page 
(https://github.com/tianocore/tianocore.github.io/wiki/Community-Virtual-Meetings)
 still says "January Meeting Details" but has the details for 
February.

-- 
Rebecca Cran


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Community Meeting Minutes

[Rebecca Cran via edk2-devel]

On Friday, 11 January 2019 12:26:30 MST stephano wrote:

> Patch Review System Evaluation
> --
> After evaluating Github, Gitlab, and Phabricator, we will be remaining
> with the mailing list for now. Github did prove a possible "2nd runner
> up" (albeit distant). Also, Stephano / Nate from Intel will be reviewing
> Gerrit use with a report being sent back to the community sometime next
> week.

I wonder if we might want to have a separate mailing list for reviews? 

I find it a bit overwhelming having both patches and more general discussions 
on the same list, since I only check it every few days.

-- 
Rebecca Cran


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Undefined symbols AsmCpuid, AsmReadCr0 etc. when building OvmfPkgX64 on FreeBSD

[Rebecca Cran via edk2-devel]

While the RELEASE build of OvmfPkgX64 works fine, the DEBUG build is failing 
with undefined symbols AsmCpuid etc. when building on my FreeBSD 13-CURRENT 
system.
I’m trying to build git revision 559a07d84e5af3db09ae91844e4cb924b8f60668 (from 
Thu Dec 13 16:48:44 2018 -0700).
I’m building with gcc 7.4, running the command:

build -p OvmfPkg/OvmfPkgX64.dsc -t GCC5 -b DEBUG -a X64

The last few lines of output are:


"gcc" -o 
/home/bcran/workspace/edk2/Build/OvmfX64/DEBUG_GCC5/X64/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2keyboardDxe/DEBUG/Ps2KeyboardDxe.dll
 -nostdlib -Wl,-n,-q,--gc-sections -z common-page-size=0x40 
-Wl,--entry,_ModuleEntryPoint -u _ModuleEntryPoint 
-Wl,-Map,/home/bcran/workspace/edk2/Build/OvmfX64/DEBUG_GCC5/X64/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2keyboardDxe/DEBUG/Ps2KeyboardDxe.map,--whole-archive
 -Wl,-melf_x86_64,--oformat=elf64-x86-64,-pie -flto -Os 
-Wl,--start-group,@/home/bcran/workspace/edk2/Build/OvmfX64/DEBUG_GCC5/X64/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2keyboardDxe/OUTPUT/static_library_files.lst,--end-group
 -g -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror 
-Wno-array-bounds -ffunction-sections -fdata-sections -include AutoGen.h 
-fno-common -DSTRING_ARRAY_NAME=Ps2KeyboardDxeStrings -m64 -fno-stack-protector 
"-DEFIAPI=__attribute__((ms_abi))" -maccumulate-outgoing-args -mno-red-zone 
-Wno-address -mcmodel=small -fpie -fno-asynchronous-unwind-tables -Wno-address 
-flto -DUSING_LTO -Os -mno-mmx -mno-sse -D DISABLE_NEW_DEPRECATED_INTERFACES 
-Wl,--defsym=PECOFF_HEADER_SIZE=0x228 
-Wl,--script=/home/bcran/workspace/edk2/BaseTools/Scripts/GccBase.lds -Wno-error
Building ... /home/bcran/workspace/edk2/PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf 
[X64]
make: Nothing to be done for 'tbuild'.
Building ... 
/home/bcran/workspace/edk2/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
 [X64]
Building ... 
/home/bcran/workspace/edk2/MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
 [X64]
make: Nothing to be done for 'tbuild'.
make: Nothing to be done for 'tbuild'.
make: Nothing to be done for 'tbuild'.
Building ... 
/home/bcran/workspace/edk2/MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
 [X64]
/tmp//ccVNNewx.ltrans0.ltrans.o: In function `GetMemEncryptionAddressMask':
Building ... 
/home/bcran/workspace/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
 [X64]
/home/bcran/workspace/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c:57:
 undefined reference to `AsmCpuid'
/tmp//ccVNNewx.ltrans0.ltrans.o: In function 
`WriteBackInvalidateDataCacheRange':
/home/bcran/workspace/edk2/MdePkg/Library/BaseCacheMaintenanceLib/X86Cache.c:141:
 undefined reference to `AsmCpuid'
/home/bcran/workspace/edk2/MdePkg/Library/BaseCacheMaintenanceLib/X86Cache.c:143:
 undefined reference to `AsmWbinvd'
/home/bcran/workspace/edk2/MdePkg/Library/BaseCacheMaintenanceLib/X86Cache.c:160:
 undefined reference to `AsmFlushCacheLine'
make: Nothing to be done for 'tbuild'.
/tmp//ccVNNewx.ltrans0.ltrans.o: In function `IsReadOnlyPageWriteProtected':
make: Nothing to be done for 'tbuild'.
/home/bcran/workspace/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c:521:
 undefined reference to `AsmReadCr0'
/tmp//ccVNNewx.ltrans0.ltrans.o: In function `DisableReadOnlyPageWriteProtect':
/home/bcran/workspace/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c:534:
 undefined reference to `AsmReadCr0'
Building ... 
/home/bcran/workspace/edk2/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf 
[X64]
/home/bcran/workspace/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c:534:
 undefined reference to `AsmWriteCr0'
/tmp//ccVNNewx.ltrans0.ltrans.o: In function `SetMemoryEncDec':
/home/bcran/workspace/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c:655:
 undefined reference to `AsmReadCr3'
/tmp//ccVNNewx.ltrans0.ltrans.o: In function `EnableReadOnlyPageWriteProtect':
/home/bcran/workspace/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c:545:
 undefined reference to `AsmReadCr0'
/home/bcran/workspace/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c:545:
 undefined reference to `AsmWriteCr0'
/tmp//ccVNNewx.ltrans0.ltrans.o: In function `InternalMemEncryptSevIsEnabled':
/home/bcran/workspace/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/MemEncryptSevLibInternal.c:52:
 undefined reference to `AsmCpuid'
/home/bcran/workspace/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/MemEncryptSevLibInternal.c:57:
 undefined reference to `AsmCpuid'
/tmp//ccVNNewx.ltrans0.ltrans.o: In function `AsmReadMsr32':
/home/bcran/workspace/edk2/MdePkg/Library/BaseLib/X86Msr.c:39: undefined 
reference to `AsmReadMsr64'
collect2: error: ld returned 1 exit status
make: *** [GNUmakefile:397: 
/home/bcran/workspace/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AmdSevDxe/AmdSevDxe/DEBUG/AmdSevDxe.dll]
 Error 1


— 
Rebecca
___

Re: [edk2] GitLab results from my POV [was: Research Request]

[Rebecca Cran via edk2-devel]

On Wednesday, 12 December 2018 06:20:24 MST Laszlo Ersek wrote:

> After having looked at GitHub, Phabricator, and GitLab, my personal
> preference remains the mailing list. A *distant* second is GitHub.
> (GitHub is "almost there", but its emails significantly lack context.)
> And Phabricator and GitLab just don't cut it for me; Phabricator doesn't
> map to multi-patch series to begin with, and GitLab is too resource
> hungry, and it did a terrible job (for me anyway) preserving history.
> 
> Can someone setup Gerrit for a test drive?...

Hopefully we'll be able to pick this up again in the new year.

-- 
Rebecca


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] my Phabricator findings [was: Research Request]

[Rebecca Cran via edk2-devel]

On December 7, 2018 at 5:00:55 AM, Laszlo Ersek 
(ler...@redhat.com(mailto:ler...@redhat.com)) wrote:

> To be honest, I'm stumped how Mozilla could adopt (according to the
> article linked at the top) "Phabricator as the primary code review
> system for Firefox".  

They previously used Review Board (https://www.reviewboard.org/), which 
similarly uses a tool ‘rbt’ (RB Tools) to post/manage reviews, so it seems 
their processes are set up to work in such a way.


I can understand that our workflow is different and not a good fit for the 
model Phabricator uses.






Rebecca

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Research Request

[Rebecca Cran via edk2-devel]

On Thursday, 6 December 2018 07:13:24 MST Laszlo Ersek wrote:

> They don't contain any code (diff hunks). I hope I can change that in my
> email preferences (I haven't gotten around checking those yet). 

I've updated the Mail settings to inline diffs up to 200 lines, and also 
attach diffs to the emails. It sends git-style diffs - it can also be 
configured to send unified diffs instead.

>   nore...@phabricator.example.com
> 
> That doesn't look right even for this testing; can you please update the
> config? I believe the emails should come from a sender @
> code.bluestop.org. Is that correct?

I've configured it to send from p...@bluestop.org .

I'm sure there are other things that aren't properly configured (for example, 
I've not set it up so you can reply to emails and have those replies be added 
to the review), but hopefully it gives you an idea of what it can do.

-- 
Rebecca


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Research Request

[Rebecca Cran via edk2-devel]

On December 6, 2018 at 7:13:24 AM, Laszlo Ersek 
(ler...@redhat.com(mailto:ler...@redhat.com)) wrote:

> I've just noticed that I got the following emails:
>  
> [Differential] [Request] [+ ] D1: Update URL of OVMF page
> [Differential] [Updated] D1: Update URL of OVMF page
>  
> They don't contain any code (diff hunks). I hope I can change that in my
> email preferences (I haven't gotten around checking those yet). However,
> one bit that I doubt I'll be able to update myself, is the sender for
> these emails:
>  
> nore...@phabricator.example.com  

Yeah, sorry - I’ll fix the configuration this evening to send diffs and allow 
replies to emails (and update the domain name).






Rebecca

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Research Request

[Rebecca Cran via edk2-devel]

On Wednesday, 5 December 2018 05:55:41 MST Laszlo Ersek wrote:

> Can you assist with the following please?

Also, a couple of notes:

Go to https://code.bluestop.org/settings/user/lersek/  to configure preferences 
related to emails (http/plain), diffs etc.

Install the arcanist package on your system or follow the instructions at 
https://secure.phabricator.com/book/phabricator/article/arcanist/#installing-arcanist
 to get a copy (the 'arc' command). It's the command-line interface to 
Phabricator.

https://code.bluestop.org/differential/ is your main code reviews page.
https://code.bluestop.org/diffusion/ is a repo browser.
https://code.bluestop.org/maniphest/ (if we were to use it) is for tasks and 
bugs.

-- 
Rebecca


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Research Request

[Rebecca Cran via edk2-devel]

On Wednesday, 5 December 2018 05:55:41 MST Laszlo Ersek wrote:

> (1) Pls. explain to me how I can create an edk2 clone at
> . :)

You don't. In a production system it may be possible to clone from either 
GitHub or code.bluestop.org (which mirrors github), but the clone URL given 
when you click "Clone" on https://code.bluestop.org/diffusion/EDK/ doesn't 
work (since I've not configured it).
 
> (2) Please create a throw-away account for yourself.

Done (though not throw-away).
 
> (3) Submit a pullreq against (1), with a topic branch that has two
> commits, and simple text file modifications.

https://code.bluestop.org/D1
Since Phabricator doesn't care about topic branches (just patches), I created 
a diff to README.

-- 
Rebecca




___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Research Request

[Rebecca Cran via edk2-devel]

On Monday, 3 December 2018 02:29:28 MST Laszlo Ersek wrote:
> On 11/29/18 22:20, Rebecca Cran wrote:
> > Would you be interested in going through this process with Phabricator,
> > too?
> Sure! Just tell me where to create an account.

Go to https://code.bluestop.org/auth/register/ to create a new account on the 
system, or https://code.bluestop.org/auth/ to login using an existing GitHub 
account.

- -
Rebecca


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Research Request

[Rebecca Cran via edk2-devel]

Would you be interested in going through this process with Phabricator, too? 

Rebecca


On November 29, 2018 at 2:48:18 AM, Laszlo Ersek 
(ler...@redhat.com(mailto:ler...@redhat.com)) wrote:

> On 11/29/18 02:07, Jeremiah Cox wrote:
> > I did a further experiment for you:
> > https://github.com/lersek/edk2/pull/2
> 
> Thanks!
> 
> > I cannot rebase away my history from PRs...
> > Hopefully you have a nice email trail too.
> 
> The emails are coming in nice, but I'm not universally pleased with the
> contents. I listed some issues regarding that in
> , but I guess I should write them
> up sometime more readably, at the end of this experiment.
> 
> Thanks!
> Laszlo
> 
> > -Original Message-
> > From: Laszlo Ersek 
> > Sent: Wednesday, November 28, 2018 2:02 PM
> > To: Jeremiah Cox ; Brian J. Johnson 
> > ; stephano 
> > Cc: edk2-devel@lists.01.org
> > Subject: Re: [edk2] [edk2-announce] Research Request
> > 
> > On 11/28/18 19:31, Jeremiah Cox wrote:
> > > Test PR submitted
> > 
> > Thanks!
> > Laszlo
> > 
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Research Request

[Rebecca Cran via edk2-devel]

On Wednesday, 28 November 2018 11:19:33 MST Jeremiah Cox wrote:
> There is a question of how the below is automated such that when there is a
> security advisory, a Phabricator instance is patched in a timely fashion. 
> Perhaps there is a mailing list that would announce these and that could
> trigger an auto-update script.

I'm not sure most people would like installations to be automatically updated 
without at least reviewing what such a script was going to do.

I agree someone would need to monitor for security advisories though, and 
schedule maintenance windows to update it.

-- 
Rebecca


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce] Research Request

[Rebecca Cran via edk2-devel]

On Tuesday, 27 November 2018 14:16:18 MST Jeremiah Cox via edk2-devel wrote:

> Do we have data on what it takes to deploy and operate Phabricator with
> Harbormaster or Jenkins?  The up front development/deployment
> activity/costs and then also the ongoing patching/servicing/maintenance
> costs?  Is Intel planning to provide this?

I haven't integrated Harbormaster or Jenkins, but for just Phabricator the 
patching/servicing has ben really simple for the year+ I've been running it. 
I'd not consider it 'production' since I'm the only person using it and I'm 
running from Git master, not a stable branch - but maintenance has been as 
simple as the following (which could of course be put in a script to reduce 
the number of steps!):

# Stop the Phabricator daemon
./bin/phd stop
# Update Phabricator
git pull
# Update libphputil
cd ../libphputil && git pull
# Upgrade arcanist (commandline interface)
cd ../arcanist && git pull
# Upgrade database schema
./bin/storage upgrade
# Start Phabricator daemon
./bin/phd start
# Reload web server
service nginx restart
service php-fpm restart

The "storage upgrade" command goes through the database looking for any 
inconsistencies - missing keys, wrong data types etc., and offers to fix them.

-- 
Rebecca


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Newbie: Getting Ovmf built

[Rebecca Cran via edk2-devel]

On Friday, 23 November 2018 17:40:15 MST stephano wrote:

> We have a set of simple instructions for folks building on standard
> Linux distros. Please have a look at this page:
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Common-instructions
> 
> Note: Be sure the TARGET_ARCH is set correctly. (E.g. TARGET_ARCH = x64)

If you just want to build OVMF, there's a simpler way. After cloning, and 
assuming you're running bash, just:

cd edk2
. ./edksetup.sh
./OvmfPkg/build.sh -a X64 -t GCC5 -b RELEASE

If the build succeeds you'll end up with Build/OvmfX64/RELEASE_GCC5/FV/OVMF.fd 
which is the 'BIOS' image to pass to Qemu, e.g.:

qemu-system-x86_64 -m 4g -drive if=pflash,format=raw,readonly,file=Build/
OvmfX64/RELEASE_GCC5/FV/OVMF.fd \
-nodefaults \
-drive format=raw,file=/hda.img -monitor stdio \
-vga std -sdl -drive format=raw,file=Install.iso

-- 
Rebecca


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce][RFC] Collaboration Software

[Rebecca Cran via edk2-devel]

On Friday, 16 November 2018 19:42:51 MST Sean Brogan via edk2-devel wrote:
> Mike,
> 
> I like the github teams option for discussion as it is just there, free, and
> easy.  It integrates nicely with all other parts of github.  Notifications
> are supported for those that want email.   Is there any reason this path
> doesn't get used now as a test since tianocore is already in github?  

I do wonder why there aren't more _big_ open source projects using Github if 
it _is_ there, free and easy to use. I'm aware lots and lots use it for 
hosting their repositories, but I'm not aware of many that use it for code 
reviews, discussions etc.

I found that CoreBoot uses Gerrit: https://review.coreboot.org/q/status:open

GNOME evaluated Phabricator and GitLab (but not GitHub, because "GitHub is not 
Free Software, of couse, which makes it unacceptable to many in the GNOME 
community") - https://wiki.gnome.org/Initiatives/DevelopmentInfrastructure .
They decided to go with GitLab:
https://mail.gnome.org/archives/desktop-devel-list/2017-May/msg00051.html

One comment from a user on the GNOME evaluation (https://wiki.gnome.org/
Initiatives/DevelopmentInfrastructure/Comments) said:

"We tried migrating libnice to phabricator.freedesktop.org and it was a bit of 
a disaster as the "drive-by" contribution process is horrible with 
Phabricator, requiring to either download a tool or copy-paste patches into a 
webpage. Upstream Phabricator is also very hostile to the github style of 
reviews (where you can review small patches, not everything squashed into one 
SVN style). Even Bugzilla with Splinter is nicer for new contributors.. So 
let's go with GitLab. That said, all of Collabora's Phabricator tools are 
already public. ? OlivieCrete"

-- 
Rebecca


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce][RFC] Collaboration Software

[Rebecca Cran via edk2-devel]

On November 16, 2018 at 7:42:51 PM, Sean Brogan via edk2-devel 
(edk2-devel@lists.01.org(mailto:edk2-devel@lists.01.org)) wrote:

> I really can't get behind the Phabricator tool suite as it just has too many 
> downsides (self-hosted or pay, lack of integrations, lack of support and 
> limited searchability, poor ci integration, etc).  
>  






At least with Phabricator you don’t have to pay to self-host it. And look at 
all the features you don’t get with Github unless you pay them:


https://github.com/pricing






Rebecca


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce][RFC] Collaboration Software

[Rebecca Cran via edk2-devel]

On Friday, 16 November 2018 14:42:44 MST stephano wrote:

> This is a great suggestion, thanks! Two questions:

> 1. Does it allow you to export your conversations in some way?

Conversations can followed via email, so that's one way of 'exporting' them. 
But otherwise, I suspect you'd need to either query the database directly or 
use "./bin/storage dump":

DUMP WORKFLOW

dump [options]
Dump all data in storage to stdout.

  --compress
  With --output, write a compressed file to disk instead of a
  plaintext file.

  --for-replica
  Add --master-data to the mysqldump command, generating a CHANGE
  MASTER statement in the output.

  --no-indexes
  Do not dump data in rebuildable index tables. This means backups
  are smaller and faster, but you will need to manually rebuild
  indexes after performing a restore.

  --output file
  Write output directly to disk. This handles errors better than
  using pipes. Use with --compress to gzip the output.

  --overwrite
  With --output, overwrite the output file if it already exists.


> 2. Is there a "file sharing" option if we wanted to, for example, share
> a JPG or ODF file?

Yes: Phabricator has a general file storage service, and files can be uploaded 
via that and shared in Conpherence.

-- 
Rebecca


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-announce][RFC] Collaboration Software

[Rebecca Cran via edk2-devel]

On Friday, 16 November 2018 12:13:37 MST stephano wrote:
> The only reason I didn't include Slack is that it will only log so much
> information before things start falling off into the ether.
> 
> Does anyone in the community currently use Slack and know of an easy way
> of archiving conversations publicly?

I'm in several Slack teams: it seems to be the go-to solution for persistent 
chat nowadays. None of those pay (i.e. they're on the free tier), so are 
subject to its 10,000 message history limit.

Another option may be Conpherence, which comes with Phabricator: https://
www.phacility.com/phabricator/conpherence/ :

"Conpherence is a group messaging application integrated into Phabricator. 
Message one-on-one or with a group of people, name your room, and keep a 
history of everything in one place. Reply via email, on the web, or on your 
mobile device.

Conpherence supports Remarkup that makes it easy to link to Maniphest tasks 
and code reviews, share code snippets, format tables, and share memes. 
Conpherence even has a persistent chat sidebar built-in, so you don't need to 
keep another tab open."

-- 
Rebecca


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel