Re: [edk2] [PATCH] MdeModulePkg/DxeCore: set ImageContext Handle and ImageRead() fields

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Friday, April 29, 2016 3:44 PM To: edk2-devel@lists.01.org; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z..

Re: [edk2] [PATCH 0/3] OvmfPkg: tighten the SMM lockdown

On 2016/4/28 3:20, Laszlo Ersek wrote: The first patch (for MdeModulePkg) fixes a bug that is exposed (triggered) by the third patch. The second and third patches fix a security vulnerability in OVMF that I reported to the UEFI SRT more than three weeks ago: To: secur...@uefi.org,

Re: [edk2] [PATCH 2/2] PerformancePkg/Dp_App: Fix the error message "Timer library instance error!"

Cinnamon, On 2016/4/29 10:42, Cinnamon Shia wrote: When executing shell dp command, there is an error message "Timer library instance error!" The error message "Timer library instance error!" should be for the case about duration > EndTimeStamp if CountUp or duration < StartTimeStamp if

Re: [edk2] [Patch] MdeModulePkg: Add description to MdeModulePkg AcpiTable driver.

On 2016/4/25 10:34, Liming Gao wrote: Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by: Star Zeng --- MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf | 3

Re: [edk2] PcRtcAcpiTableChangeCallback question

How about to call PcRtcAcpiTableChangeCallback(NULL, NULL) explicitly before or after the event creation instead of signal the event? The event is a group event, it is not same with the event in EfiCreateProtocolNotifyEvent() that is a single event, signal a group event may make other consumer

Re: [edk2] [Patch] MdePkg: Update StatusCode Runtime Protocol comments to follow PI spec.

How about to point out which PI version the patch is to follow explicitly in the commit log or title? With that, Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Gao, Liming Sent: Wednesday, May 18, 2016 9:46 AM To: edk2-devel@lists.01.org Cc

Re: [edk2] a minor logic error in PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c

The patch has been pushed at dde4aedc35ee3c06b67c1a5c4f392e7a0b0f8254. Thanks for the contribution. Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang xiaofeng Sent: Friday, May 13, 2016 10:56 AM To: Zeng, Star <star.z...@intel.com&

Re: [edk2] a minor logic error in PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c

I think you are right. Could you help contribute the patch to fix it? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang xiaofeng Sent: Friday, May 13, 2016 10:20 AM To: edk2-devel@lists.01.org Subject: [edk2] a minor logic error

Re: [edk2] [RFC] Proposal to organize packages into directories

Mike, Could we put PerformancePkg into the Deprecated directory? As PerformancePkg\Library\TscTimerLib could be replaced by PcAtChipsetPkg\Library\AcpiTimerLib and ShellPkg\Library\UefiDpLib has the same functionality with PerformancePkg\Dp_App. The valid concern is that user may want a

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Pushed at 69af847603ca1f6439031c4e1fee844fdb06ca6f and 0cd1e699e5f76b3323b5881932af8a62bc5edf2a. Thanks, Star -Original Message- From: Carsey, Jaben Sent: Monday, May 2, 2016 11:33 PM To: Zeng, Star <star.z...@intel.com>; Cinnamon Shia <cinnamon.s...@hpe.com>; edk2-devel@

Re: [edk2] [PATCH 2/2] PerformancePkg/Dp_App: Fix the error message "Timer library instance error!"

1.org] On Behalf Of Shia, Cinnamon Sent: Friday, April 29, 2016 7:03 PM To: Zeng, Star <star.z...@intel.com> Cc: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org; Qiu, Shumin <shumin@intel.com> Subject: Re: [edk2] [PATCH 2/2] PerformancePkg/Dp_App: Fix th

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Reviewed-by: Star Zeng <star.z...@intel.com> to series. Thanks, Star -Original Message- From: Cinnamon Shia [mailto:cinnamon.s...@hpe.com] Sent: Monday, May 2, 2016 12:34 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin <shumin@intel.com>; Zeng, Star <star.z...@inte

Re: [edk2] [patch] MdeModulePkg/UsbMass: Not retry if usb bot transfer execution fail

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Tian, Feng Sent: Wednesday, August 3, 2016 10:08 AM To: Zeng, Star <star.z...@intel.com> Cc: edk2-devel@lists.01.org Subject: [patch] MdeModulePkg/UsbMass: Not retry if usb bot transfer execution

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: Fix buffer overflow issue.

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Dong, Eric Sent: Tuesday, August 2, 2016 7:33 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [Patch] SecurityPkg OpalPasswordDxe: Fix buffer overflow issue. In curren

Re: [edk2] [MdeModulePkg] SetVirtualAddressMap() crashed due to DxeReportStatusCodeLib assuming the state of the BootService Memory at runtime.

phase. " Thanks, Star -Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Thursday, August 11, 2016 3:04 AM To: Kinney, Michael D <michael.d.kin...@intel.com> Cc: Zeng, Star <star.z...@intel.com>; edk2-devel <edk2-devel@lists.01.org> Subje

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Get more accurate TSC Frequency

On 2016/8/11 21:41, Brian J. Johnson wrote: On 08/10/2016 09:37 PM, Star Zeng wrote: Minimize the code overhead between the two TSC reads by adding new internal API to calculate TSC Frequency instead of reusing MicroSecondDelay (). Why not just use the MSR_PLATFORM_INFO (0xce) register bits

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Get more accurate TSC Frequency

On 2016/8/12 16:31, Paolo Bonzini wrote: On 11/08/2016 04:37, Star Zeng wrote: Minimize the code overhead between the two TSC reads by adding new internal API to calculate TSC Frequency instead of reusing MicroSecondDelay (). Cc: Michael D Kinney Cc: Liming Gao

Re: [edk2] [PATCH v1 1/1] MdeModulePkg/PeiCore: Fix ConverSinglePpiPointer () typo.

Just pushed the patch at de74668f5ea713b7e91e01318f0d15d2bf0effce. Thanks, Star -Original Message- From: Tian, Feng Sent: Monday, August 15, 2016 9:32 AM To: Zeng, Star <star.z...@intel.com>; marvin.haeu...@outlook.com; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@

Re: [edk2] [PATCH v1 1/1] MdeModulePkg/PeiCore: Fix ConverSinglePpiPointer () typo.

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Saturday, August 13, 2016 9:54 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subj

Re: [edk2] [MdeModulePkg] SetVirtualAddressMap() crashed due to DxeReportStatusCodeLib assuming the state of the BootService Memory at runtime.

On 2016/8/11 9:59, Andrew Fish wrote: On Aug 10, 2016, at 6:53 PM, Zeng, Star <star.z...@intel.com> wrote: If a DXE_RUNTIME_DRIVER driver just wants to report status code at boot phase and links to DxeReportStatusCodeLib, is it a bug? How about just to add notes for DxeReportStatusC

Re: [edk2] [PATCH] SecurityPkg: AuthVariableLib: Cache UserPhysicalPresent in AuthVariableLib

Reviewed-by: Star Zeng <star.z...@intel.com> On 2016/6/27 15:12, Yao, Jiewen wrote: Reviewed-by: jiewen@intel.com -Original Message- From: Zhang, Chao B Sent: Monday, June 27, 2016 3:06 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Zeng,

Re: [edk2] [PATCH] MdeModulePkg/Bds: MemoryTypeInformation excludes boot option mem use

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Tuesday, July 5, 2016 5:47 PM To: edk2-devel@lists.01.org Cc: Sunny Wang <sunnyw...@hpe.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH] MdeModulePkg/Bds: MemoryTypeInforma

Re: [edk2] [patch 2/3] MdeModulePkg/UsbBus: reduce the port status polling before port reset

ay, July 11, 2016 11:22 AM To: Zeng, Star <star.z...@intel.com> Cc: edk2-devel@lists.01.org Subject: [edk2] [patch 2/3] MdeModulePkg/UsbBus: reduce the port status polling before port reset This change is used to remove the port status polling in port reset functions. Why it's needed is beca

Re: [edk2] [patch 1/3] MdeModulePkg/UsbBus: remove redundant host controller reset in UsbBus

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Tian, Feng Sent: Monday, July 11, 2016 11:22 AM To: Zeng, Star <star.z...@intel.com> Cc: edk2-devel@lists.01.org Subject: [patch 1/3] MdeModulePkg/UsbBus: remove redundant host controller reset in UsbB

Re: [edk2] [patch 3/3] MdeModulePkg/XhciDxe: fix a bug on TRB check in async int transfer

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Tian, Feng Sent: Monday, July 11, 2016 11:22 AM To: Zeng, Star <star.z...@intel.com> Cc: edk2-devel@lists.01.org Subject: [patch 3/3] MdeModulePkg/XhciDxe: fix a bug on TRB check in async int transfer

Re: [edk2] [PATCH 11/16] MdeModulePkg: Series of patches to fix typos

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Mudusuru, Giri P Sent: Thursday, July 7, 2016 3:48 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: [edk2] [PATCH 11/16] MdeModulePkg:

Re: [edk2] [patch] NetworkPkg: Fix Assert issue in iSCSI driver.

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, July 8, 2016 3:51 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin

Re: [edk2] [PATCH] MdeModulePkg MemoryProfile: ASSERT to ensure 'DriverInfoData' is not NULL

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Wu, Hao A Sent: Friday, July 8, 2016 12:35 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH] MdeModulePkg MemoryProfile

Re: [edk2] [PATCH 08/17] MdeModulePkg DSC: Add build option to disable deprecated APIs

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Wu, Hao A Sent: Friday, August 5, 2016 8:53 AM To: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com> Cc: Wu, Hao A <hao.a...@intel.com>; Tian, Feng <feng.t...@intel.com>; Zeng, S

Re: [edk2] [MdeModulePkg] SetVirtualAddressMap() crashed due to DxeReportStatusCodeLib assuming the state of the BootService Memory at runtime.

Andrew, Should MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib be used for your case if there are really runtime status code reporting needed? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Tuesday, August 9,

Re: [edk2] [patch] MdeModulePkg/AtaAtapiPassThru: update AtaStatusBlock after cmd exec

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Tian, Feng Sent: Tuesday, August 9, 2016 3:42 PM To: Zeng, Star <star.z...@intel.com> Cc: edk2-devel@lists.01.org Subject: [patch] MdeModulePkg/AtaAtapiPassThru: update AtaStatusBlock aft

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

value as returned by EFI_BOOT_SERVICES.GetMemoryMap()." Thanks, Star -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Monday, June 20, 2016 1:08 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>

Re: [edk2] [PATCH] MdeModulePkg MemoryProfile: Add ASSERTs to make sure pointers are not NULL

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Wu, Hao A Sent: Monday, July 4, 2016 12:54 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH] MdeModulePkg MemoryProfile: Add AS

Re: [edk2] [PATCH] MdeModulePkg DxeIplPeim: Add ASSERTs for unexpected AllocatePages failure

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Wu, Hao A Sent: Monday, July 4, 2016 2:01 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subje

Re: [edk2] [PATCH 0/2] MdeModulePkg/AcpiTableDxe: improve FADT.{DSDT, X_DSDT} mutual exclusion

vel@lists.01.org> Cc: Tian, Feng <feng.t...@intel.com>; Michael Tsirkin <mtsir...@redhat.com>; Ard Biesheuvel <ard.biesheu...@linaro.org>; Phil Dennis-Jordan <p...@philjordan.eu>; Leo Duran <leo.du...@amd.com>; Al Stone <a...@redhat.com>; Zeng, Star <st

Re: [edk2] [Patch 2/2] MdeModulePkg PeiCore: Don't cache GUIDED section with AUTH_NOT_TESTED

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Gao, Liming Sent: Thursday, February 9, 2017 12:15 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [Patch 2/2] MdeModulePkg PeiCore: Don't cache GUIDED section with AUT

Re: [edk2] [Patch 1/2] MdeModulePkg PeiCore: Reset PeimNeedingDispatch when its security violation

software module by using StartImage() or an equivalent PEI service. Thanks, Star -Original Message- From: Gao, Liming Sent: Thursday, February 9, 2017 12:15 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [Patch 1/2] MdeModulePkg PeiCore: Reset PeimNeedingDispat

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

long mode. gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE|BOOLEAN|0x0001003b -- Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, February 9, 2017 3:48 AM To: Yao, Jiewen <jiewen@intel.com>; Duran, Leo <leo.du...@amd.com>; Zeng, Star <star.z...@intel.com>; edk

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

ginal Message- From: Zeng, Star Sent: Thursday, February 9, 2017 1:12 PM To: Laszlo Ersek <ler...@redhat.com>; Yao, Jiewen <jiewen@intel.com>; Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org Cc: Tian, Feng <feng.t...@intel.com>; Singh, Brijesh <brije

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

to above, the patch I drafted is wrong. Thanks, Star From: Yao, Jiewen Sent: Thursday, February 9, 2017 1:23 PM To: Zeng, Star <star.z...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org Cc: Tian, Feng <feng.t...@intel.com

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

, Feng <feng.t...@intel.com>; Brijesh Singh <brijesh.si...@amd.com>; Zeng, Star <star.z...@intel.com>; Leo Duran <leo.du...@amd.com> Subject: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask From: Brijesh Singh <brijesh.si...@amd.com>

Re: [edk2] [PATCH] Fix some typos of "according"

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Rebecca Cran [mailto:rebe...@bluestop.org] Sent: Wednesday, February 8, 2017 3:41 AM To: edk2-devel@lists.01.org Cc: Rebecca Cran <rebe...@bluestop.org>; Tian, Feng <feng.t...@intel.com>;

Re: [edk2] [PATCH 1/3] MdePkg: Add definitions for SMBIOS spec 3.1.1

Yes, good catch. Thanks, Star -Original Message- From: Gao, Liming Sent: Tuesday, January 24, 2017 3:25 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [PATCH 1/3] MdePkg: Add definitions for

Re: [edk2] [PATCH 2/3] MdePkg: VariableDxe: Use UEFI_VARIABLE_DATA

;; Zhang, Chao B <chao.b.zh...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH 2/3] MdePkg: VariableDxe: Use UEFI_VARIABLE_DATA Use UEFI_VARIABLE_DATA data structure according to TCG PC-Client PFP Spec 00.21. http://www.trustedcomputinggro

Re: [edk2] [PATCH 2/3] MdePkg: VariableDxe: Use UEFI_VARIABLE_DATA

Please update "MdePkg" to "MdeModulePkg" in the title. Thanks, Star -Original Message----- From: Zeng, Star Sent: Tuesday, January 24, 2017 4:33 PM To: Zhang, Chao B <chao.b.zh...@intel.com>; edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>;

Re: [edk2] [PATCH] SecurityPkg: Tcg2Dxe: Update PCR[4] measure logic

hang, Chao B <chao.b.zh...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH] SecurityPkg: Tcg2Dxe: Update PCR[4] measure logic Update PCR[4] measure logic for each boot attempt. 1. Measure event to PCR[4] instead of PCR[5] 2. Measure “Calling UEFI Applicatio

Re: [edk2] [PATCH V2 2/3] SecurityPkg: Tcg2Dxe: Measure DBT into PCR[7]

day, January 19, 2017 1:14 PM To: edk2-devel@lists.01.org Cc: yao.jie...@intel.com; Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com> Subject: [PATCH V2 2/3] SecurityPkg: Tcg2Dxe: Measure DBT into PCR[7] Measure DBT into P

Re: [edk2] [PATCH V2 3/3] MdeModulePkg: Variable: Update PCR[7] measure for new TCG spec

PM To: edk2-devel@lists.01.org Cc: yao.jie...@intel.com; Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com> Subject: [PATCH V2 3/3] MdeModulePkg: Variable: Update PCR[7] measure for new TCG spec Measure DBT into PCR[7

Re: [edk2] [PATCH V2 1/3] SecurityPkg: DxeImageVerificationLib: Update PCR[7] measure logic

.org Cc: Zhang, Chao B <chao.b.zh...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@intel.com>; yao.jie...@intel.com Subject: [edk2] [PATCH V2 1/3] SecurityPkg: DxeImageVerificationLib: Update PCR[7] measure logic Update PCR[7] measure logic according to

Re: [edk2] [PATCH V3] MdeModulePkg: Variable: Update PCR[7] measure for new TCG spec

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Zhang, Chao B Sent: Sunday, January 22, 2017 12:54 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@intel.com>; Zhang, Chao B <chao.b.zh.

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

Ray & Jaben, I am not so sure about the rule. The mixed using of strings in c code and strings in uni file has been there since it was created. Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Sunday, January 22, 2017 4:56 PM To: Zeng, Star <star.z...@intel.com>; edk2-d

Re: [edk2] UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)

' <edk2-de...@ml01.01.org>; Tian, Feng <feng.t...@intel.com> Cc: Zeng, Star <star.z...@intel.com> Subject: [edk2] UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c) Hi Feng, et al, I'm wondering if the SetCacheability() function has been deprecated from the build tree? That is, th

Re: [edk2] [PATCH v3 2/4] MdeModulePkg/Universal/CapsulePei: Add support for PCD PcdPteMemoryEncryptionAddressOrMask

xt->PhyMask) == Address) like you did at other place? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Duran, Leo Sent: Wednesday, February 22, 2017 12:43 AM To: Zeng, Star <star.z...@intel.com>; edk2-de...@ml01.01.org C

Re: [edk2] [PATCH 00/12] Add SmiHandlerProfile feature

ntel.com>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>; Laszlo Ersek <ler...@redhat.com> Subject: [PATCH 00/12] Add SmiHandlerProfile feature This series patch add SMI handler profile. The purpose of SMI handler profile is to add the capabilit

Re: [edk2] [PATCH v4 1/3] MdeModulePkg: Add performance property configuration table

lists.01.org; Carsey, Jaben <jaben.car...@intel.com>; Zeng, Star <star.z...@intel.com>; Andrew Fish <af...@apple.com>; Gao, Liming <liming@intel.com> Subject: Re: [edk2] [PATCH v4 1/3] MdeModulePkg: Add performance property configuration table On 3 February 2017 at 05:3

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

eng <feng.t...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error Platform PEI may add LOCAL APIC memory mapped space into EFI_HOB_MEMORY_ALLOCATION. Or platform may a

Re: [edk2] [PATCH v3 2/4] MdeModulePkg/Universal/CapsulePei: Add support for PCD PcdPteMemoryEncryptionAddressOrMask

Leo, Comments added inline. On 2017/2/17 5:02, Leo Duran wrote: This PCD holds the address mask for page table entries when memory encryption is enabled on AMD processors supporting the Secure Encrypted Virtualization (SEV) feature. The mask is applied when 4GB tables are created

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

EFI_HOB_CPU? Is there discussion in PIWG for it? Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, February 9, 2017 5:13 PM To: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Duran, Leo <leo.du...@am

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

Seemingly not big problem since OVMF does not support 64BITs waking vector. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, February 9, 2017 5:10 PM To: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Duran,

Re: [edk2] [PATCH v2] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, February 9, 2017 3:05 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star

Re: [edk2] [PATCH 2/3] MdeModulePkg/Universal/CapsulePei: Add support for PCD PcdPteMemoryEncryptionAddressOrMask

com>; Tian, Feng <feng.t...@intel.com>; Leo Duran <leo.du...@amd.com>; Brijesh Singh <brijesh.si...@amd.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH 2/3] MdeModulePkg/Universal/CapsulePei: Add support for PCD PcdPteMemoryEncryptionAddressOrMask T

Re: [edk2] [PATCH 1/3] MdeModulePkg: Add PCD PcdPteMemoryEncryptionAddressOrMask

.t...@intel.com>; Brijesh Singh <brijesh.si...@amd.com>; Zeng, Star <star.z...@intel.com>; Leo Duran <leo.du...@amd.com> Subject: [edk2] [PATCH 1/3] MdeModulePkg: Add PCD PcdPteMemoryEncryptionAddressOrMask From: Brijesh Singh <brijesh.si...@amd.com> This PCD holds the addre

Re: [edk2] [PATCH 3/3] UefiCpuPkg/Universal/Acpi/S3Resume2Pei: Add support for PCD PcdPteMemoryEncryptionAddressOrMask

Leo Duran <leo.du...@amd.com>; Fan, Jeff <jeff@intel.com>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Brijesh Singh <brijesh.si...@amd.com> Subject: [PATCH 3/3] UefiCpuPkg/Uni

Re: [edk2] [PATCH] PcAtChipsetPkg: Fix typing errors

Reviewed-by: Star Zeng I can help push the patch at tomorrow if no other comments are received. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Thomas Huth Sent: Wednesday, January 18, 2017 9:40 PM To: Ni,

Re: [edk2] [PATCH] MdeModulePkg: Remove superfluous return statements

.@ml01.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH] MdeModulePkg: Remove superfluous return statements If the code eventually returns "Status" anyway, it does not make sense to explicitely return "Status" in cas

Re: [edk2] [PATCH 0/7] Make the event empty function in UefiLib public

Hi, Please kindly help take a review to the patches. :) So far, I have got the RB from Liming and Ard to MdePkg and ArmPlatformPkg. Thanks, Star -Original Message- From: Zeng, Star Sent: Tuesday, January 17, 2017 3:09 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.

Re: [edk2] [PATCH] PcAtChipsetPkg: Fix typing errors

Pushed at https://github.com/tianocore/edk2/commit/619ad10f3af2774880867dd638a8016d3181b516, thanks for the contribution. Star -Original Message- From: Zeng, Star Sent: Thursday, January 19, 2017 9:43 AM To: Thomas Huth <th...@redhat.com>; Ni, Ruiyu <ruiyu...@intel.com&g

Re: [edk2] [PATCH] MdeModulePkg: Remove superfluous return statements

No need to resend path, I can help push it with the typo fixed. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Thomas Huth Sent: Friday, January 20, 2017 1:58 PM To: Zeng, Star <star.z...@intel.com>; edk2-de...@ml01.01.org Cc

Re: [edk2] [PATCH] MdeModulePkg: Remove superfluous return statements

Pushed the patch at cd5b2ae437553df0e491f926b8748bf88809e76a, thanks for the contribution. Star -Original Message- From: Zeng, Star Sent: Friday, January 20, 2017 2:03 PM To: Thomas Huth <th...@redhat.com>; edk2-de...@ml01.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng,

Re: [edk2] [PATCH 0/7] Make the event empty function in UefiLib public

, CorebootPayloadPkg and ArmPlatformPkg with RB received. And I will keep QuarkPlatformPkg as is before I get any RB. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, January 19, 2017 6:30 PM To: Zeng, Star

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: On 08/19/16 04:00, Fan, Jeff wrote: Laszlo, I could revert this patch firstly. Thank you, that would be very kind. Could you please dig out the OVMF to address the potential issue, then I could re-commit

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

On 2016/8/19 10:26, Laszlo Ersek wrote: On 08/19/16 04:00, Fan, Jeff wrote: Laszlo, I could revert this patch firstly. Thank you, that would be very kind. Could you please dig out the OVMF to address the potential issue, then I could re-commit it for those platforms required this patch.

Re: [edk2] [PATCH V1] SecurityPkg: AuthVariableLib: Fix potential inconsistency corner case for Time Auth variable

B <chao.b.zh...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH V1] SecurityPkg: AuthVariableLib: Fix potential inconsistency corner case for Time Auth variable 2 steps are used to create/delete a time based variable. For create, step 1: Insert Signer Cert to CertDB

Re: [edk2] [PATCH v4 1/6] MdeModulePkg: Add PCD PcdPteMemoryEncryptionAddressOrMask

Reviewed-by: Star Zeng <star.z...@intel.com> to MdeModulePkg changes. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Duran, Leo Sent: Monday, February 27, 2017 10:13 PM To: Zeng, Star <star.z...@intel.com>; edk2-de...@ml

Re: [edk2] [PATCH 2/7] MdeModulePkg: Replace [Ascii|Unicode]ValueToString

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Wu, Hao A Sent: Tuesday, February 21, 2017 7:35 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Tian, Feng <feng.t...@intel.com>; Zeng, S

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

If it is really needed, I am fine to either this patch or another patch to add it. :) Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Monday, February 27, 2017 4:16 PM To: Zeng, Star <star.z...@intel.com&

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

; Yao, Jiewen <jiewen@intel.com>; leif.lindh...@linaro.org Cc: Tian, Feng <feng.t...@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org>; af...@apple.com; Gao, Liming <liming@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; ler...@redhat.com; Z

Re: [edk2] [PATCH 0/2] Dp: Add check to avoid NULL pointer dereference

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Wu, Hao A Sent: Monday, February 27, 2017 9:39 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH 0/2] Dp: Add check to avoid NULL p

Re: [edk2] [PATCH v4 1/6] MdeModulePkg: Add PCD PcdPteMemoryEncryptionAddressOrMask

Cc: Leo Duran <leo.du...@amd.com>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Brijesh Singh <brijesh.si...@amd.com> Subject: [PATCH v4 1/6] MdeModulePkg: Add PCD PcdPteMemoryEncryptionAddressOrMask T

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

Biesheuvel <ard.biesheu...@linaro.org>; edk2-devel@lists.01.org; Yao, Jiewen <jiewen@intel.com>; leif.lindh...@linaro.org Cc: af...@apple.com; Kinney, Michael D <michael.d.kin...@intel.com>; ler...@redhat.com; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.

Re: [edk2] [PATCH v4 0/6] Add PCD PcdPteMemoryEncryptionAddressOrMask

The patch series has been pushed at https://github.com/tianocore/edk2/compare/a9b4ee43d319...241f914975d5. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leo Duran Sent: Monday, February 27, 2017 1:43 AM To: edk2-de...@ml01.01.org

Re: [edk2] [PATCH 0/7] MdeModulePkg ArmVirtPkg: fixes for 64-bit PCI DMA

Also cc Ruiyu to see if any comments. Thanks, Star -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, September 6, 2016 3:48 PM To: edk2-devel-01 <edk2-devel@lists.01.org>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@

Re: [edk2] [PATCH v5 0/4] deModulePkg/EbcDxe: AARCH64 improvements

I am fine. :) Thanks, Star -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, September 2, 2016 2:26 PM To: edk2-devel-01 <edk2-devel@lists.01.org>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Cc: Leif Li

Re: [edk2] [patch] MdeModulePkg/XhciPei: 1ms delay before accessing MMIO reg in reset

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Tian, Feng Sent: Wednesday, September 14, 2016 9:49 AM To: Zeng, Star <star.z...@intel.com> Cc: edk2-devel@lists.01.org Subject: [patch] MdeModulePkg/XhciPei: 1ms delay before accessing MMIO reg in rese

Re: [edk2] [patch] MdeModulePkg/Xhci: add 1ms delay before access MMIO reg during reset

How about to use XhciDxe instead of Xhci in the title to be more differentiated with another change in XhciPei? Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Tian, Feng Sent: Wednesday, September 14, 2016 9:37 AM To: Zeng, Star <star.z...@

Re: [edk2] [PATCH V2] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Follow the suggestion, the V3 patch has been just sent out, please help review that. Thanks, Star -Original Message- From: Kinney, Michael D Sent: Sunday, October 9, 2016 3:49 AM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <mich

Re: [edk2] [PATCH V2] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

-bits ACPI timers." Thanks, Star -Original Message- From: Kinney, Michael D Sent: Wednesday, September 28, 2016 10:58 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Laszlo Ersek <ler...@redhat.

Re: [edk2] [PATCH 0/6] Move/Extract generic duplicated code to Tpm2CommandLib

There is typo in the title of patches, SecuriryPkg should be SecurityPkg and I have correct it at local, you may skip it when reviewing patches. Thanks, Star -Original Message- From: Zeng, Star Sent: Tuesday, September 20, 2016 6:51 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <sta

Re: [edk2] [Patch] MdeModulePkg FormBrowserEx: Change its structure name with EDKII_ prefix

Is there change needed to gEfiFormBrowserExProtocolGuid in FormBrowserEx.h and MdeModulePkg.dec? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, September 22, 2016 10:05 AM To: edk2-devel@lists.01.org Cc:

Re: [edk2] [PATCH 2/6] MdeModulePkg PiDxeS3BootScriptLib: Support multiple PCI segment

Mike, That means PiDxeS3BootScriptLib will depend on both PciLib and PciSegmentLib. Is there any negative impact for PiDxeS3BootScriptLib to only depend on PciSegmentLib? Thanks, Star -Original Message- From: Kinney, Michael D Sent: Tuesday, August 23, 2016 9:59 AM To: Zeng, Star

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

On 2016/8/23 23:33, Laszlo Ersek wrote: On 08/18/16 22:57, Zeng, Star wrote: On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: On 08/19/16 04:00, Fan, Jeff wrote: Laszlo, I could revert this patch firstly. Thank you, that would be very kind. Could you please

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

On 2016/8/24 11:27, Laszlo Ersek wrote: On 08/23/16 22:39, Zeng, Star wrote: On 2016/8/23 23:33, Laszlo Ersek wrote: On 08/18/16 22:57, Zeng, Star wrote: On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: On 08/19/16 04:00, Fan, Jeff wrote: Laszlo, I could

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

On 2016/8/24 13:22, Zeng, Star wrote: On 2016/8/24 11:27, Laszlo Ersek wrote: On 08/23/16 22:39, Zeng, Star wrote: On 2016/8/23 23:33, Laszlo Ersek wrote: On 08/18/16 22:57, Zeng, Star wrote: On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: On 08/19/16 04:00

Re: [edk2] [PATCH 2/6] MdeModulePkg PiDxeS3BootScriptLib: Support multiple PCI segment

Thanks, Star -Original Message- From: Kinney, Michael D Sent: Tuesday, August 23, 2016 11:45 AM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Yao, Jiewen <jiewen@intel.com>; Chan, Amy <amy.c...

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

[Snipped] I am not so clear about "the pristine "OVMF_VARS.fd" varstore template that falls right out of the OVMF build". Variable driver depends on PcdFlashNvStorageVariableBase(64) be set correctly to produce gEfiVariableArchProtocolGuid protocol. After PiSmmCpuDxeSmm adds

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Jiewen, Thanks for the Rb, I just send the V2 patch that follows Laszlo's suggestion to use IoBitFieldRead32 (Port, 0, 23), could you help review the patch again? Star -Original Message- From: Yao, Jiewen Sent: Wednesday, September 28, 2016 7:59 PM To: Zeng, Star <star.z...@intel.

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Laszlo, I agree that is a better idea, please check the V2 patch. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, September 28, 2016 6:51 PM To: Zeng, Star <star.z...@intel.com> Cc: edk2-de...@ml01.01.org; Yao, Jiewen <jiewen@

Re: [edk2] [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to ARRAY_SIZE()

Oh, it is Reviewed-by: Star Zeng <star.z...@intel.com>. :) Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, October 27, 2016 5:08 PM To: Zeng, Star <star.z...@intel.com>; Zhang, Chao

Re: [edk2] [PATCH 00/47] edk2: centralize and adopt ARRAY_SIZE()

..@suse.com>; Carsey, Jaben <jaben.car...@intel.com>; Fan, Jeff <jeff@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; Gao, Liming <liming@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Ni, R

Re: [edk2] [patch] MdeModulePkg/UsbMass: Revert changes of removing retry logic

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Tian, Feng Sent: Monday, November 7, 2016 3:49 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [patch] MdeModulePkg/UsbMass: Revert changes of removing retry logic This p

<    1   2   3   4   5   6   7   8   9   10   >