Re: [edk2] [PATCH] MdeModulePkg/PciSioSerial: Fix a bug that wrongly produces 2 UARTs

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Tuesday, November 8, 2016 10:36 AM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com> Subject: [PATCH] MdeModulePkg/PciSioSerial: Fix

Re: [edk2] [PATCH 00/33] Fix typos in comments and variables

Reviewed-by: Star Zeng to MdeModulePkg change. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Wednesday, October 19, 2016 3:01 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 00/33] Fix

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

As I remember, the parent FV file system type will inherit the file system type of child file or even child FV in guided section. See r2612 at https://svn.code.sf.net/p/edk2-buildtools/code/trunk/BaseTools/ that is the original BaseTools development trunk. Which revision of BaseTools is being

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

ply email and destroy all copies of the original message. > -Original Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Thursday, October 20, 2016 6:02 PM > To: Sean Brogan <sean.bro...@microsoft.com>; Gao, Liming > <liming....@intel.com&g

Re: [edk2] [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB and VBT data

My suggestion is to split the patch to two different patches since it is adding two GUIDs. Thanks, Star -Original Message- From: Mudusuru, Giri P Sent: Saturday, October 22, 2016 12:18 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@

Re: [edk2] [PATCH 01/19] MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()

In fact, EFI_* codes are a subset of RETURN_* codes, so it seems work to implement ASSERT_EFI_ERROR() using new ASSERT_RETURN_ERROR(). Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Tuesday, October 25, 2016

Re: [edk2] [PATCH] MdePkg PeiServicesLib: Make sure FvInfo has FFS2 format if FvFormat == NULL

Sent: Monday, October 24, 2016 5:16 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH] MdePkg PeiServicesLib: Make sure FvInfo has FFS2 format if FvFormat == NULL Star: Besides this patch, I think

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

Sean, I guess the codes are reporting FvInfo PPI like below that makes the problem. PeiServicesInstallFvInfoPpi( NULL, (VOID *)PcdGet32(PcdFlashFvXXXBase), PcdGet32(PcdFlashFvXXXSize), NULL, NULL ); PeiServicesInstallFvInfoPpi() has below

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Free SmramRanges to save SMM space

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Fan, Jeff Sent: Tuesday, November 15, 2016 10:24 AM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel

Re: [edk2] [patch] MdeModulePkg/Xhci: Add 10ms delay before sending SendAddr cmd to dev

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng Tian Sent: Wednesday, November 23, 2016 9:58 AM To: edk2-devel@lists.01.org Cc: Baraneedharan Anbazhagan <anbazha...@hp.com>; Zeng, S

Re: [edk2] [Patch] MdeModulePkg PeiCore: Make SetPeiServicesTablePointer() early in EntryPoint

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, November 23, 2016 12:51 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>

Re: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL table entry in RSDT/XSDT

Hi Ray, Add two minor comments inline. Thanks, Star > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Monday, November 14, 2016 1:26 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Handle

Re: [edk2] [PATCH] SecurityPkg TPM2: Assign real copied count in CopyDigestListToBuffer()

Chao, Great comments, just sent out V2 patch, please help review it. Thanks, Star -Original Message- From: Zhang, Chao B Sent: Thursday, November 17, 2016 11:19 AM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com> Subject

Re: [edk2] [PATCH 2/2] SecurityPkg Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB

: Zeng, Star Sent: Thursday, November 17, 2016 5:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com> Subject: [PATCH 2/2] SecurityPkg Tcg2Dxe: Filter inactive digest in event2 log from P

Re: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL table entry in RSDT/XSDT

I agree to use FADT in commit log. I got the reason why "Table = 0;" needs. With that commit log updated, Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Friday, November 18, 2016 9:59 AM To: Zeng, Star <star.z...@int

Re: [edk2] [PATCH] SecurityPkg Tcg2Dxe: Get correct digest list size

tBinSize (DigestBuffer)" May I know how did you observe such error? DigestList points to the original full un-compacted digest list, DigestBuffer points to the copied partial compacted digest list. Thanks, Star Thank you Yao Jiewen -----Original Message- From: Zeng, Star Sent:

Re: [edk2] [PATCH] MdeModulePkg DxeCore: Show error message on unaligned FvImage issue

Jiewen & Mike, I just supplemented a patch to update PeiHobLib according to your suggestion. Thanks, Star From: Yao, Jiewen Sent: Monday, November 14, 2016 9:43 AM To: Kinney, Michael D <michael.d.kin...@intel.com>; Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org

Re: [edk2] [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Mudusuru, Giri P Sent: Tuesday, November 1, 2016 12:57 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@intel.com>; Kinney, Michael D <michael.d.kin.

Re: [edk2] [patch v2] MdeModulePkg/Xhci: Change short packet debug message to verbose level

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Tian, Feng Sent: Monday, October 31, 2016 1:28 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [patch v2] MdeModulePkg/Xhci: Change short packet debug message to verbose

Re: [edk2] [PATCH v2 2/2] NetworkPkg: Do not free memory during ExitBootServices ().

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin H?user Sent: Friday, November 4, 2016 7:11 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Wu, Jiaxin

Re: [edk2] [PATCH v2 1/2] MdeModulePkg: Do not free memory during ExitBootServices ().

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Friday, November 4, 2016 7:10 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subj

Re: [edk2] [PATCH] MdeModulePkg/PCD: Fix PcdGetNextToken may get a wrong PCD token

:41 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH] MdeModulePkg/PCD: Fix PcdGetNextToken may get a wrong PCD token If there are two DynamicEx PCDs have the same PCD token number but in different

Re: [edk2] [PATCH] IntelSiliconPkg: Add Intel Firmware Version Info (FVI) definitions

Shouldn't +#include SmBios.h be +#include ? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Giri P Mudusuru Sent: Thursday, October 13, 2016 10:11 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ;

Re: [edk2] [Patch] MdeModulePkg PiSmmCore: Update FreePages to handle zero address and pages

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Gao, Liming Sent: Thursday, December 1, 2016 2:48 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [Patch] MdeModulePkg PiSmmCore

Re: [edk2] [Patch 1/2] MdeModulePkg SmmIpl: Fill Smram range for SMM driver when LMFA enable

Liming, A small comment added inline. With that update, Reviewed-by: Star Zeng to this patch series. On 2016/12/1 14:49, Liming Gao wrote: Allocate the additional Smram range to describe the reserved smram for SMM core and driver when LMFA feature is enabled. Cc: Star

Re: [edk2] [PATCH] SecurityPkg:/Tcg2Dxe: remove 4G limitation

With that, Reviewed-by: Star Zeng <star.z...@intel.com> From: Yao, Jiewen Sent: Monday, December 12, 2016 2:55 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Zhang, Chao B <chao.b.zh...@intel.com> Subject: RE: [edk2] [PATCH] SecurityPkg:/Tcg2Dxe: remove 4G

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: Correct debug message.

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Yao, Jiewen Sent: Saturday, December 10, 2016 3:09 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH] MdeModulePkg/CapsuleLib: Cor

Re: [edk2] [PATCH] SecurityPkg:/Tcg2Dxe: remove 4G limitation

Jiewen, Minor comments added inline below. On 2016/12/12 14:35, Jiewen Yao wrote: Tcg2Dxe allocates event log below 4G. It is unnecessary. Cc: Chao Zhang Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen

Re: [edk2] TPL of RegisterKeyNotify

Michael, There is already an approved UEFI mantis https://mantis.uefi.org/mantis/view.php?id=1634 that has the clarification to the TPL of KeyNotify function. Currently KB drivers just call the KeyNotify functions in TimerEvent that has TPL_NOTIFY, we are updating code to make the KeyNotify

Re: [edk2] [PATCH v2 1/1] ShellPkg/SmbiosView: Add decoding of SMBIOS record type 43

se update patch. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Augustine, Linson P Sent: Thursday, January 12, 2017 1:59 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.com>;

Re: [edk2] [PATCH v3 1/1] ShellPkg/SmbiosView: Add decoding of SMBIOS record type 43

anuary 12, 2017 3:00 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com>; Gao, Liming <liming@intel.com> Subject: [edk2] [PA

Re: [edk2] [PATCH] SecuritPkg: Tcg2Smm: Add PlatformClass to TPM2 Table

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Zhang, Chao B Sent: Thursday, January 12, 2017 10:44 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@intel.com>; Zhang, Chao B <chao.b.zh...@intel

Re: [edk2] [PATCH v2] Nt32Pkg: Fix code to correctly set SMBIOS Type 2 Length

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris Phillips Sent: Wednesday, January 11, 2017 12:49 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [edk2] [PATCH v2]

Re: [edk2] [PATCH 2/2] SecurityPkg: Tcg2Config: TPM2 ACPI Table Rev Option

Chao, Add minor comments at below, others are good to me. Reviewed-by: Star Zeng On 2017/1/10 10:24, Zhang, Chao B wrote: Add TPM2 ACPI Table Rev Option in Tcg2Config UI. Rev 4 is defined in TCG ACPI Specification 00.37 Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH v3 1/1] ShellPkg/SmbiosView: Add decoding of SMBIOS record type 43

Linson, The patch has been pushed at e9f0be021b7649c15d823e193110c0088cda9a89, thanks for the contribution Star -Original Message- From: Zeng, Star Sent: Thursday, January 12, 2017 3:17 PM To: Linson Augustine <linson.august...@hpe.com>; edk2-devel@lists.01.org Cc: Kinney, Mic

Re: [edk2] [PATCH v2] Nt32Pkg: Fix code to correctly set SMBIOS Type 2 Length

Chris, The patches have been pushed at https://github.com/tianocore/edk2/compare/32fd9c4150d0...12233c19177d. Thanks for the contribution. Star -Original Message- From: Phillips, Chris J (Plano, TX) [mailto:chr...@hpe.com] Sent: Thursday, January 12, 2017 4:16 PM To: Zeng, Star

Re: [edk2] [PATCH] SecurityPkg: Tcg2ConfigDxe/Tcg2Smm: Fix TPM2 HID issue

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Zhang, Chao B Sent: Tuesday, January 10, 2017 2:54 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@intel.com>; Zhang, Chao B <chao.b.zh...@intel

Re: [edk2] [PATCH v2 1/1] ShellPkg/SmbiosView: Add decoding of SMBIOS record type 43

Linson, Add minor comments inline. :) On 2017/1/11 16:57, Linson Augustine wrote: Added decoding of the new SMBIOS Type 43 record. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Augustine Linson P ---

Re: [edk2] [PATCH v2] Nt32Pkg: Fix code to correctly set SMBIOS Type 2 Length

Chris, Since no other comments received, do you need me to help push the SMBIOS related patches? Thanks, Star On 2017/1/11 9:36, Zeng, Star wrote: Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43

Linson, Add minor comments inline. On 2017/1/11 17:10, Linson Augustine wrote: Added definitions for the new SMBIOS Type 43 record. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Augustine Linson P ---

Re: [edk2] [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43

Linson, The patch has been pushed at 713e4b007cb791829397522ad8f366dd1e08bee6, thanks for the contribution. Star -Original Message- From: Augustine, Linson P [mailto:linson.august...@hpe.com] Sent: Wednesday, January 11, 2017 5:36 PM To: Zeng, Star <star.z...@intel.com>; edk2

Re: [edk2] [patch] MdeModulePkg/SdMmc: Fix build failure caused by last check-in

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Tian, Feng Sent: Thursday, December 1, 2016 4:42 PM To: edk2-devel@lists.01.org Cc: Jan Dabros <j...@semihalf.com>; Marcin Wojtas <m...@semihalf.com>; Zeng, Star <star.z...@intel.com> Subje

Re: [edk2] [patch] MdeModulePkg/Ehci: don't clear port status bits during init

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Tian, Feng Sent: Wednesday, November 30, 2016 1:16 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Mike Turner <michael.tur...@microsoft.com> Subject: [patch] MdeModulePkg/Ehci

Re: [edk2] [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

On 2016/12/1 1:20, Leif Lindholm wrote: LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied from IntelFrameworkModulePkg to MdeModulePkg, but the originals were kept for compatibility. Nevertheless, new code should be using the MdeModulePkg versions, so change all references

Re: [edk2] [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: 64-bit LoopTimes in S3 MEM_POLL

1:56 AM To: edk2-devel-01 <edk2-de...@ml01.01.org> Cc: Tian, Feng <feng.t...@intel.com>; Gao, Liming <liming@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Zeng, Star <star.z...@intel.com>; Wei, David <david@intel.com> Subject: [ed

Re: [edk2] [PATCH 2/2] SecurityPkg: Add Pcd PROMPT/HELP & Chang default setting

Please correct the typo "Inital" in dec and uni files. With that, Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Zhang, Chao B Sent: Thursday, January 5, 2017 10:19 AM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.

Re: [edk2] [PATCH v1 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43

Hi Linson, On 2017/1/9 16:58, Linson Augustine wrote: Added defintions for the new SMBIOS Type 43 record. Typo "defintions" should be "definitions". I noticed that the new type 43 is added in new SMBIOS spec 3.1.0, but there are also other definitions and structure fields added in new

Re: [edk2] [PATCH v1 1/1] ShellPkg/PrintInfo.c: Add decoding of SMBIOS record type 43

Linson, Add some comments below. On 2017/1/9 17:14, Linson Augustine wrote: Added decoding of the new SMBIOS Type 43 record. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Augustine Linson P ---

Re: [edk2] [PATCH] MdeModulePkg/DxeCore:Clear RT attribute on SetCapabilities.

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Yao, Jiewen Sent: Monday, January 9, 2017 2:35 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: [PATCH] MdeModulePkg/DxeCore:

Re: [edk2] [Patch] MdeModulePkg/DxeCore: Fix ASSERT() from GCD DEBUG() messages

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Kinney, Michael D Sent: Monday, January 9, 2017 1:00 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [Patch] MdeModulePkg/DxeCore: Fix

Re: [edk2] [PATCH] Nt32Pkg: Fix code to correctly set SMBIOS Type 2 Length

Chris, Could you also correct the typo "Assert" to "Asset"? With the typo fixed, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris Phillips Sent: Tuesday, January 10, 2017 2:55 PM To:

Re: [edk2] [PATCH] MdePkg: Add comments for SMBIOS Type 3 structure to cover SKU Number

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris Phillips Sent: Tuesday, January 10, 2017 2:49 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming

Re: [edk2] [PATCH] ShellPkg: Update smbiosview command to display Type 3 values

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris Phillips Sent: Tuesday, January 10, 2017 2:53 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben ; Ni, Ruiyu

Re: [edk2] [PATCH] Nt32Pkg: Fixes to correctly set SMBIOS Type 3

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris Phillips Sent: Tuesday, January 10, 2017 2:57 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [edk2] [PATCH] Nt32Pkg:

Re: [edk2] [Patch] SecurityPkg Tcg2ConfigDxe: Force reset when PCR Allocation changed.

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Dong, Eric Sent: Tuesday, December 20, 2016 3:57 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [Patch] SecurityPkg Tcg2ConfigDxe: Fo

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check.

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Yao, Jiewen Sent: Thursday, December 22, 2016 11:45 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH] MdeModulePkg/CapsuleLib:

Re: [edk2] [PATCH 0/2] Handle NULL capsule name in record.

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Thursday, December 22, 2016 1:48 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] Handle NULL capsule name in record.

Re: [edk2] [PATCH 1/5] MdeModulePkg UsbKbDxe: Execute key notify func at TPL_CALLBACK

Ray, Good comment, it can make the code more clear, I agree it. Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Friday, December 23, 2016 3:01 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, F

Re: [edk2] [PATCH 1/5] MdeModulePkg UsbKbDxe: Execute key notify func at TPL_CALLBACK

, December 23, 2016 3:10 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: RE: [edk2] [PATCH 1/5] MdeModulePkg UsbKbDxe: Execute key notify func at TPL_CALLBACK Star, Another c

Re: [edk2] [PATCH 0/5] Execute key notify function at TPL_CALLBACK

Ray, Thanks for the comments, I just sent out the V2 patch series based on the disucssion, please help review them again. :) Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Friday, December 23, 2016 3:12 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc

Re: [edk2] [PATCH V2] SecurityPkg: Tcg2Smm: TPM2 Vendor specific HID

B <chao.b.zh...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH V2] SecurityPkg: Tcg2Smm: TPM2 Vendor specific HID Update TPM2 HID using vendor ManufacturerID & FirmwareVersion1. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Z

Re: [edk2] [PATCH] SecurityPkg: Tcg2Smm: TPM2 Vendor specific HID

return status? Thanks, Star Thanks & Best regards Chao Zhang From: Zeng, Star Sent: Tuesday, December 27, 2016 11:19 AM To: Zhang, Chao B; edk2-devel@lists.01.org Cc: Yao, Jiewen; Zeng, Star Subject: Re: [edk2] [PATCH] SecurityPkg: Tcg2Smm: TPM2 Vendor specific HID Chao, Minor comments

Re: [edk2] [PATCH] SecurityPkg: Tcg2Smm: TPM2 Vendor specific HID

Chao, Minor comments inline. On 2016/12/27 9:51, Zhang, Chao B wrote: Update TPM2 HID using vendor ManufacturerID & FirmwareVersion1. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- .../Library/Tpm2CommandLib/Tpm2Capability.c

Re: [edk2] [PATCH] MdeModulePkg ConSplitterDxe: Support toggle state sync

, December 26, 2016 9:26 AM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: RE: [edk2] [PATCH] MdeModulePkg ConSplitterDxe: Support toggle state sync Star, Why do you need &q

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: Support result rolling over.

B <chao.b.zh...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH] MdeModulePkg/CapsuleLib: Support result rolling over. According to UEFI spec, capsule result variable may roll over to 0. Cc: Feng Tian <feng.t...@intel.com> Cc: Star Zeng <star.z...@intel.com> Cc

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: Follow UEFI 22.2.3 to process FMP.

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Yao, Jiewen Sent: Saturday, December 24, 2016 3:51 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>; Zhang, Chao B <chao.b.zh...@intel

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: Support result rolling over.

B <chao.b.zh...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH] MdeModulePkg/CapsuleLib: Support result rolling over. According to UEFI spec, capsule result variable may roll over to 0. Cc: Feng Tian <feng.t...@intel.com> Cc: Star Zeng <star.z...@intel.com> Cc

Re: [edk2] [PATCH V2] MdeModulePkg/CapsuleLib: Add CapsuleTarget support.

Minor comment inline. On 2016/12/24 0:02, Jiewen Yao wrote: UEFI spec requires CapsuleTarget to be a device path associated with FMP producer. Cc: Feng Tian Cc: Star Zeng Cc: Chao Zhang Contributed-under: TianoCore

Re: [edk2] [PATCH V2] MdeModulePkg/CapsuleLib: Add CapsuleTarget support.

With that, Reviewed-by: Star Zeng <star.z...@intel.com> From: Yao, Jiewen Sent: Monday, December 26, 2016 11:01 AM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>; Zhang, Chao B <chao

Re: [edk2] [PATCH] MdeModulePkg ConSplitterDxe: Support toggle state sync

EFI spec that doesn't have VOID * Context as the 2nd parameter of the hot key notification function. Yes Thanks for the comments. Star Regards, Ray -----Original Message- From: Zeng, Star Sent: Thursday, December 22, 2016 9:43 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star

Re: [edk2] [PATCH v2 05/12] ArmPkg: introduce EDKII Platform Has ACPI Protocol, and plug-in library

: Re: [edk2] [PATCH v2 05/12] ArmPkg: introduce EDKII Platform Has ACPI Protocol, and plug-in library On 23 March 2017 at 01:41, Zeng, Star <star.z...@intel.com> wrote: > I prefer to do not include the protocol definition and the library instance > into MdeModulePkg at this moment until the

Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe: Clear SEV mask on MMIO regions

as other archs do not need them? Thanks, Star -Original Message- From: Leo Duran [mailto:leo.du...@amd.com] Sent: Friday, March 24, 2017 10:51 AM To: edk2-de...@ml01.01.org Cc: Leo Duran <leo.du...@amd.com>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>; B

Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe: Clear SEV mask on MMIO regions

Jiewen, I like the solution you proposed. :) Thanks, Star -Original Message- From: Yao, Jiewen Sent: Friday, March 24, 2017 3:49 PM To: Zeng, Star <star.z...@intel.com>; Leo Duran <leo.du...@amd.com>; edk2-de...@ml01.01.org Cc: Tian, Feng <feng.t...@intel.com&

Re: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?

Siyuan, Could you help confirm it? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Guoheyi Sent: Thursday, March 23, 2017 10:45 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@

Re: [edk2] [PATCH v2 05/12] ArmPkg: introduce EDKII Platform Has ACPI Protocol, and plug-in library

To: Leif Lindholm <leif.lindh...@linaro.org>; Zeng, Star <star.z...@intel.com>; Tian, Feng <feng.t...@intel.com> Cc: edk2-devel-01 <edk2-devel@lists.01.org>; Ard Biesheuvel <ard.biesheu...@linaro.org> Subject: Re: [edk2] [PATCH v2 05/12] ArmPkg: introduce EDKII Platfor

Re: [edk2] [PATCH] MdeModulePkg/BootGraphicsResourceTableDxe: don't allocate below 4 GB

I am ok with this patch. Jiewen and Liming, do you have any comments? Thanks, Star -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, March 20, 2017 1:20 AM To: edk2-devel@lists.01.org; Zeng, Star <star.z...@intel.com>; Tian, Feng &

Re: [edk2] [PATCH v2 05/12] ArmPkg: introduce EDKII Platform Has ACPI Protocol, and plug-in library

Laszlo, Could the implementation have multiple instances of PlatformHasAcpiLib to return unsuccessfully in the constructor when EFI_ACPI_TABLE_PROTOCOL is not needed? And then eliminate PlatformHasAcpiDtDxe, gEdkiiPlatformHasAcpiProtocolGuid and gEdkiiPlatformHasDeviceTreeProtocolGuid?

Re: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages

; Tian, Feng <feng.t...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Leif Lindholm <leif.lindh...@linaro.org>; Zeng, Star <star.z...@intel.com> Subject: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages RamDiskDxe installs the RamDi

Re: [edk2] [RFC PATCH] MdeModulePkg/AcpiTableDxe: inhibit table publication until we have a FADT

; leif.lindh...@linaro.org; Zeng, Star <star.z...@intel.com> Cc: Tian, Feng <feng.t...@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> Subject: [RFC PATCH] MdeModulePkg/AcpiTableDxe: inhibit table publication until we have a FADT Since commit 78c41ff519b1 ("ArmVirtPkg/FdtC

Re: [edk2] [PATCH v2 05/12] ArmPkg: introduce EDKII Platform Has ACPI Protocol, and plug-in library

Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zeng, Star Sent: Monday, March 20, 2017 5:57 PM To: Laszlo Ersek <ler...@redhat.com>; edk2-devel-01 <edk2-devel@lists.01.org>; Kinney, Michael D <michael.d.kin...@intel.com>; Yao, Jiewen <jie

Re: [edk2] [PATCH] MdeModulePkg CapsuleApp: Add -NR (no-reset) option support

sday, March 21, 2017 10:41 AM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Xiaofeng Wang <winggundu...@163.com> Subject: RE: [PATCH] MdeModulePkg CapsuleApp: Add -NR (no-reset) option support I feel a little confused on "but no CAPSULE_FLAGS_INITIATE_

Re: [edk2] [PATCH] MdeModulePkg/AcpiTableDxe: consider version mask when removing tables

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, March 20, 2017 10:52 PM To: edk2-devel@lists.01.org; Zeng, Star <star.z...@intel.com>; Tian, Feng <feng.t...@intel.com> Cc: Ard Biesh

Re: [edk2] [PATCH v2 05/12] ArmPkg: introduce EDKII Platform Has ACPI Protocol, and plug-in library

[mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Monday, March 20, 2017 5:18 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel-01 <edk2-devel@lists.01.org> Cc: Leif Lindholm <leif.lindh...@linaro.org>; Ard Biesheuvel <ard.biesheu...@linaro.org> Su

Re: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages

Yes, please. :) Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Monday, March 20, 2017 5:46 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel-01 <edk2-devel@lists.01.org> Cc: Wu, Hao A <hao.a...@i

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/AcpiTableDxe: improve FADT.{DSDT, X_DSDT} mutual exclusion

On 2017/3/14 21:13, Laszlo Ersek wrote: On 03/14/17 09:33, Zeng, Star wrote: In original code for < 4G table, Dsdt and XDsdt will be both assigned if FADT is installed before DSDT, but Dsdt and XDsdt will have mutual exclusion if FADT is installed after DSDT. They are inconsistent. Tha

Re: [edk2] [PATCH] MdeModulePkg/DxeCore: deal with allocations spanning several memmap entries

<eug...@hp.com>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> Subject: Re: [PATCH] MdeModulePkg/DxeCore: deal with allocations spanning several memmap entries On 16 March 2017 at 11:35, Ard Biesheuvel <ard

Re: [edk2] [Patch] MdeModulePkg: Remove unsupported PcdExpression usage in module INF

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Gao, Liming Sent: Friday, March 31, 2017 1:04 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [Patch] MdeModulePkg:

Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option

- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, April 6, 2017 4:15 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option GCC -fno-b

Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option

With that, you can have my Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Gao, Liming Sent: Thursday, April 6, 2017 4:40 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch] MdeModulePkg RegularE

Re: [edk2] [ScsiDiskDxe] Implict type conversion bug

Hao has sent patch for this issue. You can search emails with title "[edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Fix potential implicit sign extension". Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Guoheyi Sent: Monday, April 10,

Re: [edk2] [PATCH] MdeModulePkg: Add EFI_GCD_MEMORY_SPACE_NOTIFY_PROTOCOL

Duran <leo.du...@amd.com>; edk2-de...@ml01.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Tian, Feng <feng.t...@intel.com>; Brijesh Singh <brijesh.si...@amd.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH] MdeModulePkg: Add EFI_GCD_MEMORY_SPAC

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: Remove redundant PoolTail pointer assignment

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Wu, Hao A Sent: Friday, April 21, 2017 10:45 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subje

Re: [edk2] [Patch] MdeModulePkg DxeCore: Fix issue to print GUID value %g without pointer

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Gao, Liming Sent: Thursday, April 13, 2017 3:08 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [Patch] MdeModulePkg DxeCore: Fix issue to print GUID value %g without po

Re: [edk2] [PATCH] MdeModulePkg/FirmwarePerformanceDxe: Error Level is not used correctly

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Fan, Jeff Sent: Thursday, April 20, 2017 2:16 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH] MdeModulePkg/FirmwarePerforman

Re: [edk2] [PATCH 2/2] MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart

-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, April 24, 2017 1:46 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH 2/2] MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart

Re: [edk2] [PATCH 1/2] MdeModulePkg/UfsPciHc: Remove unused field in UfsHc private struct

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Wu, Hao A Sent: Monday, April 24, 2017 1:46 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH 1/2] MdeModulePkg/UfsPc

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Wu, Hao A Sent: Monday, April 24, 2017 1:59 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH v2 2/2] MdeModuleP

Re: [edk2] [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal

It is ok to me. Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Westfahl Sent: Saturday, April 22, 2017 5:25 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ;

Re: [edk2] [PATCH v2 0/2] MdeModulePkg/AcpiTableDxe: improve FADT.{DSDT, X_DSDT} mutual exclusion

gt;; Tian, Feng <feng.t...@intel.com>; Igor Mammedov <imamm...@redhat.com>; Yao, Jiewen <jiewen@intel.com>; Leo Duran <leo.du...@amd.com>; Michael Tsirkin <mtsir...@redhat.com>; Phil Dennis-Jordan <p...@philjordan.eu>; Zeng, Star <star.z...@intel.com&g

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/AcpiTableDxe: improve FADT.{DSDT, X_DSDT} mutual exclusion

; Ard Biesheuvel <ard.biesheu...@linaro.org>; Phil Dennis-Jordan <p...@philjordan.eu>; Leo Duran <leo.du...@amd.com>; Yao, Jiewen <jiewen@intel.com>; Al Stone <a...@redhat.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH v2 2/2] MdeModulePkg/A

<    1   2   3   4   5   6   7   8   9   10   >