Re: [edk2] [PATCH edk2-platforms v3 00/11] Update D03/D05 binary for edk2 update and bug fix.

2017-09-21 Thread graeme . gregory
All ACPI changes apart from the small comment I had on I2C one Reviewed-by: Graeme Gregory <graeme.greg...@linaro.org> On Thu, Sep 21, 2017 at 06:59:39PM +0800, Heyi Guo wrote: > Code can also be found in github: > https://github.com/hisilicon/OpenPlatformPkg.git > branch: rp-17

Re: [edk2] [PATCH 0/2] Add FPDT Acpi table

2017-10-09 Thread Graeme Gregory
point of view this looks fine to me. Reviewed-by: Graeme Gregory <graeme.greg...@linaro.org> > > Alexei Fedorov (1): > ArmPlatformPkg: Store initial timer value > > ArmPlatformPkg/PrePi/PeiMPCore.inf | 3 ++- > ArmPlatformPkg/PrePi/PeiUniCore.inf | 3 ++- > ArmPlatform

Re: [edk2] [PATCH edk2-platforms v3 12/27] Silicon/SynQuacer: add ACPI support

2017-11-01 Thread graeme . gregory
I see nothing wrong with the ACPI in this patch, but I question the sanity of exposing ACPI on this SoC where it seems to be not suited. Given the comment in the commit message would an alternative OS like windows actually work with this PCIe setup? Graeme On Tue, Oct 31, 2017 at 10:52:03AM

Re: [edk2] [PATCH edk2-platforms v1 01/14] Hisilicon/D05: Add PPTT support

2018-01-24 Thread graeme . gregory
On Mon, Jan 22, 2018 at 01:53:18PM +, Leif Lindholm wrote: > Detailed commit description, please. > > Graeme - any comments on ACPIness? > I think Jeremy probably gave it a much more in depth review than I can below. Once he is happy Ill be happy. Graeme > On Thu, Jan 18, 2018 at

Re: [edk2] [PATCH edk2-platforms v2 13/15] Hisilicon/D05/ACPI: Add ITS PXM

2018-01-30 Thread graeme . gregory
- Looks sane to me. Reviewed-by: Graeme Gregory <gra...@xora.org.uk> > Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc | 10 ++ > Silicon/Hisilicon/Include/Library/AcpiNextLib.h | 10 +- > 2 files changed, 19 insertions(+), 1 deletion(-) > >

Re: [edk2] [PATCH edk2-platforms v2 01/15] Hisilicon/D05: Move Madt definition to head file

2018-01-30 Thread graeme . gregory
d-off-by: Heyi Guo <heyi@linaro.org> > --- Looks sane to me Reviewed-by: Graeme Gregory <gra...@xora.org.uk> > Silicon/Hisilicon/Hi1616/D05AcpiTables/Hi1616Platform.h | 30 > +++- > Silicon/Hisilicon/Hi1616/D05AcpiTables/MadtHi1616.aslc | 23 +-- &g

Re: [edk2] [PATCH edk2-platforms v2 02/15] Hisilicon/D05: Add PPTT support

2018-01-30 Thread graeme . gregory
rg/show_bug.cgi?id=3206 > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang <huangmin...@huawei.com> > Signed-off-by: Heyi Guo <heyi@linaro.org> > --- Code looks sane enough to me, but I cant give an indepth review of the PP

Re: [edk2] [PATCH edk2-platforms v2 14/15] Hisilicon/D05/ACPI: Add Pcie, HNS and SAS PXM

2018-01-30 Thread graeme . gregory
igned-off-by: Ming Huang <huangmin...@huawei.com> > Signed-off-by: Heyi Guo <heyi@linaro.org> > --- Looks sane to me Reviewed-by: Graeme Gregory <gra...@xora.org.uk> > Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl | 9 ++ > Silic

Re: [edk2] [PATCH edk2-platforms v3 13/15] Hisilicon/D05/ACPI: Add ITS PXM

2018-02-07 Thread graeme . gregory
...@huawei.com> > > Signed-off-by: Heyi Guo <heyi@linaro.org> > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Reviewed-by: Graeme Gregory <gra...@xora.org.uk> > > Err, a comment - and apologies if I missed this in other pat

Re: [edk2] [PATCH edk2-platforms v1 00/38] Upload for D06 platform

2018-08-02 Thread Graeme Gregory
On Thu, Aug 02, 2018 at 11:12:56AM +0100, Leif Lindholm wrote: > On Thu, Aug 02, 2018 at 09:46:13AM +0800, Ming wrote: > > I am sorry for the first issue, the modify FIRMWARE_VER patch is add > > alone just befor send out the patchset. > > > > For generating acpi table, I use acpica-tools

Re: [edk2] [PATCH edk2-platforms v2 0/7] SynQuacer ACPI support

2018-03-01 Thread Graeme Gregory (Linaro)
driver support for the eMMC and network controller only landed in > v4.15, but when using a SATA driver and a plugin network card that does have > driver support, these patches should allow the SynQuacer based platforms to > boot stock Debian Stretch/Fedora/Centos etc installers. > The AC