Reviewed-by: Jaben Carsey
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, April 02, 2019 2:44 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Liming
> Subject: [PATCH] ShellPkg: Clarify the description of acpiview option '-s'
>
Blurb missing.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Agyeman
> Sent: Monday, April 01, 2019 2:14 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [edk2-platforms][PATCH v2 0/2] Adding python build scripts
> to ClevoOpenBoardPkg ,
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, March 28, 2019 6:50 PM
> To: Zhang, Shenglei ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: RE: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some
> unused Gui
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, March 28, 2019 6:50 PM
> To: Zhang, Shenglei ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: RE: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib
> Importance: High
>
age-
> From: Ooi, Tzy Way
> Sent: Thursday, March 21, 2019 5:20 AM
> To: Carsey, Jaben ; Ni, Ray ;
> edk2-devel@lists.01.org
> Cc: Loh, Tien Hock ; Ooi, Tzy Way
>
> Subject: Enquiry on GetTimerPeriod function in Ping.c
>
> Hi,
>
> I am enabling an UEFI ethernet d
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Feng, Bob C
> Sent: Thursday, March 14, 2019 7:48 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: Fixed the issue of
Good catch. After fixing this typo, my RB stands.
Sent from my iPad
On Mar 6, 2019, at 7:59 AM, Nariman Poushin
mailto:nariman.pous...@linaro.org>> wrote:
On Wed, 6 Mar 2019 at 15:54, Carsey, Jaben
mailto:jaben.car...@intel.com>> wrote:
Reviewed-by: Jaben Carsey
mail
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, March 05, 2019 11:05 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Carsey, Jaben ;
> Gao, Liming
> Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note
> i
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Feng, Bob C
> Sent: Monday, March 04, 2019 9:28 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
> ; Carsey, Jaben
> Subject: [Patch] Document: Update Build spec to remove EDK related
> con
Reviewed-by: Jaben Carsey
It's a lot of changes. It looks good to me.
> -Original Message-
> From: Feng, Bob C
> Sent: Monday, March 04, 2019 7:49 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
> ; Carsey, Jaben
> Subject: [Patch] Document: Upda
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zhang, Shenglei
> Sent: Monday, March 04, 2019 6:06 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray
> Subject: [PATCH] ShellPkg: Correct a parameter's name
> Importance: High
>
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Fan, ZhijuX
> Sent: Thursday, February 28, 2019 6:52 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py
Is this something that should also get added to edksetup? Force users to get
the error without running this test.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Feng, Bob C
> Sent: Thursday, February 28, 2019
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Feng, Bob C
> Sent: Wednesday, February 27, 2019 6:11 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] Document: Update Dsc spec to all
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Feng, Bob C
> Sent: Wednesday, February 27, 2019 6:12 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] Document: Update the INF spec
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, February 25, 2019 11:41 AM
> To: Rebecca Cran ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Daryl McDaniel li...@mc2research.org>
> Subject: Re: [edk2] [PATCH] StdLib: Update resolv
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, February 25, 2019 2:11 AM
> To: Rebecca Cran ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Daryl McDaniel li...@mc2research.org>
> Subject: Re: [edk2] [
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Feng, Bob C
> Sent: Tuesday, February 19, 2019 7:44 AM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
> ; Carsey, Jaben
> Subject: [Patch V2] BaseTools: replace Sdict with OrderedDict in UPT
>
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zhichao Gao
> Sent: Monday, February 18, 2019 12:28 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [PATCH] ShellPkg: add array index check for
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Fan, ZhijuX
> Sent: Thursday, February 14, 2019 7:18 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [PATCH] BaseTools:BaseTools supports to the
I am really confused by this patch and how it ever worked.
I see that you remove the import for sdict. But I see that sdict is used in
other places in that file.
I also cant find a class definition for sdict anywhere (certainly not in
Common/Misc).
So maybe refactor and remove all the other
Note: deviating from "RE: [edk2] [Patch 0/3] BaseTools: Implement splitquoted
function"
Laszlo,
Since I am working on some research related to this, I have a few follow up
questions.
If there is significant performance improvement, how would you feel about
requiring a 3rd party package to be
I sent this earlier, but failed the mailing list part.
Reviewed-by: Jaben Carsey
And pushed.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Vladimir Olovyannikov via edk2-devel
> Sent: Tuesday, February 05, 2019 8:58 AM
> To: Laszlo Ersek
Reviewed-by: Jaben Carsey
And pushed.
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, February 06, 2019 8:26 AM
> To: Philippe Mathieu-Daudé ; Kinney, Michael D
> ; edk2-devel@lists.01.org; Carsey, Jaben
>
> Cc: Leif Li
Laszlo,
not sure which Andrew you wanted, but he didn’t get added so far as I can tell.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, February 05, 2019 4:05 AM
> To: Leif Lindholm
> Cc:
Code looks good, but I think the function comment is lacking. How about
describe the function and what it does instead of saying it replaces distutils
function (which while correct, didn't really answer my question of "what is
this supposed to do").
> -Original Message-
> From:
rg
> Cc: Kinney, Michael D ; Carsey, Jaben
> ; Daryl McDaniel
> Subject: Re: [edk2] [PATCH v2] AppPkg: fix webserver build for !Ia32/X64
> Importance: High
>
> Mike, Daryl, Jaben - any comments on v2?
>
> On Fri, Nov 02, 2018 at 10:50:15AM +, Leif Lindholm wrote:
>
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, January 29, 2019 10:34 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Carsey, Jaben
> Subject: [PATCH v5 7/7] ShellPkg/UefiShellLib: Use BaseLib api CharToUpper
> Importance:
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, January 29, 2019 10:34 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Carsey, Jaben
> Subject: [PATCH v5 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper
> Importance:
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Bi, Dandan
> Sent: Sunday, January 27, 2019 7:29 PM
> To: edk2-devel@lists.01.org
> Cc: Krzysztof Koch ; Carsey, Jaben
> ; Ni, Ray
> Subject: [patch] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS tool
Reviewed-by: Jaben Carsey
And pushed with the BZ added to commit REF.
> -Original Message-
> From: Li, Songpeng
> Sent: Thursday, January 24, 2019 9:08 PM
> To: Vladimir Olovyannikov ; edk2-
> de...@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray
> Subject: RE: [e
I think that if the application wants to depend on the libs, then we should
discuss moving the application to the ShellPkg.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gao, Liming
> Sent: Friday, January 25, 2019 1:25 AM
> To:
Reviewed-by: Jaben Carsey
And pushed.
> -Original Message-
> From: Sami Mujawar [mailto:sami.muja...@arm.com]
> Sent: Thursday, January 24, 2019 8:05 AM
> To: Carsey, Jaben ; Krzysztof Koch
> ; edk2-devel@lists.01.org
> Cc: leif.lindh...@linaro.org; Matteo Carlini ;
lists.01.org
> Cc: leif.lindh...@linaro.org; matteo.carl...@arm.com; Stephanie.Hughes-
> f...@arm.com; Carsey, Jaben ; Ni, Ray
> ; sami.muja...@arm.com; n...@arm.com
> Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Add
> support for PPTT
> Importance: High
9 3:34 PM
> To: Carsey, Jaben
> Cc: sssky...@163.com; edk2-devel@lists.01.org
> Subject: RE: [edk2] A question about shell-application's argument make
> system blocked;
> Importance: High
>
> Jaben,
>
> The shell does not parse properly (my opinion) in some instances.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Li, Songpeng
> Sent: Wednesday, January 09, 2019 6:54 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray ;
> Wu, Jiaxin
> Subject: [PATCH v2] ShellPkg/TftpDynamicCommand: Change file writing
> met
Is this in a script file? I don't remember how "comments" work on raw command
lines where the user types them.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> krishnaLee
> Sent: Wednesday, January 09, 2019 10:13 PM
> To:
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Feng, Bob C
> Sent: Tuesday, January 08, 2019 11:15 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
> ; Carsey, Jaben
> Subject: [Patch 1/3 V2] BaseTools: Remove unused logic for EDKI
> Im
Reviewed-by: Jaben Carsey
Note: in BaseTools/Source/C/EfiRom/EfiRom.h. it looks like you both delete and
add EBC.
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, January 09, 2019 12:34 AM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
&g
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, January 09, 2019 12:35 AM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
> ; Carsey, Jaben
> Subject: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C
Liming,
I think that the user should not need to set PYTHON3_ENABLE at all if they
manually set PYTHON_COMMAND.
-Jaben
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, January 08, 2019 4:43 PM
> To: Carsey, Jaben ; Laszlo Ersek
> ; Ni, Ray ; edk2-dev
I did the work last year so I didn't do anything but the email this year...
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, January 08, 2019 5:18 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Cc: Wang, Jian J ; Zeng, Star
> Subject: RE: [Patch v1 1/1]
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, January 08, 2019 9:26 AM
> To: Carsey, Jaben ; Gao, Liming
> ; Ni, Ray ; edk2-
> de...@lists.01.org; leif.lindh...@linaro.org; af...@apple.com; Kinney,
> Michael D
> Subjec
Liming and Laszlo,
What if we add a 4th option to the environment variable - the path to a
specific python interpreter for use.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gao, Liming
> Sent: Tuesday, January 08, 2019
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, January 03, 2019 4:13 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [PATCH] BaseTools/GenFds: permit
Reviewed-by: Jaben Carsey
And pushed.
> -Original Message-
> From: Alex James [mailto:theracermas...@gmail.com]
> Sent: Monday, December 17, 2018 8:25 PM
> To: edk2-devel@lists.01.org
> Cc: Daryl McDaniel ; Carsey, Jaben
>
> Subject: [PATCH v1 2/2] StdLib/Env
Reviewed-by: Jaben Carsey
And pushed.
> -Original Message-
> From: Alex James [mailto:theracermas...@gmail.com]
> Sent: Monday, December 17, 2018 8:25 PM
> To: edk2-devel@lists.01.org
> Cc: Daryl McDaniel ; Carsey, Jaben
>
> Subject: [PATCH v1 2/2] StdLib/Env
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, December 25, 2018 12:17 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
> Subject: [PATCH v4 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper
> Importance:
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, December 25, 2018 12:17 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
> Subject: [PATCH v4 7/7] ShellPkg/UefiShellLib: Use BaseLib api CharToUpper
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, December 14, 2018 1:54 AM
> To: Zhang, Shenglei ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: Re: [PATCH v2] ShellPkg/UefiShellDebug1C
I will submit a new change with those changed back.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Thursday, December 6, 2018 4:50 PM
> To: Zhu, Yonghong ; edk2-devel@lists.01.org
> Cc: Gao,
How about undo those and push the remaining? Since that's a very small change.
-Jaben
> -Original Message-
> From: Zhu, Yonghong
> Sent: Monday, December 3, 2018 5:53 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Cc: Gao, Liming ; Zhu, Yonghong
>
> Subje
You didn't CC anyone, but that is the right syntax for adding the shell command.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Wednesday, December 05, 2018 10:50 AM
> To:
I was trying to change all use of *, without regard to the usage of it.
Do you think that mathematical * should not be changed?
-Jaben
> -Original Message-
> From: Zhu, Yonghong
> Sent: Sunday, December 02, 2018 6:31 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
>
I do not think that expanding shellPkg would work since there is no requirement
that any of these apps depend on it. As was stated, MicroPythonPkg does not.
I also do not think that moving ShellPkg makes lots of sense since it is used
by many platforms.
-Jaben
> -Original Message-
>
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, November 29, 2018 4:31 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Gao, Liming
> Subject: [edk2] [PATCH 6/6]
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, November 29, 2018 4:31 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Gao, Liming
> Subject: [edk2] [PATCH 4/6]
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, November 29, 2018 4:31 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Gao, Liming
> Subject: [edk2] [PATCH 2/6]
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, November 29, 2018 4:31 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Gao, Liming
> Subject: [edk2] [PATCH 3/6]
Poke. Any comments on this one?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jaben Carsey
> Sent: Friday, November 16, 2018 7:38 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch v1 1/1] BaseTools: cleanup
Poke. Any comments on this one?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jaben Carsey
> Sent: Friday, November 16, 2018 7:42 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch v1 1/1] BaseTools: Move
Poke. Any comments on this one?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jaben Carsey
> Sent: Friday, November 16, 2018 7:40 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch v1 1/1] BaseTools: create and
Agreed.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Wednesday, November 14, 2018 6:34 PM
> To: edk2-devel@lists.01.org
> Cc: Kacperski, Kamil ; Jin, Eric
> ; Orlowski, Pawel ; Kinney,
>
vel@lists.01.org
> Cc: Gao, Liming ; Carsey, Jaben
>
> Subject: [Patch V2] BaseTools: Replace the sqlite database with list
> Importance: High
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1288
>
> [V2]
> Optimize this patch so that it can be easy to review
How concerned with spaces in the DSC lines are we? The following looks very
sensitive to spaces and could be replaced with a regular expression that would
be more flexible.
if "{CODE(" not in PcdValue:
aprox:
if re.match('[{]\w*CODE\w*[(]', PcdValue)
> -Original Message-
> From:
For the series.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jeff Brasen
> Sent: Thursday, November 08, 2018 11:04 AM
> To: edk2-devel@lists.01.org
> Cc: Jeff Brasen
> Subject: [edk2] [PATCH v3 0/2] SortLib for
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, November 08, 2018 2:16 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Carsey, Jaben
>
> Subject: [Patch] BaseTools: Optimize string concatenation
> Imp
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> BobCF
> Sent: Wednesday, November 07, 2018 10:04 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Gao, Liming
>
> Subject: [edk2] [Pat
PM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ye, Ting
> Subject: RE: [PATCH v1] ShellPkg/TftpDynamicCommand: Clarify the retry
> count option in command.
> Importance: High
>
> Reviewed-by: Fu Siyuan
>
>
>
> > -Original Message-
&g
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Wednesday, November 07, 2018 1:37 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Jim Dailey
> Subject: [edk2] [PATCH] ShellPkg/ShellLib: Fix
Laszlo, thanks a bunch for this information. I hadn’t realized I had to do
that manually.
Jaben
> On Nov 5, 2018, at 8:52 AM, Laszlo Ersek wrote:
>
>> On 11/01/18 12:31, Leif Lindholm wrote:
>>> On Thu, Nov 01, 2018 at 06:03:22AM +, Zhang, Shenglei wrote:
>>> Hi Leif,
>>>
>>> Thanks
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Wu, Jiaxin
> Sent: Sunday, November 04, 2018 10:59 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ye, Ting ;
> Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH v1] ShellPkg/TftpDynamicCommand: Clarify the
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zhaozh1x
> Sent: Wednesday, October 31, 2018 3:36 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [PATCH] BaseTools: Check the max size for
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Tuesday, October 30, 2018 8:50 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch V2] BaseTools: Add special handle
Code looks good.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jeff Brasen
> Sent: Tuesday, October 30, 2018 2:31 PM
> To: edk2-devel@lists.01.org
> Cc: Jeff Brasen
> Subject: [edk2] [PATCH 1/2]
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jeff Brasen
> Sent: Tuesday, October 30, 2018 2:31 PM
> To: edk2-devel@lists.01.org
> Cc: Jeff Brasen
> Subject: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable
Please separate includes to each on their own line. PEP8 says no to multiples
on one line.
Not:
include random, string
But instead:
include string
include random
Also, if we only need sample from random, can we just use "from random import
sample"?
-Jaben
> -Original Message-
>
I have the same behavior as Leif describes (with probably the hypothesized
client).
When I reply, I get nothing but the mailing list in "to" (empty "cc").
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Leif Lindholm
> Sent:
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Thursday, October 25, 2018 8:05 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch 1/2 V2] BaseTools: Add $(INC)-like
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Thursday, October 25, 2018 12:38 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch 1/2] BaseTools: Add $(INC)-like support when
> compiling
Reviewed-by: Jaben Carsey
Ray?
I can push this one also if you don't see an issue.
> -Original Message-
> From: jim.dai...@dell.com [mailto:jim.dai...@dell.com]
> Sent: Wednesday, October 24, 2018 9:35 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
&
To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
> Subject: [edk2] [PATCH 2/2] ShellPkg-Shell App: Provide fully-qualified path
> to shell scripts
> Importance: High
>
> Section 3.6.2 of version 2.2 of the shell specification requires that
> the first positio
No effect on functionality, but sometimes first is spelled fisrt in below
patch.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Feng, Bob C
> Sent: Sunday, October 21, 2018 3:48 AM
> To: Zhao, ZhiqiangX ; edk2-devel@lists.01.org
> Cc:
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> BobCF
> Sent: Friday, October 19, 2018 5:00 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTool: Filter out unused structure pcds
>
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Friday, October 19, 2018 12:27 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] BaseTools: Fix the bug that PcdValueFromComm is
> not
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Friday, October 19, 2018 12:21 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] BaseTools: Fix the crash issue when Dynamic
> structure
Reviewed-by: Jaben Carsey
Note that you could change your first 2 lines (of the new content in both
places) to:
for Data in OverrideValues.values():
since you don't ever use the key later on...
-Jaben
> -Original Message-
> From: edk2-devel
I would like to know when a patch fixes a BZ. Subject/body I have less strong
opinion about.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> stephano
> Sent: Thursday, October 18, 2018 2:13 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2]
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gao, Liming
> Sent: Wednesday, October 17, 2018 6:04 PM
> To: Zhu, Yonghong ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [Patch] BaseTools: Fix a bug --pcd option
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> BobCF
> Sent: Wednesday, October 17, 2018 10:43 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: Remove Arch specific build
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zhaozh1x
> Sent: Wednesday, October 17, 2018 10:09 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [PATCH V2] BaseTools: Convert "Unicode
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, October 17, 2018 11:37 AM
> To: Zhao, ZhiqiangX
> Cc: edk2-devel@lists.01.org; Gao, Liming
> Subject: Re: [edk2] [PATCH] BaseTools: covert "unicode string"
Propose to use a set not a list when the data is unordered and unique names of
functions.
With that: reviewed-by:Jaben.carsey
Sent from my iPad
> On Oct 16, 2018, at 7:25 PM, Yonghong Zhu wrote:
>
> From: Hess Chen
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
Hess,
Thanks for the clarification. Makes sense!
I glanced at, but didn't read in detail the code... so.
Acked-by: Jaben Carsey
> -Original Message-
> From: Chen, Hesheng
> Sent: Monday, October 15, 2018 2:34 PM
> To: Carsey, Jaben ; Zhu, Yonghong
> ; edk2-devel@lists.0
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Monday, October 15, 2018 3:24 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Hesheng
> Subject: [edk2] [PATCH] BaseTools/EOT: Change to call a program instead of
> calling
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Monday, October 15, 2018 5:45 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: Add check for the string
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Monday, October 15, 2018 5:46 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] BaseTools: Fix bugs use special character in the --pcd
>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gao, Liming
> Sent: Sunday, October 07, 2018 6:42 PM
> To: Tomas Pilar (tpilar) ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] BaseTools: Allow multiple PciDeviceId in Fdf
>
Seems good to me.
Any thoughts Ray?
Reviewed-by: Jaben Carsey
> -Original Message-
> From: jim.dai...@dell.com [mailto:jim.dai...@dell.com]
> Sent: Thursday, October 04, 2018 9:47 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: [edk2] [
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Sunday, October 07, 2018 8:03 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ye, Ting ;
> Fu, Siyuan ; Wu, Jiaxin ; Bi
1 - 100 of 653 matches
Mail list logo