Re: [edk2] [PATCH edk2-platforms 1/2] Platform/ARM/Sgi: fix incorrect check of config-id value

2018-12-04 Thread chandni cherukuri
On Tue, Dec 4, 2018 at 8:26 PM Ard Biesheuvel wrote: > > On Tue, 4 Dec 2018 at 12:36, Chandni Cherukuri > wrote: > > > > On SGI platform, the value of configuration ID can be zero. > > So avoid returning an error from the function that creates > > th

[edk2] [PATCH edk2-platforms 2/2] Platform/ARM/Sgi: Use NT_FW_CONFIG instead of HW_CONFIG

2018-12-04 Thread Chandni Cherukuri
. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/SgiPlatform.dec | 2 +- Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 2 +- Platform/ARM/SgiPkg

[edk2] [PATCH edk2-platforms 1/2] Platform/ARM/Sgi: fix incorrect check of config-id value

2018-12-04 Thread Chandni Cherukuri
-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c b/Platform/ARM

[edk2] [PATCH edk2-platforms 0/2] Use NT_FW_CONFIG instead of HW_CONFIG

2018-12-04 Thread Chandni Cherukuri
. Chandni Cherukuri (2): Platform/ARM/Sgi: fix incorrect check of config-id value Platform/ARM/Sgi: Use NT_FW_CONFIG instead of HW_CONFIG Platform/ARM/SgiPkg/SgiPlatform.dec | 2 +- Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 2 +- Platform/ARM

Re: [edk2] [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors

2018-11-22 Thread chandni cherukuri
On Thu, Nov 22, 2018 at 1:20 PM Ard Biesheuvel wrote: > > On Thu, 22 Nov 2018 at 05:01, Thomas Abraham wrote: > > > > Hi Ard, > > > > On Thu, Nov 22, 2018 at 3:46 AM Ard Biesheuvel > > wrote: > > > > > > On Wed, 21 Nov 2018 at 14:48, Thomas Abraham > > > wrote: > > > > > > > > Hi Ard, > > > >

[edk2] [PATCH v3 edk2-platforms 6/6] Platform/ARM/Sgi: Add initial support for SGI-Clark.Helios platform

2018-11-21 Thread Chandni Cherukuri
Add the initial support for ARM's System Guidance for Infrastructure SGI-Clark.Helios platform. The ACPI tables for this platform are installed. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM

[edk2] [PATCH v3 edk2-platforms 5/6] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Helios platform

2018-11-21 Thread Chandni Cherukuri
Add ACPI tables specific for SGI-Clark.Helios platform and let this platform reuse the rest of the common SGI platform ACPI tables. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg

[edk2] [PATCH v3 edk2-platforms 4/6] Platform/ARM/Sgi: Add initial support for SGI-Clark.Ares platform

2018-11-21 Thread Chandni Cherukuri
Add the initial support for ARM's System Guidance for Infrastructure SGI-Clark.Ares platform. The ACPI tables for this platform are installed. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg

[edk2] [PATCH v3 edk2-platforms 3/6] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform

2018-11-21 Thread Chandni Cherukuri
Add ACPI tables specific for SGI-Clark.Ares platform and let this platform reuse the rest of the common SGI platform ACPI tables. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg

[edk2] [PATCH v3 edk2-platforms 2/6] Platform/ARM/Sgi: Refactor ACPI tables for SGI platforms

2018-11-21 Thread Chandni Cherukuri
in the platform specific folder. Also the AcpiTables.inf file is renamed as Sgi575AcpiTables.inf and moved to AcpiTables folder. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/SgiPlatform.dsc

[edk2] [PATCH v3 edk2-platforms 1/6] Platform/ARM/Sgi: Adapt to changes in system-id DT node.

2018-11-21 Thread Chandni Cherukuri
takes the SGI_PLATFORM_DESCRIPTOR HoB as the function parameter. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Include/SgiPlatform.h| 1 + Platform/ARM/SgiPkg/Drivers

[edk2] [PATCH v3 edk2-platforms 0/6] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms

2018-11-21 Thread Chandni Cherukuri
platforms. Chandni Cherukuri (6): Platform/ARM/Sgi: Adapt to changes in system-id DT node. Platform/ARM/Sgi: Refactor ACPI tables for SGI platforms Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform Platform/ARM/Sgi: Add initial support for SGI-Clark.Ares platform Platform/ARM/Sgi

Re: [edk2] [PATCH v3 edk2-platforms 0/5] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms

2018-11-19 Thread chandni cherukuri
st the new v3 patchset containing the changes that we've discussed? Thanks Chandni > On Mon, Nov 12, 2018 at 05:11:51PM +0530, Chandni Cherukuri wrote: > > Changes since v2: > > - Added additional checks for platform-id and config-id values. > > > > Changes since v1: &

Re: [edk2] [PATCH v2 edk2-platforms 1/5] Platform/ARM/Sgi: Adapt to changes in system-id DT node.

2018-11-12 Thread chandni cherukuri
On Mon, Nov 12, 2018 at 4:55 PM Leif Lindholm wrote: > > +edk2-devel > > On Mon, Nov 12, 2018 at 04:28:35PM +0530, chandni cherukuri wrote: > > On Fri, Nov 9, 2018 at 9:59 PM Leif Lindholm > > wrote: > > > > > > On Mon, Nov 05, 2018 at

[edk2] [PATCH v3 edk2-platforms 5/5] Platform/ARM/Sgi: Add initial support for SGI-Clark.Helios platform

2018-11-12 Thread Chandni Cherukuri
Add the initial support for ARM's System Guidance for Infrastructure SGI-Clark.Helios platform. The ACPI tables for this platform are installed. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Chandni Cherukuri --- Platform/ARM

[edk2] [PATCH v3 edk2-platforms 4/5] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Helios platform

2018-11-12 Thread Chandni Cherukuri
Added ACPI tables and GUID name 'gSgiClarkHeliosAcpiTablesFileGuid' for SGI-Clark.Helios platform. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/SgiPlatform.dec | 1

[edk2] [PATCH v3 edk2-platforms 3/5] Platform/ARM/Sgi: Add initial support for SGI-Clark.Ares platform

2018-11-12 Thread Chandni Cherukuri
Add the initial support for ARM's System Guidance for Infrastructure SGI-Clark.Ares platform. The ACPI tables for this platform are installed. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg

[edk2] [PATCH v3 edk2-platforms 1/5] Platform/ARM/Sgi: Adapt to changes in system-id DT node.

2018-11-12 Thread Chandni Cherukuri
own in the 'system-id' node. So adapt to these changes in the 'system-id' node. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 24

[edk2] [PATCH v3 edk2-platforms 0/5] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms

2018-11-12 Thread Chandni Cherukuri
in this series adds support to use a new binding added to the system-id node for Platform Identification. The rest of the patches add support for the two new SGI platforms. Chandni Cherukuri (5): Platform/ARM/Sgi: Adapt to changes in system-id DT node. Platform/ARM/Sgi: Add ACPI tables for SGI

[edk2] [PATCH v2 edk2-platforms 5/5] Platform/ARM/Sgi: Add platform support for SGI-Clark.Helios

2018-11-05 Thread Chandni Cherukuri
Platform support for SGI-Clark.Helios platform has been added. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 3 +++ Platform/ARM/SgiPkg/Include/SgiPlatform.h | 1 + 2 files changed

[edk2] [PATCH v2 edk2-platforms 4/5] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Helios platform

2018-11-05 Thread Chandni Cherukuri
Added ACPI tables and GUID name 'gSgiClarkHeliosAcpiTablesFileGuid' for SGI-Clark.Helios platform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- .../ARM/SgiPkg/AcpiTables/SgiClarkH/AcpiTables.inf | 58 + Platform/ARM/SgiPkg/AcpiTables

[edk2] [PATCH v2 edk2-platforms 3/5] Platform/ARM/Sgi: Add support for SGI-Clark.Ares platform

2018-11-05 Thread Chandni Cherukuri
Platform support for SGI-Clark.Ares platform has been added Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 16 +--- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 4

[edk2] [PATCH v2 edk2-platforms 2/5] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform

2018-11-05 Thread Chandni Cherukuri
Added ACPI tables and GUID name 'gSgiClarkAresAcpiTablesFileGuid' for SGI-Clark.Ares platform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- .../ARM/SgiPkg/AcpiTables/SgiClarkA/AcpiTables.inf | 58 +++ Platform/ARM/SgiPkg/AcpiTables/SgiClarkA

[edk2] [PATCH v2 edk2-platforms 1/5] Platform/ARM/Sgi: Adapt to changes in system-id DT node.

2018-11-05 Thread Chandni Cherukuri
own in the 'system-id' node. So adapt to these changes in the 'system-id' node. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- .../SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 19 ++- 1 file changed, 18 insertions(+), 1

[edk2] [PATCH v2 edk2-platforms 0/5] Platform/ARM/Sgi: Add support for Clark.Ares and

2018-11-05 Thread Chandni Cherukuri
node for Platform Identification. The rest of the patches add support for the two new SGI platforms. Chandni Cherukuri (5): Platform/ARM/Sgi: Adapt to changes in system-id DT node. Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform Platform/ARM/Sgi: Add support for SGI-Clark.Ares

[edk2] [PATCH edk2-platforms 5/5] Platform/ARM/Sgi: Add platform support for SGI-Clark.Helios

2018-11-02 Thread Chandni Cherukuri
Platform support for SGI-Clark.Helios platform has been added. Change-Id: Iaf7962334b6366d35a195e4c94341d1972783a81 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 3 +++ Platform/ARM/SgiPkg

[edk2] [PATCH edk2-platforms 4/5] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Helios platform

2018-11-02 Thread Chandni Cherukuri
Added ACPI tables and GUID name 'gSgiClarkHeliosAcpiTablesFileGuid' for SGI-Clark.Helios platform. Change-Id: Ib212c0b27ad1f9f709385ac92e5e06b1bd33bfc0 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkH

[edk2] [PATCH edk2-platforms 3/5] Platform/ARM/Sgi: Add support for SGI-Clark.Ares platform

2018-11-02 Thread Chandni Cherukuri
Platform support for SGI-Clark.Ares platform has been added Change-Id: I3bb15950963f1ccbf3c099894e90ef730dfc3f8e Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 16 +--- Platform/ARM

[edk2] [PATCH edk2-platforms 2/5] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform

2018-11-02 Thread Chandni Cherukuri
Added ACPI tables and GUID name 'gSgiClarkAresAcpiTablesFileGuid' for SGI-Clark.Ares platform. Change-Id: Ic58fdc4cdd5919b59ca7752ab3468b41cb79d0f0 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkA

[edk2] [PATCH edk2-platforms 1/5] Platform/ARM/Sgi: Adapt to changes in system-id DT node.

2018-11-02 Thread Chandni Cherukuri
own in the 'system-id' node. So adapt to these changes in the 'system-id' node. Change-Id: Ia15e31df50f2f43746231e5c4352035a13510bba Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 241

[edk2] [PATCH edk2-platforms 0/5] Add platform support for SGI-Clark platforms

2018-11-02 Thread Chandni Cherukuri
Rest of the patches add support for SGI-Clark.Ares and SGI-Clark.Helios platforms. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms] sgi575/acpi: Use ACPI 6.2 specification

2018-08-30 Thread chandni cherukuri
On Thu, Aug 30, 2018 at 6:33 PM Ard Biesheuvel wrote: > > On 30 August 2018 at 13:23, Leif Lindholm wrote: > > On Wed, Aug 29, 2018 at 04:14:16PM +0530, Chandni Cherukuri wrote: > >> Switched from using ACPI 6.1 to 6.2 specification for > >> SGI575 since SBB

[edk2] [PATCH edk2-platforms] sgi575/acpi: Use ACPI 6.2 specification

2018-08-29 Thread Chandni Cherukuri
Switched from using ACPI 6.1 to 6.2 specification for SGI575 since SBBR 1.1 requires ACPI 6.2 tables or later. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dbg2.aslc | 8

Re: [edk2] [PATCH edk2-platforms v2 0/2] ARM Dynamic Configuration

2018-06-17 Thread chandni cherukuri
On Fri, Jun 15, 2018 at 6:10 PM, Leif Lindholm wrote: > On Fri, Jun 15, 2018 at 05:30:00PM +0530, Chandni Cherukuri wrote: >> On SGI platforms, the trusted firmware executes prior to the SEC >> phase. It supplies to the SEC phase, a pointer to a HW CONFIG fdt >> in the x1 wh

Re: [edk2] [PATCH edk2-platforms v2 2/2] Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID

2018-06-17 Thread chandni cherukuri
On Fri, Jun 15, 2018 at 6:35 PM, Ard Biesheuvel wrote: > On 15 June 2018 at 14:00, Chandni Cherukuri wrote: >> Use the platform ID and config ID values from the platform ID >> HOB to choose the right set of ACPI tables to be installed. >> >> Contributed-under: Tiano

[edk2] [PATCH edk2-platforms v3 1/2] Platform/ARM/Sgi: Install a Platform ID HOB

2018-06-17 Thread Chandni Cherukuri
-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Include/Ppi/SgiPlatformId.h | 23 Platform/ARM/SgiPkg/Include/SgiPlatform.h | 13 +++ Platform/ARM/SgiPkg/Library/PlatformLib/AArch64/Helper.S | 13 ++- Platform/ARM/SgiPkg/Library/PlatformLib

[edk2] [PATCH edk2-platforms v3 2/2] Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID

2018-06-17 Thread Chandni Cherukuri
Use the platform ID and config ID values from the platform ID HOB to choose the right set of ACPI tables to be installed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 30

Re: [edk2] [PATCH 1/2] Platform/ARM/Sgi: Install a Platform ID HOB

2018-06-15 Thread chandni cherukuri
On Fri, Jun 15, 2018 at 3:48 PM, Leif Lindholm wrote: > > Just some minor formatting points in addition to the comment on Ard's > reply.. > > On Fri, Jun 15, 2018 at 11:25:31AM +0530, Chandni Cherukuri wrote: > > On SGI platforms, the trusted firmware executes prior

[edk2] [PATCH edk2-platforms v2 2/2] Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID

2018-06-15 Thread Chandni Cherukuri
Use the platform ID and config ID values from the platform ID HOB to choose the right set of ACPI tables to be installed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 33

[edk2] [PATCH edk2-platforms v2 0/2] ARM Dynamic Configuration

2018-06-15 Thread Chandni Cherukuri
the information. During DXE phase the drivers can access the Platform ID HOB to get the platform information and perform platform specific functions based on the platform. Chandni Cherukuri (2): Platform/ARM/Sgi: Install a Platform ID HOB Platform/ARM/Sgi: Pick ACPI tables to install based on platfo

[edk2] [PATCH edk2-platforms v2 1/2] Platform/ARM/Sgi: Install a Platform ID HOB

2018-06-15 Thread Chandni Cherukuri
-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Include/Ppi/SgiPlatformId.h | 23 Platform/ARM/SgiPkg/Include/SgiPlatform.h | 13 +++ Platform/ARM/SgiPkg/Library/PlatformLib/AArch64/Helper.S | 13 ++- Platform/ARM/SgiPkg/Library/PlatformLib

[edk2] [PATCH 0/2] ARM Dynamic Configuration

2018-06-14 Thread Chandni Cherukuri
mation. During DXE phase the drivers can access the Platform ID HOB to get the platform information and perform platform specific functions based on the platform. Chandni Cherukuri (2): Platform/ARM/Sgi: Install a Platform ID HOB Platform/ARM/Sgi: Pick ACPI tables to install based on platf

[edk2] [PATCH 2/2] Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID

2018-06-14 Thread Chandni Cherukuri
Use the platform ID and config ID values from the platform ID HOB to choose the right set of ACPI tables to be installed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- .../ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 33

[edk2] [PATCH 1/2] Platform/ARM/Sgi: Install a Platform ID HOB

2018-06-14 Thread Chandni Cherukuri
-off-by: Chandni Cherukuri --- .../SgiPkg/Library/PlatformLib/AArch64/Helper.S| 15 ++- .../ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 10 ++ .../ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 3 + .../Library/SgiPlatformPeiLib/SgiPlatformPeiLib.c | 108