Re: [edk2] [Patch] MdeModulePkg: Fix IPv4 UseDefaultAddress failure case.

2016-06-08 Thread El-Haj-Mahmoud, Samer
Reviewed-by : Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Jiaxin Wu [jiaxin...@intel.com] Received: Wednesday, 08 Jun 2016, 12:49AM To: edk2-devel@lists.01.org [edk2-devel@lists.01.org] CC: Ye Ting [ting...@intel.com]; El-Haj-Mahmoud, Samer [samer.el-ha

Re: [edk2] [PATCH] [edk2-staging/HTTPS-TLS][PATCH]: CryptoPkg/TlsLib: Remove NULL cipher

2016-06-07 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Palmer, Thomas Sent: Monday, June 6, 2016 9:47 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; jiaxin...@intel.com; Palmer, Thomas <thomas.pal...@hpe.com&g

Re: [edk2] [PATCH] [edk2-staging/HTTPS-TLS][PATCH]: CryptoPkg/TlsLib: Handshake failure

2016-06-07 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Palmer, Thomas Sent: Tuesday, June 7, 2016 1:36 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; jiaxin...@intel.com; Palmer, Thomas <thomas.pal...@h

Re: [edk2] [PATCH] MdeModulePkg:Prevent the BmRepairAllControllers routine in an infinite loop

2016-06-02 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Li, Gary (HPS SW) Sent: Thursday, June 2, 2016 2:00 AM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; ruiyu...@intel.com; Li, Gary (HPS SW) <gar...@hpe.com&g

Re: [edk2] [Patch 0/2] Stop-the-timer-before-clean-IP-service

2016-05-25 Thread El-Haj-Mahmoud, Samer
Reviewed-by : Samer El-Haj-Mahmoud -Original Message- From: Fu Siyuan [siyuan...@intel.com] Received: Wednesday, 25 May 2016, 9:04PM To: edk2-devel@lists.01.org [edk2-devel@lists.01.org] Subject: [edk2] [Patch 0/2] Stop-the-timer-before-clean-IP-service Fu Siyuan (2):

Re: [edk2] edk2-staging/HTTPS-TLS

2016-05-25 Thread El-Haj-Mahmoud, Samer
Thanks Jiaxin. I will pull the code and let you know if I run into issues -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Tuesday, May 24, 2016 10:17 PM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@lists.01.org Subject: RE: edk2-s

Re: [edk2] [PATCH v2] MdeModulePkg RamDiskDxe: VALID_ARCH cleanup to list supported options

2016-05-25 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tian, Feng Sent: Wednesday, May 25, 2016 12:23 AM To: Wu, Hao A ; edk2-devel@lists.01.org Cc: Tian, Feng

Re: [edk2] [Patch 1/2] MdePkg: Correct EFI_HTTP_CONFIGURE return status value

2016-05-25 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Wednesday, May 25, 2016 3:28 AM To: edk2-devel@lists.01.org Cc: Ye Ting ; Zhang Lubo ; Fu

Re: [edk2] [PATCH] MdePkg/WSMT.h: update header comment to use official URL link.

2016-05-20 Thread El-Haj-Mahmoud, Samer
Thanks for fixing it.. I was wondering what that URL was, and had to ping MS about it. Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Thursday, May 19, 2016 7:58 PM To:

Re: [edk2] [patch] NetworkPkg: Refine codes of Http boot driver.

2016-05-20 Thread El-Haj-Mahmoud, Samer
Yes this is probably better than HTTP drivers directly printing on console -Original Message- From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Thursday, May 19, 2016 9:04 PM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Zhang, Lubo <lubo.zh...@intel.com>

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

2016-05-19 Thread El-Haj-Mahmoud, Samer
Yes this works, A simple checkbox in the HII form before starting File Explorer -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, May 19, 2016 2:49 AM To: Tian, Feng <feng.t...@intel.com>; El-Haj-Mahmoud,

Re: [edk2] [patch] NetworkPkg: Refine codes of Http boot driver.

2016-05-19 Thread El-Haj-Mahmoud, Samer
Thanks Zhang. I know this makes sense (and does help during lengthy download), and I also know that PXE does something similar. I am only concerned about this happening after BGRT logo is displayed on the screen (if PXE/HTTP boot options are tried after a failed HDD boot option for instance).

Re: [edk2] [PATCH 2/2] NetworkPkg/TcpDxe: Remove the status check of SockProcessRcvToken

2016-05-19 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Wednesday, May 18, 2016 10:49 PM To: edk2-devel@lists.01.org Cc: Siyuan Fu ; Jiaxin Wu

Re: [edk2] [PATCH 1/2] NetworkPkg/HttpDxe: Don't free Wrap in HttpTcpReceiveNotifyDpc

2016-05-19 Thread El-Haj-Mahmoud, Samer
that the HTTP Token Wrap will be freed in EfiHttpResponse or HttpResponseWorker, this commit removes every "FreePool (Wrap)" in HttpTcpReceiveNotifyDpc. Cc: "Wu, Jiaxin" <jiaxin...@intel.com> Cc: "Siyuan Fu" <siyuan...@intel.com> Cc: "El-Haj-Mahmoud, Samer"

Re: [edk2] [PATCH 1/2] NetworkPkg/HttpDxe: Don't free Wrap in HttpTcpReceiveNotifyDpc

2016-05-19 Thread El-Haj-Mahmoud, Samer
Interesting (and accurate) deduction... :) -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Thursday, May 19, 2016 5:07 AM To: Laszlo Ersek Cc: edk2-de...@ml01.01.org; Wu, Jiaxin ; Siyuan Fu

Re: [edk2] edk2-staging/HTTPS-TLS

2016-05-19 Thread El-Haj-Mahmoud, Samer
com>; Wu, Jiaxin <jiaxin...@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Li, Ruth <ruth...@intel.com>; Ye, Ting <ting...@intel.com>; Long, Qin <qin.l...@intel.com>; edk2-devel@lists.01.org <edk2-de...@ml01.01.org>; Justen, Jordan L <

[edk2] edk2-staging/HTTPS-TLS

2016-05-18 Thread El-Haj-Mahmoud, Samer
Jiaxin, The HTTPs-TLS branch is behind EDK2 master, and they are quite a few conflicts to try to keep up with both. Can you please sync the branch from EDK2 master? Thanks, --Samer ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread El-Haj-Mahmoud, Samer
Thanks Jaben! Will you give it a reviewed-by ? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Wednesday, May 18, 2016 11:25 AM To: Palmer, Thomas ; jim_dai...@dell.com; edk2-devel@lists.01.org Cc:

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

2016-05-18 Thread El-Haj-Mahmoud, Samer
: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, May 18, 2016 9:28 AM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Andrew Fish <af...@apple.com>; Foster, Matthew I <matthew.i.fos...@intel.com>; feng.t...@intel.com Cc: edk2-devel@lists.01.org <edk2-de...@ml0

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

2016-05-18 Thread El-Haj-Mahmoud, Samer
in troubleshooting. Thanks, --Samer -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Wednesday, May 18, 2016 9:04 AM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Andrew Fish <af...@apple.com>; Foste

Re: [edk2] [PATCH v2 0/3] *** Add Nvme.h and NvmExpressLib ***

2016-05-18 Thread El-Haj-Mahmoud, Samer
Series Reviewed-By: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Reyes, Darbin Sent: Tuesday, May 17, 2016 4:16 PM To: edk2-devel@lists.01.org Cc: feng.t...@intel.com; Reyes, Darbin

Re: [edk2] HTTP Boot crashed when downloading remote image

2016-05-18 Thread El-Haj-Mahmoud, Samer
Gary, The EDK2 list blocked the wireshark attachment. Can you put it on a share and send a link please? We are trying to look at this internally as well. Thanks, --Samer -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Tuesday,

Re: [edk2] [PATCH v2 3/3] MdeModulePkg: Add NvmExpressLib.

2016-05-18 Thread El-Haj-Mahmoud, Samer
lt;star.z...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming <liming....@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Tian, Feng <feng.t...@intel.com> Subject: RE: [PATCH v2 3/3] MdeModulePkg: Add NvmExpressLib. Hi, Da

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

2016-05-18 Thread El-Haj-Mahmoud, Samer
Does it make sense to update the RAM Disk HII (at \MdeModulePkg\Universal\Disk\RamDiskDxe) to allow creating a RAM Disk of Type Reserved, for this kind of testing? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Wednesday,

Re: [edk2] [PATCH 0/3] *** Add Nvme.h and NvmExpressLib ***

2016-05-11 Thread El-Haj-Mahmoud, Samer
el.com [star.z...@intel.com]; michael.d.kin...@intel.com [michael.d.kin...@intel.com]; liming@intel.com [liming@intel.com]; El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; Reyes, Darbin [darbin.emm.re...@hpe.com] Subject: [PATCH 0/3] *** Add Nvme.h and NvmExpressLib *** From: Darbin

Re: [edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Handle HTTPS indefinite poll case

2016-05-11 Thread El-Haj-Mahmoud, Samer
u, Siyuan <siyuan...@intel.com>; Long, > Qin <qin.l...@intel.com> > Subject: [edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Handle HTTPS > indefinite poll case > > This patch is used to handle handle HTTPS indefinite poll case. > > Cc: El-Haj-Mahmoud Samer <samer.el-haj-

Re: [edk2] [Patch] SecurityPkg: SecureBootConfigDxe: Add NULL pointer check

2016-05-10 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Tuesday, May 10, 2016 2:52 AM To: edk2-devel@lists.01.org Cc: shumin@intel.com; Chao Zhang

Re: [edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Fix unclosed TCP connection case if TLS session failed

2016-05-09 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Sunday, May 8, 2016 9:51 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Ye Ting <ting...@intel.com>;

Re: [edk2] [PATCH v4 0/2] Report ACPI NFIT for reserved memory RAM disks

2016-05-06 Thread El-Haj-Mahmoud, Samer
Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, May 6, 2016 10:57 AM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@lists.01.org <edk2-de...@ml01.01.org>; jordan.l.jus...@intel.com; hao.a...@intel.com Cc: Hsiung, Harry L <harry.l.hsi...@int

Re: [edk2] [PATCH v4 0/2] Report ACPI NFIT for reserved memory RAM disks

2016-05-06 Thread El-Haj-Mahmoud, Samer
What is the status of this series? It got reviewed a while ago, but it still not committed. From: El-Haj-Mahmoud, Samer Sent: Thursday, April 28, 2016 10:30 PM To: edk2-devel@lists.01.org; ler...@redhat.com; jordan.l.jus...@intel.com; hao.a...@intel.com Cc: hao.a...@intel.com Subject: RE: [edk2

Re: [edk2] [Patch 0/2] Do not use hard coded TTL/ToS in PXE driver.

2016-05-04 Thread El-Haj-Mahmoud, Samer
Thanks for fixing this. We noticed the same and were about to submit a patch. Series Reviewed-By: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Monday, May 2, 2016 9:26 PM To:

Re: [edk2] [PATCH v1 1/1] NetworkPkg:HttpDxe: Code changes to support HTTP PUT/POST operations

2016-05-04 Thread El-Haj-Mahmoud, Samer
Series Reviewed-By: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Hegde, Nagaraj P Sent: Wednesday, May 4, 2016 5:46 AM To: edk2-devel@lists.01.org Cc: jiaxin...@intel.com; siyuan...@intel.com; ting...@intel.com; El-Haj-Mahmoud, Samer <samer.el-haj-mahm..

Re: [edk2] [PATCH v4 0/2] Report ACPI NFIT for reserved memory RAM disks

2016-04-28 Thread El-Haj-Mahmoud, Samer
Series Reviewed-By: Samer El-Haj-Mahmoud -Original Message- From: Hao Wu [hao.a...@intel.com] Received: Thursday, 28 Apr 2016, 9:23PM To: edk2-devel@lists.01.org [edk2-devel@lists.01.org]; ler...@redhat.com [ler...@redhat.com]; jordan.l.jus...@intel.com

Re: [edk2] [PATCH v3 0/2] Report ACPI NFIT for reserved memory RAM disks

2016-04-28 Thread El-Haj-Mahmoud, Samer
-Original Message- From: Hao Wu [mailto:hao.a...@intel.com] Sent: Thursday, April 28, 2016 12:08 AM To: edk2-devel@lists.01.org; feng.t...@intel.com; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; jiewen@intel.com Cc: Hao Wu <hao.a...@intel.com> Subject: [PATCH v3 0/2] Repo

Re: [edk2] [PATCH 1/5] MdePkg: Revert AuditMode/DeployedMode name definition

2016-04-28 Thread El-Haj-Mahmoud, Samer
Series reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Thursday, April 28, 2016 2:46 AM To: edk2-devel@lists.01.org Cc: siyuan...@intel.com; Chao Zhang

[edk2] [staging/HTTPs-TLS] merge from tianocore master

2016-04-28 Thread El-Haj-Mahmoud, Samer
the timer check to avoid the indefinite wait case in HttpDxe driver A.HTTP receive Header process in HttpTcpReceiveHeader(); B.HTTP receive Body process in HttpTcpReceiveBody(); Cc: Hegde Nagaraj P <nagaraj-p.he...@hpe.com> Cc: El-Haj-Mahmoud Samer <samer.el-haj-mahm...@hpe.com> Cc: Y

Re: [edk2] [PATCH] ShellPkg: Fix typos and EDK2 coding style issues

2016-04-27 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Shah, Tapan Sent: Wednesday, April 27, 2016 9:56 AM To: edk2-devel@lists.01.org Cc: jaben.car...@intel.com Subject: [edk2] [PATCH] ShellPkg: Fix

Re: [edk2] [PATCH v2] MdeModulePkg: Export ConfigResp only for form Package after ReadyToBoot

2016-04-26 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: Bi, Dandan > Sent: Tuesday, April 26, 2016 11:03 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [PATCH v2] MdeModulePkg: Export ConfigResp only for form > Package after ReadyToBoot

Re: [edk2] [PATCH v3] SecurityPkg/DxeImageVerificationLib: Add DEBUG messages for image verification failures

2016-04-26 Thread El-Haj-Mahmoud, Samer
e...@ml01.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; chao.b.zh...@intel.com Subject: Re: [PATCH v3] SecurityPkg/DxeImageVerificationLib: Add DEBUG messages for image verification failures On 04/26/16 18:51, Cinnamon Shia wrote: > Add DEBUG messages in DxeImageerifica

Re: [edk2] Questions on write access to edk2-staging

2016-04-26 Thread El-Haj-Mahmoud, Samer
Mike, Laszlo, Thanks for the answers. --Samer -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, April 26, 2016 12:13 PM To: Kinney, Michael D <michael.d.kin...@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@

Re: [edk2] [PATCH v1] MdePkg:Http11.h: Add defines for "Expect" header

2016-04-26 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Hegde, Nagaraj P Sent: Monday, April 25, 2016 10:47 PM To: edk2-devel@lists.01.org Cc: jiaxin...@intel.com; siyuan...@intel.com; ting...@intel.com; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com

Re: [edk2] [PATCH v2] NetworkPkg: Allow user to create a HTTP corporate boot option in setup page.

2016-04-26 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Fu, Siyuan Sent: Tuesday, April 26, 2016 11:47 AM To: edk2-devel@lists.01.org Cc: Li Gary ; Ye, Ting ; Wu, Jiaxin Subject: [PATCH v2] NetworkPkg: Allow

Re: [edk2] [PATCH] CryptoPkg: Fix TLS Lib issue when certificate is added to store multiple times

2016-04-26 Thread El-Haj-Mahmoud, Samer
- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, Jiaxin Sent: Monday, April 25, 2016 8:54 PM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Carsey, Jaben <jaben.car...@intel.com> Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] Crypto

[edk2] Questions on write access to edk2-staging

2016-04-26 Thread El-Haj-Mahmoud, Samer
What is the process of requesting write access to edk2-staging? *Should only module and tree maintainers have write access (similar to edk2)? *Should developers working on contributing to the feature branches have write access? Also related: *Should developers use

Re: [edk2] [PATCH] CryptoPkg: Fix TLS Lib issue when certificate is added to store multiple times

2016-04-26 Thread El-Haj-Mahmoud, Samer
en.car...@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com> Cc: edk2-devel@lists.01.org <edk2-de...@ml01.01.org> Subject: Re: [edk2] [PATCH] CryptoPkg: Fix TLS Lib issue when certificate is added to store multiple times On 04/26/16 02:43, Wu, Jiaxin wrote: &

Re: [edk2] [PATCH] CryptoPkg: Fix TLS Lib issue when certificate is added to store multiple times

2016-04-25 Thread El-Haj-Mahmoud, Samer
Jiaxin Wu <jiaxin...@intel.com> BTW, Do you commit the patch by yourself or need I help to check in the patch? Best Regards! Jiaxin > -Original Message- > From: Carsey, Jaben > Sent: Tuesday, April 26, 2016 4:00 AM > To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...

Re: [edk2] [PATCH] CryptoPkg: Fix TLS Lib issue when certificate is added to store multiple times

2016-04-25 Thread El-Haj-Mahmoud, Samer
: Monday, April 25, 2016 12:54 PM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Wu, Jiaxin <jiaxin...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> Subject: RE: [edk2] [PATCH

Re: [edk2] [PATCH] ShellPkg: Enahance 'dh' command to add more protocols decoding support

2016-04-22 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Shah, Tapan Sent: Friday, April 22, 2016 11:32 AM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; jaben.car...@intel.com; Shah, Tapan <tapands...@hpe.com&g

Re: [edk2] [staging/HTTPS-TLS][PATCH 0/3] Provide an UI to support TLS authentication

2016-04-22 Thread El-Haj-Mahmoud, Samer
Series Reviewed-By: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Tuesday, April 19, 2016 10:08 PM To: edk2-devel@lists.01.org Cc: Ye Ting ; Fu Siyuan ;

Re: [edk2] [PATCH] NetworkPkg: Don't need to update device path in home environment

2016-04-22 Thread El-Haj-Mahmoud, Samer
Ting, Siyuan, Jiaxin, Can one of you please commit this change if you have no objections? Thanks, --Samer -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El-Haj-Mahmoud, Samer Sent: Friday, April 15, 2016 8:26 AM To: Li, Gary (HPS SW) <

Re: [edk2] [PATCH] [Staging/Customized-Secure-Boot]: Create branch for Customized Secure Boot

2016-04-21 Thread El-Haj-Mahmoud, Samer
Will the existing customized secureboot code in EDK2 Master be reverted until this branch is ready to be merged back into Master (With ECR1263 changes?) -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Thursday, April 21,

Re: [edk2] [staging/HTTPS-TLS][PATCH 0/3] Provide an UI to support TLS authentication

2016-04-20 Thread El-Haj-Mahmoud, Samer
Thanks! I will take a look once I can build this and test it. For now: Series Reviewed-By: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, Jiaxin Sent: Tuesday, April 19, 2016 10:13 PM To:

Re: [edk2] [staging/HTTPS-TLS][PATCH] Readme.MD: Add Readme for HTTPS-TLS branch

2016-04-19 Thread El-Haj-Mahmoud, Samer
[qin.l...@intel.com]; El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com] Subject: [staging/HTTPS-TLS][PATCH] Readme.MD: Add Readme for HTTPS-TLS branch Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Long Qin <qin.l...@intel.com> Cc: El-Haj-Mahmoud Samer <s

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: API BmIsValidLoadOptionVariableName

2016-04-19 Thread El-Haj-Mahmoud, Samer
Never mind, I just saw this was committed in 3dc5c1ae5c7575ba2d1714b40692b36fca56c120 Thanks! --Samer -Original Message- From: El-Haj-Mahmoud, Samer Sent: Tuesday, April 19, 2016 2:39 PM To: Palmer, Thomas <thomas.pal...@hpe.com>; edk2-devel@lists.01.org Cc: feng.t...@int

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: API BmIsValidLoadOptionVariableName

2016-04-19 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> Ray, Feng, Star, Can you please help review and commit this change? -Original Message- From: Palmer, Thomas Sent: Monday, April 4, 2016 2:52 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com

Re: [edk2] Request HTTPS branch in edk2-staging

2016-04-19 Thread El-Haj-Mahmoud, Samer
Looks good. No objection here Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, Jiaxin Sent: Tuesday, April 19, 2016 3:55 AM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.co

Re: [edk2] Tianocore Staging Process

2016-04-14 Thread El-Haj-Mahmoud, Samer
Excellent! Thank you Tony. First feature branch request sent -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Mangefeste, Tony Sent: Wednesday, April 13, 2016 4:54 PM To: edk2-devel@lists.01.org Subject: [edk2] Tianocore Staging Process

Re: [edk2] [PATCH v2 5/6] NetworkPkg: HTTPS support over IPv4 and IPv6

2016-04-12 Thread El-Haj-Mahmoud, Samer
To: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; edk2-devel@lists.01.org [edk2-devel@lists.01.org] CC: Ye, Ting [ting...@intel.com]; Fu, Siyuan [siyuan...@intel.com]; Long, Qin [qin.l...@intel.com] Subject: RE: [edk2] [PATCH v2 5/6] NetworkPkg: HTTPS support over IPv4 and IPv6 Thanks

Re: [edk2] [PATCH v2 5/6] NetworkPkg: HTTPS support over IPv4 and IPv6

2016-04-12 Thread El-Haj-Mahmoud, Samer
jiaxin...@intel.com] Sent: Monday, April 11, 2016 2:50 AM To: edk2-devel@lists.01.org Cc: Ye Ting <ting...@intel.com>; Fu Siyuan <siyuan...@intel.com>; Long Qin <qin.l...@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com> Subject: [PATCH v2 5/6] NetworkPkg: HTTPS

Re: [edk2] [Patch v4 0/3] HTTP Boot to RAM Disk

2016-04-05 Thread El-Haj-Mahmoud, Samer
Series reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Tuesday, April 5, 2016 2:54 AM To: edk2-devel@lists.01.org Cc: Ruiyu Ni Subject: [edk2] [Patch v4 0/3]

Re: [edk2] [PATCH v1 0/2] Rename and update HttpGenRequestString API

2016-04-04 Thread El-Haj-Mahmoud, Samer
Series reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hegde, Nagaraj P Sent: Monday, April 4, 2016 4:51 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 0/2] Rename and update

Re: [edk2] [Patch] NetworkPkg: Add RAM disk boot support to HTTP Boot driver.

2016-04-01 Thread El-Haj-Mahmoud, Samer
ch 31, 2016 7:46 PM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> Subject: RE: [edk2] [Patch] NetworkPkg: Add RAM disk boot support to HTTP Boot driver. Hi, Samer Does th

Re: [edk2] [Patch] NetworkPkg: Check pointer for NULL before use.

2016-04-01 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Friday, April 1, 2016 12:16 AM To: edk2-devel@lists.01.org Cc: Ye Ting ; Wu Jiaxin Subject:

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Expose BmLoadOption function

2016-03-31 Thread El-Haj-Mahmoud, Samer
Thanks Ray. We will address the feedback and resubmit a new patch. From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Wednesday, March 30, 2016 7:39 PM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Palmer, Thomas <thomas.pal...@hpe.com>

Re: [edk2] [Patch] NetworkPkg: Add RAM disk boot support to HTTP Boot driver.

2016-03-31 Thread El-Haj-Mahmoud, Samer
Virtual Disk Image Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> Cc: El-Haj-Mahmoud Samer <samer.el-haj-mahm...@hpe.com> --- NetworkPkg/HttpBoo

Re: [edk2] [Patch v2 2/3] MdeModulePkg/Bds: Free resources after ram disk boot finishes

2016-03-31 Thread El-Haj-Mahmoud, Samer
Looks good... Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, Siyuan Sent: Wednesday, March 30, 2016 9:32 PM To: Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Tian, Feng

Re: [edk2] [Patch v3 1/3] MdeModulePkg/Bds: Allocate reserved memory for RAM Disk boot media

2016-03-31 Thread El-Haj-Mahmoud, Samer
Looks good. Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Wednesday, March 30, 2016 9:37 PM To: edk2-devel@lists.01.org Cc: Ruiyu Ni ; Siyuan Fu

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Expose BmLoadOption function

2016-03-30 Thread El-Haj-Mahmoud, Samer
tion Thomas, May I know the purpose to expose this function? Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >El-Haj-Mahmoud, Samer >Sent: Wednesday, March 30, 2016 6:12 AM >To: Palmer, Thomas <thomas.pal...@hpe.com

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Report ACPI NFIT for reserved memory RAM disks

2016-03-30 Thread El-Haj-Mahmoud, Samer
Hao, Thanks for the patch! It looks like this change will create an NFIT table instead of trying to append to an existing one. This is problematic, as NFIT table might already exist (from NVDIMM support code for instance). Both NVDIMM and RAMDisk code that deals with NFIT need to be able to

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Expose BmLoadOption function

2016-03-29 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Palmer, Thomas Sent: Tuesday, March 29, 2016 5:08 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; feng.t...@intel.com; star.z...@intel.com; Palmer, Thomas

Re: [edk2] [PATCH] SecurityPkg/Tcg2Dxe: Fix undersized TempBuf

2016-03-29 Thread El-Haj-Mahmoud, Samer
Reviewed- by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Palmer, Thomas Sent: Tuesday, March 29, 2016 5:01 PM To: edk2-devel@lists.01.org Cc: chao.b.zh...@intel.com; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Palmer, Thomas <thomas.pal...@h

Re: [edk2] [PATCH] * MdePkg: Add UEFI2.6 HII Font protocol definitions.

2016-03-29 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Sheng, Cecil (HPS SW) Sent: Tuesday, March 29, 2016 1:30 AM To: edk2-devel@lists.01.org Cc: liming@intel.com; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Sheng, Cecil (HPS SW) <ceci

Re: [edk2] [PATCH] ShellPkg/UefiHandleParsingLib: Fix GUID reference

2016-03-24 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Palmer, Thomas Sent: Thursday, March 24, 2016 5:05 PM To: edk2-devel@lists.01.org Cc: jaben.car...@intel.com; shumin@intel.com; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Ar

Re: [edk2] [Patch 5/6] NetworkPkg: HTTPS support over IPv4 and IPv6

2016-03-14 Thread El-Haj-Mahmoud, Samer
I have finally got some time to go over this with others from HPE. We have a concern that TlsCaCertificate is currently limited to one certificate. That is not practical for clients like HTTPs Boot. Supporting configuring multiple trusted certs is necessary. Can the variable instead be

Re: [edk2] [PATCH] MdeModulePkg: Fixed incorrect Regular expression protocol MatchString return value.

2016-03-14 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer EL-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Sheng, Cecil (HPS SW) Sent: Monday, March 14, 2016 9:39 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; feng.t...@intel.com; star.z...@intel.com Subject

Re: [edk2] [Patch 1/6] MdePkg: Add TLS related protocol definition

2016-03-09 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Wednesday, February 24, 2016 2:15 AM To: edk2-devel@lists.01.org Cc: Ye Ting ; Fu Siyuan ;

Re: [edk2] [PATCH v4] MdeModulePkg: Increase the maximum number of PEI performance log entries

2016-03-07 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Shia, Cinnamon Sent: Monday, March 7, 2016 12:48 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Shia, Cinnamon <cinnamon.s...@hpe.com> Subject: [PATC

Re: [edk2] [PATCH v2 1/2] PerformancePkg/Dp_App: Support execution break

2016-03-07 Thread El-Haj-Mahmoud, Samer
Series Reviewed-by: Samer EL-Haj-Mahmoud On 2016/3/7 11:23, Cinnamon Shia wrote: > Support UEFI shell execution break. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Cinnamon Shia > --- > PerformancePkg/Dp_App/Dp.c |

Re: [edk2] [PATCH v2] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

2016-03-07 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer EL-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Shia, Cinnamon Sent: Monday, March 7, 2016 1:57 AM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Shia, Cinnamon <cinnamon.s...@hpe.com> Subject: [PATC

Re: [edk2] [PATCH 2/2] NetworkPkg: Use the New Functions from HttpLib

2016-03-07 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer EL-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Belaam, Ghazi Sent: Friday, March 4, 2016 4:08 PM To: edk2-devel@lists.01.org Cc: feng.t...@intel.com; star.z...@intel.com; siyuan...@intel.com; jiaxin...@intel.com; El-Haj-Mahmoud, Samer <samer.el

Re: [edk2] [PATCH 1/2] ModulePkg/DxeHttpLib: Adding Functions to HttpLib

2016-03-07 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer EL-Haj-Mahmoud > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ghazi Belaam > Sent: Saturday, March 5, 2016 6:08 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Wu, Jiaxin >

Re: [edk2] [PATCH] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

2016-03-05 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Shia, Cinnamon Sent: Saturday, March 5, 2016 7:19 AM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Shia, Cinnamon <cinnamon.s...@hpe.com> Subject: [P

Re: [edk2] [PATCH v2 0/2] RAM disk driver implementation

2016-02-26 Thread El-Haj-Mahmoud, Samer
Series Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Hao Wu [mailto:hao.a...@intel.com] Sent: Thursday, February 25, 2016 11:14 PM To: edk2-devel@lists.01.org; feng.t...@intel.com; sigmaepsilo...@gmail.com; El-Haj-Mahmoud, Samer <samer.el

Re: [edk2] [PATCH 2/2] MdeModulePkg: Add RamDiskDxe driver implementation

2016-02-25 Thread El-Haj-Mahmoud, Samer
Reviewed-By: Samer EL-Haj-Mahmoud Please see comments below RamDiskDriver.c * Comments say "SecureBoot" in multiple locations. Should say "RAM Disk" instead. UNI file: * Use "RAM" consistently, not "Ram" or "ram" -Original Message- From: edk2-devel

Re: [edk2] [PATCH 1/2] MdePkg: Add EFI RAM Disk Protocol definitions

2016-02-25 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Thursday, February 4, 2016 1:31 AM To: edk2-devel@lists.01.org; feng.t...@intel.com Cc: Hao Wu Subject: [edk2]

Re: [edk2] [PATCH] MdeModulePkg: Add HttpUtilLib

2016-02-23 Thread El-Haj-Mahmoud, Samer
-Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, Siyuan Sent: Tuesday, February 23, 2016 8:17 PM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com> Subjec

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-02-23 Thread El-Haj-Mahmoud, Samer
ure: >>>>Boot Time cost:1st:3.353s 2nd: 3.035s >>>>With this feature: >>>>Boot Time cost:1st: 3.125s 2nd: 3.126s >>>> >>>> Base on the above analysis, we provide this design and prefer to alwa

Re: [edk2] [PATCH] MdePkg: Fix CPER GUID definitions to match UEFI spec

2016-02-22 Thread El-Haj-Mahmoud, Samer
Will do. Thanks Liming. -Original Message- From: Gao, Liming [liming@intel.com] Received: Monday, 22 Feb 2016, 6:34AM To: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; edk2-devel@lists.01.org [edk2-devel@lists.01.org] CC: Kinney, Michael D [michael.d.kin...@intel.com]; El

Re: [edk2] [PATCH v2 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

2016-02-21 Thread El-Haj-Mahmoud, Samer
Siyuan, Can you review please? -Original Message- From: El-Haj-Mahmoud, Samer Sent: Thursday, February 18, 2016 4:48 PM To: edk2-devel@lists.01.org Cc: siyuan...@intel.com; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm..

Re: [edk2] [PATCH] MdePkg: Fix CPER GUID definitions to match UEFI spec

2016-02-21 Thread El-Haj-Mahmoud, Samer
Mike or Liming, Can you review please? -Original Message- From: El-Haj-Mahmoud, Samer Sent: Thursday, February 18, 2016 5:35 PM To: edk2-devel@lists.01.org Cc: michael.d.kin...@intel.com; liming@intel.com; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; El-Haj-Mahmoud,

Re: [edk2] [PATCH] MdePkg: Fix incorrect PCIe Extended Capabilities definition

2016-02-21 Thread El-Haj-Mahmoud, Samer
Mike or Liming, Can you review please? -Original Message- From: El-Haj-Mahmoud, Samer Sent: Thursday, February 18, 2016 6:01 PM To: edk2-devel@lists.01.org Cc: michael.d.kin...@intel.com; liming@intel.com; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; El-Haj-Mahmoud,

Re: [edk2] [PATCH] MdeModulePkg: Add HttpUtilLib

2016-02-21 Thread El-Haj-Mahmoud, Samer
Siyuan, Can you review please? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El-Haj-Mahmoud, Samer Sent: Thursday, February 18, 2016 6:49 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>;

Re: [edk2] [PATCH] MdeModulePkg : Fix a bug in BmpImageDecoderLib

2016-02-21 Thread El-Haj-Mahmoud, Samer
Eric or Ray, Can you review please? -Original Message- From: El-Haj-Mahmoud, Samer Sent: Thursday, February 18, 2016 6:59 PM To: edk2-devel@lists.01.org Cc: eric.d...@intel.com; ruiyu...@intel.com; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; El-Haj-Mahmoud, Samer <

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-18 Thread El-Haj-Mahmoud, Samer
Thanks Jiewen. On ARCH64 systems, it is possible not to have any memory below 4GB at all. Ard, Are you OK with a solution that does not use a PCD? -Original Message- From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Thursday, February 18, 2016 8:35 AM To: El-Haj-Mahmoud, Samer

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-18 Thread El-Haj-Mahmoud, Samer
Jiewen, I think ACPI and SMBIOS solutions could be the same, or could be different. The SMBIOS 3.0 spec allows SMBIOS table to be above 4GB, and some platforms may chose that even if they have memory below 4GB. For the ACPI patch, it looks like Ard's feedback and yours are contradictory. Ard

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

2016-02-17 Thread El-Haj-Mahmoud, Samer
this was the intention of introducing the PCDs. Previously, the policy was hard-coded to DHCP/auto in the EDK2 drivers. -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, February 17, 2016 3:00 PM To: El-Haj-Mahmoud, Samer <samer.el-haj-m

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-02-16 Thread El-Haj-Mahmoud, Samer
+1 I also would add there may be some HII strings that are hidden from user interfaces, and reflect settings for field service or troubleshooting, and that a mass export to the OS may expose these settings to OS runtime code and possibly applications. -Original Message- From:

Re: [edk2] [PATCH v2 1/2] ShellPkg/UefiDpLib: Refine the code of locating all handles in DpTrace.c.

2016-02-16 Thread El-Haj-Mahmoud, Samer
Series Reviewed -By: Samer El-Haj-Mahmoud <el...@hpe.com> -Original Message- From: Shia, Cinnamon Sent: Monday, February 15, 2016 3:07 AM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Shia, Cinnamon <cinnamon.s...@hpe.com> Subj

Re: [edk2] [PATCH 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

2016-02-13 Thread El-Haj-Mahmoud, Samer
Siyuan Either way is fine. Do you want to make the changes yourself or wait for me to submit a patch next week? -Original Message- From: Fu, Siyuan [siyuan...@intel.com] Received: Saturday, 13 Feb 2016, 8:53PM To: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; edk2-devel

Re: [edk2] github development process

2016-02-12 Thread El-Haj-Mahmoud, Samer
Thank you! This is much better... -Original Message- From: Bjorge, Erik C [mailto:erik.c.bjo...@intel.com] Sent: Thursday, February 11, 2016 7:14 PM To: Bjorge, Erik C <erik.c.bjo...@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@lists.01.org

  1   2   >