Re: [edk2] [PATCH v7] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

+ @param[in] *Cr2 Pointer to variable to hold CR2 register value +**/ the indicator in should be out。 发自我的小米手机 在 2019年3月29日 下午9:56，nkvangup 写道： BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593 For every SMI occurrence, save and restore CR2 register only when SMM on-demand paging

[edk2] 答复: 答复: [Patch v2 2/2] UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.

Sorry. Correct some critical wording. “ACPI NVS and 4G limitation are history reason and are NOT necessary currently.” Jeff 发件人: edk2-devel 代表 Fan Jeff 发送时间: Friday, August 10, 2018 12:00:08 PM 收件人: Dong, Eric; 'Laszlo Ersek' 抄送: Ni, Ruiyu; Kinney

[edk2] 答复: [Patch v2 2/2] UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.

also the address not > > limit to below 4G. > > This change remove the limit of ACPI NVS memory type and below 4G. > > > > Pass OS boot and resume from S3 test. > > > > Bugz: https://bugzilla.tianocore.org/show_bug.cgi?id=959 > > > > Reported-by: Mar

Re: [edk2] 答复: [Patch] UefiCpuPkg/MpInitLib: Optimize get processor number performance.

Laszlo， Thanks your remind. You are right! I agree original commit message is correct and neednt updating. Eric, please ignore my comments on commit message. Thanks! Jeff 发自我的小米手机 在 Laszlo Ersek ，2018年7月5日 下午9:04写道： Hi Jeff, On 07/04/18 11:39, Fan Jeff wrote: > Eric, > >

[edk2] 答复: [Patch] UefiCpuPkg/MpInitLib: Optimize get processor number performance.

Eric, Current implementation does not call GetApicid() many times, Please correct you commit message. Your fix is to improve the performance against the current implementation. This code part is ok to me. Reviewed-by: Jeff Fan vanjeff_...@hotmail.com

[edk2] 答复: Is the PEI Core MP Safe? UefiCpuPkg seems to think so calling GetFirstGuidHob on the APs?

Andrew, Not all services are permitted for AP routines. For example, MP->WhoAmI() could be invoked by AP by specified Current implementation should be safe. I also agree with IDT entry solution, as we did in DebugAgentLib. Thanks! Jeff 发件人: Andrew Fish 发送时间:

Re: [edk2] CpuS3DataDxe / DxeRegisterCpuFeaturesLib dependency.

he PCD allocation code from CpuFeaturesPei. Regards, Marvin. From: Fan Jeff <vanjeff_...@hotmail.com> Sent: Monday, May 28, 2018 11:51 AM To: Laszlo Ersek <ler...@redhat.com>; Marvin Häuser <marvin.haeu...@outlook.com> Cc: edk2-devel@lists.01.org; eric.d...@intel.com Subject:

Re: [edk2] 答复: CpuS3DataDxe / DxeRegisterCpuFeaturesLib dependency.

implement one AllocateAcpiCpuData() in DXE instance as PEI instance. Thanks! Jeff 发自我的小米手机 在 Fan Jeff <vanjeff_...@hotmail.com>，2018年5月28日 下午5:50写道： Hi, The current implementation assumes CpuS3DataDxe was dispatched before CpuFeaturesDxe. I do not remember clearly why

[edk2] 答复: CpuS3DataDxe / DxeRegisterCpuFeaturesLib dependency.

Hi, The current implementation assumes CpuS3DataDxe was dispatched before CpuFeaturesDxe. I do not remember clearly why I made this assumption before. (It maybe only due to CpuS3DataDxe was just dispatched firstly on all my validation platforms.), I agree this is one bug. Simply, we could

[edk2] 答复: [PATCH] UefiCpuPkg/MpInitLib: Disable interrupt at ExitBootServices AP Mwait

Thanks! Reviewed-by: Jeff Fan 发件人: Hao Wu 发送时间: 2018年3月19日 13:31 收件人: edk2-devel@lists.01.org 抄送: Hao Wu; Laszlo Ersek; Jeff

[edk2] 答复: [PATCH] UefiCpuPkg/PeiMpLib: Fix a system hang-in-pei issue.

Reviewed-by: Jeff Fan 发件人: Ruiyu Ni 发送时间: 2018年1月22日 17:17 收件人: edk2-devel@lists.01.org 抄送: Eric Dong; Star Zeng 主题: [edk2] [PATCH] UefiCpuPkg/PeiMpLib: Fix

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Fix a bug that AP enters timer INT handler

Reviewed-by: Jeff Fan Ray,thank you find/fix this issue! 发自我的 iPhone > 在 2018年1月5日，下午5:08，Ruiyu Ni 写道： > > When SourceLevelDebug is enabled, AP randomly executes the DXECORE > timer handler logic. The root cause is the interrupts are not > masked

[edk2] 答复: [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

Cool. PI SCT is better and easier. Jeff 发件人: Yao, Jiewen<mailto:jiewen@intel.com> 发送时间: 2018年1月5日 10:58 收件人: Wang, Jian J<mailto:jian.j.w...@intel.com>; Fan Jeff<mailto:vanjeff_...@hotmail.com>; Laszlo Ersek<mailto:ler...@redhat.com>; edk2-devel@lists.01.org<mai

[edk2] 答复: [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

Sorry, Dump the APICID, not CPUID. Jeff 发件人: Fan Jeff<mailto:vanjeff_...@hotmail.com> 发送时间: 2018年1月5日 10:48 收件人: Wang, Jian J<mailto:jian.j.w...@intel.com>; Laszlo Ersek<mailto:ler...@redhat.com>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> 抄送: Y

[edk2] 答复: [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

You may use MP->SwitchBSP() to do BSP switch and then dump BSP’s CPUID to know if the switch is successfully. Jeff From: Wang, Jian J <jian.j.w...@intel.com> Sent: Friday, January 5, 2018 9:57:31 AM To: Fan Jeff; Laszlo Ersek; edk2-devel@lists.01.or

[edk2] 答复: [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

Laszlo, Firstly, SwitchBSP() is one service of MP defined in PI spec. For real case, I think multiple socket system(with different processor stepping) may use this service for purpose. Thanks! Jeff 发件人: Laszlo Ersek 发送时间: 2018年1月4日 20:21 收件人: Wang, Jian

[edk2] 答复: [RFC v4 1/6] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

Paulo, I did not receive your #0 patch. So, I reply #1 here. Your serial of patches should work for IA32/X64 GCC and IA32 MSFT. I suggest you could push this serial of patches as soon as pass UefiCpuPkg owner/reviewers’ review and validation, And then I could send my x64 MSFT support

[edk2] 答复: [RFC v4 6/6] UefiCpuPkg/CpuExceptionHandlerLib: Correctly print IP addresses

Paulo, Thanks. Reviewed-by: Jeff Fan Jeff From: edk2-devel on behalf of Paulo Alcantara Sent: Friday, December 29, 2017 12:39:39 PM To:

[edk2] 答复: [RFC v4 5/6] UefiCpuPkg/CpuExceptionHandlerLib: Ensure valid frame/stack pointers

Paulo, +if (!IsLogicalAddressValid (SystemContext, +SystemContext.SystemContextIa32->Ss, +(UINTN)Ebp) || +!IsLogicalAddressValid (SystemContext, +SystemContext.SystemContextIa32->Ss, +

[edk2] 答复: [RFC v4 4/6] UefiCpuPkg/CpuExceptionHandlerLib: Add helper to valid memory addresses

Paul, + // + // Calculate physical address of PML4E + // + PhysicalAddress = (UINT64)Cr3 & (((1ULL << MaxPhyAddrBits) - 1) << 12); + PhysicalAddress |= (((UINT64)LinearAddress >> 39) & 0x1FF) << 3; + Should not pass VS build, instead you could use LShiftU64/RShiftU64 to do 64bit shift

[edk2] 答复: [PATCH V2] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

I agree to add one _MAX #define in library instance implementation instead of in class header file. Jeff From: edk2-devel on behalf of Ni, Ruiyu Sent: Wednesday, December 13, 2017 4:49:01 PM To: Laszlo

[edk2] 答复: [PATCH v2 0/8] Implement stack guard feature

Jian, I reviewed your patches and sent my minimal comments in other separate mail. They should not impact the functionality. I am ok if you push the v2 patches now and do the updating based on my comments in separate patches later. Reviewed-by: Jeff Fan Thanks! Jeff

[edk2] 答复: [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Jian, EFIAPI is not required for ArchSetupExcpetionStack(). Reviewed-by: Jeff Fan Jeff From: edk2-devel on behalf of Jian J Wang Sent: Wednesday, November 22, 2017

[edk2] 答复: [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Hi, About 1.1), I agree with Jiewen’s suggestion. Besides it, we also need to provide dummy function of InitializeCpuExceptionStackSwitchHandlers() in NULL instance in MdeModulePkg/Library/CpuExceptionHandlerLibNull. But we need to think about the return status carefully. For example, if

[edk2] 答复: [PATCH v2 2/8] MdeModulePkg/CpuExceptionHandlerLib.h: Add a new API

Hi, I am not sure if this is good idea to define such arch specific definitions in MdeModulePkg. Moreover, we don’t know how ARM or other processors define this definition, either. Jeff From: edk2-devel on behalf of

Re: [edk2] [RFC v3 1/3] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

Paulo could provide his gcc reassembly code. Thanks! Jeff 发自我的 iPhone 在 2017年11月24日，上午2:34，Andrew Fish <af...@apple.com<mailto:af...@apple.com>> 写道： On Nov 23, 2017, at 6:27 AM, Fan Jeff <vanjeff_...@hotmail.com<mailto:vanjeff_...@hotmail.com>> wrote: Hi Paulo,

[edk2] 答复: 答复: [RFC v3 1/3] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

) in PartitionDxe.dll Thanks! Jeff From: Paulo Alcantara <pca...@zytor.com> Sent: Monday, November 20, 2017 10:59:41 PM To: Fan Jeff; edk2-devel@lists.01.org Cc: Laszlo Ersek; Eric Dong Subject: Re: 答复: [edk2] [RFC v3 1/3] UefiCpuPkg/CpuExceptionHandlerL

[edk2] 答复: [RFC v3 1/3] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

Paulo, I don't understand why you - 1 when calculating EIP offset in image, it confused me. + for (;;) { +// +// Print stack frame in the following format: +// +// # @ + (RBP) in [ | ] +// +InternalPrintMessage ( + "%d 0x%016lx @ 0x%016lx+0x%x (0x%016lx) in

[edk2] 答复: 答复: 答复: [RFC 0/1] Stack trace support in X64 exception handling

ber 15, 2017 10:41:00 PM To: Fan Jeff; edk2-devel@lists.01.org Cc: Rick Bramley; Laszlo Ersek; Andrew Fish; Eric Dong Subject: Re: 答复: 答复: [edk2] [RFC 0/1] Stack trace support in X64 exception handling Hi Fan, On 15/11/2017 11:21, Fan Jeff wrote: > Paulo, > > I will try to validate

[edk2] 答复: 答复: [RFC 0/1] Stack trace support in X64 exception handling

on IA32 arch with GCC toolchain? Thanks! Jeff From: Paulo Alcantara <pca...@zytor.com> Sent: Tuesday, November 14, 2017 11:37:35 PM To: Fan Jeff; edk2-devel@lists.01.org Cc: Rick Bramley; Laszlo Ersek; Andrew Fish; Eric Dong Subject: Re: 答复: [edk2] [R

[edk2] 答复: [RFC 1/1] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

Andrew, We could use he EIP offset in Paul’s trace message and work with the generated map file under debug directory for debug trace. Jeff 发件人: Andrew Fish 发送时间: 2017年11月14日 22:01 收件人: Paulo Alcantara 抄送:

[edk2] 答复: 答复: [RFC 0/1] Stack trace support in X64 exception handling

Paul, Sorry, correct some import words in my last mail. “I did NOT finalize my POC”.:-) Jeff From: edk2-devel <edk2-devel-boun...@lists.01.org> on behalf of Fan Jeff <vanjeff_...@hotmail.com> Sent: Tuesday, November 14, 2017 10:03:20

[edk2] 答复: [RFC 0/1] Stack trace support in X64 exception handling

Paul, I like this feature very much. Actually, I did some POC one year ago but I did finalize it. In my POC, I could use EBP to tack the stack frame on IAS32 arch. But for x64, I tried to use �Ckeepexceptiontable flag to explain stack frame from the debug section of image. I may workson MSFT

[edk2] 答复: [PATCH 3/4] UefiCpuPkg/MtrrLib: Update algorithm to calculate optimal settings

Laszlo, PiSmmCpuDxeSmm isn’t the problem, it also only consumed MtrrSetAllMtrrs() that will not consume big local variable buffer. Jeff From: edk2-devel on behalf of Ni, Ruiyu Sent: Thursday,

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

callback function on CPU MP Protocol to allocate stack for Aps. For 2),we could consider new API solution if PEI phase does support this new feature. Jeff 发件人: Yao, Jiewen<mailto:jiewen@intel.com> 发送时间: 2017年11月6日 9:55 收件人: Wang, Jian J<mailto:jian.j.w...@intel.com>

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Jian, In EDKII, DS == SS on most of cases. I don’t think there is any issue to use data range for stack. Jeff From: Wang, Jian J <jian.j.w...@intel.com> Sent: Monday, November 6, 2017 8:30:29 AM To: Fan Jeff; Yao, Jiewen; Kinney, Michael D; edk2-devel@li

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

ael.d.kin...@intel.com>; Fan Jeff<mailto:vanjeff_...@hotmail.com>; Wang, Jian J<mailto:jian.j.w...@intel.com>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> 抄送: Dong, Eric<mailto:eric.d...@intel.com>; Zeng, Star<mailto:star.z...@intel.com> 主题: RE: [PATCH 3

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Jian, You are right! The exception handler setup in DxeIplPeim does not need stack at all. Thanks your clarification. Jeff 发件人: Wang, Jian J<mailto:jian.j.w...@intel.com> 发送时间: 2017年11月1日 11:12 收件人: Wang, Jian J<mailto:jian.j.w...@intel.com>; Fan Jeff<mailto:vanjeff_...@ho

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

That’s fine. Thanks Developers should have such assumption without exception dumping message if NULL instance used. Jeff 发件人: Wang, Jian J<mailto:jian.j.w...@intel.com> 发送时间: 2017年11月1日 11:08 收件人: Fan Jeff<mailto:vanjeff_...@hotmail.com>; Yao, Jiewen<mailto:jiewen@intel.co

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

, could Stack Switch work if PCD PcdCpuStackGuard is set to TRUE. Thanks! Jeff 发件人: Wang, Jian J<mailto:jian.j.w...@intel.com> 发送时间: 2017年11月1日 10:48 收件人: Fan Jeff<mailto:vanjeff_...@hotmail.com>; Yao, Jiewen<mailto:jiewen@intel.com>; edk2-devel@lists.01.org<mailto:edk2-d

[edk2] 答复: [PATCH] MdeModulePkg/PciBus: Disable BME of all devices when entering RT

Minimal comment: To use DEBUG_INFO instead of EFI_D_INFO for consistence in this patch. +DEBUG (( + EFI_D_INFO," %02x %02x %02x %04x\n", + PciIoDevice->BusNumber, PciIoDevice->DeviceNumber, PciIoDevice->FunctionNumber, + Command + ));

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

1. Should add EFIAPI for the following function. +VOID +AsmWriteTr ( + UINT16 Selector + ); 2. Should not add EFIAPI for the following function. +VOID +EFIAPI +ArchSetupExcpetionStack ( + IN IA32_IDT_GATE_DESCRIPTOR *IdtTable + ) 发件人: Jian J

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Per https://bugzilla.tianocore.org/show_bug.cgi?id=109, TR should be setup (Such as in DxeIplPeim) even though NULL Cpu Exception Handler instance is chosen. For long term, I agree we need to move AsmWriteTr, IA32_TASK_STATE_SEGMENT, IA32_TSS_DESCRIPTOR to MdePkg(Such as BaseLib) For this

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Keep compatible with former solution.

Reviewed-by: Jeff Fan > 发自我的小米手机 在 Eric Dong ，2017年10月26日 下午1:59写道： For some special platforms (such as Ovmf), it is possible that, some APs start up *and finish* before the remaining APs not start up *at all*. In

[edk2] 答复: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Laszlo, I agree BZ#251 can not be closed if commit 0594ec417c89 does not work for OVMF. I will reopen it. Jeff 发件人: Laszlo Ersek 发送时间: 2017年10月25日 1:40 收件人: Dong, Eric; edk2-devel@lists.01.org 抄送: Ni,

[edk2] 答复: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Johnson, For OVMF case, we knew the actual processor number. But for most real platform cases, we have no this knowledge on the first time sending broadcast INIT-SIPI-SIPI. Jeff 发件人: Brian J. Johnson 发送时间: 2017年10月25日 6:30 收件人: Laszlo

[edk2] 答复: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Laszlo, How about to skip the condition check on CpuCount? - if (CpuMpData->CpuCount == 0) { TimedWaitForApFinish ( CpuMpData, PcdGet32 (PcdCpuMaxLogicalProcessorNumber) - 1, PcdGet32 (PcdCpuApInitTimeOutInMicroSeconds) ); - } For OVMF

[edk2] 答复: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Sure. Done. 发件人: Ni, Ruiyu<mailto:ruiyu...@intel.com> 发送时间: 2017年10月24日 15:18 收件人: Fan Jeff<mailto:vanjeff_...@hotmail.com>; Dong, Eric<mailto:eric.d...@intel.com>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> 主题: RE: [Patch 2/2] UefiCpuPkg/MpInitLib

[edk2] 答复: [Patch 0/2] Enhance collect AP Count logic

Reviewed-by: Jeff Fan 发件人: Eric Dong 发送时间: 2017年10月23日 15:22 收件人: edk2-devel@lists.01.org 主题: [edk2] [Patch 0/2] Enhance collect AP Count logic Current logic always waiting for a specific value to collect all

[edk2] 答复: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Ray, MpCpuExchangeInfo was declared as volatile type. It may not be necessary to add volatile for NumApsExecuting. Jeff 发件人: Ni, Ruiyu 发送时间: 2017年10月24日 14:03 收件人: Dong, Eric; edk2-devel@lists.01.org 主题:

Re: [edk2] [Patch] Edk2: Update UefiCpuPkg owner.

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Dong, Eric Sent: Friday, August 04, 2017 1:01 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [Patch] Edk2: Update UefiCpuPkg owner. Cc: Jeff Fan <jeff@intel.com> Contributed-under: TianoCore

Re: [edk2] [Patch v4 2/3] UefiCpuPkg: Add Processor Trace feature definition.

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Friday, August 04, 2017 11:37 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Fan, Jeff Subject: [edk2] [Patch v4 2/3] UefiCpuPk

Re: [edk2] [Patch v4 1/3] UefiCpuPkg: Add Pcds used by processor trace feature.

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Dong, Eric Sent: Friday, August 04, 2017 11:37 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Ni, Ruiyu Subject: [Patch v4 1/3] UefiCpuPkg: Add Pcds used by processor trace feature. Cc: Jeff Fan <jeff@inte

Re: [edk2] [Patch v3 3/3] UefiCpuPkg: Enable Processor Trace feature.

, then the Protected Processor Inventory + Number feature must be disabled. + + @retval RETURN_SUCCESS Intel Processor Trace feature is initialized. Jeff -Original Message- From: Fan, Jeff Sent: Thursday, August 03, 2017 10:04 PM To: Dong, Eric; edk2-d

Re: [edk2] [Patch 1/3] UefiCpuPkg: Add definition for LMCE feature.

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Dong, Eric Sent: Tuesday, August 01, 2017 3:51 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Ni, Ruiyu Subject: [Patch 1/3] UefiCpuPkg: Add definition for LMCE feature. Cc: Jeff Fan <jeff@intel.com>

Re: [edk2] [Patch 3/3] UefiCpuPkg PiSmmCpuDxeSmm: Check LMCE capability when wait for AP.

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Dong, Eric Sent: Tuesday, August 01, 2017 3:51 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Ni, Ruiyu Subject: [Patch 3/3] UefiCpuPkg PiSmmCpuDxeSmm: Check LMCE capability when wait for AP. Cc: Jeff Fan

Re: [edk2] [Patch 2/3] UefiCpuPkg CpuCommonFeaturesLib: Enable LMCE feature.

edk2-devel@lists.01.org Cc: Fan, Jeff; Ni, Ruiyu Subject: [Patch 2/3] UefiCpuPkg CpuCommonFeaturesLib: Enable LMCE feature. Cc: Jeff Fan <jeff@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by

Re: [edk2] [Patch v3 3/3] UefiCpuPkg: Enable Processor Trace feature.

buffer, for ProcTraceInitialize() is invoked by BSP only. Jeff -Original Message- From: Dong, Eric Sent: Tuesday, August 01, 2017 3:41 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Ni, Ruiyu Subject: [Patch v3 3/3] UefiCpuPkg: Enable Processor Trace feature. Cc: Jeff Fan <jeff@intel.

Re: [edk2] [Patch 3/3] UefiCpuPkg: Enable Processor Trace feature.

sage- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan, Jeff Sent: Monday, July 31, 2017 5:27 PM To: Dong, Eric; edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: Re: [edk2] [Patch 3/3] UefiCpuPkg: Enable Processor Trace feature. Eric, ProcTraceGetConfigData() is invoked

Re: [edk2] [Patch 3/3] UefiCpuPkg: Enable Processor Trace feature.

@lists.01.org Cc: Fan, Jeff; Ni, Ruiyu Subject: [Patch 3/3] UefiCpuPkg: Enable Processor Trace feature. Cc: Jeff Fan <jeff@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong <eric

Re: [edk2] [PATCH 2/3] UefiCpuPkg SecCore: Add SecPerformancePpiCallBack

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Zeng, Star Sent: Monday, July 31, 2017 11:32 AM To: edk2-devel@lists.01.org Cc: Zeng, Star; Gao, Liming; Fan, Jeff Subject: [PATCH 2/3] UefiCpuPkg SecCore: Add SecPerformancePpiCallBack Add SecPerformancePpiCa

Re: [edk2] [PATCH 1/3] UefiCpuPkg SecCore: Adjust PeiTemporaryRamBase to be 8byte aligned

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Zeng, Star Sent: Monday, July 31, 2017 11:32 AM To: edk2-devel@lists.01.org Cc: Zeng, Star; Gao, Liming; Fan, Jeff Subject: [PATCH 1/3] UefiCpuPkg SecCore: Adjust PeiTemporaryRamBase to be 8byte aligned As HOB

Re: [edk2] [PATCH] UefiCpuPkg/CpuCommonFeaturesLib: Fix the documentation of PpinSupport().

Reviewed-by: Jeff Fan <jeff@intel.com> Thanks! -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Friday, July 21, 2017 6:20 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [PATCH] UefiCpuPkg/CpuCommonFeaturesLib: Fix the documen

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Cast the return value of GetPageTableBase().

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin Häuser Sent: Friday, July 21, 2017 6:20 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm

Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

Marvin, Could you tell what VS version you are using? Jeff -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Friday, July 21, 2017 6:20 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements. Old

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

Marvin, Could the following updating fix your issue? ApicBase = MsrValue & ~0xfff; Thanks! Jeff -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin Häuser Sent: Tuesday, July 25, 2017 12:57 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael

Re: [edk2] [Patch v2 0/3] Enable PPIN Cpu feature.

Reivewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Monday, July 17, 2017 10:57 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch v2 0/3] Enable PPIN Cpu feature. Enable PPIN Cpu f

Re: [edk2] [Patch] UefiCpuPkg: Remove deprecated CPU feature.

Reivewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Thursday, July 20, 2017 1:47 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Fan, Jeff Subject: [edk2] [Patch] UefiCpuPkg: Remove depr

Re: [edk2] [Patch] UefiCpuPkg: Update RegisterCpuFeaturesLib to consume PcdGetSize with UINTN

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, July 11, 2017 11:34 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] UefiCpuPkg: Update RegisterCpuFeaturesLib to c

Re: [edk2] [Patch] UefiCpuPkg: Update RegisterCpuFeaturesLib module UNI to match it

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, July 11, 2017 11:33 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] UefiCpuPkg: Update RegisterCpuFeaturesLib modu

Re: [edk2] [Patch V2 0/2] Fix enable Smx/Vmx error.

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Tuesday, July 11, 2017 10:19 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch V2 0/2] Fix enable Smx/Vmx error. Patch also add

Re: [edk2] [Patch 0/4] Update code to follow spec definition.

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Thursday, July 06, 2017 9:30 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/4] Update code to follow spec definition.

Re: [edk2] [PATCH v2] UefiCpuPkg: ApicLib

, July 02, 2017 6:45 AM To: edk2-devel@lists.01.org Cc: Leo Duran; Justen, Jordan L; Fan, Jeff; Gao, Liming; Brijesh Singh Subject: [PATCH v2] UefiCpuPkg: ApicLib 1) SendInitSipiSipi () Skip repeating SendIpi () on AMD processor. 2) SendInitSipiSipiAllExcludingSelf () Skip repeating SendIpi

Re: [edk2] [patch] UefiCpuPkg: Fix coding style issues

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Bi, Dandan Sent: Wednesday, June 28, 2017 10:43 AM To: edk2-devel@lists.01.org Cc: Brijesh Singh; Fan, Jeff Subject: [patch] UefiCpuPkg: Fix coding style issues Cc: Brijesh Singh <brijesh.si...@amd.com>

Re: [edk2] [PATCH v5 1/2] UefiCpuPkg: Add CPUID definitions for AMD.

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Leo Duran [mailto:leo.du...@amd.com] Sent: Saturday, June 17, 2017 8:42 AM To: edk2-devel@lists.01.org Cc: Leo Duran; Justen, Jordan L; Fan, Jeff; Gao, Liming; Brijesh Singh Subject: [PATCH v5 1/2] UefiCpuPkg: Add

Re: [edk2] [PATCH V2] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl.

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Tuesday, June 13, 2017 2:44 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Fan, Jeff Subject: [edk2] [PATCH V2] Uefi

Re: [edk2] [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl.

them into your patch? Thank! Jeff -Original Message- From: Yao, Jiewen Sent: Monday, June 12, 2017 10:14 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Kinney, Michael D Subject: [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl. Add more CPU ID which can support

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Wednesday, May 24, 2017 7:21 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A; Kinney, Michael D; Laszlo Ersek; Andrew Fish; Fan

Re: [edk2] [Patch V2] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Kinney, Michael D Sent: Tuesday, May 23, 2017 1:13 AM To: edk2-devel@lists.01.org Cc: Andrew Fish; Fan, Jeff; Kinney, Michael D Subject: [Patch V2] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues

the InitialzeFloatingPointUnitsAddress after this piece of code copied into AP reset vector in memory in BackupAndPrepareWakeupBuffer(). Thanks! Jeff -Original Message- From: Kinney, Michael D Sent: Monday, May 22, 2017 3:05 AM To: edk2-devel@lists.01.org Cc: Andrew Fish; Fan, Jeff; Kinney, Michael D Subject: [Patch

Re: [edk2] [Patch] UefiCpuPkg: Use FINIT instead of hex values

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Kinney, Michael D Sent: Friday, May 19, 2017 2:37 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Gao, Liming; Kinney, Michael D Subject: [Patch] UefiCpuPkg: Use FINIT instead of hex values https://bugzilla.tianoco

Re: [edk2] [PATCH v2] MdeModulePkg/BDS: Fix a buffer overflow bug

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Ni, Ruiyu Sent: Friday, May 19, 2017 3:26 PM To: edk2-devel@lists.01.org Cc: Shi, Steven; Zeng, Star; Fan, Jeff Subject: [PATCH v2] MdeModulePkg/BDS: Fix a buffer overflow bug KeyOption points to a buffer h

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add missing JMP instruction

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Kinney, Michael D Sent: Friday, May 19, 2017 2:14 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Andrew Fish; Laszlo Ersek Subject: [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add missing JMP instruction

Re: [edk2] [RFC v4 01/13] UefiCpuPkg: Define AMD Memory Encryption specific CPUID and MSR

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Brijesh Singh [mailto:brijesh.si...@amd.com] Sent: Thursday, May 11, 2017 6:09 AM To: edk2-devel@lists.01.org Cc: thomas.lenda...@amd.com; leo.du...@amd.com; Brijesh Singh; Justen, Jordan L; Laszlo Ersek; Fan, Jef

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Don't report OutOfResource when MTRR is enough

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Ni, Ruiyu Sent: Friday, May 05, 2017 10:16 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [PATCH] UefiCpuPkg/MtrrLib: Don't report OutOfResource when MTRR is enough The MTRR calculation algorithm contains

Re: [edk2] [PATCH V2 0/4] Add SmmIoLib

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Monday, April 24, 2017 10:15 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH V2 0/4] Add SmmIoLib V2 Remove ASSERT

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Lock should be acquired

to the following code are using AcquireSpinLock() to check AP's BUSY state also. Thanks! Jeff -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, April 24, 2017 7:41 PM To: Fan, Jeff; edk2-devel@lists.01.org Cc: Wu, Hao A; Kinney, Michael D; Tian, Feng Subject: Re

Re: [edk2] [PATCH 2/4] MdePkg/SmmIoLib: Add sample instance.

h (0x%lx)\n", +BaseAddress, +Length +)); + ASSERT (FALSE); + return FALSE; +} Thank! Jeff -Original Message- From: Yao, Jiewen Sent: Friday, April 21, 2017 11:50 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Gao, Liming Subject: [PATCH 2/4] MdePk

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Avoid buggy USB short-form expanding

Reviewed-by: Jeff Fan <jeff@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Wednesday, April 19, 2017 5:17 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng <feng.t...

Re: [edk2] [PATCH 0/9] Export Dump CPU Context service

Jiewen, That's fine. If you consider the patch based on module for this case is better your review, I will combine some of them soon. Thanks! Jeff From: Yao, Jiewen Sent: Friday, April 07, 2017 8:41 AM To: Fan, Jeff; edk2-devel@lists.01.org Cc: Kinney, Michael D; Tian, Feng Subject: RE: [PATCH

Re: [edk2] [patch] UefiCpuPkg: Fix typos in UefiCpuPkg.dec

Reviewed-by: Jeff Fan <jeff@intel.com> Thanks! -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Thursday, April 06, 2017 8:53 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [edk2] [patch] UefiCpuPkg: Fix

Re: [edk2] Using Intel UDk debugger

-Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Arka Sharma Sent: Friday, March 31, 2017 2:53 PM To: Fan, Jeff Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Using Intel UDk debugger I have built my application with /Od and /Oy-, and GENFW_FLAGS

Re: [edk2] [PATCH 00/10] Use a better algorithm to calculate MTRR

Serials Reviewed-by: Jeff Fan <jeff@intel.com> Please updating the correct Copyright date when you push this serial of patches. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Wednesday, March 29, 2017 11:04 AM To: edk2

Re: [edk2] Using Intel UDk debugger

Sharma [mailto:arka.sw1...@gmail.com] Sent: Friday, March 31, 2017 11:23 AM To: Fan, Jeff Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Using Intel UDk debugger Thanks a lot Jeff. Setting FlowControl to 0 worked. Now I am able to break into the target system. Just wondering is it same

Re: [edk2] Using Intel UDk debugger

[mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Arka Sharma Sent: Friday, March 31, 2017 10:45 AM To: Fan, Jeff Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Using Intel UDk debugger After changing the putty settings I am getting this message "Send INIT break packet and try to connect the

Re: [edk2] Using Intel UDk debugger

INIT break packet and try to connect the HOST (Intel(R) UDK Debugger Tool v1.5)" Thanks! Jeff -Original Message- From: Arka Sharma [mailto:arka.sw1...@gmail.com] Sent: Friday, March 31, 2017 10:14 AM To: Fan, Jeff Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Using Intel UDk debugg

Re: [edk2] Using Intel UDk debugger

the correct serial port parameter on your platform. Thanks! Jeff -Original Message- From: Arka Sharma [mailto:arka.sw1...@gmail.com] Sent: Friday, March 31, 2017 9:40 AM To: Kinney, Michael D Cc: Fan, Jeff; edk2-devel@lists.01.org Subject: Re: [edk2] Using Intel UDk debugger Thanks a lot Mike

Re: [edk2] Using Intel UDk debugger

Arka, UDK Debugger tool supports your usage model. Please see the section "9.11 Debugging a standalone module loaded in a UEFI shell" @ https://firmware.intel.com/sites/default/files/UDK_Debugger_Tool_User_Manual_V1.11.pdf Thanks! Jeff -Original Message- From: edk2-devel

Re: [edk2] [PATCH] MdeModulePkg/SmmCore: Fix memory leak on Profile unregistered.

Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: Yao, Jiewen Sent: Monday, March 27, 2017 11:02 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Tian, Feng; Zeng, Star; Bret Barkelew Subject: [PATCH] MdeModulePkg/SmmCore: Fix memory leak on Profile unregistered.

Re: [edk2] [RFC PATCH v2 01/10] OvmfPkg/Include: Define SEV specific CPUID and MSR

/Register/Cpuid.h and remove old definitions. Thanks! Jeff From: Brijesh Singh [mailto:brijesh.ksi...@gmail.com] Sent: Monday, March 27, 2017 7:59 PM To: Fan, Jeff Cc: Laszlo Ersek; Kinney, Michael D; Justen, Jordan L; edk2-de...@ml01.01.org; Gao, Liming; leo.du...@amd.com; brijesh.si...@amd.com

  1   2   3   4   >