Re: [edk2] [PATCH v2 1/2] Maintainers: add TPM2 reviewers for OvmfPkg

2019-02-21 Thread Marc-André Lureau
ish > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Marc-André Lureau > Cc: Michael D Kinney > Cc: Stefan Berger > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > Reviewed-by: Leif Lindholm > Reviewed-by:

Re: [edk2] [Patch v2] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu

2019-02-11 Thread Marc-André Lureau
tribution Agreement 1.1 > Signed-off-by: Stefan Berger patch looks good (I have done minimal testing, though). Reviewed-by: Marc-André Lureau > --- > OvmfPkg/OvmfPkgIa32.dsc| 4 > OvmfPkg/OvmfPkgIa32.fdf| 3 +++ > OvmfPkg/OvmfPkgIa32X64.dsc | 4 > OvmfPkg/OvmfPk

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Marc-André Lureau
Hi On Tue, Oct 2, 2018 at 4:19 PM Laszlo Ersek wrote: > > On 10/02/18 14:10, Marc-André Lureau wrote: > > Hi > > > > On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek wrote: > >> > >> On 10/02/18 13:37, Marc-André Lureau wrote: > >>&

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Marc-André Lureau
Hi On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek wrote: > > On 10/02/18 13:37, Marc-André Lureau wrote: > > On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: > > >> Please fix your git settings for your local edk2 clone. Your patch > >> contains context line

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Marc-André Lureau
Hi On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: > > Hi Marc-André, > > On 10/02/18 10:36, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This is for conformance with the TCG "Platform Reset Attack Mitigation > > Specif

[edk2] TCG MOR and processor caches

2018-09-27 Thread Marc-André Lureau
ataCache? (or direct AsmWbinvd call) thanks -- Marc-André Lureau ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Missing boot related measurements at TPM 2.0 PCRs 0-7 with OVMF

2018-08-09 Thread Marc-André Lureau
it only when it no longer breaks OVMF. If the issue is not hard > to fix and we can commit the solution quickly, then I'll be fine with > leaving f15cb995bb38 applied. > > Thanks, > Laszlo > >> >> De: "Zhang, Chao B" mailto:chao.b.zh...@intel.com>&g

Re: [edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

2018-05-17 Thread Marc-André Lureau
Hi On Thu, May 17, 2018 at 9:54 AM, Laszlo Ersek <ler...@redhat.com> wrote: > On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> Hi, >> >> The following series adds basic TPM PPI 1.3 sup

Re: [edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

2018-05-17 Thread Marc-André Lureau
Hi On Wed, May 16, 2018 at 11:29 AM, Laszlo Ersek <ler...@redhat.com> wrote: > Hi Marc-André, > > On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> Hi, >> >> The following ser

Re: [edk2] [PATCH v3 0/7] ovmf: preliminary TPM2 support

2018-03-09 Thread Marc-André Lureau
Hi On Fri, Mar 9, 2018 at 2:09 PM, <marcandre.lur...@redhat.com> wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > Hi, > > The following series adds basic TPM2 support for OVMF-on-QEMU (I > haven't tested TPM1, for lack of interest). It links wit

Re: [edk2] [PATCH v2 2/8] SecurityPkg/Tcg2Pei: drop PeiReadOnlyVariable from Depex

2018-03-09 Thread Marc-André Lureau
Hi On Thu, Mar 8, 2018 at 1:36 AM, Zhang, Chao B <chao.b.zh...@intel.com> wrote: > Hi Lureau: >I think we can remove same dependency in TcgPei. > Thanks, feel free to explore that as a separate patch. This is out of scope to me. -- Ma

Re: [edk2] [PATCH v2 0/8] RFC: ovmf: preliminary TPM2 support

2018-03-08 Thread Marc-André Lureau
sh,format=raw,file=OVMF_CODE.fd,readonly -drive if=pflash,format=raw,file=OVMF_VARS.fd .. cheers -- Marc-André Lureau ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob

2018-03-07 Thread Marc-André Lureau
Hi On Wed, Mar 7, 2018 at 12:24 PM, <marcandre.lur...@redhat.com> wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > The ZeroMem() call goes beyond the HashInterfaceHob structure, causing > HOB list corruption. The intent was to clear all but the Identi

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

2018-03-07 Thread Marc-André Lureau
Hi On Wed, Mar 7, 2018 at 10:06 AM, Laszlo Ersek <ler...@redhat.com> wrote: > Hi Marc-André, > > On 03/06/18 21:27, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> The ZeroMem() call goes beyond the HashInte

Re: [edk2] [PATCH 5/7] ovmf: link with Tcg2Dxe module

2018-03-05 Thread Marc-André Lureau
Hi On Mon, Feb 26, 2018 at 10:50 AM, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> This module measures and log the boot environment. It also pro

Re: [edk2] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-03-05 Thread Marc-André Lureau
Hi On Fri, Feb 23, 2018 at 8:45 PM, Andrew Fish <af...@apple.com> wrote: > > >> On Feb 23, 2018, at 5:23 AM, marcandre.lur...@redhat.com wrote: >> >> From: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> Without this hack, GetNextHob()

Re: [edk2] [PATCH 4/7] ovmf: link with Tcg2Pei module

2018-03-01 Thread Marc-André Lureau
Hi On Mon, Feb 26, 2018 at 10:38 AM, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> This module will initialize TPM device, measure reported FVs and

Re: [edk2] [PATCH 2/7] ovmf: link with Tcg2ConfigPei module

2018-03-01 Thread Marc-André Lureau
Hi On Fri, Feb 23, 2018 at 6:31 PM, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> This module initializes TPM device type based on variable and >&

[edk2] Enabling TPM support in ovmf & hang during qemu boot

2017-11-12 Thread Marc-André Lureau
, looking for EFI_HOB_TYPE_UNUSED. How is the HobList populated? Is it possible to add more of the UNUSED entries? Any help welcome -- Marc-André Lureau commit 9e13683ae1351054bf14a087bfb89a14009b38e5 Author: Marc-André Lureau <marcandre.lur...@redhat.com> Date: Fri Nov 10 14:49:02 2017