[edk2] Bug 843 - Need to remove unnecessary return statements in void functions of EDKII.

[Mohammad Younas Khan Pathan]

Hi all,

I have updated the changes after removing all the unecessary return
statements in EDKII packages.

I have created EDKIIBug843 branch under master.
Also attached the changes here.

Please help to review and share your comments.

Thank you,
Younas khan.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Bug 868 - Need to add several functions related to date and time in BaseLib.

[Mohammad Younas Khan Pathan]

Hi All,

If there is any generic library function, then we do not need to have
2 or more definitions for same function like IsLeapYear().

Searching for 'isleapyear'
By Mask:
*.c
ArmPlatformPkg\Library\PL031RealTimeClockLib\PL031RealTimeClockLib.c(199)
:IsLeapYear (
ArmPlatformPkg\Library\PL031RealTimeClockLib\PL031RealTimeClockLib.c(227)
:  (Time->Month == 2 && (!IsLeapYear (Time) && Time->Day > 28))
EmbeddedPkg\Library\HalRuntimeServicesExampleLib\Rtc.c(134) :IsLeapYear (
EmbeddedPkg\Library\HalRuntimeServicesExampleLib\Rtc.c(163) :
(Time->Month == 2 && (!IsLeapYear (Time) && Time->Day > 28))
EmulatorPkg\RealTimeClockRuntimeDxe\RealTimeClock.c(33) :IsLeapYear (
EmulatorPkg\RealTimeClockRuntimeDxe\RealTimeClock.c(279) :
(Time->Month == 2 && (!IsLeapYear (Time) && Time->Day > 28))
EmulatorPkg\RealTimeClockRuntimeDxe\RealTimeClock.c(288) :IsLeapYear (
Nt32Pkg\RealTimeClockRuntimeDxe\RealTimeClock.c(37) :IsLeapYear (
Nt32Pkg\RealTimeClockRuntimeDxe\RealTimeClock.c(356) :
(Time->Month == 2 && (!IsLeapYear (Time) && Time->Day > 28))
Nt32Pkg\RealTimeClockRuntimeDxe\RealTimeClock.c(365) :IsLeapYear (
PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcRtc.c(1021) :
(Time->Month == 2 && (!IsLeapYear (Time) && Time->Day > 28))
PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcRtc.c(1038) :IsLeapYear (
PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcRtc.c(1178) :  if
((From->Month == 2) && !IsLeapYear(From)) {

Similarly for other functions, can we have the common functions used
for time in BaseLib or some common library?

Can we move them to BaseLib or any other common library?

Bug link:
https://bugzilla.tianocore.org/show_bug.cgi?id=868

Please provide your suggestions on the same.

Thank you,
Younas khan.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel