Re: [edk2] [patch 2/2] Vlv2TbltDevicePkg: Remove duplicated BSD license
Reviewed-by: Zailiang Sun > -Original Message- > From: Bi, Dandan > Sent: Monday, March 11, 2019 2:23 PM > To: edk2-devel@lists.01.org > Cc: Sun, Zailiang ; Qian, Yi ; > Kinney, Michael D ; Gao, Liming > > Subject: [patch 2/2] Vlv2TbltDevicePkg: Remove duplicated BSD license > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1612 > > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf > b/Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf > index 6e1496bcf5..32959d9bd5 100644 > --- a/Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf > +++ b/Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf > @@ -1,23 +1,15 @@ > ## @file > # Null instance of Debug Agent Library with empty functions. > # > # Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. > -# > > -# This program and the accompanying materials are licensed and made > available under > > -# the terms and conditions of the BSD License that accompanies this > distribution. > > -# The full text of the license may be found at > > -# http://opensource.org/licenses/bsd-license.php. > > -# > > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > > -# > > # > # This program and the accompanying materials # are licensed and made > available under the terms and conditions of the BSD License # which > accompanies this distribution. The full text of the license may be found at # > http://opensource.org/licenses/bsd-license.php > +# > # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, > EITHER EXPRESS OR IMPLIED. > # > # > > -- > 2.18.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch V2] edk2-platforms/devel-IntelAtomProcessorE3900: Enable tracehub
Reviewed-by: Zailiang Sun
-Original Message-
From: Wei, David
Sent: Saturday, February 02, 2019 12:55 PM
To: Qian, Yi ; edk2-devel@lists.01.org
Cc: Sun, Zailiang
Subject: RE: [Patch V2] edk2-platforms/devel-IntelAtomProcessorE3900: Enable
tracehub
Reviewed-by: David Wei
Regards,
David
Intel Firmware Development
-Original Message-
From: Qian, Yi
Sent: Saturday, February 2, 2019 12:51 PM
To: edk2-devel@lists.01.org
Cc: Qian, Yi ; Wei, David ; Sun,
Zailiang
Subject: [Patch V2] edk2-platforms/devel-IntelAtomProcessorE3900: Enable
tracehub
https://bugzilla.tianocore.org/show_bug.cgi?id=1508
Expose npk related setup options and convey right settings to fsp upd for
tracehub enabling.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yi Qian
CC: David Wei
CC: Zailiang Sun
---
Platform/BroxtonPlatformPkg/BuildBxtBios.bat
| 4 ++--
Platform/BroxtonPlatformPkg/Common/Include/Guid/SetupVariable.h
| 19 +++
Platform/BroxtonPlatformPkg/Common/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c
| 43 ++-
Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/DebugConfig.vfi
| 141
+
Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/VfrStrings.uni
| Bin 306466 -> 320330 bytes
5 files changed, 192 insertions(+), 15 deletions(-)
diff --git a/Platform/BroxtonPlatformPkg/BuildBxtBios.bat
b/Platform/BroxtonPlatformPkg/BuildBxtBios.bat
index 9bd71198e5..492eb1cd3c 100644
--- a/Platform/BroxtonPlatformPkg/BuildBxtBios.bat
+++ b/Platform/BroxtonPlatformPkg/BuildBxtBios.bat
@@ -523,7 +523,7 @@ if not exist "%STITCH_PATH%\FlashMap.h" (
call :FindVariableInFile _PCD_VALUE_PcdFlashNvStorageSize 3
NvStorageSize "%STITCH_PATH%\FlashMap.h"
:: Find image offset as opposed to memory offset
del /f /q temp.pcd >NUL 2>&1
-PowerShell ([uint32]$env:NvStorageBase - [uint32]$env:BaseAddress) >
temp.pcd
+PowerShell ([uint64]$env:NvStorageBase - [uint64]$env:BaseAddress)
+ > temp.pcd
set /p VpdOffset=NUL 2>&1
:: Force the variables we care about into DEC string format @@ -566,7
+566,7 @@ if not exist "%WORKSPACE%\%PLATFORM_PATH%\PlatformDsc\Defines.dsc" (
echo - BLD_IBBM_SIZE = %BldIbbmSize%
:: Find magic number
del /f /q temp.pcd >NUL 2>&1
-PowerShell ([uint32]$env:CarBaseAddress + [uint32]$env:BldRamDataSize +
[uint32]$env:FspRamDataSize + [uint32]$env:FspEmpDataSize +
[uint32]$env:BldIbbmSize) > temp.pcd
+PowerShell ([uint64]$env:CarBaseAddress +
+ [uint64]$env:BldRamDataSize + [uint64]$env:FspRamDataSize +
+ [uint64]$env:FspEmpDataSize + [uint64]$env:BldIbbmSize) > temp.pcd
set /p FspBaseAddress=NUL 2>&1
call :ForceToHex FspBaseAddress
diff --git a/Platform/BroxtonPlatformPkg/Common/Include/Guid/SetupVariable.h
b/Platform/BroxtonPlatformPkg/Common/Include/Guid/SetupVariable.h
index 2d81068778..de4c70d819 100644
--- a/Platform/BroxtonPlatformPkg/Common/Include/Guid/SetupVariable.h
+++ b/Platform/BroxtonPlatformPkg/Common/Include/Guid/SetupVariable.h
@@ -908,6 +908,25 @@ typedef struct {
UINT8 PkgCStateDemotion;
UINT8 PkgCStateUnDemotion;
+ //
+ // NPK debug Options
+ //
+ UINT8 NpkEn;
+ UINT8 FwTraceEn;
+ UINT8 FwTraceDestination;
+ UINT8 RecoverDump;
+ UINT32Msc0Size;
+ UINT8 Msc0Wrap;
+ UINT32Msc1Size;
+ UINT8 Msc1Wrap;
+ UINT8 PtiMode;
+ UINT8 PtiTraining;
+ UINT8 PtiSpeed;
+ UINT8 NpkDCIEn;
+ UINT8 PunitMlvl;
+ UINT8 PmcMlvl;
+ UINT8 SwTraceEn;
+
UINT8 ProcTraceMemSize;
UINT8 ProcTraceEnable;
UINT8 ProcTraceOutputScheme;
diff --git
a/Platform/BroxtonPlatformPkg/Common/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c
b/Platform/BroxtonPlatformPkg/Common/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c
index 2fb3bd9d3e..0863706645 100644
---
a/Platform/BroxtonPlatformPkg/Common/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c
+++ b/Platform/BroxtonPlatformPkg/Common/Library/PeiFspPolicyInitLib/Pei
+++ FspSaPolicyInitLib.c
@@ -155,19 +155,36 @@ PeiFspSaPolicyInitPreMem (
FspmUpd->FspmConfig.Igd = SystemConfiguration->Igd;
FspmUpd->FspmConfig.PrimaryVideoAdaptor =
SystemConfiguration->PrimaryVideoAdaptor;
-FspmUpd->FspmConfig.FwTraceEn = 1;
-FspmUpd->FspmConfig.FwTraceDestination = 4;
-FspmUpd->FspmConfig.RecoverDump= 0;
-FspmUpd->FspmConfig.Msc0Size = 0;
-FspmUpd->FspmConfig.Msc0Wrap = 1;
-FspmUpd->FspmCon
Re: [edk2] [PATCH 03/26] Vlv2TbltDevicePkg: assume GCC48 or later
Reviewed-by: Zailiang Sun
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, January 3, 2019 10:48 AM
> To: edk2-devel-01
> Cc: Sun, Zailiang ; Qian, Yi
> Subject: [PATCH 03/26] Vlv2TbltDevicePkg: assume GCC48 or later
>
> We're about to remove BaseTools support for GCC44..GCC47. Bump the
> assumption about the minimum gcc version to GCC48 in
> "Vlv2TbltDevicePkg/bld_vlv.sh".
>
> No GCC44..GCC47 references remain under Vlv2TbltDevicePkg after this
> patch.
>
> Cc: Zailiang Sun
> Cc: Yi Qian
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek
> ---
>
> Notes:
> Untested.
>
> Vlv2TbltDevicePkg/bld_vlv.sh | 14 +-
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/Vlv2TbltDevicePkg/bld_vlv.sh b/Vlv2TbltDevicePkg/bld_vlv.sh
> index 538b3ef9d730..51d3acacb48b 100755
> --- a/Vlv2TbltDevicePkg/bld_vlv.sh
> +++ b/Vlv2TbltDevicePkg/bld_vlv.sh
> @@ -179,23 +179,11 @@ sed -i '/^MAX_CONCURRENT_THREAD_NUMBER/d'
> Conf/target.txt
>
> gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}')
> case $gcc_version in
> -4.5.*)
> - TARGET_TOOLS=GCC45
> - ;;
> -4.6.*)
> - TARGET_TOOLS=GCC46
> - ;;
> -4.7.*)
> - TARGET_TOOLS=GCC47
> - ;;
> -4.8.*)
> - TARGET_TOOLS=GCC48
> - ;;
> 4.9.*|4.1[0-9].*|5.*.*|6.*.*)
>TARGET_TOOLS=GCC49
>;;
> *)
> - TARGET_TOOLS=GCC44
> + TARGET_TOOLS=GCC48
>;;
> esac
>
> --
> 2.19.1.3.g30247aa5d201
>
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch] Maintainers.txt: update Vlv2*Pkg maintainers.
Cc: David Wei Cc: Yi Qian Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zailiang Sun --- Maintainers.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index f3ead7c504..9a36f0232b 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -257,12 +257,12 @@ M: Ruiyu Ni R: Laszlo Ersek Vlv2DeviceRefCodePkg -M: David Wei -M: Mang Guo +M: Zailiang Sun +M: Yi Qian Vlv2TbltDevicePkg -M: David Wei -M: Mang Guo +M: Zailiang Sun +M: Yi Qian StandaloneMmPkg M: Achin Gupta -- 2.19.1.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] Changed Maintainers.txt
Thanks to Laszlo. I've subscribed the edk2-devel mail list and send the formatted patch again. Best Regards, Zailiang > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, November 13, 2018 10:27 PM > To: Wei, David ; Sun, Zailiang > ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] Changed Maintainers.txt > > On 11/13/18 02:41, Wei, David wrote: > > Reviewed-by: David Wei > > (1) The original patch never reached the list. Is Zailiang Sun perhaps > not subscribed? I think maintainership requires that the maintainer be > subscribed. > > (2) The subject line is a wreck. Zailiang, please resubmit the patch > with the following subject (or similar): > > Maintainers.txt: update Vlv2*Pkg maintainers > > (44 characters) > > One more comment below: > > > -Original Message- > > From: Sun, Zailiang > > Sent: Monday, November 12, 2018 1:05 PM > > To: edk2-devel@lists.01.org > > Cc: Sun, Zailiang ; Wei, David > > > Subject: [PATCH] Changed Maintainers.txt > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Zailiang Sun > > CC: David Wei > > --- > > Maintainers.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Maintainers.txt b/Maintainers.txt > > index b3048384c3..6ff80e76c2 100644 > > --- a/Maintainers.txt > > +++ b/Maintainers.txt > > @@ -3,8 +3,8 @@ MINNOWBOARD MAX/TURBOT PLATFORM Maintainers > > > > Vlv2DeviceRefCodePkg > >David Wei > > - Mang Guo > > + Zailiang Sun > > > > Vlv2TbltDevicePkg > >David Wei > > - Mang Guo > > + Zailiang Sun > > > > (3) I don't understand how this patch was formatted. The context doesn't > match at all: the lines don't start with "M:". Here's how > "Maintainers.txt" looks on my end, at commit da2c81ee96eb: > > - > Vlv2DeviceRefCodePkg > M: David Wei > M: Mang Guo > > Vlv2TbltDevicePkg > M: David Wei > M: Mang Guo > - > > Ahh! Wait a second. In the hunk header above, I see: > > MINNOWBOARD MAX/TURBOT PLATFORM > > That's totally not in the edk2 project. Is this patch perhaps for the > "edk2-platforms" tree? In that case: > > - the subject prefix should not be [PATCH], but [PATCH edk2-platforms] > > - I don't understand why edk2 and edk2-platforms *both* have > Vlv2DeviceRefCodePkg and Vlv2TbltDevicePkg directories! > > > Thanks > Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix the D1 stepping issue for Minnowboard Turbot
Since there are no ways to differentiate D0 and D1 stepping value by only
checking CPUID, we use string "D0/D1" for boards with a D0 or D1 stepping value.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun
CC: David Wei
---
.../SmBiosMiscDxe/MiscSystemManufacturerFunction.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
index 726e9b2426..10dbabe777 100644
--- a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
+++ b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
@@ -294,11 +294,11 @@ if (Event != NULL) {
DEBUG ((EFI_D_ERROR, "C0 Stepping Detected\n"));
break;
case PchD0:
- UnicodeSPrint (Buffer, sizeof (Buffer),L"%s%s", PlatformNameBuffer, L"D0
PLATFORM");
+ UnicodeSPrint (Buffer, sizeof (Buffer),L"%s%s", PlatformNameBuffer,
L"D0/D1 PLATFORM");
HiiSetString(mHiiHandle,STRING_TOKEN(STR_MISC_SYSTEM_PRODUCT_NAME),
Buffer, NULL);
- UnicodeSPrint (Buffer, sizeof (Buffer),L"%s",L"D0");
+ UnicodeSPrint (Buffer, sizeof (Buffer),L"%s",L"D0/D1");
HiiSetString(mHiiHandle,STRING_TOKEN(STR_MISC_SYSTEM_VERSION), Buffer,
NULL);
- DEBUG ((EFI_D_ERROR, "D0 Stepping Detected\n"));
+ DEBUG ((EFI_D_ERROR, "D0/D1 Stepping Detected\n"));
break;
default:
DEBUG ((EFI_D_ERROR, "Unknow Stepping Detected\n"));
--
2.19.1.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Change SMBIOS vendor name from "ADI" to "Silicom"
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun
CC: David Wei
---
.../SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c | 2 +-
.../SmBiosMiscDxe/MiscChassisManufacturerFunction.c | 2 +-
.../SmBiosMiscDxe/MiscSystemManufacturerFunction.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c
b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c
index b2c12fd5ec..63b3de7615 100644
--- a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c
+++ b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c
@@ -164,7 +164,7 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscBaseBoardManufacturer)
}
if (BOARD_ID_MINNOW2_TURBOT == mPlatformInfo->BoardId) {
-UnicodeSPrint (Buffer, sizeof (Buffer),L"ADI");
+UnicodeSPrint (Buffer, sizeof (Buffer),L"Silicom");
HiiSetString(mHiiHandle,STRING_TOKEN(STR_MISC_BASE_BOARD_MANUFACTURER),
Buffer, NULL);
}
TokenToGet = STRING_TOKEN (STR_MISC_BASE_BOARD_MANUFACTURER);
diff --git a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscChassisManufacturerFunction.c
b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscChassisManufacturerFunction.c
index 4981306bde..08baee9379 100644
--- a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscChassisManufacturerFunction.c
+++ b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscChassisManufacturerFunction.c
@@ -70,7 +70,7 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscChassisManufacturer)
}
if (BOARD_ID_MINNOW2_TURBOT == mPlatformInfo->BoardId) {
-UnicodeSPrint (Buffer, sizeof (Buffer),L"ADI");
+UnicodeSPrint (Buffer, sizeof (Buffer),L"Silicom");
HiiSetString(mHiiHandle,STRING_TOKEN(STR_MISC_CHASSIS_MANUFACTURER),
Buffer, NULL);
}
TokenToGet = STRING_TOKEN (STR_MISC_CHASSIS_MANUFACTURER);
diff --git a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
index 40a84a8fd0..726e9b2426 100644
--- a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
+++ b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
@@ -306,7 +306,7 @@ if (Event != NULL) {
}
if (BOARD_ID_MINNOW2_TURBOT == mPlatformInfo->BoardId) {
-UnicodeSPrint (Buffer, sizeof (Buffer),L"ADI");
+UnicodeSPrint (Buffer, sizeof (Buffer),L"Silicom");
HiiSetString(mHiiHandle,STRING_TOKEN(STR_MISC_SYSTEM_MANUFACTURER),
Buffer, NULL);
}
TokenToGet = STRING_TOKEN (STR_MISC_SYSTEM_MANUFACTURER);
--
2.19.1.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Maintainers.txt: update platform and silicon maintainers
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zailiang Sun CC: David Wei --- Maintainers.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 3bbf57212d..f665f9e7e1 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -2,9 +2,9 @@ MINNOWBOARD 3 PLATFORM Maintainers == Platform - David Wei - Mang Guo +M: Zailiang Sun +M: Yi Qian Silicon - David Wei - Mang Guo +M: Zailiang Sun +M: Yi Qian -- 2.19.1.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
