Re: [edk2] [Patch] Maintainers.txt: Update maintainers for MdeModulePkg

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, May 3, 2017 10:33 AM To: Dong, Eric <eric.d...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com

Re: [edk2] [PATCH] UefiCpuPkg: Move ProgramVirtualWireMode() to MpInitLib

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Fan, Jeff Sent: Friday, April 21, 2017 1:30 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [PATCH] UefiCpuPkg: Move Prog

Re: [edk2] [PATCH v2] UefiCpuPkg/MpLib.c: Set AP state after X2APIC mode enabled

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Fan, Jeff Sent: Tuesday, April 25, 2017 2:54 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [PATCH v2] UefiCpuPkg/MpL

Re: [edk2] [PATCH 0/2] Borrow the space below 1MB for AP reset vector

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Friday, April 21, 2017 2:04 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [PATCH 0/2] Borr

Re: [edk2] [PATCH 0/2] MdeModulePkg/Ufs: Wait fDeviceInit be cleared by devices during init

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Wu, Hao A Sent: Wednesday, March 22, 2017 9:28 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: [PATCH 0/2] MdeModulePkg/Ufs: Wait fDev

Re: [edk2] NvmExpressDxe async application crash with UDK debugger

Arka, Could you please share us your test code? Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Arka Sharma Sent: Wednesday, April 12, 2017 12:59 PM To: edk2-devel@lists.01.org Subject: [edk2] NvmExpressDxe async application crash

Re: [edk2] [PATCH v3 0/5] Fix undefined behavior in signed left shift

PS: lt's a typo on pkg name: IntelFWMdlPkg/IdeBusDxe: Fix undefined behavior in signed left shift -Original Message- From: Tian, Feng Sent: Wednesday, April 12, 2017 9:53 AM To: Wu, Hao A <hao.a...@intel.com>; edk2-devel@lists.01.org; guoh...@huawei.com Cc: Tian, Feng &

Re: [edk2] [PATCH v3 0/5] Fix undefined behavior in signed left shift

Series reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Wu, Hao A Sent: Wednesday, April 12, 2017 9:52 AM To: edk2-devel@lists.01.org; guoh...@huawei.com Cc: Wu, Hao A <hao.a...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: [PATCH v3

Re: [edk2] [PATCH 3/3] UefiCpuPkg: Error Level is not used correctly

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Fan, Jeff Sent: Monday, April 10, 2017 2:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [PATCH 3/3] UefiCpuPkg: Error Level is not

Re: [edk2] [PATCH 1/3] MdeModulePkg: Error Level is not used correctly

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Fan, Jeff Sent: Monday, April 10, 2017 2:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [PATCH 1/3] MdeModulePkg: Error Level is not used correctly Cc: Feng Tian <feng

Re: [edk2] Using USB-Ethernet adapter in UEFI on an arm64 platform

driver for use. Thanks Feng -Original Message- From: Vladimir Olovyannikov [mailto:vladimir.olovyanni...@broadcom.com] Sent: Tuesday, April 11, 2017 12:14 AM To: Tian, Feng <feng.t...@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] Using USB-Ethernet adapter in UEFI on an

Re: [edk2] [PATCH v2] MdeModulePkg/ScsiDiskDxe: Fix undefined behavior in signed left shift

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Wu, Hao A Sent: Tuesday, April 11, 2017 9:30 AM To: edk2-devel@lists.01.org; ler...@redhat.com; guoh...@huawei.com Cc: Wu, Hao A <hao.a...@intel.com>; Tian, Feng <feng.t...@intel.com>

Re: [edk2] Using USB-Ethernet adapter in UEFI on an arm64 platform

Hi, Vladimir, Which usb2lan driver you are using for AX88772 adpater? The one in OptionRomPkg\Bus\Usb\UsbNetworking has bug on the polling performance. The one in OptionRomPkg\Bus\Usb\UsbNetworking\Ax88772b is better but if there is no data received, the polling operation still wastes some

Re: [edk2] NvmExpressDxe TimerEvent frequency

Yes. For example, old platforms usually use 50ms as timer interval. So at such platforms, even the code is programming to use 1 ms timer, the actual trigger time interval is 50ms. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] [PATCH] UefiCpuPkg/CpuFeatures: Change CPU features name to follow IA32 SDM

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Thursday, April 6, 2017 1:47 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Enhance short-form expanding logic

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Thursday, April 6, 2017 5:45 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Dong, Eric <eric.d...@intel.com>; Fan, Jeff <jeff@intel

Re: [edk2] [PATCH] UefiCpuPkg/MpLib.c: Load microcode before mtrr sync per IA32 SDM

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Wednesday, April 5, 2017 11:07 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng &l

Re: [edk2] DisconnectController API not working.

Kumar, Do "map -r" at first please. PS: for the issue you encounter, are you trying to disconnect the usb controller in use? Please note at this time you are reading the file from usb key. It means the disconnect will never succeed. Thanks Feng -Original Message- From: edk2-devel

Re: [edk2] [Patch] MdeModulePkg: Remove unsupported PcdExpression usage in module INF

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Gao, Liming Sent: Friday, March 31, 2017 1:04 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [Patch] MdeModulePkg:

Re: [edk2] [PATCH 1/2] MdeModulePkg/Tcp4Dxe: Fix unconditional window shrinking

Adding network module owners for further review. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of ate...@kraftway.ru Sent: Tuesday, March 28, 2017 3:20 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 1/2] MdeModulePkg/Tcp4Dxe:

Re: [edk2] [patch 1/2] MdeModulePkg/MemoryProtection: Fix coding style issue

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Bi, Dandan Sent: Tuesday, March 28, 2017 9:02 AM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Tian, Feng <feng.t...@intel.com> Subject: [patch

Re: [edk2] [PATCH v2] UefiCpuPkg/MpLib.c: Add checking CR0 PG bit

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Tuesday, March 28, 2017 8:57 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [PATCH v2] UefiC

Re: [edk2] [PATCH 0/2] [UefiCpuPkg] Support 64bit MMIO address in CPU Register Table

Series Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan, Jeff Sent: Thursday, March 23, 2017 1:28 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] [UefiCpuPkg] Support 64bit

Re: [edk2] [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Add ASSERT on allocated memory

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan, Jeff Sent: Thursday, March 23, 2017 3:21 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>

Re: [edk2] [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues.

Series Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, March 27, 2017 11:02 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [PATC

Re: [edk2] [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Set CpuFeatureEntry initial value

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Fan, Jeff Sent: Thursday, March 23, 2017 9:45 AM To: edk2-de...@ml01.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [PATCH] UefiCpuPkg/RegisterC

Re: [edk2] [PATCH] UefiCpuPkg/CpuCommonFeaturesLib: Fix case write issue

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Fan, Jeff Sent: Thursday, March 23, 2017 9:16 AM To: edk2-de...@ml01.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [PATCH] UefiCpuPkg/CpuComm

Re: [edk2] [PATCH v5 00/11] Add CPU features driver

Series Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, March 20, 2017 4:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [PATCH

Re: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages

Ok to me as well. Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Zeng, Star Sent: Monday, March 20, 2017 10:16 AM To: Laszlo Ersek <ler...@redhat.com>; edk2-devel-01 <edk2-devel@lists.01.org> Cc: Ard Biesheuvel <ard.biesheu...@li

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Remove MSR_IA32_MISC_ENABLE check

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Wednesday, March 15, 2017 9:55 AM To: edk2-devel@lists.01.org Cc: Anthony PERARD <anthony.per...@citrix.com>

Re: [edk2] [PATCH] MdeModulePkg/LogoDxe: Add missing dependency gEfiHiiImageExProtocolGuid

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, March 16, 2017 2:05 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Dong,

Re: [edk2] [PATCH] Nt32Pkg: Use Shell source code directly

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Thursday, March 16, 2017 1:58 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [PATCH] Nt32Pkg: Use Shell source code directly Contributed-unde

Re: [edk2] Testing NVMe async commands

Hi, Sharma As far as I know, we have UEFI SCT test suite to cover NVME_PASS_THRU async test. But it's not complex as your case. As you have sent 210720 cmds, it's more like memory leak issue. Could you please only send 1 cmds and compare the memory map change before and after? If there is

Re: [edk2] [PATCH 3/3] MdeModulePkg BmPerf: Handle "/" separator in debug path for GCC build

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, March 15, 2017 1:51 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Gao, Liming <liming@intel.com>; Ni, Ruiyu <ruiyu...@intel.com

Re: [edk2] [PATCH 0/3] Add Context in SmiHandlerProfileUnregister.

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, March 13, 2017 10:06 AM To: Yao, Jiewen <jiewen@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Generate boot description for NVME

Behalf Of > Wang, Sunny (HPS SW) > Sent: Friday, March 10, 2017 6:11 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Haskell, Darrell > <darrell.hask...@hpe.com> > Subject: Re: [edk2] [PATCH] MdeModulePk

Re: [edk2] [PATCH v3 02/12] MdeModulePkg: Refine casting expression result to bigger size

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Wu, Hao A Sent: Saturday, February 25, 2017 1:12 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com&g

Re: [edk2] [PATCH v3 1/6] MdeModulePkg: Refine type cast for pointer subtraction

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Wu, Hao A Sent: Saturday, February 25, 2017 12:05 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com&

Re: [edk2] [Patch] MdeModulePkg: use LShiftU64() instead of "<<" to avoid IA32 build error.

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, March 1, 2017 12:13 PM To: Fu, Siyuan <siyuan...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Ard Biesheuvel <ard.biesheu

Re: [edk2] [PATCH v3 1/6] MdeModulePkg: Add DxeBmDmaLib (BmDmaLib class) library

A minor comment: > + LIBRARY_CLASS = BmDmaLib|DXE_DRIVER Shouldn't this lib support UEFI driver? Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Wednesday, March 1, 2017 10:39 AM To: Leo Duran <leo.du...@amd.com>; edk2-de...@ml01.01.org Cc: Tian, Fen

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Remove used SetCacheability()

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, February 27, 2017 1:31 PM To: edk2-devel@lists.01.org Cc: Leo Duran <leo.du...@amd.com>; Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin.

Re: [edk2] Should Path Name in File Path Media Device Path node be NULL terminated?

UEFI spec clearly say: "Path Name" is A NULL-terminated Path string including directory and file names. The length of this string n can be determined by subtracting 4 from the Length entry. A device path may contain one or more of these nodes. Each node can optionally add a "\" separator to the

Re: [edk2] [PATCH v3 2/7] MdePkg IndustryStandard/Scsi.h: Add sense code macro

Linton, Could you let me know where the +#define EFI_SCSI_REQUEST_SENSE_ERROR (0x70) comes from? According to SCSI SPC5r08 spec, the first byte of sense data is the RESPONSE CODE field. And 0x70 means a) the result of an error, exception condition, or protocol specific failure that is

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Friday, February 24, 2017 2:12 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek <ler...@redhat.com>; Zeng, Star <star.z...@intel.com>; Tian, Feng <feng.t...@intel.co

Re: [edk2] [PATCH] MdeModulePkg SmmSmiHandlerProfileLib: Fix GCC build failure

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Zeng, Star Sent: Friday, February 24, 2017 9:56 AM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Tian, Feng <feng.t...@intel.com>; Yao, Jiewen <jiewen@intel

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Replace EFI_D_xxx with DEBUG_xxx in DEBUG()

Reviewed-by: Feng Tian<feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Wednesday, February 22, 2017 3:56 PM To: edk2-de...@ml01.01.org Cc: Laszlo Ersek <ler...@redhat.com>; Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <micha

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix hard code actual TimerPeriod value

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Fan, Jeff Sent: Monday, February 20, 2017 4:38 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [PATCH] UefiCpuPkg/Cpu

Re: [edk2] [PATCH] MdeModulePkg/SdMmc: Avoid assigning 0 to the BlockSize of Trb

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Wu, Hao A Sent: Monday, February 20, 2017 11:06 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: [PATCH] MdeModulePkg/SdMmc:

Re: [edk2] [PATCH v2] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, February 9, 2017 3:05 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng,

Re: [edk2] [PATCH v2 1/6] MdeModulePkg/PciSioSerialDxe: Use MAX_UINT8 instead of PCI_BAR_ALL

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, February 6, 2017 2:01 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [PATCH v2 1/6] MdeModulePkg/PciSioSerialDxe: Use MAX_UINT8 instead of

Re: [edk2] [PATCH] Fix some typos of "according"

MdeModulePkg reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, February 8, 2017 9:45 AM To: Rebecca Cran <rebe...@bluestop.org>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Fu, Siyuan <siy

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/PciBus: Accept Spec values as BarIndex and Alignment

2/3/4 looks good to me Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, February 6, 2017 2:01 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff <jeff@intel.com>; Tian, Feng <feng.t...@intel.com> Subj

Re: [edk2] [PATCH 3/3] MdeModulePkg/DxeCore: Add UEFI image protection.

Jiewen, So where will you add such limitation statements? In this commit log or other places? Thanks Feng From: Gao, Liming Sent: Saturday, February 4, 2017 11:40 AM To: Yao, Jiewen <jiewen@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>

Re: [edk2] [PATCH 1/2] MdeModulePkg/AcpiTableDxe: condense whitespace around FADT.{DSDT, X_DSDT}

biesheu...@linaro.org>; Tian, Feng <feng.t...@intel.com>; Igor Mammedov <imamm...@redhat.com>; Leo Duran <leo.du...@amd.com>; Michael Tsirkin <mtsir...@redhat.com>; Phil Dennis-Jordan <p...@philjordan.eu>; Zeng, Star <star.z...@intel.com> Subject: [PATCH 1/2] MdeMo

Re: [edk2] [Patch] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Gao, Liming Sent: Friday, February 3, 2017 9:35 AM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: [Patch] MdeModulePk

Re: [edk2] [PATCH 2/3] MdeModulePkg: Update PcdSmbiosDocRev to 0x1 for SMBIOS spec 3.1.1

reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Zeng, Star Sent: Sunday, January 22, 2017 4:18 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Tian, Feng <feng.t...@intel.com>; Gao, Liming <liming@intel.com

Re: [edk2] [PATCH 1/3] MdeModulePkg/FrameBufferBltLib: Refine ConfigurePixelBitMaskFormat

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, January 23, 2017 2:12 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [PATCH 1/3] MdeModulePkg/FrameBufferBltLib: Refine ConfigurePixelB

Re: [edk2] [PATCH 2/3] MdeModulePkg/FrameBufferBltLib: Use dynamic allocated line buffer

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, January 23, 2017 2:12 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [PATCH 2/3] MdeModulePkg/FrameBufferBltLib: Use dynamic allocated

Re: [edk2] [PATCH 0/7] Make the event empty function in UefiLib public

2-de...@ml01.01.org>; Kinney, Michael D <michael.d.kin...@intel.com>; Fan, Jeff <jeff@intel.com>; Tian, Feng <feng.t...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Ma, Maurice <maurice...@intel.com>; Agyeman, Prince <prince.agye...@intel.com>; Steele, Kell

Re: [edk2] Why is USB_BOOT_IO_BLOCKS set to 128?

the device model/serial no, then we can modify this value accordingly. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Wednesday, January 18, 2017 2:41 PM To: Tian, Feng <feng.t...@intel.com>; edk2-devel@lists.01.

Re: [edk2] [PATCH 0/3] Add SMBIOS spec 3.1.0 support

l D <michael.d.kin...@intel.com>; Tian, Feng <feng.t...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> Subject: [PATCH 0/3] Add SMBIOS spec 3.1.0 support REF: https://bugzilla.tianocore.org/show_bug.cgi?id=340 T

Re: [edk2] [PATCH v2 5/5] MdeModulePkg/UfsBlockIoPei: fix initialize OCS value to 0x0F

.lindh...@linaro.org] Sent: Tuesday, January 17, 2017 12:03 AM To: Haojian Zhuang <haojian.zhu...@linaro.org> Cc: Tian, Feng <feng.t...@intel.com>; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Subject: Re: [PATCH v2 5/5] MdeModulePkg/UfsBlockIoPei: fix initialize OCS value to 0x0F On Mon,

Re: [edk2] [PATCH 1/8] MdeModulePkg/TerminalDxe: Replace macro with enum for terminal types

Series reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Tuesday, January 10, 2017 4:39 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: [PATCH 1/8] MdeMod

Re: [edk2] [PATCH] MdeModulePkg/Stall: Refine to compare 2 values with the same type

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Wu, Hao A Sent: Friday, January 6, 2017 4:52 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.co

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

To: Tian, Feng <feng.t...@intel.com>; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register Hi Feng, What’s the commit number of the old EDKII UFS dri

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of haojian.zhu...@linaro.org Sent: Tuesday, January 10, 2017 2:09 PM To: Tian, Feng <feng.t...@intel.com>; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@

Re: [edk2] [Patch] MdeModulePkg/DxeCore: Fix ASSERT() from GCD DEBUG() messages

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Zeng, Star Sent: Monday, January 9, 2017 1:06 PM To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: RE: [Patch] Md

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

this, your fix also disobeys the UFS spec, which requests the UTRLBA is 1KB align. [cid:image003.jpg@01D26A5A.4655E180] Thanks Feng From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org] Sent: Friday, January 6, 2017 5:06 PM To: Tian, Feng <feng.t...@intel.com>; leif.lindh...@lina

Re: [edk2] [PATCH 6/9] Ufs: add PhyInit

Yes, I am thinking moving UFS HC enable to lower layer, this way should be able to eliminate interface change... Thanks Feng -Original Message- From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org] Sent: Friday, January 6, 2017 4:22 PM To: Tian, Feng <feng.t...@intel.com&

Re: [edk2] [PATCH 8/9] Ufs: fix to add cache operation

: Friday, January 6, 2017 2:52 PM To: Tian, Feng <feng.t...@intel.com>; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Haojian Zhuang <haojian.zhu...@linaro.org> Subject: [PATCH 8/9] Ufs: fix to add cache operation Since command UPIU is initialized

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

Hi, Haojian If the UTRLBA & UTRLBAU gets changed like below, the doorbell location also should be updated. So I don't suggest to update them. Thanks Feng -Original Message- From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org] Sent: Friday, January 6, 2017 2:52 PM To: Tian,

Re: [edk2] [PATCH 9/9] ScsiDisk: retry if device detected power failure

To: Tian, Feng <feng.t...@intel.com>; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Haojian Zhuang <haojian.zhu...@linaro.org> Subject: [PATCH 9/9] ScsiDisk: retry if device detected power failure If device detected power failure, just retry. This operati

Re: [edk2] [PATCH 6/9] Ufs: add PhyInit

Could this be done at lower layer rather than changing existing interface? Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Haojian Zhuang Sent: Friday, January 6, 2017 2:52 PM To: Tian, Feng <feng.t...@intel.com>; leif

Re: [edk2] [PATCH 7/9] Ufs: fix initialize OCS value to 0x0F

Same with previous patches, could you please fix Ufs PEI driver as well? Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Haojian Zhuang Sent: Friday, January 6, 2017 2:52 PM To

Re: [edk2] [PATCH 3/9] Ufs: fix the bit in UFS_HC_UTRLDBR_OFFSET register

@lists.01.org] On Behalf Of Haojian Zhuang Sent: Friday, January 6, 2017 2:52 PM To: Tian, Feng <feng.t...@intel.com>; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Haojian Zhuang <haojian.zhu...@linaro.org> Subject: [edk2] [PATCH 3/9

Re: [edk2] [PATCH 2/9] Ufs: fix to identify 32 bits address mode

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Haojian Zhuang Sent: Friday, January 6, 2017 2:52 PM To: Tian, Feng <feng.t...@intel.com>; leif.lindh...@linaro.org;

Re: [edk2] [PATCH 1/9] Ufs: fix data direction checking

6, 2017 2:52 PM To: Tian, Feng <feng.t...@intel.com>; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Haojian Zhuang <haojian.zhu...@linaro.org> Subject: [edk2] [PATCH 1/9] Ufs: fix data direction checking BIT6 is used in read operation, and BIT5 i

Re: [edk2] [patch] MdeModulePkg/StaControllerDxe: Fix coding style issue

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Bi, Dandan Sent: Thursday, January 5, 2017 1:22 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [patch] MdeModulePkg/StaControllerDxe: Fix coding style issue Remo

Re: [edk2] [PATCH 0/6] Support source debugging on DXE AP function

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, December 26, 2016 7:21 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney; Kinney, Michael D <michael.d.kin...@intel.com>; Ni, Ruiyu &

Re: [edk2] [PATCH 0/2] Handle NULL capsule name in record.

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Thursday, December 22, 2016 1:48 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] Handle NULL capsule name in

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check.

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Thursday, December 22, 2016 11:45 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng,

Re: [edk2] [patch 7/8] MdeModulePkg/SataControllerDxe: Fix coding style issue

Monday, December 19, 2016 3:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [patch 7/8] MdeModulePkg/SataControllerDxe: Fix coding style issue Cc: Feng Tian <feng.t...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi &l

Re: [edk2] [patch 6/8] MdeModulePkg/TerminalDxe: Initialize variable after declaration

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Bi, Dandan Sent: Monday, December 19, 2016 3:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [patch 6/8] MdeModulePkg/TerminalDxe: Initialize variable after dec

Re: [edk2] [patch] MdeModulePkg: Fix assert in iSCSI.

Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Thursday, December 1, 2016 2:59 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu,

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Always initialze PSD

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Kinney, Michael D Sent: Tuesday, December 6, 2016 11:57 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Fan, Jeff <jeff....@intel.com>; Tian, Feng <feng.t.

Re: [edk2] [PATCH] MdeModulePkg/CapsuleApp: add Internal for function name.

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Yao, Jiewen Sent: Thursday, December 1, 2016 4:51 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Fan, Jeff <jeff@intel.com> Subject: [PATCH] MdeModulePkg/Capsul

Re: [edk2] [PATCH 0/3] mReservedVectors is not set

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Wednesday, November 30, 2016 3:23 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/3] mReservedVectors is not set

Re: [edk2] [Patch 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: Reduce use of PSD

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Thursday, December 1, 2016 12:58 PM To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen....@intel.com>; Tian, Feng &l

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 30, 2016 4:48 PM To: Fan, Jeff <jeff@intel.com>; edk2-de...@ml01.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.c

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Replace deprecated debug level macros

Reviewed-by: Feng Tian <feng.t...@intel.com> I will help push it into EDKII trunk. Thanks Feng -Original Message- From: Marcin Wojtas [mailto:m...@semihalf.com] Sent: Tuesday, November 29, 2016 9:52 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinne

Re: [edk2] [PATCH v2] MdeModulePkg/AtaAtapiPassThru: Ensure GHC.AE bit is always set in Ahci

Reviewed-by: Feng Tian <feng.t...@intel.com> Do you want me to push it into EDKII trunk? Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marcin Wojtas Sent: Thursday, November 24, 2016 3:55 PM To: edk2-devel@lists.01.org Cc

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: Set GHC.AE bit unconditionally for Ahci

To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Gao, Liming <liming@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: Set GHC.AE bit uncond

Re: [edk2] [PATCH v3 1/5] MdeModulePkg: introduce non-discoverable device protocol

nks Feng -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, November 18, 2016 2:57 PM To: Tian, Feng <feng.t...@intel.com> Cc: Ni, Ruiyu <ruiyu...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org;

Re: [edk2] [PATCH v3 1/5] MdeModulePkg: introduce non-discoverable device protocol

Ard, I have another question. Is it the only way to specify device type in below enum? Looks like it will be changed often. Is it possible to make use of DevicePath node? Of course, I have no good idea to handle AMBA controller... +// +// Data Types +// +typedef enum { +

Re: [edk2] [PATCH 0/6] UefiCpuPkg/MpInitLib: Program AP stack in fixed address

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, November 14, 2016 11:47 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Kinney, Michael D <michael.d.kin.

Re: [edk2] USB hub port reset

To: Tian, Feng <feng.t...@intel.com>; edk2-devel@lists.01.org Subject: Re: [edk2] USB hub port reset Feng, Below change solves the problem with a device behind the hub. Do we still need the 10ms delay in UsbHubResetPort function for manual port reset in case of XHCI? Thanks, B

Re: [edk2] [PATCH] UefiCpuPkg/SecCore: Use %x to print stack information

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Tuesday, November 15, 2016 4:32 PM To: edk2-de...@ml01.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [PATCH] UefiC

Re: [edk2] USB hub port reset

zeof (INPUT_CONTEXT_64)); CmdTrbAddr.PtrLo= XHC_LOW_32BIT (PhyAddr); Could you please have a try to see if it solves your problem? Thanks Feng -Original Message- From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Monday, November 14, 2016 9:46 PM To: Tian, Feng <feng.t...

Re: [edk2] USB hub port reset

n 9.4 respectively) after the reset recovery time 10 ms (TRSTRCY) after the reset is removed." Thanks Feng -Original Message- From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Monday, November 14, 2016 11:33 AM To: Tian, Feng <feng.t...@intel.com>; edk2-devel@list

Re: [edk2] USB hub port reset

Hi, Baranee Linux wait 10 + 40 ms (TRSTRCY = 10 ms, plus extra 40 ms). Do you mean EDKII should be same with linux to wait more time? Thanks Feng From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Sunday, November 13, 2016 11:53 AM To: edk2-devel@lists.01.org; Tian, Feng <fen

  1   2   3   4   >