To: edk2-devel@lists.01.org
> > Cc: Hao Wu <hao.a...@intel.com>; Michael D Kinney
> > <michael.d.kin...@intel.com>; Jiewen Yao <jiewen@intel.com>; Star
> Zeng
> > <star.z...@intel.com>
> > Subject: [edk2] [PATCH] MdeModulePkg/DxeCore: Add co
Mike,
Thanks for the feedbacks. I will refine the commit message and code
comments according to your suggestions.
Best Regards,
Hao Wu
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, September 29, 2017 12:49 AM
> To: Wu, Hao A; edk2-devel@lists.01.org; Kinney, Michael D
Hao Wu,
The comment block clearly describes that the condition is not
possible, so we would never expect this ASSERT() condition to
ever be triggered. Looking at the comment in this patch and
the ASSERT() statement, a developer in the future may be tempted
to remove this comment and ASSERT()
intel.com>; Jiewen Yao <jiewen@intel.com>; Star Zeng
> <star.z...@intel.com>
> Subject: [edk2] [PATCH] MdeModulePkg/DxeCore: Add comments for the
> ASSERT to check NULL ptr
>
> Commit 8932679df5be046feba30fae80776c5815232a08 adds an ASSERT for
> checking NULL
Commit 8932679df5be046feba30fae80776c5815232a08 adds an ASSERT for
checking NULL pointer dereference.
This commit adds comments to clarify the reason for using ASSERT as the
check.
Cc: Star Zeng
Cc: Michael D Kinney
Cc: Jiewen Yao
5 matches
Mail list logo