Re: [edk2] [PATCH v2 1/2] ShellPkg: force use of AARCH64 small model when building DEBUG shell
On 19 August 2015 at 19:03, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > Thanks. Series committed as SVN r18241 .. r18242 >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Ard Biesheuvel >> Sent: Wednesday, August 19, 2015 2:48 AM >> To: edk2-devel@lists.01.org; leif.lindh...@linaro.org >> Cc: Carsey, Jaben ; Qiu, Shumin >> ; ler...@redhat.com; Ard Biesheuvel >> >> Subject: [edk2] [PATCH v2 1/2] ShellPkg: force use of AARCH64 small model >> when building DEBUG shell >> Importance: High >> >> The tiny code model used by AARCH64 only supports binaries of up to >> 1 MB in size. Since the Shell application exceeds that when built in >> DEBUG mode, make sure we build it using the small code model instead. >> >> Cc: Jaben Carsey , >> Cc: Shumin Qiu >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel >> Reviewed-by: Leif Lindholm >> Tested-by: Leif Lindholm >> --- >> ShellPkg/Application/Shell/Shell.inf | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/ShellPkg/Application/Shell/Shell.inf >> b/ShellPkg/Application/Shell/Shell.inf >> index f7039369227c..09aecf717bd7 100644 >> --- a/ShellPkg/Application/Shell/Shell.inf >> +++ b/ShellPkg/Application/Shell/Shell.inf >> @@ -108,3 +108,9 @@ [Pcd] >>gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole ## CONSUMES >>gEfiShellPkgTokenSpaceGuid.PcdShellSupplier ## CONSUMES >> >> +[BuildOptions.AARCH64] >> + # The tiny code model used by AARCH64 only supports binaries of up to 1 >> MB in >> + # size. Since the Shell application exceeds that when built in DEBUG mode, >> + # make sure we build it using the small code model instead. >> + GCC:DEBUG_*_*_CC_FLAGS = -mcmodel=small >> + GCC:DEBUG_*_*_DLINK_FLAGS = -z common-page-size=0x1000 >> -- >> 1.9.1 >> >> ___ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2 1/2] ShellPkg: force use of AARCH64 small model when building DEBUG shell
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Wednesday, August 19, 2015 2:48 AM > To: edk2-devel@lists.01.org; leif.lindh...@linaro.org > Cc: Carsey, Jaben ; Qiu, Shumin > ; ler...@redhat.com; Ard Biesheuvel > > Subject: [edk2] [PATCH v2 1/2] ShellPkg: force use of AARCH64 small model > when building DEBUG shell > Importance: High > > The tiny code model used by AARCH64 only supports binaries of up to > 1 MB in size. Since the Shell application exceeds that when built in > DEBUG mode, make sure we build it using the small code model instead. > > Cc: Jaben Carsey , > Cc: Shumin Qiu > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > Reviewed-by: Leif Lindholm > Tested-by: Leif Lindholm > --- > ShellPkg/Application/Shell/Shell.inf | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/ShellPkg/Application/Shell/Shell.inf > b/ShellPkg/Application/Shell/Shell.inf > index f7039369227c..09aecf717bd7 100644 > --- a/ShellPkg/Application/Shell/Shell.inf > +++ b/ShellPkg/Application/Shell/Shell.inf > @@ -108,3 +108,9 @@ [Pcd] >gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole ## CONSUMES >gEfiShellPkgTokenSpaceGuid.PcdShellSupplier ## CONSUMES > > +[BuildOptions.AARCH64] > + # The tiny code model used by AARCH64 only supports binaries of up to 1 > MB in > + # size. Since the Shell application exceeds that when built in DEBUG mode, > + # make sure we build it using the small code model instead. > + GCC:DEBUG_*_*_CC_FLAGS = -mcmodel=small > + GCC:DEBUG_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > -- > 1.9.1 > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH v2 1/2] ShellPkg: force use of AARCH64 small model when building DEBUG shell
The tiny code model used by AARCH64 only supports binaries of up to 1 MB in size. Since the Shell application exceeds that when built in DEBUG mode, make sure we build it using the small code model instead. Cc: Jaben Carsey , Cc: Shumin Qiu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Tested-by: Leif Lindholm --- ShellPkg/Application/Shell/Shell.inf | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ShellPkg/Application/Shell/Shell.inf b/ShellPkg/Application/Shell/Shell.inf index f7039369227c..09aecf717bd7 100644 --- a/ShellPkg/Application/Shell/Shell.inf +++ b/ShellPkg/Application/Shell/Shell.inf @@ -108,3 +108,9 @@ [Pcd] gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole ## CONSUMES gEfiShellPkgTokenSpaceGuid.PcdShellSupplier ## CONSUMES +[BuildOptions.AARCH64] + # The tiny code model used by AARCH64 only supports binaries of up to 1 MB in + # size. Since the Shell application exceeds that when built in DEBUG mode, + # make sure we build it using the small code model instead. + GCC:DEBUG_*_*_CC_FLAGS = -mcmodel=small + GCC:DEBUG_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -- 1.9.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
