Re: [edk2] [Patch 0/2] Use correct field name.

2019-01-13 Thread Zeng, Star 
Agree with Laszlo's comments to those two patches.

Reviewed-by: Star Zeng 

Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo 
Ersek
Sent: Friday, January 11, 2019 6:45 PM
To: Dong, Eric ; edk2-devel@lists.01.org
Cc: Ni, Ray ; Aleksiy 
Subject: Re: [edk2] [Patch 0/2] Use correct field name.

On 01/11/19 06:46, Eric Dong wrote:
> ((Facs->Flags & EFI_ACPI_4_0_OSPM_64BIT_WAKE__F) != 0))
> 
> In above code, Facs->OspmFlags should be used instead.
> EFI_ACPI_4_0_OSPM_64BIT_WAKE__F is a bit in OSPM Enabled Firmware 
> Control Structure Flags field, not in Firmware Control Structure 
> Feature Flags.
> 
> Update all related code to use correct field name.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1430
> 
> Cc: Aleksiy 
> Cc: Ray Ni 
> Cc: Laszlo Ersek 
> Cc: Jian Wang 
> Eric Dong (2):
>   UefiCpuPkg/S3Resume2Pei: Use correct field name.
>   MdeModulePkg/BootScriptExecuteorDxe: Use correct field name.
> 
>  MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/ScriptExecute.c   | 4 ++--
>  MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/X64/SetIdtEntry.c | 4 ++--
>  UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c   | 6 
> +++---
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 

Regression-tested-by: Laszlo Ersek  
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch 0/2] Use correct field name.

2019-01-11 Thread Laszlo Ersek 
On 01/11/19 06:46, Eric Dong wrote:
> ((Facs->Flags & EFI_ACPI_4_0_OSPM_64BIT_WAKE__F) != 0))
> 
> In above code, Facs->OspmFlags should be used instead.
> EFI_ACPI_4_0_OSPM_64BIT_WAKE__F is a bit in OSPM Enabled Firmware
> Control Structure Flags field, not in Firmware Control Structure
> Feature Flags.
> 
> Update all related code to use correct field name.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1430
> 
> Cc: Aleksiy 
> Cc: Ray Ni 
> Cc: Laszlo Ersek 
> Cc: Jian Wang 
> Eric Dong (2):
>   UefiCpuPkg/S3Resume2Pei: Use correct field name.
>   MdeModulePkg/BootScriptExecuteorDxe: Use correct field name.
> 
>  MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/ScriptExecute.c   | 4 ++--
>  MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/X64/SetIdtEntry.c | 4 ++--
>  UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c   | 6 
> +++---
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 

Regression-tested-by: Laszlo Ersek 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [Patch 0/2] Use correct field name.

2019-01-10 Thread Eric Dong 
((Facs->Flags & EFI_ACPI_4_0_OSPM_64BIT_WAKE__F) != 0))

In above code, Facs->OspmFlags should be used instead.
EFI_ACPI_4_0_OSPM_64BIT_WAKE__F is a bit in OSPM Enabled Firmware
Control Structure Flags field, not in Firmware Control Structure
Feature Flags.

Update all related code to use correct field name.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1430

Cc: Aleksiy 
Cc: Ray Ni 
Cc: Laszlo Ersek 
Cc: Jian Wang 
Eric Dong (2):
  UefiCpuPkg/S3Resume2Pei: Use correct field name.
  MdeModulePkg/BootScriptExecuteorDxe: Use correct field name.

 MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/ScriptExecute.c   | 4 ++--
 MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/X64/SetIdtEntry.c | 4 ++--
 UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c   | 6 +++---
 3 files changed, 7 insertions(+), 7 deletions(-)

-- 
2.15.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel