Re: [edk2] [edk2-test][PATCH v1 1/1] uefi-sct: Change line endings to CR LF.
Reviewed-by: Eric Jin -Original Message- From: Supreeth Venkatesh Sent: Thursday, December 13, 2018 5:44 AM To: edk2-devel@lists.01.org Cc: Jin, Eric ; Supreeth Venkatesh Subject: [edk2][edk2-test][PATCH v1 1/1] uefi-sct: Change line endings to CR LF. No functionality change. Change line endings to CR LF (windows style) and avoid mixing unix and windows line endings for all source files with the exception for shell script files. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .gitignore| 2 +- .../SCT/Framework/Include/SctDef.h| 6 +- uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c | 50 ++--- uefi-sct/SctPkg/UEFI/UEFI.dec | 204 +- 4 files changed, 131 insertions(+), 131 deletions(-) diff --git a/.gitignore b/.gitignore index e04ef8de..3b8d818e 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,3 @@ Build/ tags/ -*.[od] +*.[od] diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h index 3a1afaae..ea488db0 100644 --- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h +++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h @@ -2,7 +2,7 @@ Copyright 2006 - 2017 Unified EFI, Inc. Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. - Copyright (c) 2018, ARM Ltd. All rights reserved. + Copyright (c) 2018, ARM Ltd. All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -47,8 +47,8 @@ Abstract: #define EFI_SCT_NAMEL"UEFI2.5 Self Certification Test(SCT2)" #elif (EFI_SPECIFICATION_VERSION == EFI_2_60_SYSTEM_TABLE_REVISION) #define EFI_SCT_NAMEL"UEFI2.6 Self Certification Test(SCT2)" -#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION) -#define EFI_SCT_NAMEL"UEFI2.7 Self Certification Test(SCT2)" +#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION) +#define EFI_SCT_NAMEL"UEFI2.7 Self Certification Test(SCT2)" #else #error Unknown EFI_SPECIFICATION_VERSION #endif diff --git a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c b/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c index f812e511..557a6207 100644 --- a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c +++ b/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c @@ -2,7 +2,7 @@ Copyright 2006 - 2010 Unified EFI, Inc. Copyright (c) 2010 Intel Corporation. All rights reserved. - Copyright (c) 2018 ARM Ltd. All rights reserved. + Copyright (c) 2018 ARM Ltd. All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -33,7 +33,7 @@ Abstract: #include #include #include -#include +#include // // Definitions @@ -51,7 +51,7 @@ PrintUsage ( void ); -char * +char * Trim ( char*String ); @@ -161,42 +161,42 @@ PrintUsage ( } -char * +char * Trim ( char*String ) { int Length; - char *end; + char *end; Length = strlen (String); - if (!Length) { -return String; + if (!Length) { +return String; } - end = String + Length - 1; + end = String + Length - 1; // // Remove the space characters from the end of this string // - while (end >= String && isspace (*end)) { -end--; + while (end >= String && isspace (*end)) { +end--; } - *(end + 1) = '\0'; - - // - // Remove the space characters from the beginning of this string - // - while (*String && isspace (*String)) { -String++; - } + *(end + 1) = '\0'; + + // + // Remove the space characters from the beginning of this string // + while (*String && isspace (*String)) { +String++; + } // // Done // - return String; + return String; } @@ -226,15 +226,15 @@ GetLine ( // // Remove the beginning and ending space characters // -String = Trim (Result); +String = Trim (Result); // -// Skip the empty line and comment line +// Skip the empty line and comment line // -if ((String[0] == '\0') || -(String[0] == '#' )) { - continue; -} +if ((String[0] == '\0') || +(String[0] == '#' )) { + continue; +} } // diff --git a/uefi-sct/SctPkg/UEFI/UEFI.dec b/uefi-sct/SctPkg/UEFI/UEFI.dec index 8495a4e1..e3a6148c 100644 --- a/uefi-sct/SctPkg/UEFI/UEFI.dec +++ b/uefi-sct/SctPkg/UEFI/UEFI.dec @@ -1,7 +1,7 @@ ## @file # # Copyright 2004 - 2017 Unified EFI, Inc. -# Copyright (c) 2014 - 2018, ARM Limited. All rights reserved. +# Copyright (c) 2014 - 2018, ARM Limited. All rights reserved. # Copyright (c
[edk2] [edk2-test][PATCH v1 1/1] uefi-sct: Change line endings to CR LF.
No functionality change. Change line endings to CR LF (windows style) and avoid mixing unix and windows line endings for all source files with the exception for shell script files. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .gitignore| 2 +- .../SCT/Framework/Include/SctDef.h| 6 +- uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c | 50 ++--- uefi-sct/SctPkg/UEFI/UEFI.dec | 204 +- 4 files changed, 131 insertions(+), 131 deletions(-) diff --git a/.gitignore b/.gitignore index e04ef8de..3b8d818e 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,3 @@ Build/ tags/ -*.[od] +*.[od] diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h index 3a1afaae..ea488db0 100644 --- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h +++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h @@ -2,7 +2,7 @@ Copyright 2006 - 2017 Unified EFI, Inc. Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. - Copyright (c) 2018, ARM Ltd. All rights reserved. + Copyright (c) 2018, ARM Ltd. All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -47,8 +47,8 @@ Abstract: #define EFI_SCT_NAMEL"UEFI2.5 Self Certification Test(SCT2)" #elif (EFI_SPECIFICATION_VERSION == EFI_2_60_SYSTEM_TABLE_REVISION) #define EFI_SCT_NAMEL"UEFI2.6 Self Certification Test(SCT2)" -#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION) -#define EFI_SCT_NAMEL"UEFI2.7 Self Certification Test(SCT2)" +#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION) +#define EFI_SCT_NAMEL"UEFI2.7 Self Certification Test(SCT2)" #else #error Unknown EFI_SPECIFICATION_VERSION #endif diff --git a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c b/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c index f812e511..557a6207 100644 --- a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c +++ b/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c @@ -2,7 +2,7 @@ Copyright 2006 - 2010 Unified EFI, Inc. Copyright (c) 2010 Intel Corporation. All rights reserved. - Copyright (c) 2018 ARM Ltd. All rights reserved. + Copyright (c) 2018 ARM Ltd. All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -33,7 +33,7 @@ Abstract: #include #include #include -#include +#include // // Definitions @@ -51,7 +51,7 @@ PrintUsage ( void ); -char * +char * Trim ( char*String ); @@ -161,42 +161,42 @@ PrintUsage ( } -char * +char * Trim ( char*String ) { int Length; - char *end; + char *end; Length = strlen (String); - if (!Length) { -return String; + if (!Length) { +return String; } - end = String + Length - 1; + end = String + Length - 1; // // Remove the space characters from the end of this string // - while (end >= String && isspace (*end)) { -end--; + while (end >= String && isspace (*end)) { +end--; } - *(end + 1) = '\0'; - - // - // Remove the space characters from the beginning of this string - // - while (*String && isspace (*String)) { -String++; - } + *(end + 1) = '\0'; + + // + // Remove the space characters from the beginning of this string + // + while (*String && isspace (*String)) { +String++; + } // // Done // - return String; + return String; } @@ -226,15 +226,15 @@ GetLine ( // // Remove the beginning and ending space characters // -String = Trim (Result); +String = Trim (Result); // -// Skip the empty line and comment line +// Skip the empty line and comment line // -if ((String[0] == '\0') || -(String[0] == '#' )) { - continue; -} +if ((String[0] == '\0') || +(String[0] == '#' )) { + continue; +} } // diff --git a/uefi-sct/SctPkg/UEFI/UEFI.dec b/uefi-sct/SctPkg/UEFI/UEFI.dec index 8495a4e1..e3a6148c 100644 --- a/uefi-sct/SctPkg/UEFI/UEFI.dec +++ b/uefi-sct/SctPkg/UEFI/UEFI.dec @@ -1,7 +1,7 @@ ## @file # # Copyright 2004 - 2017 Unified EFI, Inc. -# Copyright (c) 2014 - 2018, ARM Limited. All rights reserved. +# Copyright (c) 2014 - 2018, ARM Limited. All rights reserved. # Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved. # (C) Copyright 2017 Hewlett Packard Enterprise Development LP # @@ -44,25 +44,25 @@ [Guids.common] - gBlackBoxEfiFileInfoGuid = { 0x9576e92, 0x6d3f, 0x11d2, { 0x8e, 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b }} - gBlackBoxEfiFileInfoIdGuid = { 0x9576e93, 0x6d3f, 0x11d2, { 0x8e, 0x39, 0x0,