Re: [edk2] [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE

2016-02-17 Thread Laszlo Ersek 
On 02/17/16 13:38, Jiewen Yao wrote:
> UEFI2.6 specification does not recommend to use BIT0
> attribute for PropertiesTable, so we change default
> value to FALSE.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: "Yao, Jiewen" 
> Cc: "Gao, Liming" 
> ---
>  MdeModulePkg/MdeModulePkg.dec | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index 5c5a9ee..2df8c19 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1415,8 +1415,10 @@
># this PCD to be TURE if and only if all runtime driver has seperated 
> Code/Data
># section. If PE code/data sections are merged, the result is 
> unpredictable.
>#
> +  # UEFI 2.6 specification does not recommand to use this BIT0 attribute.

should be "recommend"

> +  #
># @Prompt Publish UEFI PropertiesTable.
> -  
> gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|TRUE|BOOLEAN|0x006e
> +  
> gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|FALSE|BOOLEAN|0x006e
>  
>## Default OEM ID for ACPI table creation, its length must be 0x6 bytes to 
> follow ACPI specification.
># @Prompt Default OEM ID for ACPI table creation.
> 

With the typo fixed:

Reviewed-by: Laszlo Ersek 

Thanks!
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE

2016-02-17 Thread Gao, Liming 
Reviewed-by: Liming Gao 

-Original Message-
From: Yao, Jiewen 
Sent: Wednesday, February 17, 2016 8:39 PM
To: edk2-de...@ml01.01.org
Cc: Yao, Jiewen ; Gao, Liming 
Subject: [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE

UEFI2.6 specification does not recommend to use BIT0
attribute for PropertiesTable, so we change default
value to FALSE.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen" 
Cc: "Gao, Liming" 
---
 MdeModulePkg/MdeModulePkg.dec | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 5c5a9ee..2df8c19 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -1415,8 +1415,10 @@
   # this PCD to be TURE if and only if all runtime driver has seperated 
Code/Data
   # section. If PE code/data sections are merged, the result is unpredictable.
   #
+  # UEFI 2.6 specification does not recommand to use this BIT0 attribute.
+  #
   # @Prompt Publish UEFI PropertiesTable.
-  
gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|TRUE|BOOLEAN|0x006e
+  
gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|FALSE|BOOLEAN|0x006e
 
   ## Default OEM ID for ACPI table creation, its length must be 0x6 bytes to 
follow ACPI specification.
   # @Prompt Default OEM ID for ACPI table creation.
-- 
1.9.5.msysgit.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE

2016-02-17 Thread Ard Biesheuvel 
On 17 February 2016 at 13:38, Jiewen Yao  wrote:
> UEFI2.6 specification does not recommend to use BIT0
> attribute for PropertiesTable, so we change default
> value to FALSE.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: "Yao, Jiewen" 
> Cc: "Gao, Liming" 

Reviewed-by: Ard Biesheuvel 

> ---
>  MdeModulePkg/MdeModulePkg.dec | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index 5c5a9ee..2df8c19 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1415,8 +1415,10 @@
># this PCD to be TURE if and only if all runtime driver has seperated 
> Code/Data
># section. If PE code/data sections are merged, the result is 
> unpredictable.
>#
> +  # UEFI 2.6 specification does not recommand to use this BIT0 attribute.
> +  #
># @Prompt Publish UEFI PropertiesTable.
> -  
> gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|TRUE|BOOLEAN|0x006e
> +  
> gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|FALSE|BOOLEAN|0x006e
>
>## Default OEM ID for ACPI table creation, its length must be 0x6 bytes to 
> follow ACPI specification.
># @Prompt Default OEM ID for ACPI table creation.
> --
> 1.9.5.msysgit.0
>
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE

2016-02-17 Thread Jiewen Yao 
UEFI2.6 specification does not recommend to use BIT0
attribute for PropertiesTable, so we change default
value to FALSE.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen" 
Cc: "Gao, Liming" 
---
 MdeModulePkg/MdeModulePkg.dec | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 5c5a9ee..2df8c19 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -1415,8 +1415,10 @@
   # this PCD to be TURE if and only if all runtime driver has seperated 
Code/Data
   # section. If PE code/data sections are merged, the result is unpredictable.
   #
+  # UEFI 2.6 specification does not recommand to use this BIT0 attribute.
+  #
   # @Prompt Publish UEFI PropertiesTable.
-  
gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|TRUE|BOOLEAN|0x006e
+  
gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|FALSE|BOOLEAN|0x006e
 
   ## Default OEM ID for ACPI table creation, its length must be 0x6 bytes to 
follow ACPI specification.
   # @Prompt Default OEM ID for ACPI table creation.
-- 
1.9.5.msysgit.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel