Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

> My description was not very clear, and the point is academic if you are > happy with the solution. I think it's important that we're aligned on how the GIC works so thanks for humoring me. > However: > The GIC spec has a state machine diagram (Figure 4.3), where: > Transition D, pending to

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

gt;Subject: RE: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt > >Evan, > >> I'd like to re-think our GIC EIOR changes in the light of comments from >> Heyi Guo. (inserted before Eugene's e-mail below) >> Despite Eugene's cogent advocacy of the change, and

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

Evan, > I'd like to re-think our GIC EIOR changes in the light of comments from > Heyi Guo. (inserted before Eugene's e-mail below) > Despite Eugene's cogent advocacy of the change, and the fact that > Alexei's fix is now accepted, I have come to the conclusion that it is not > the best thing to

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

nal Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >Biesheuvel >Sent: 08 August 2016 14:51 >To: Cohen, Eugene >Cc: Alexei Fedorov; edk2-devel@lists.01.org; Leif Lindholm; Andrew Fish >(af...@apple.com); Heyi Guo >Subject: Re: [edk2] [PA

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

On 8 August 2016 at 15:42, Ard Biesheuvel wrote: > On 8 August 2016 at 15:22, Cohen, Eugene wrote: >> Guys, sorry to join so late, something about timezones... Let me try to >> provide some context and history. >> >>> > it does change the contract we

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

On 8 August 2016 at 15:22, Cohen, Eugene wrote: > Guys, sorry to join so late, something about timezones... Let me try to > provide some context and history. > >> > it does change the contract we have with registered interrupt handlers >> >> Looks like it does not: >> From

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

ei Fedorov <alexei.fedo...@arm.com> > Cc: edk2-devel@lists.01.org <edk2-de...@ml01.01.org>; Heyi Guo > <heyi@linaro.org>; Leif Lindholm <leif.lindh...@linaro.org>; Cohen, > Eugene <eug...@hp.com> > Subject: Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write pe

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

On 8 August 2016 at 13:08, Ard Biesheuvel wrote: > On 8 August 2016 at 13:06, Alexei Fedorov wrote: >> Timer's pending interrupt is cleared HARDWARE_INTERRUPT_HANDLER >> TimerInterruptHandler() in when timer is re-programmed for the next

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 08 August 2016 11:59 > To: Alexei Fedorov > Cc: Evan Lloyd; Cohen, Eugene; edk2-devel@lists.01.org; Heyi Guo; Leif > Lindholm > Subject: Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR w

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

] Sent: 08 August 2016 11:59 To: Alexei Fedorov Cc: Evan Lloyd; Cohen, Eugene; edk2-devel@lists.01.org; Heyi Guo; Leif Lindholm Subject: Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt On 8 August 2016 at 12:56, Alexei Fedorov <alexei.fedo...@arm.com> wrote: >

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

08 August 2016 11:49 > To: Alexei Fedorov > Cc: Evan Lloyd; Cohen, Eugene; edk2-devel@lists.01.org; Heyi Guo; Leif > Lindholm > Subject: Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt > > On 8 August 2016 at 12:48, Alexei Fedorov <alexei.fedo...@ar

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

vel [mailto:ard.biesheu...@linaro.org] > Sent: 08 August 2016 11:45 > To: Alexei Fedorov > Cc: Evan Lloyd; Cohen, Eugene; edk2-devel@lists.01.org; Heyi Guo; Leif > Lindholm > Subject: Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt > > On 8 Augus

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

> Sent: 08 August 2016 11:45 > To: Alexei Fedorov > Cc: Evan Lloyd; Cohen, Eugene; edk2-devel@lists.01.org; Heyi Guo; Leif > Lindholm > Subject: Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt > > On 8 August 2016 at 12:40, Alexei Fedorov <alexei.fedo...@ar

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

sts.01.org; Heyi Guo; Leif Lindholm Subject: Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt On 8 August 2016 at 12:40, Alexei Fedorov <alexei.fedo...@arm.com> wrote: > The interrupt is cleared in TimerInterruptHandler() > (ArmPkg\Drivers\Timer

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

yi Guo; Leif > Lindholm > Subject: Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt > > On 8 August 2016 at 12:25, Alexei Fedorov <alexei.fedo...@arm.com> wrote: >> >>> it does change the contract we have with registered interrupt >&g

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

ler(). -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: 08 August 2016 11:32 To: Alexei Fedorov Cc: Evan Lloyd; Cohen, Eugene; edk2-devel@lists.01.org; Heyi Guo; Leif Lindholm Subject: Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt O

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: 06 August 2016 09:25 > To: Evan Lloyd; Cohen, Eugene > Cc: edk2-devel@lists.01.org; Heyi Guo; Leif Lindholm > Subject: Re: [edk2] [PATCH] ArmPkg: Fix double GI

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

ugust 2016 09:25 To: Evan Lloyd; Cohen, Eugene Cc: edk2-devel@lists.01.org; Heyi Guo; Leif Lindholm Subject: Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt (+ Eugene) On 5 August 2016 at 18:59, <evan.ll...@arm.com> wrote: > From: Alexei <alexei.fedo...@arm.com&

Re: [edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

(+ Eugene) On 5 August 2016 at 18:59, wrote: > From: Alexei > > This commit fixes a bug in the GIC v2 and v3 drivers where the GICC_EOIR > (End Of Interrupt Register) is written twice for a single interrupt. > GicV(2|3)IrqInterruptHandler() calls the

[edk2] [PATCH] ArmPkg: Fix double GIC EIOR write per interrupt

From: Alexei This commit fixes a bug in the GIC v2 and v3 drivers where the GICC_EOIR (End Of Interrupt Register) is written twice for a single interrupt. GicV(2|3)IrqInterruptHandler() calls the Interrupt Handler and then GicV(2|3)EndOfInterrupt() on exit: