Re: [edk2] [PATCH] ArmVirtPkg/PrePi: don't export PE/COFF and LZMA libraries via HOBs

[Ard Biesheuvel]

On 27 November 2017 at 12:32, Laszlo Ersek  wrote:
> On 11/24/17 10:51, Ard Biesheuvel wrote:
>> The PrePi code we inherited from ArmPlatformPkg contains a rather
>> obscure optimization, where entry points of the PE/COFF and LZMA
>> handling routines are recorded in special HOBs, allowing DXE core
>> to call into that code directly rather than carry its own copy of
>> these libraries.
>>
>> Given that no ArmVirtPkg platforms actually include the library
>> resolutions* that take advantage of these optimizations, let's not
>> bother with them, and remove the associated code.
>>
>> * 
>> EmbeddedPkg/Library/LzmaHobCustomDecompressLib/LzmaHobCustomDecompressLib.inf
>>   EmbeddedPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLib.inf
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel 
>> ---
>>  ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf |   1 -
>>  ArmVirtPkg/PrePi/LzmaDecompress.h   | 103 
>> 
>>  ArmVirtPkg/PrePi/PrePi.c|  11 ---
>>  3 files changed, 115 deletions(-)
>>
>> diff --git a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf 
>> b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
>> index 58290d2d1b76..b3a3f5da065e 100755
>> --- a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
>> +++ b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
>> @@ -51,7 +51,6 @@ [LibraryClasses]
>>SerialPortLib
>>ExtractGuidedSectionLib
>>LzmaDecompressLib
>> -  PeCoffGetEntryPointLib
>>PrePiLib
>>MemoryAllocationLib
>>HobLib
>> diff --git a/ArmVirtPkg/PrePi/LzmaDecompress.h 
>> b/ArmVirtPkg/PrePi/LzmaDecompress.h
>> deleted file mode 100644
>> index a79ff343d231..
>> --- a/ArmVirtPkg/PrePi/LzmaDecompress.h
>> +++ /dev/null
>> @@ -1,103 +0,0 @@
>> -/** @file
>> -  LZMA Decompress Library header file
>> -
>> -  Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.
>> -  This program and the accompanying materials
>> -  are licensed and made available under the terms and conditions of the BSD 
>> License
>> -  which accompanies this distribution.  The full text of the license may be 
>> found at
>> -  http://opensource.org/licenses/bsd-license.php
>> -
>> -  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
>> -  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
>> IMPLIED.
>> -
>> -**/
>> -
>> -#ifndef __LZMA_DECOMPRESS_H___
>> -#define __LZMA_DECOMPRESS_H___
>> -
>> -/**
>> -  Examines a GUIDed section and returns the size of the decoded buffer and 
>> the
>> -  size of an scratch buffer required to actually decode the data in a 
>> GUIDed section.
>> -
>> -  Examines a GUIDed section specified by InputSection.
>> -  If GUID for InputSection does not match the GUID that this handler 
>> supports,
>> -  then RETURN_UNSUPPORTED is returned.
>> -  If the required information can not be retrieved from InputSection,
>> -  then RETURN_INVALID_PARAMETER is returned.
>> -  If the GUID of InputSection does match the GUID that this handler 
>> supports,
>> -  then the size required to hold the decoded buffer is returned in 
>> OututBufferSize,
>> -  the size of an optional scratch buffer is returned in ScratchSize, and 
>> the Attributes field
>> -  from EFI_GUID_DEFINED_SECTION header of InputSection is returned in 
>> SectionAttribute.
>> -
>> -  If InputSection is NULL, then ASSERT().
>> -  If OutputBufferSize is NULL, then ASSERT().
>> -  If ScratchBufferSize is NULL, then ASSERT().
>> -  If SectionAttribute is NULL, then ASSERT().
>> -
>> -
>> -  @param[in]  InputSection   A pointer to a GUIDed section of an FFS 
>> formatted file.
>> -  @param[out] OutputBufferSize   A pointer to the size, in bytes, of an 
>> output buffer required
>> - if the buffer specified by InputSection 
>> were decoded.
>> -  @param[out] ScratchBufferSize  A pointer to the size, in bytes, required 
>> as scratch space
>> - if the buffer specified by InputSection 
>> were decoded.
>> -  @param[out] SectionAttribute   A pointer to the attributes of the GUIDed 
>> section. See the Attributes
>> - field of EFI_GUID_DEFINED_SECTION in the 
>> PI Specification.
>> -
>> -  @retval  RETURN_SUCCESSThe information about InputSection was 
>> returned.
>> -  @retval  RETURN_UNSUPPORTEDThe section specified by InputSection 
>> does not match the GUID this handler supports.
>> -  @retval  RETURN_INVALID_PARAMETER  The information can not be retrieved 
>> from the section specified by InputSection.
>> -
>> -**/
>> -RETURN_STATUS
>> -EFIAPI
>> -LzmaGuidedSectionGetInfo (
>> -  IN  CONST VOID  *InputSection,
>> -  OUT UINT32  *OutputBufferSize,
>> -  OUT UINT32  *ScratchBufferSize,
>> -  OUT UINT16  *SectionAttribute
>> -  );
>> -
>> -/**
>> -  Decompress a LZAM compressed GUIDed 

Re: [edk2] [PATCH] ArmVirtPkg/PrePi: don't export PE/COFF and LZMA libraries via HOBs

[Laszlo Ersek]

On 11/24/17 10:51, Ard Biesheuvel wrote:
> The PrePi code we inherited from ArmPlatformPkg contains a rather
> obscure optimization, where entry points of the PE/COFF and LZMA
> handling routines are recorded in special HOBs, allowing DXE core
> to call into that code directly rather than carry its own copy of
> these libraries.
> 
> Given that no ArmVirtPkg platforms actually include the library
> resolutions* that take advantage of these optimizations, let's not
> bother with them, and remove the associated code.
> 
> * 
> EmbeddedPkg/Library/LzmaHobCustomDecompressLib/LzmaHobCustomDecompressLib.inf
>   EmbeddedPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLib.inf
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel 
> ---
>  ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf |   1 -
>  ArmVirtPkg/PrePi/LzmaDecompress.h   | 103 
> 
>  ArmVirtPkg/PrePi/PrePi.c|  11 ---
>  3 files changed, 115 deletions(-)
> 
> diff --git a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf 
> b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
> index 58290d2d1b76..b3a3f5da065e 100755
> --- a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
> +++ b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
> @@ -51,7 +51,6 @@ [LibraryClasses]
>SerialPortLib
>ExtractGuidedSectionLib
>LzmaDecompressLib
> -  PeCoffGetEntryPointLib
>PrePiLib
>MemoryAllocationLib
>HobLib
> diff --git a/ArmVirtPkg/PrePi/LzmaDecompress.h 
> b/ArmVirtPkg/PrePi/LzmaDecompress.h
> deleted file mode 100644
> index a79ff343d231..
> --- a/ArmVirtPkg/PrePi/LzmaDecompress.h
> +++ /dev/null
> @@ -1,103 +0,0 @@
> -/** @file
> -  LZMA Decompress Library header file
> -
> -  Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.
> -  This program and the accompanying materials
> -  are licensed and made available under the terms and conditions of the BSD 
> License
> -  which accompanies this distribution.  The full text of the license may be 
> found at
> -  http://opensource.org/licenses/bsd-license.php
> -
> -  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
> IMPLIED.
> -
> -**/
> -
> -#ifndef __LZMA_DECOMPRESS_H___
> -#define __LZMA_DECOMPRESS_H___
> -
> -/**
> -  Examines a GUIDed section and returns the size of the decoded buffer and 
> the
> -  size of an scratch buffer required to actually decode the data in a GUIDed 
> section.
> -
> -  Examines a GUIDed section specified by InputSection.
> -  If GUID for InputSection does not match the GUID that this handler 
> supports,
> -  then RETURN_UNSUPPORTED is returned.
> -  If the required information can not be retrieved from InputSection,
> -  then RETURN_INVALID_PARAMETER is returned.
> -  If the GUID of InputSection does match the GUID that this handler supports,
> -  then the size required to hold the decoded buffer is returned in 
> OututBufferSize,
> -  the size of an optional scratch buffer is returned in ScratchSize, and the 
> Attributes field
> -  from EFI_GUID_DEFINED_SECTION header of InputSection is returned in 
> SectionAttribute.
> -
> -  If InputSection is NULL, then ASSERT().
> -  If OutputBufferSize is NULL, then ASSERT().
> -  If ScratchBufferSize is NULL, then ASSERT().
> -  If SectionAttribute is NULL, then ASSERT().
> -
> -
> -  @param[in]  InputSection   A pointer to a GUIDed section of an FFS 
> formatted file.
> -  @param[out] OutputBufferSize   A pointer to the size, in bytes, of an 
> output buffer required
> - if the buffer specified by InputSection 
> were decoded.
> -  @param[out] ScratchBufferSize  A pointer to the size, in bytes, required 
> as scratch space
> - if the buffer specified by InputSection 
> were decoded.
> -  @param[out] SectionAttribute   A pointer to the attributes of the GUIDed 
> section. See the Attributes
> - field of EFI_GUID_DEFINED_SECTION in the PI 
> Specification.
> -
> -  @retval  RETURN_SUCCESSThe information about InputSection was 
> returned.
> -  @retval  RETURN_UNSUPPORTEDThe section specified by InputSection 
> does not match the GUID this handler supports.
> -  @retval  RETURN_INVALID_PARAMETER  The information can not be retrieved 
> from the section specified by InputSection.
> -
> -**/
> -RETURN_STATUS
> -EFIAPI
> -LzmaGuidedSectionGetInfo (
> -  IN  CONST VOID  *InputSection,
> -  OUT UINT32  *OutputBufferSize,
> -  OUT UINT32  *ScratchBufferSize,
> -  OUT UINT16  *SectionAttribute
> -  );
> -
> -/**
> -  Decompress a LZAM compressed GUIDed section into a caller allocated output 
> buffer.
> -
> -  Decodes the GUIDed section specified by InputSection.
> -  If GUID for InputSection does not match the GUID that this handler 
> supports, 

[edk2] [PATCH] ArmVirtPkg/PrePi: don't export PE/COFF and LZMA libraries via HOBs

[Ard Biesheuvel]

The PrePi code we inherited from ArmPlatformPkg contains a rather
obscure optimization, where entry points of the PE/COFF and LZMA
handling routines are recorded in special HOBs, allowing DXE core
to call into that code directly rather than carry its own copy of
these libraries.

Given that no ArmVirtPkg platforms actually include the library
resolutions* that take advantage of these optimizations, let's not
bother with them, and remove the associated code.

* EmbeddedPkg/Library/LzmaHobCustomDecompressLib/LzmaHobCustomDecompressLib.inf
  EmbeddedPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLib.inf

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel 
---
 ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf |   1 -
 ArmVirtPkg/PrePi/LzmaDecompress.h   | 103 
 ArmVirtPkg/PrePi/PrePi.c|  11 ---
 3 files changed, 115 deletions(-)

diff --git a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf 
b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
index 58290d2d1b76..b3a3f5da065e 100755
--- a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
+++ b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
@@ -51,7 +51,6 @@ [LibraryClasses]
   SerialPortLib
   ExtractGuidedSectionLib
   LzmaDecompressLib
-  PeCoffGetEntryPointLib
   PrePiLib
   MemoryAllocationLib
   HobLib
diff --git a/ArmVirtPkg/PrePi/LzmaDecompress.h 
b/ArmVirtPkg/PrePi/LzmaDecompress.h
deleted file mode 100644
index a79ff343d231..
--- a/ArmVirtPkg/PrePi/LzmaDecompress.h
+++ /dev/null
@@ -1,103 +0,0 @@
-/** @file
-  LZMA Decompress Library header file
-
-  Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.
-  This program and the accompanying materials
-  are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution.  The full text of the license may be 
found at
-  http://opensource.org/licenses/bsd-license.php
-
-  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-
-**/
-
-#ifndef __LZMA_DECOMPRESS_H___
-#define __LZMA_DECOMPRESS_H___
-
-/**
-  Examines a GUIDed section and returns the size of the decoded buffer and the
-  size of an scratch buffer required to actually decode the data in a GUIDed 
section.
-
-  Examines a GUIDed section specified by InputSection.
-  If GUID for InputSection does not match the GUID that this handler supports,
-  then RETURN_UNSUPPORTED is returned.
-  If the required information can not be retrieved from InputSection,
-  then RETURN_INVALID_PARAMETER is returned.
-  If the GUID of InputSection does match the GUID that this handler supports,
-  then the size required to hold the decoded buffer is returned in 
OututBufferSize,
-  the size of an optional scratch buffer is returned in ScratchSize, and the 
Attributes field
-  from EFI_GUID_DEFINED_SECTION header of InputSection is returned in 
SectionAttribute.
-
-  If InputSection is NULL, then ASSERT().
-  If OutputBufferSize is NULL, then ASSERT().
-  If ScratchBufferSize is NULL, then ASSERT().
-  If SectionAttribute is NULL, then ASSERT().
-
-
-  @param[in]  InputSection   A pointer to a GUIDed section of an FFS 
formatted file.
-  @param[out] OutputBufferSize   A pointer to the size, in bytes, of an output 
buffer required
- if the buffer specified by InputSection were 
decoded.
-  @param[out] ScratchBufferSize  A pointer to the size, in bytes, required as 
scratch space
- if the buffer specified by InputSection were 
decoded.
-  @param[out] SectionAttribute   A pointer to the attributes of the GUIDed 
section. See the Attributes
- field of EFI_GUID_DEFINED_SECTION in the PI 
Specification.
-
-  @retval  RETURN_SUCCESSThe information about InputSection was 
returned.
-  @retval  RETURN_UNSUPPORTEDThe section specified by InputSection 
does not match the GUID this handler supports.
-  @retval  RETURN_INVALID_PARAMETER  The information can not be retrieved from 
the section specified by InputSection.
-
-**/
-RETURN_STATUS
-EFIAPI
-LzmaGuidedSectionGetInfo (
-  IN  CONST VOID  *InputSection,
-  OUT UINT32  *OutputBufferSize,
-  OUT UINT32  *ScratchBufferSize,
-  OUT UINT16  *SectionAttribute
-  );
-
-/**
-  Decompress a LZAM compressed GUIDed section into a caller allocated output 
buffer.
-
-  Decodes the GUIDed section specified by InputSection.
-  If GUID for InputSection does not match the GUID that this handler supports, 
then RETURN_UNSUPPORTED is returned.
-  If the data in InputSection can not be decoded, then 
RETURN_INVALID_PARAMETER is returned.
-  If the GUID of InputSection does match the GUID that this handler supports, 
then InputSection
-  is decoded into the buffer specified by OutputBuffer and the