Re: [edk2] [PATCH] BaseTool: Fixed the incorrect cache key.

2018-07-11 Thread Gao, Liming
Reviewed-by: Liming Gao 

> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, July 11, 2018 12:19 AM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming 
> Subject: [PATCH] BaseTool: Fixed the incorrect cache key.
> 
> From: "bob.c.f...@intel.com" 
> 
> This patch is to fix the incorrect cache key of
> skip ModuleAutoGen cache.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng 
> Cc: Liming Gao 
> ---
>  BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py 
> b/BaseTools/Source/Python/AutoGen/AutoGen.py
> index b27290989e..54c6b7330f 100644
> --- a/BaseTools/Source/Python/AutoGen/AutoGen.py
> +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
> @@ -4320,7 +4320,7 @@ class ModuleAutoGen(AutoGen):
>  #  If any source file is newer than the module than we cannot skip
>  #
>  def CanSkip(self):
> -if self.MetaFile in GlobalData.gSikpAutoGenCache:
> +if self.MakeFileDir in GlobalData.gSikpAutoGenCache:
>  return True
>  if not os.path.exists(self.GetTimeStampPath()):
>  return False
> @@ -4340,7 +4340,7 @@ class ModuleAutoGen(AutoGen):
>  ModuleAutoGen.TimeDict[source] = os.stat(source)[8]
>  if ModuleAutoGen.TimeDict[source] > DstTimeStamp:
>  return False
> -GlobalData.gSikpAutoGenCache.add(self.MetaFile)
> +GlobalData.gSikpAutoGenCache.add(self.MakeFileDir)
>  return True
> 
>  def GetTimeStampPath(self):
> --
> 2.18.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] [PATCH] BaseTool: Fixed the incorrect cache key.

2018-07-10 Thread BobCF
From: "bob.c.f...@intel.com" 

This patch is to fix the incorrect cache key of
skip ModuleAutoGen cache.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng 
Cc: Liming Gao 
---
 BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py 
b/BaseTools/Source/Python/AutoGen/AutoGen.py
index b27290989e..54c6b7330f 100644
--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
@@ -4320,7 +4320,7 @@ class ModuleAutoGen(AutoGen):
 #  If any source file is newer than the module than we cannot skip
 #
 def CanSkip(self):
-if self.MetaFile in GlobalData.gSikpAutoGenCache:
+if self.MakeFileDir in GlobalData.gSikpAutoGenCache:
 return True
 if not os.path.exists(self.GetTimeStampPath()):
 return False
@@ -4340,7 +4340,7 @@ class ModuleAutoGen(AutoGen):
 ModuleAutoGen.TimeDict[source] = os.stat(source)[8]
 if ModuleAutoGen.TimeDict[source] > DstTimeStamp:
 return False
-GlobalData.gSikpAutoGenCache.add(self.MetaFile)
+GlobalData.gSikpAutoGenCache.add(self.MakeFileDir)
 return True
 
 def GetTimeStampPath(self):
-- 
2.18.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel