Reviewed-by: Long Qin
(Thanks, Gary.
I cannot recall why we used "char" instead of "int" here. Obviously, the
prototype of CRT memset should use "int").
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Wednesday, November 22, 2017 12:44 PM
To: edk2-devel@lists.01.org
Cc: Long, Qin ; Ye, Ting
Subject: [PATCH] CryptoPkg/IntrinsicLib: Fix the warning on memset
Gcc issued the warning when compiling CryptoPkg:
CryptoPkg/Library/Include/CrtLibSupport.h:135:17: warning: type of 'memset'
does not match original declaration [-Wlto-type-mismatch]
void *memset (void *, int, size_t);
^
CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c:27:8: note: type mismatch in
parameter 2 void * memset (void *dest, char ch, size_t count)
^
This commit changes the type of ch from char to int to match the declaration.
Cc: Qin Long
Cc: Ting Ye
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin
---
CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c
b/CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c
index bf485d680d..e095f9aa0d 100644
--- a/CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c
+++ b/CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c
@@ -24,7 +24,7 @@ typedef UINTN size_t; int _fltused = 1;
/* Sets buffers to a specified character */ -void * memset (void *dest, char
ch, size_t count)
+void * memset (void *dest, int ch, size_t count)
{
//
// NOTE: Here we use one base implementation for memset, instead of the
direct @@ -42,7 +42,7 @@ void * memset (void *dest, char ch, size_t count)
Pointer = (UINT8 *)dest;
while (count-- != 0) {
-*(Pointer++) = ch;
+*(Pointer++) = (UINT8)ch;
}
return dest;
--
2.15.0
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel