Re: [edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of checking input FilePath

2015-11-22 Thread Heyi Guo
- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Friday, November 20, 2015 5:10 PM To: Fu, Siyuan <siyuan...@intel.com>; edk2-devel@lists.01.org Cc: Zhang, Lubo <lubo.zh...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: Re: [edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of check

Re: [edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of checking input FilePath

2015-11-20 Thread Fu, Siyuan
: Zhang, Lubo <lubo.zh...@intel.com>; Heyi Guo <heyi@linaro.org>; Tian, Feng <feng.t...@intel.com> Subject: [edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of checking input FilePath There is a simple bug in below code and will cause PXE always returning invalid parameter: if

[edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of checking input FilePath

2015-11-20 Thread Heyi Guo
There is a simple bug in below code and will cause PXE always returning invalid parameter: if (FilePath == NULL || !IsDevicePathEnd (FilePath)) { return EFI_INVALID_PARAMETER; FilePath should *not* be end node, so return invalid parameter when FilePath *is* device path end.