Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update comment for spec compliance status

2019-01-28 Thread Wu, Hao A
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, January 29, 2019 11:28 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Ni, Ray
> Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update comment for
> spec compliance status
> 
> Just two typos (see below). With them addressed,
> 
> Reviewed-by: Jian J Wang 

Thanks for the catch.
I will handle them before pushing the patch.

Best Regards,
Hao Wu

> 
> > -Original Message-
> > From: Wu, Hao A
> > Sent: Tuesday, January 29, 2019 11:14 AM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A ; Wang, Jian J ;
> > Ni, Ray 
> > Subject: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update comment for
> spec
> > compliance status
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1441
> >
> > This commit will update the file-level comments within the SdMmcPciHcDxe
> > to reflect the latest specification compliance status of the driver.
> >
> > Cc: Jian J Wang 
> > Cc: Ray Ni 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Hao Wu 
> > ---
> >  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf | 5 +++--
> >  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c   | 6 --
> >  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 6 --
> >  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni | 5 +++--
> >  4 files changed, 14 insertions(+), 8 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> > index 1246e1d88d..025fb7faba 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> > @@ -1,11 +1,12 @@
> >  ## @file
> >  #  SdMmcPciHcDxe driver is used to manage those host controllers which
> > comply with SD
> > -#  Host Controller Simplified Specifiction version 3.0.
> > +#  Host Controller Simplified Specifiction version 3.0 plus the 64-bit 
> > System
> 
> Typo: Specifiction
> 
> > Addressing
> > +#  support in SD Host Controller Simplified Specification version 4.20.
> >  #
> >  #  It will produce EFI_SD_MMC_PASS_THRU_PROTOCOL to allow sending
> > SD/MMC/eMMC cmds
> >  #  to specified devices from upper layer.
> >  #
> > -#  Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
> > +#  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
> >  #
> >  #  This program and the accompanying materials
> >  #  are licensed and made available under the terms and conditions of the
> BSD
> > License
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> > index 76c32a4dcd..b474f8decd 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> > @@ -1,11 +1,13 @@
> >  /** @file
> >This driver is used to manage SD/MMC PCI host controllers which are
> > compliance
> > -  with SD Host Controller Simplified Specification version 3.00.
> > +  with SD Host Controller Simplified Specification version 3.00 plus the 
> > 64-bit
> > +  System Addressing support in SD Host Controller Simplified Specification
> > version
> > +  4.20.
> >
> >It would expose EFI_SD_MMC_PASS_THRU_PROTOCOL for upper layer use.
> >
> >Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> > -  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> > +  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
> >This program and the accompanying materials
> >are licensed and made available under the terms and conditions of the BSD
> > License
> >which accompanies this distribution.  The full text of the license may be
> found
> > at
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > index 5aec8c6992..4c64da3b20 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > @@ -1,11 +1,13 @@
> >  /** @file
> >This driver is used to manage SD/MMC PCI host controllers which are
> > compliance
> > -  with SD Host Controller Simplified Specification version 3.00.
> > +  with SD Host Controller Simplified Specification version 3.00 plus the 
> > 64-bit
> > +  System Addressing support in SD Host Controller Simplified Specification
> > version
> > +  4.20.
> >
> >It would expose EFI_SD_MMC_PASS_THRU_PROTOCOL for upper layer use.
> >
> >Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> > -  Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> > +  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
> >This program and the accompanying materials
> >are licensed and made available under the terms and conditions of the BSD
> > License
> >which accompanies this distribution.  The full text of the license may be
> found
> > at
> > diff --git 

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update comment for spec compliance status

2019-01-28 Thread Wang, Jian J
Just two typos (see below). With them addressed,

Reviewed-by: Jian J Wang 

> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, January 29, 2019 11:14 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray 
> Subject: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update comment for spec
> compliance status
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1441
> 
> This commit will update the file-level comments within the SdMmcPciHcDxe
> to reflect the latest specification compliance status of the driver.
> 
> Cc: Jian J Wang 
> Cc: Ray Ni 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu 
> ---
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf | 5 +++--
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c   | 6 --
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 6 --
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni | 5 +++--
>  4 files changed, 14 insertions(+), 8 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> index 1246e1d88d..025fb7faba 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> @@ -1,11 +1,12 @@
>  ## @file
>  #  SdMmcPciHcDxe driver is used to manage those host controllers which
> comply with SD
> -#  Host Controller Simplified Specifiction version 3.0.
> +#  Host Controller Simplified Specifiction version 3.0 plus the 64-bit System

Typo: Specifiction

> Addressing
> +#  support in SD Host Controller Simplified Specification version 4.20.
>  #
>  #  It will produce EFI_SD_MMC_PASS_THRU_PROTOCOL to allow sending
> SD/MMC/eMMC cmds
>  #  to specified devices from upper layer.
>  #
> -#  Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
> +#  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
>  #
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the BSD
> License
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> index 76c32a4dcd..b474f8decd 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> @@ -1,11 +1,13 @@
>  /** @file
>This driver is used to manage SD/MMC PCI host controllers which are
> compliance
> -  with SD Host Controller Simplified Specification version 3.00.
> +  with SD Host Controller Simplified Specification version 3.00 plus the 
> 64-bit
> +  System Addressing support in SD Host Controller Simplified Specification
> version
> +  4.20.
> 
>It would expose EFI_SD_MMC_PASS_THRU_PROTOCOL for upper layer use.
> 
>Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> -  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> +  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD
> License
>which accompanies this distribution.  The full text of the license may be 
> found
> at
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> index 5aec8c6992..4c64da3b20 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> @@ -1,11 +1,13 @@
>  /** @file
>This driver is used to manage SD/MMC PCI host controllers which are
> compliance
> -  with SD Host Controller Simplified Specification version 3.00.
> +  with SD Host Controller Simplified Specification version 3.00 plus the 
> 64-bit
> +  System Addressing support in SD Host Controller Simplified Specification
> version
> +  4.20.
> 
>It would expose EFI_SD_MMC_PASS_THRU_PROTOCOL for upper layer use.
> 
>Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> -  Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> +  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD
> License
>which accompanies this distribution.  The full text of the license may be 
> found
> at
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni
> index 57f9fa76a1..497d2cc9f0 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni
> @@ -1,11 +1,12 @@
>  // /** @file
>  // SdMmcPciHcDxe driver is used to manage those host controllers which
> comply with SD
> -// Host Controller Simplified Specifiction version 3.0.
> +// Host Controller Simplified Specifiction version 3.0 plus the 64-bit System

Typo: Specifiction

> Addressing
> 

[edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update comment for spec compliance status

2019-01-28 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1441

This commit will update the file-level comments within the SdMmcPciHcDxe
to reflect the latest specification compliance status of the driver.

Cc: Jian J Wang 
Cc: Ray Ni 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu 
---
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf | 5 +++--
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c   | 6 --
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 6 --
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni | 5 +++--
 4 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf 
b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
index 1246e1d88d..025fb7faba 100644
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
@@ -1,11 +1,12 @@
 ## @file
 #  SdMmcPciHcDxe driver is used to manage those host controllers which comply 
with SD
-#  Host Controller Simplified Specifiction version 3.0.
+#  Host Controller Simplified Specifiction version 3.0 plus the 64-bit System 
Addressing
+#  support in SD Host Controller Simplified Specification version 4.20.
 #
 #  It will produce EFI_SD_MMC_PASS_THRU_PROTOCOL to allow sending SD/MMC/eMMC 
cmds
 #  to specified devices from upper layer.
 #
-#  Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
+#  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
 #
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD 
License
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c 
b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
index 76c32a4dcd..b474f8decd 100644
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
@@ -1,11 +1,13 @@
 /** @file
   This driver is used to manage SD/MMC PCI host controllers which are 
compliance
-  with SD Host Controller Simplified Specification version 3.00.
+  with SD Host Controller Simplified Specification version 3.00 plus the 64-bit
+  System Addressing support in SD Host Controller Simplified Specification 
version
+  4.20.
 
   It would expose EFI_SD_MMC_PASS_THRU_PROTOCOL for upper layer use.
 
   Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
-  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
+  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
   which accompanies this distribution.  The full text of the license may be 
found at
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c 
b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
index 5aec8c6992..4c64da3b20 100644
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
@@ -1,11 +1,13 @@
 /** @file
   This driver is used to manage SD/MMC PCI host controllers which are 
compliance
-  with SD Host Controller Simplified Specification version 3.00.
+  with SD Host Controller Simplified Specification version 3.00 plus the 64-bit
+  System Addressing support in SD Host Controller Simplified Specification 
version
+  4.20.
 
   It would expose EFI_SD_MMC_PASS_THRU_PROTOCOL for upper layer use.
 
   Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
-  Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
+  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
   which accompanies this distribution.  The full text of the license may be 
found at
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni 
b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni
index 57f9fa76a1..497d2cc9f0 100644
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni
@@ -1,11 +1,12 @@
 // /** @file
 // SdMmcPciHcDxe driver is used to manage those host controllers which comply 
with SD
-// Host Controller Simplified Specifiction version 3.0.
+// Host Controller Simplified Specifiction version 3.0 plus the 64-bit System 
Addressing
+// support in SD Host Controller Simplified Specification version 4.20.
 //
 // It will produce EFI_SD_MMC_PASS_THRU_PROTOCOL to allow sending SD/MMC/eMMC 
cmds
 // to specified devices from upper layer.
 //
-// Copyright (c) 2015, Intel Corporation. All rights reserved.
+// Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
 //
 // This program and the accompanying materials
 // are licensed and made available under the terms and conditions of the BSD 
License
-- 
2.12.0.windows.1

___
edk2-devel mailing