Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-04-01 Thread Tian, Feng
Ard, I totally agree with your judgement:). PciIo.AllocateBuffer() is specific for allocating a common buffer which could be accessed by CPU and DMA simultaneously. Map() could be used to map the host/cpu address got from AllocateBuffer() to pci device address. These APIs are common for

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-04-01 Thread Ard Biesheuvel
On 31 March 2016 at 22:51, Leendert van Doorn wrote: > >> So what we may have here is either a bug in DmaLib on ARM, or a bug in the >> PCI emulation >> where it handles EfiPciIoOperationBusMasterCommonBuffer allocations >> incorrectly, since such >> buffers need to be

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-03-31 Thread Duran, Leo
Part of the answers below... > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, March 31, 2016 11:25 AM > To: Duran, Leo; Tian, Feng > Cc: edk2-devel-01; Leif Lindholm; Leendert van Doorn > Subject: Re: [PATCH] MdeModulePkg: support AHCI

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-03-31 Thread Ard Biesheuvel
On 31 March 2016 at 17:58, Ard Biesheuvel wrote: > On 31 March 2016 at 17:56, Ard Biesheuvel wrote: >> On 31 March 2016 at 17:45, Ard Biesheuvel wrote: >>> On 24 March 2016 at 21:30, Leo Duran

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-03-31 Thread Ard Biesheuvel
On 31 March 2016 at 17:56, Ard Biesheuvel wrote: > On 31 March 2016 at 17:45, Ard Biesheuvel wrote: >> On 24 March 2016 at 21:30, Leo Duran wrote: >>> From: Leendert van Doorn >>> >>>

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-03-31 Thread Ard Biesheuvel
On 31 March 2016 at 17:45, Ard Biesheuvel wrote: > On 24 March 2016 at 21:30, Leo Duran wrote: >> From: Leendert van Doorn >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Leo Duran

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-03-31 Thread Ard Biesheuvel
On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran Looking in more detail at this patch, I am a bit puzzled so please see

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-03-25 Thread Duran, Leo
endert van Doorn [mailto:leend...@paramecium.org] Sent: Friday, March 25, 2016 3:28 AM To: Tian, Feng; Duran, Leo; edk2-devel@lists.01.org Cc: leif.lindh...@linaro.org; ard.biesheu...@linaro.org Subject: Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation Wow, this is a

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-03-25 Thread Tian, Feng
AHCI controller using PCI emulation Hi Ard, On 3/25/16, 3:41 AM, "Ard Biesheuvel" <ard.biesheu...@linaro.org> wrote: >Hello Leendert, > >Thanks for the explanation. > >This does mean that the patch in its current form does not make sense. >PCI emulation is use

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-03-25 Thread Tian, Feng
gt;>-Original Message- >>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leo >>Duran >>Sent: Friday, March 25, 2016 4:30 AM >>To: edk2-devel@lists.01.org >>Cc: Leo Duran; Leendert van Doorn; leif.lindh...@linaro.org; >>ard.bies

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-03-24 Thread Tian, Feng
: support AHCI controller using PCI emulation From: Leendert van Doorn <leend...@paramecium.org> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran <leo.du...@amd.com> --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 88 +-

[edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

2016-03-24 Thread Leo Duran
From: Leendert van Doorn Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 88 +- .../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf | 1 +