Re: [edk2] [PATCH] MdeModulePkg PiSmmIpl: Add missing update to the prototype

2017-12-12 Thread Bi, Dandan 
Reviewed-by: Dandan Bi 

Thanks,
Dandan

-Original Message-
From: Zeng, Star 
Sent: Tuesday, December 12, 2017 4:16 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Bi, Dandan ; Yao, 
Jiewen 
Subject: [PATCH] MdeModulePkg PiSmmIpl: Add missing update to the prototype

It is missing to update the prototype of SmmCommunicationCommunicate() in 
d1632f694be027dee87dd18fa8172d674221face.

This patch is to add it.

Cc: Dandan Bi 
Cc: Jiewen Yao 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng 
---
 MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 24 +---
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c 
b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
index 31d2c9e45e1f..a7663ca291c4 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
@@ -90,20 +90,30 @@ SmmBase2GetSmstLocation (
   be called in physical mode prior to SetVirtualAddressMap() and in virtual 
mode 
   after SetVirtualAddressMap().
 
-  @param[in] ThisThe EFI_SMM_COMMUNICATION_PROTOCOL 
instance.
-  @param[in, out] CommBuffer  A pointer to the buffer to convey into 
SMRAM.
-  @param[in, out] CommSizeThe size of the data buffer being passed 
in.On exit, the size of data
- being returned. Zero if the handler does 
not wish to reply with any data.
+  @param[in] ThisThe EFI_SMM_COMMUNICATION_PROTOCOL instance.
+  @param[in, out] CommBuffer A pointer to the buffer to convey into SMRAM.
+  @param[in, out] CommSize   The size of the data buffer being passed in. 
On exit, the size of data
+ being returned. Zero if the handler does not 
wish to reply with any data.
+ This parameter is optional and may be NULL.
+
+  @retval EFI_SUCCESSThe message was successfully posted.
+  @retval EFI_INVALID_PARAMETER  The CommBuffer was NULL.
+  @retval EFI_BAD_BUFFER_SIZEThe buffer is too large for the MM 
implementation.
+ If this error is returned, the MessageLength 
field
+ in the CommBuffer header or the integer 
pointed by
+ CommSize, are updated to reflect the maximum 
payload
+ size the implementation can accommodate.
+  @retval EFI_ACCESS_DENIED  The CommunicateBuffer parameter or CommSize 
parameter,
+ if not omitted, are in address range that 
cannot be
+ accessed by the MM environment.
 
-  @retval EFI_SUCCESSThe message was successfully posted.
-  @retval EFI_INVALID_PARAMETER  The CommBuffer was NULL.
 **/
 EFI_STATUS
 EFIAPI
 SmmCommunicationCommunicate (
   IN CONST EFI_SMM_COMMUNICATION_PROTOCOL  *This,
   IN OUT VOID  *CommBuffer,
-  IN OUT UINTN *CommSize
+  IN OUT UINTN *CommSize OPTIONAL
   );
 
 /**
--
2.7.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] MdeModulePkg PiSmmIpl: Add missing update to the prototype

2017-12-12 Thread Star Zeng 
It is missing to update the prototype of SmmCommunicationCommunicate()
in d1632f694be027dee87dd18fa8172d674221face.

This patch is to add it.

Cc: Dandan Bi 
Cc: Jiewen Yao 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng 
---
 MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 24 +---
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c 
b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
index 31d2c9e45e1f..a7663ca291c4 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
@@ -90,20 +90,30 @@ SmmBase2GetSmstLocation (
   be called in physical mode prior to SetVirtualAddressMap() and in virtual 
mode 
   after SetVirtualAddressMap().
 
-  @param[in] ThisThe EFI_SMM_COMMUNICATION_PROTOCOL 
instance.
-  @param[in, out] CommBuffer  A pointer to the buffer to convey into 
SMRAM.
-  @param[in, out] CommSizeThe size of the data buffer being passed 
in.On exit, the size of data
- being returned. Zero if the handler does 
not wish to reply with any data.
+  @param[in] ThisThe EFI_SMM_COMMUNICATION_PROTOCOL instance.
+  @param[in, out] CommBuffer A pointer to the buffer to convey into SMRAM.
+  @param[in, out] CommSize   The size of the data buffer being passed in. 
On exit, the size of data
+ being returned. Zero if the handler does not 
wish to reply with any data.
+ This parameter is optional and may be NULL.
+
+  @retval EFI_SUCCESSThe message was successfully posted.
+  @retval EFI_INVALID_PARAMETER  The CommBuffer was NULL.
+  @retval EFI_BAD_BUFFER_SIZEThe buffer is too large for the MM 
implementation.
+ If this error is returned, the MessageLength 
field
+ in the CommBuffer header or the integer 
pointed by
+ CommSize, are updated to reflect the maximum 
payload
+ size the implementation can accommodate.
+  @retval EFI_ACCESS_DENIED  The CommunicateBuffer parameter or CommSize 
parameter,
+ if not omitted, are in address range that 
cannot be
+ accessed by the MM environment.
 
-  @retval EFI_SUCCESSThe message was successfully posted.
-  @retval EFI_INVALID_PARAMETER  The CommBuffer was NULL.
 **/
 EFI_STATUS
 EFIAPI
 SmmCommunicationCommunicate (
   IN CONST EFI_SMM_COMMUNICATION_PROTOCOL  *This,
   IN OUT VOID  *CommBuffer,
-  IN OUT UINTN *CommSize
+  IN OUT UINTN *CommSize OPTIONAL
   );
 
 /**
-- 
2.7.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel