Re: [edk2] [PATCH] MdePkg/UefiDevicePathLib: Fix print logic in DevPathToTextiSCSI

2018-09-27 Thread Kinney, Michael D
ng Li > Sent: Thursday, September 27, 2018 12:37 AM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin > ; Gao, Liming > > Subject: [edk2] [PATCH] MdePkg/UefiDevicePathLib: Fix > print logic in DevPathToTextiSCSI > > In DevPathToTextiSCSI(), ISCSIDevPath->Lun

Re: [edk2] [PATCH] MdePkg/UefiDevicePathLib: Fix print logic in DevPathToTextiSCSI

2018-09-27 Thread Li, Songpeng
The variable in memory is stored as little endian, so the byte 0 is actually stored in the last byte in memory. Best, Songpeng > -Original Message- > From: Fu, Siyuan > Sent: Thursday, September 27, 2018 3:51 PM > To: Li, Songpeng ; edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Gao,

Re: [edk2] [PATCH] MdePkg/UefiDevicePathLib: Fix print logic in DevPathToTextiSCSI

2018-09-27 Thread Fu, Siyuan
Hi, Songpeng According to the iSCSI text device note in UEFI spec, the byte 0 of LUN should come first, seems there is no problem in original code logic. Could you please double confirm that? "The LUN is an 8 byte array that is displayed in hexadecimal format with byte 0 first (i.e.,

[edk2] [PATCH] MdePkg/UefiDevicePathLib: Fix print logic in DevPathToTextiSCSI

2018-09-27 Thread Songpeng Li
In DevPathToTextiSCSI(), ISCSIDevPath->Lun is printed in reversed orders. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1216 Cc: Fu Siyuan Cc: Wu Jiaxin Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Songpeng Li ---