Re: [edk2] [PATCH] MdePkg FirmwareManagement.h: Fix code style issue
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Star Zeng > Sent: Monday, July 30, 2018 2:45 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Bi, > Dandan ; Gao, Liming > ; Zeng, Star > ; Chen, Hesheng > > Subject: [edk2] [PATCH] MdePkg FirmwareManagement.h: > Fix code style issue > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Dandan Bi > Cc: Hess Chen > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > MdePkg/Include/Protocol/FirmwareManagement.h | 8 - > --- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git > a/MdePkg/Include/Protocol/FirmwareManagement.h > b/MdePkg/Include/Protocol/FirmwareManagement.h > index 7c8f1ce65ded..fdd5a7f2a34c 100644 > --- a/MdePkg/Include/Protocol/FirmwareManagement.h > +++ b/MdePkg/Include/Protocol/FirmwareManagement.h > @@ -317,11 +317,11 @@ EFI_STATUS >This function allows a copy of the current firmware > image to be created and saved. >The saved copy could later been used, for example, > in firmware image recovery or rollback. > > - @param[in] This A pointer to the > EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance. > - @param[in] ImageIndex A unique number > identifying the firmware image(s) within the device. > + @param[in] This A pointer to the > EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance. > + @param[in] ImageIndex A unique number > identifying the firmware image(s) within the device. > The number is between > 1 and DescriptorCount. > - @param[out] Image Points to the buffer > where the current image is copied to. > - @param[out] ImageSize On entry, points to > the size of the buffer pointed to by Image, in bytes. > + @param[in, out] Image Points to the buffer > where the current image is copied to. > + @param[in, out] ImageSize On entry, points to > the size of the buffer pointed to by Image, in bytes. > On return, points to > the length of the image, in bytes. > >@retval EFI_SUCCESSThe device was > successfully updated with the new image. > -- > 2.7.0.windows.1 > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] MdePkg FirmwareManagement.h: Fix code style issue
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Monday, July 30, 2018 5:45 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Bi, Dandan ; Gao, Liming ; Zeng, Star ; Chen, Hesheng Subject: [edk2] [PATCH] MdePkg FirmwareManagement.h: Fix code style issue Cc: Michael D Kinney Cc: Liming Gao Cc: Dandan Bi Cc: Hess Chen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdePkg/Include/Protocol/FirmwareManagement.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h b/MdePkg/Include/Protocol/FirmwareManagement.h index 7c8f1ce65ded..fdd5a7f2a34c 100644 --- a/MdePkg/Include/Protocol/FirmwareManagement.h +++ b/MdePkg/Include/Protocol/FirmwareManagement.h @@ -317,11 +317,11 @@ EFI_STATUS This function allows a copy of the current firmware image to be created and saved. The saved copy could later been used, for example, in firmware image recovery or rollback. - @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance. - @param[in] ImageIndex A unique number identifying the firmware image(s) within the device. + @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance. + @param[in] ImageIndex A unique number identifying the firmware image(s) within the device. The number is between 1 and DescriptorCount. - @param[out] Image Points to the buffer where the current image is copied to. - @param[out] ImageSize On entry, points to the size of the buffer pointed to by Image, in bytes. + @param[in, out] Image Points to the buffer where the current image is copied to. + @param[in, out] ImageSize On entry, points to the size of the buffer pointed to by Image, in bytes. On return, points to the length of the image, in bytes. @retval EFI_SUCCESSThe device was successfully updated with the new image. -- 2.7.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH] MdePkg FirmwareManagement.h: Fix code style issue
Cc: Michael D Kinney Cc: Liming Gao Cc: Dandan Bi Cc: Hess Chen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdePkg/Include/Protocol/FirmwareManagement.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h b/MdePkg/Include/Protocol/FirmwareManagement.h index 7c8f1ce65ded..fdd5a7f2a34c 100644 --- a/MdePkg/Include/Protocol/FirmwareManagement.h +++ b/MdePkg/Include/Protocol/FirmwareManagement.h @@ -317,11 +317,11 @@ EFI_STATUS This function allows a copy of the current firmware image to be created and saved. The saved copy could later been used, for example, in firmware image recovery or rollback. - @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance. - @param[in] ImageIndex A unique number identifying the firmware image(s) within the device. + @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance. + @param[in] ImageIndex A unique number identifying the firmware image(s) within the device. The number is between 1 and DescriptorCount. - @param[out] Image Points to the buffer where the current image is copied to. - @param[out] ImageSize On entry, points to the size of the buffer pointed to by Image, in bytes. + @param[in, out] Image Points to the buffer where the current image is copied to. + @param[in, out] ImageSize On entry, points to the size of the buffer pointed to by Image, in bytes. On return, points to the length of the image, in bytes. @retval EFI_SUCCESSThe device was successfully updated with the new image. -- 2.7.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
