Re: [edk2] [PATCH 0/3] Optimizing code

[Zhu, Yonghong]

Reviewed-by: Yonghong Zhu 

Best Regards,
Zhu Yonghong


-Original Message-
From: Feng, YunhuaX 
Sent: Wednesday, August 08, 2018 2:55 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong ; Gao, Liming 
Subject: [PATCH 0/3] Optimizing code

Modify class OrderedListDict, remove cmp and use hashlib instead of
md5

Yunhua Feng (3):
  BaseTools: Modify class OrderedListDict
  BaseTools: remove cmp due to deprecated in python3
  BaseTools: Use hashlib instead of md5

 BaseTools/Source/Python/AutoGen/AutoGen.py|  6 +++---
 BaseTools/Source/Python/BPDG/GenVpd.py|  4 ++--
 BaseTools/Source/Python/UPT/GenMetaFile/GenDecFile.py |  4 ++--  
BaseTools/Source/Python/UPT/GenMetaFile/GenInfFile.py |  4 ++--
 BaseTools/Source/Python/UPT/InstallPkg.py | 12 ++--
 BaseTools/Source/Python/UPT/MkPkg.py  |  4 ++--
 BaseTools/Source/Python/UPT/RmPkg.py  |  4 ++--
 BaseTools/Source/Python/Workspace/MetaFileParser.py   |  6 +++---
 BaseTools/Source/Python/Workspace/WorkspaceCommon.py  |  6 +-
 9 files changed, 27 insertions(+), 23 deletions(-)

--
2.12.2.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/3] Optimizing code

[Laszlo Ersek]

Hello Yunhua,

On 08/08/18 08:54, Feng, YunhuaX wrote:
> Modify class OrderedListDict, remove cmp and use hashlib instead of
> md5
> 
> Yunhua Feng (3):
>   BaseTools: Modify class OrderedListDict
>   BaseTools: remove cmp due to deprecated in python3
>   BaseTools: Use hashlib instead of md5
> 
>  BaseTools/Source/Python/AutoGen/AutoGen.py|  6 +++---
>  BaseTools/Source/Python/BPDG/GenVpd.py|  4 ++--
>  BaseTools/Source/Python/UPT/GenMetaFile/GenDecFile.py |  4 ++--
>  BaseTools/Source/Python/UPT/GenMetaFile/GenInfFile.py |  4 ++--
>  BaseTools/Source/Python/UPT/InstallPkg.py | 12 ++--
>  BaseTools/Source/Python/UPT/MkPkg.py  |  4 ++--
>  BaseTools/Source/Python/UPT/RmPkg.py  |  4 ++--
>  BaseTools/Source/Python/Workspace/MetaFileParser.py   |  6 +++---
>  BaseTools/Source/Python/Workspace/WorkspaceCommon.py  |  6 +-
>  9 files changed, 27 insertions(+), 23 deletions(-)
> 

please post patch sets with "shallow threading" enabled -- the cover
letter (0/3) should be posted as a standalone message, and then each of
the patches (1/3, 2/3, 3/3) should be posted as a response to the 0/3
cover letter.

git config format.coverletter true
git config format.numberedtrue
git config sendemail.chainreplyto false
git config sendemail.thread   true

(From
.)

(No need to repost the series just because of this.)

Thanks!
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 0/3] Optimizing code

[Feng, YunhuaX]

Modify class OrderedListDict, remove cmp and use hashlib instead of
md5

Yunhua Feng (3):
  BaseTools: Modify class OrderedListDict
  BaseTools: remove cmp due to deprecated in python3
  BaseTools: Use hashlib instead of md5

 BaseTools/Source/Python/AutoGen/AutoGen.py|  6 +++---
 BaseTools/Source/Python/BPDG/GenVpd.py|  4 ++--
 BaseTools/Source/Python/UPT/GenMetaFile/GenDecFile.py |  4 ++--
 BaseTools/Source/Python/UPT/GenMetaFile/GenInfFile.py |  4 ++--
 BaseTools/Source/Python/UPT/InstallPkg.py | 12 ++--
 BaseTools/Source/Python/UPT/MkPkg.py  |  4 ++--
 BaseTools/Source/Python/UPT/RmPkg.py  |  4 ++--
 BaseTools/Source/Python/Workspace/MetaFileParser.py   |  6 +++---
 BaseTools/Source/Python/Workspace/WorkspaceCommon.py  |  6 +-
 9 files changed, 27 insertions(+), 23 deletions(-)

-- 
2.12.2.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel