Re: [edk2] [PATCH 0/4] ArmVirtPkg: add empty varstore definition to ArmVirtQemu
On 22 June 2016 at 16:46, Leif Lindholm wrote: > On Tue, Jun 21, 2016 at 12:30:30PM +0200, Ard Biesheuvel wrote: >> This series refactors some of the NOR flash code in ArmPlatformPkg and >> ArmVirtPkg so that we can add an empty varstore definition to the >> ArmVirtQemu amd ArmVirtQemuKernel FDFs. The refactoring is necessary to make >> NorFlashDxe deal with either of the GUIDs gEfiAuthenticatedVariableGuid and >> gEfiVariableGuid in the varstore FV headers, and is an improvement by itself, >> since it allows us to get rid of the 'secure boot' flavor of NorFlashDxe. > > > >> Ard Biesheuvel (4): >> ArmPlatformPkg/NorFlashDxe: accept both non-secure and secure varstore >> GUIDs > > For 1/4: > Reviewed-by: Leif Lindholm > >> ArmVirtPkg/ArmVirtQemu: switch secure boot build to NorFlashDxe >> ArmPlatformPkg/NorFlashAuthenticatedDxe: remove this obsolete module > > For 3/4: > Reviewed-by: Leif Lindholm > Thanks. As suggested by Laszlo, I have merged the first three patches 8753858f8476 ArmPlatformPkg/NorFlashDxe: accept both non-secure and secure varstore GUIDs 146961937861 ArmVirtPkg/ArmVirtQemu: switch secure boot build to NorFlashDxe 3460c75dfe95 ArmPlatformPkg/NorFlashAuthenticatedDxe: remove this obsolete module ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/4] ArmVirtPkg: add empty varstore definition to ArmVirtQemu
On Tue, Jun 21, 2016 at 12:30:30PM +0200, Ard Biesheuvel wrote: > This series refactors some of the NOR flash code in ArmPlatformPkg and > ArmVirtPkg so that we can add an empty varstore definition to the > ArmVirtQemu amd ArmVirtQemuKernel FDFs. The refactoring is necessary to make > NorFlashDxe deal with either of the GUIDs gEfiAuthenticatedVariableGuid and > gEfiVariableGuid in the varstore FV headers, and is an improvement by itself, > since it allows us to get rid of the 'secure boot' flavor of NorFlashDxe. > Ard Biesheuvel (4): > ArmPlatformPkg/NorFlashDxe: accept both non-secure and secure varstore > GUIDs For 1/4: Reviewed-by: Leif Lindholm > ArmVirtPkg/ArmVirtQemu: switch secure boot build to NorFlashDxe > ArmPlatformPkg/NorFlashAuthenticatedDxe: remove this obsolete module For 3/4: Reviewed-by: Leif Lindholm > ArmVirtPkg: add FDF definition for empty varstore > > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedDxe.inf | 77 > --- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedVariableDep.c | 19 > - > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.h | 2 - > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf| 2 +- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c | 5 +- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashVariableDep.c | 19 > - > ArmVirtPkg/ArmVirtQemu.dsc| 4 - > ArmVirtPkg/ArmVirtQemu.fdf| 5 +- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 4 - > ArmVirtPkg/ArmVirtQemuKernel.fdf | 5 +- > ArmVirtPkg/VarStore.fdf.inc | 79 > > 11 files changed, 85 insertions(+), 136 deletions(-) > delete mode 100644 > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedDxe.inf > delete mode 100644 > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedVariableDep.c > delete mode 100644 ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashVariableDep.c > create mode 100644 ArmVirtPkg/VarStore.fdf.inc > > -- > 2.7.4 > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/4] ArmVirtPkg: add empty varstore definition to ArmVirtQemu
On 06/21/16 12:30, Ard Biesheuvel wrote: > This series refactors some of the NOR flash code in ArmPlatformPkg and > ArmVirtPkg so that we can add an empty varstore definition to the > ArmVirtQemu amd ArmVirtQemuKernel FDFs. The refactoring is necessary to make > NorFlashDxe deal with either of the GUIDs gEfiAuthenticatedVariableGuid and > gEfiVariableGuid in the varstore FV headers, and is an improvement by itself, > since it allows us to get rid of the 'secure boot' flavor of NorFlashDxe. Hm... Okay. With the unification of the authenticated and non-authenticated variable drivers, we've been able to do the following in OvmfPkg: https://github.com/tianocore/edk2/commit/d92eaabefbe06 >From a quick skim, your patch set seems to move in the same direction. It might make sense to reference the above commit hash in one (or more?) of your patches. Anyway, I'll look at the patches individually. Thanks! Laszlo > > Ard Biesheuvel (4): > ArmPlatformPkg/NorFlashDxe: accept both non-secure and secure varstore > GUIDs > ArmVirtPkg/ArmVirtQemu: switch secure boot build to NorFlashDxe > ArmPlatformPkg/NorFlashAuthenticatedDxe: remove this obsolete module > ArmVirtPkg: add FDF definition for empty varstore > > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedDxe.inf | 77 > --- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedVariableDep.c | 19 > - > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.h | 2 - > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf| 2 +- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c | 5 +- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashVariableDep.c | 19 > - > ArmVirtPkg/ArmVirtQemu.dsc| 4 - > ArmVirtPkg/ArmVirtQemu.fdf| 5 +- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 4 - > ArmVirtPkg/ArmVirtQemuKernel.fdf | 5 +- > ArmVirtPkg/VarStore.fdf.inc | 79 > > 11 files changed, 85 insertions(+), 136 deletions(-) > delete mode 100644 > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedDxe.inf > delete mode 100644 > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedVariableDep.c > delete mode 100644 ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashVariableDep.c > create mode 100644 ArmVirtPkg/VarStore.fdf.inc > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH 0/4] ArmVirtPkg: add empty varstore definition to ArmVirtQemu
This series refactors some of the NOR flash code in ArmPlatformPkg and ArmVirtPkg so that we can add an empty varstore definition to the ArmVirtQemu amd ArmVirtQemuKernel FDFs. The refactoring is necessary to make NorFlashDxe deal with either of the GUIDs gEfiAuthenticatedVariableGuid and gEfiVariableGuid in the varstore FV headers, and is an improvement by itself, since it allows us to get rid of the 'secure boot' flavor of NorFlashDxe. Ard Biesheuvel (4): ArmPlatformPkg/NorFlashDxe: accept both non-secure and secure varstore GUIDs ArmVirtPkg/ArmVirtQemu: switch secure boot build to NorFlashDxe ArmPlatformPkg/NorFlashAuthenticatedDxe: remove this obsolete module ArmVirtPkg: add FDF definition for empty varstore ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedDxe.inf | 77 --- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedVariableDep.c | 19 - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.h | 2 - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf| 2 +- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c | 5 +- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashVariableDep.c | 19 - ArmVirtPkg/ArmVirtQemu.dsc| 4 - ArmVirtPkg/ArmVirtQemu.fdf| 5 +- ArmVirtPkg/ArmVirtQemuKernel.dsc | 4 - ArmVirtPkg/ArmVirtQemuKernel.fdf | 5 +- ArmVirtPkg/VarStore.fdf.inc | 79 11 files changed, 85 insertions(+), 136 deletions(-) delete mode 100644 ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedDxe.inf delete mode 100644 ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashAuthenticatedVariableDep.c delete mode 100644 ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashVariableDep.c create mode 100644 ArmVirtPkg/VarStore.fdf.inc -- 2.7.4 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
