On 27 November 2015 at 16:11, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Thu, Nov 26, 2015 at 01:10:45PM +0100, Ard Biesheuvel wrote: >> As pointed out by Eugene, the use of the ArmPlatformGlobalVariableLib to >> store >> the PEI services pointer violates the PI spec, since it prevents PEI modules >> built from a different code base from running under our firmware. >> >> So instead, use the thread ID CPU registers, both for the PEI services table >> pointer (as the PI spec mandates), but also for the HOB list pointer that is >> recorded in the ArmGlobalVariable region when running under PrePi. >> >> After this change, no users of ArmPlatformGlobalVariableLib remain, so we can >> remove all implementations, and all plubming in the early init code in the >> various PrePi and PrePeiCore modules that allocate the global variable >> region. >> >> Ard Biesheuvel (23): > > ... > >> 68 files changed, 29 insertions(+), 1214 deletions(-) > > Spectacular :) >
Yes, I quite enjoyed that :-) > For anywhere in the series you want/need it: > Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > Thanks. Committed as SVN r18982 ... r19004 > As a side note, this means the pruning of pre-v7 support from EDK2 was > actually completely non-controversial, since the PI spec does not > permit such platforms. > Indeed, if it was controversial in the first place :-) -- Ard. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
