Re: [edk2] [PATCH 03/26] Vlv2TbltDevicePkg: assume GCC48 or later

2019-01-03 Thread Sun, Zailiang
Reviewed-by: Zailiang Sun 

> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, January 3, 2019 10:48 AM
> To: edk2-devel-01 
> Cc: Sun, Zailiang ; Qian, Yi 
> Subject: [PATCH 03/26] Vlv2TbltDevicePkg: assume GCC48 or later
> 
> We're about to remove BaseTools support for GCC44..GCC47. Bump the
> assumption about the minimum gcc version to GCC48 in
> "Vlv2TbltDevicePkg/bld_vlv.sh".
> 
> No GCC44..GCC47 references remain under Vlv2TbltDevicePkg after this
> patch.
> 
> Cc: Zailiang Sun 
> Cc: Yi Qian 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek 
> ---
> 
> Notes:
> Untested.
> 
>  Vlv2TbltDevicePkg/bld_vlv.sh | 14 +-
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/Vlv2TbltDevicePkg/bld_vlv.sh b/Vlv2TbltDevicePkg/bld_vlv.sh
> index 538b3ef9d730..51d3acacb48b 100755
> --- a/Vlv2TbltDevicePkg/bld_vlv.sh
> +++ b/Vlv2TbltDevicePkg/bld_vlv.sh
> @@ -179,23 +179,11 @@ sed -i '/^MAX_CONCURRENT_THREAD_NUMBER/d'
> Conf/target.txt
> 
>  gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}')
>  case $gcc_version in
> -4.5.*)
> -  TARGET_TOOLS=GCC45
> -  ;;
> -4.6.*)
> -  TARGET_TOOLS=GCC46
> -  ;;
> -4.7.*)
> -  TARGET_TOOLS=GCC47
> -  ;;
> -4.8.*)
> -  TARGET_TOOLS=GCC48
> -  ;;
>  4.9.*|4.1[0-9].*|5.*.*|6.*.*)
>TARGET_TOOLS=GCC49
>;;
>  *)
> -  TARGET_TOOLS=GCC44
> +  TARGET_TOOLS=GCC48
>;;
>  esac
> 
> --
> 2.19.1.3.g30247aa5d201
> 

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] [PATCH 03/26] Vlv2TbltDevicePkg: assume GCC48 or later

2019-01-02 Thread Laszlo Ersek
We're about to remove BaseTools support for GCC44..GCC47. Bump the
assumption about the minimum gcc version to GCC48 in
"Vlv2TbltDevicePkg/bld_vlv.sh".

No GCC44..GCC47 references remain under Vlv2TbltDevicePkg after this
patch.

Cc: Zailiang Sun 
Cc: Yi Qian 
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek 
---

Notes:
Untested.

 Vlv2TbltDevicePkg/bld_vlv.sh | 14 +-
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/Vlv2TbltDevicePkg/bld_vlv.sh b/Vlv2TbltDevicePkg/bld_vlv.sh
index 538b3ef9d730..51d3acacb48b 100755
--- a/Vlv2TbltDevicePkg/bld_vlv.sh
+++ b/Vlv2TbltDevicePkg/bld_vlv.sh
@@ -179,23 +179,11 @@ sed -i '/^MAX_CONCURRENT_THREAD_NUMBER/d' Conf/target.txt
 
 gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}')
 case $gcc_version in
-4.5.*)
-  TARGET_TOOLS=GCC45
-  ;;
-4.6.*)
-  TARGET_TOOLS=GCC46
-  ;;
-4.7.*)
-  TARGET_TOOLS=GCC47
-  ;;
-4.8.*)
-  TARGET_TOOLS=GCC48
-  ;;
 4.9.*|4.1[0-9].*|5.*.*|6.*.*)
   TARGET_TOOLS=GCC49
   ;;
 *)
-  TARGET_TOOLS=GCC44
+  TARGET_TOOLS=GCC48
   ;;
 esac
 
-- 
2.19.1.3.g30247aa5d201


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel