Re: [edk2] [PATCH 1/1] BaseTools: Fix regression boot hang issue by commit 0e982cf03dd5

2018-10-15 Thread Zhu, Yonghong 
I pushed this patch first since it helped to fix the critical bug.
Version: SHA-1: 272ecccd793c8fb12f4f356ada18a870c2426603

Best Regards,
Zhu Yonghong


-Original Message-
From: Zhu, Yonghong 
Sent: Monday, October 15, 2018 6:18 PM
To: Feng, YunhuaX ; edk2-devel@lists.01.org
Cc: Gao, Liming ; Zhu, Yonghong 
Subject: RE: [PATCH 1/1] BaseTools: Fix regression boot hang issue by commit 
0e982cf03dd5

Reviewed-by: Yonghong Zhu  

Best Regards,
Zhu Yonghong


-Original Message-
From: Feng, YunhuaX 
Sent: Monday, October 15, 2018 5:04 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong ; Gao, Liming 
Subject: [PATCH 1/1] BaseTools: Fix regression boot hang issue by commit 
0e982cf03dd5

Fix regression boot hang issue by commit 
0e982cf03dd5023b90def60c3656e5e18135ebac

Cc: Liming Gao 
Cc: Yonghong Zhu 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng 
---
 BaseTools/Source/Python/GenFds/Fv.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/GenFds/Fv.py 
b/BaseTools/Source/Python/GenFds/Fv.py
index 510f2834a8..c66fc38327 100644
--- a/BaseTools/Source/Python/GenFds/Fv.py
+++ b/BaseTools/Source/Python/GenFds/Fv.py
@@ -202,12 +202,12 @@ class FV (FvClassObject):
 Signature = FvHeaderBuffer[0x28:0x32]
 if Signature and Signature.startswith('_FVH'):
 GenFdsGlobalVariable.VerboseLogger("\nGenerate %s FV 
Successfully" % self.UiFvName)
 GenFdsGlobalVariable.SharpCounter = 0
 
-Buffer.write(FvFileObj.read())
 FvFileObj.seek(0)
+Buffer.write(FvFileObj.read())
 # FV alignment position.
 FvAlignmentValue = 1 << (ord(FvHeaderBuffer[0x2E]) & 0x1F)
 if FvAlignmentValue >= 0x400:
 if FvAlignmentValue >= 0x10:
 if FvAlignmentValue >= 0x100:
-- 
2.12.2.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 1/1] BaseTools: Fix regression boot hang issue by commit 0e982cf03dd5

2018-10-15 Thread Zhu, Yonghong 
Reviewed-by: Yonghong Zhu  

Best Regards,
Zhu Yonghong


-Original Message-
From: Feng, YunhuaX 
Sent: Monday, October 15, 2018 5:04 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong ; Gao, Liming 
Subject: [PATCH 1/1] BaseTools: Fix regression boot hang issue by commit 
0e982cf03dd5

Fix regression boot hang issue by commit 
0e982cf03dd5023b90def60c3656e5e18135ebac

Cc: Liming Gao 
Cc: Yonghong Zhu 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng 
---
 BaseTools/Source/Python/GenFds/Fv.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/GenFds/Fv.py 
b/BaseTools/Source/Python/GenFds/Fv.py
index 510f2834a8..c66fc38327 100644
--- a/BaseTools/Source/Python/GenFds/Fv.py
+++ b/BaseTools/Source/Python/GenFds/Fv.py
@@ -202,12 +202,12 @@ class FV (FvClassObject):
 Signature = FvHeaderBuffer[0x28:0x32]
 if Signature and Signature.startswith('_FVH'):
 GenFdsGlobalVariable.VerboseLogger("\nGenerate %s FV 
Successfully" % self.UiFvName)
 GenFdsGlobalVariable.SharpCounter = 0
 
-Buffer.write(FvFileObj.read())
 FvFileObj.seek(0)
+Buffer.write(FvFileObj.read())
 # FV alignment position.
 FvAlignmentValue = 1 << (ord(FvHeaderBuffer[0x2E]) & 0x1F)
 if FvAlignmentValue >= 0x400:
 if FvAlignmentValue >= 0x10:
 if FvAlignmentValue >= 0x100:
-- 
2.12.2.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 1/1] BaseTools: Fix regression boot hang issue by commit 0e982cf03dd5

2018-10-15 Thread Feng, YunhuaX 
Fix regression boot hang issue by commit 
0e982cf03dd5023b90def60c3656e5e18135ebac

Cc: Liming Gao 
Cc: Yonghong Zhu 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng 
---
 BaseTools/Source/Python/GenFds/Fv.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/GenFds/Fv.py 
b/BaseTools/Source/Python/GenFds/Fv.py
index 510f2834a8..c66fc38327 100644
--- a/BaseTools/Source/Python/GenFds/Fv.py
+++ b/BaseTools/Source/Python/GenFds/Fv.py
@@ -202,12 +202,12 @@ class FV (FvClassObject):
 Signature = FvHeaderBuffer[0x28:0x32]
 if Signature and Signature.startswith('_FVH'):
 GenFdsGlobalVariable.VerboseLogger("\nGenerate %s FV 
Successfully" % self.UiFvName)
 GenFdsGlobalVariable.SharpCounter = 0
 
-Buffer.write(FvFileObj.read())
 FvFileObj.seek(0)
+Buffer.write(FvFileObj.read())
 # FV alignment position.
 FvAlignmentValue = 1 << (ord(FvHeaderBuffer[0x2E]) & 0x1F)
 if FvAlignmentValue >= 0x400:
 if FvAlignmentValue >= 0x10:
 if FvAlignmentValue >= 0x100:
-- 
2.12.2.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel