Re: [edk2] [PATCH 1/2] PcAtChipsetPkg/PcRtc: Fix a stack corruption issue

2016-07-26 Thread Dong, Eric 
Reviewed-by: Eric Dong 

> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, July 26, 2016 9:12 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric
> Subject: [PATCH 1/2] PcAtChipsetPkg/PcRtc: Fix a stack corruption issue
> 
> In 32bit environment, ScanTableInSDT() incorrectly copies 8 bytes
> of data to 4-byte pointer Table, which causes the stack corruption.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni 
> Cc: Eric Dong 
> ---
>  PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c 
> b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c
> index b86c1f4..40d2e49 100644
> --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c
> +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c
> @@ -1271,7 +1271,7 @@ GetCenturyRtcAddress (
>Fadt = NULL;
>if (Rsdp->Revision >= 
> EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER_REVISION) {
>  Xsdt = (EFI_ACPI_DESCRIPTION_HEADER *) (UINTN) Rsdp->XsdtAddress;
> -Fadt = ScanTableInSDT (Xsdt, 
> EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, sizeof (UINT64));
> +Fadt = ScanTableInSDT (Xsdt, 
> EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, sizeof (UINTN));
>}
> 
>if (Fadt == NULL) {
> --
> 2.9.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 1/2] PcAtChipsetPkg/PcRtc: Fix a stack corruption issue

2016-07-26 Thread Ruiyu Ni 
In 32bit environment, ScanTableInSDT() incorrectly copies 8 bytes
of data to 4-byte pointer Table, which causes the stack corruption.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni 
Cc: Eric Dong 
---
 PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c 
b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c
index b86c1f4..40d2e49 100644
--- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c
+++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c
@@ -1271,7 +1271,7 @@ GetCenturyRtcAddress (
   Fadt = NULL;
   if (Rsdp->Revision >= EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER_REVISION) 
{
 Xsdt = (EFI_ACPI_DESCRIPTION_HEADER *) (UINTN) Rsdp->XsdtAddress;
-Fadt = ScanTableInSDT (Xsdt, 
EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, sizeof (UINT64));
+Fadt = ScanTableInSDT (Xsdt, 
EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, sizeof (UINTN));
   }
 
   if (Fadt == NULL) {
-- 
2.9.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel