Re: [edk2] [PATCH 15/15] ArmVirtPkg: remove ArmPlatformLib implementations

2017-11-21 Thread Laszlo Ersek 
On 11/17/17 17:09, Ard Biesheuvel wrote:
> These libraries are no longer used, so remove them from the tree.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel 
> ---
>  ArmVirtPkg/ArmVirtQemuKernel.dsc 
>   |   1 -
>  ArmVirtPkg/ArmVirtXen.dsc
>   |   1 -
>  
> ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/AARCH64/RelocatableVirtHelper.S
>| 141 -
>  ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/ARM/RelocatableVirtHelper.S 
>   | 123 ---
>  
> ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/ArmQemuRelocatablePlatformLib.inf
>  |  64 
>  ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/FdtParser.c 
>   |  90 ---
>  ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/QemuVirtMem.c   
>   | 106 -
>  ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/RelocatableVirt.c   
>   |  70 -
>  ArmVirtPkg/Library/ArmVirtPlatformLib/AARCH64/VirtHelper.S   
>   |  70 -
>  ArmVirtPkg/Library/ArmVirtPlatformLib/ARM/VirtHelper.S   
>   |  57 ---
>  ArmVirtPkg/Library/ArmVirtPlatformLib/ARM/VirtHelper.asm 
>   |  71 -
>  ArmVirtPkg/Library/ArmVirtPlatformLib/ArmVirtPlatformLib.inf 
>   |  64 
>  ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c 
>   | 160 
>  ArmVirtPkg/Library/ArmVirtPlatformLib/VirtMem.c  
>   | 102 -
>  
> ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/AARCH64/RelocatableVirtHelper.S
> | 140 -
>  ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/ARM/RelocatableVirtHelper.S  
>   | 123 ---
>  
> ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/ArmXenRelocatablePlatformLib.inf
>|  63 
>  ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/FdtParser.c  
>   |  89 ---
>  ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/RelocatableVirt.c
>   |  70 -
>  ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/XenVirtMem.c 
>   |  82 --
>  20 files changed, 1687 deletions(-)

This feels awesome.

Reviewed-by: Laszlo Ersek 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 15/15] ArmVirtPkg: remove ArmPlatformLib implementations

2017-11-17 Thread Ard Biesheuvel 
These libraries are no longer used, so remove them from the tree.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel 
---
 ArmVirtPkg/ArmVirtQemuKernel.dsc   
|   1 -
 ArmVirtPkg/ArmVirtXen.dsc  
|   1 -
 
ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/AARCH64/RelocatableVirtHelper.S
   | 141 -
 ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/ARM/RelocatableVirtHelper.S   
| 123 ---
 
ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/ArmQemuRelocatablePlatformLib.inf
 |  64 
 ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/FdtParser.c   
|  90 ---
 ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/QemuVirtMem.c 
| 106 -
 ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/RelocatableVirt.c 
|  70 -
 ArmVirtPkg/Library/ArmVirtPlatformLib/AARCH64/VirtHelper.S 
|  70 -
 ArmVirtPkg/Library/ArmVirtPlatformLib/ARM/VirtHelper.S 
|  57 ---
 ArmVirtPkg/Library/ArmVirtPlatformLib/ARM/VirtHelper.asm   
|  71 -
 ArmVirtPkg/Library/ArmVirtPlatformLib/ArmVirtPlatformLib.inf   
|  64 
 ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c   
| 160 
 ArmVirtPkg/Library/ArmVirtPlatformLib/VirtMem.c
| 102 -
 
ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/AARCH64/RelocatableVirtHelper.S 
   | 140 -
 ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/ARM/RelocatableVirtHelper.S
| 123 ---
 
ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/ArmXenRelocatablePlatformLib.inf
   |  63 
 ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/FdtParser.c
|  89 ---
 ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/RelocatableVirt.c  
|  70 -
 ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/XenVirtMem.c   
|  82 --
 20 files changed, 1687 deletions(-)

diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
index f50d30388cf2..cc2c5a50c925 100644
--- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
+++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
@@ -48,7 +48,6 @@ [LibraryClasses.common]
   QemuFwCfgLib|ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf
   QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf
 
-  
ArmPlatformLib|ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/ArmQemuRelocatablePlatformLib.inf
   
ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.inf
 
   TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
index 3df684d13cb0..11e073287a84 100644
--- a/ArmVirtPkg/ArmVirtXen.dsc
+++ b/ArmVirtPkg/ArmVirtXen.dsc
@@ -43,7 +43,6 @@ [LibraryClasses]
   VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf
   
VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf
 
-  
ArmPlatformLib|ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/ArmXenRelocatablePlatformLib.inf
   ArmVirtMemInfoLib|ArmVirtPkg/Library/XenVirtMemInfoLib/XenVirtMemInfoLib.inf
 
   TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
diff --git 
a/ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/AARCH64/RelocatableVirtHelper.S
 
b/ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/AARCH64/RelocatableVirtHelper.S
deleted file mode 100644
index ec6955cf0af8..
--- 
a/ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/AARCH64/RelocatableVirtHelper.S
+++ /dev/null
@@ -1,141 +0,0 @@
-#
-#  Copyright (c) 2011-2013, ARM Limited. All rights reserved.
-#  Copyright (c) 2016, Linaro Limited. All rights reserved.
-#
-#  This program and the accompanying materials
-#  are licensed and made available under the terms and conditions of the BSD 
License
-#  which accompanies this distribution.  The full text of the license may be 
found at
-#  http://opensource.org/licenses/bsd-license.php
-#
-#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
IMPLIED.
-#
-#
-
-#include 
-#include 
-
-// VOID
-// ArmPlatformPeiBootAction (
-//   VOID   *DeviceTreeBaseAddress,   // passed by loader in x0
-//   VOID   *ImageBase// passed by FDF trampoline in x1
-//   );
-ASM_FUNC(ArmPlatformPeiBootAction)
-  //
-  // If we are booting from RAM using the Linux kernel boot protocol, x0 will
-  // point to the DTB image in memory. Otherwise, use the default value defined
-  // by the platform.
-  //
-  cbnz  x0, 0f
-  ldr   x0, PcdGet64 (PcdDeviceTreeInitialBaseAddress)
-
-0:mov   x29, x30// preserve LR
-  mov