Re: [edk2] [PATCH 2/2] MdeModulePkg/EbcDxe: cleanup

2016-08-05 Thread Ard Biesheuvel
On 5 August 2016 at 21:24, Daniil Egranov wrote: > Hi Ard, > > > > On 08/01/2016 09:22 AM, Ard Biesheuvel wrote: >> >> - indentation >> - premature optimization of the thunking code, i.e., align function >> prototypes >>so we don't have to move arguments around or

Re: [edk2] [PATCH 2/2] MdeModulePkg/EbcDxe: cleanup

2016-08-05 Thread Daniil Egranov
Hi Ard, On 08/01/2016 09:22 AM, Ard Biesheuvel wrote: - indentation - premature optimization of the thunking code, i.e., align function prototypes so we don't have to move arguments around or duplicate them on the stack, and perform tail calls where possible - adhere to calling

[edk2] [PATCH 2/2] MdeModulePkg/EbcDxe: cleanup

2016-08-01 Thread Ard Biesheuvel
- indentation - premature optimization of the thunking code, i.e., align function prototypes so we don't have to move arguments around or duplicate them on the stack, and perform tail calls where possible - adhere to calling convention (stack frame layout) - replace instruction buffer with a