Re: [edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib

2019-03-28 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ray > Sent: Thursday, March 28, 2019 6:50 PM > To: Zhang, Shenglei ; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib > Importance: High > > Reviewed-by: Ray Ni > > >

Re: [edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib

2019-03-28 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Zhang, Shenglei > Sent: Friday, March 29, 2019 9:41 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib > > With Itanium architecture unsupported,

[edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib

2019-03-28 Thread Shenglei Zhang
With Itanium architecture unsupported, gEfiSalSystemTableGuid and gEfiMpsTableGuid will be no longer used. https://bugzilla.tianocore.org/show_bug.cgi?id=1560 Cc: Jaben Carsey Cc: Ray Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

Re: [edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable

2016-03-24 Thread Qiu, Shumin
Hi Ard, Thanks for catching this. Reviewed-by: Qiu Shumin -Shumin -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, March 24, 2016 2:28 PM To: edk2-devel@lists.01.org; ler...@redhat.com; Gao, Liming; Zeng, Star; Tian,

Re: [edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable

2016-03-24 Thread Laszlo Ersek
On 03/24/16 07:28, Ard Biesheuvel wrote: > Remove variable FStartRow that is declared, assigned but never referenced. > This fixes a warning emitted by GCC when -Wunused-but-set-variable is in > effect. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable

2016-03-24 Thread Ard Biesheuvel
Remove variable FStartRow that is declared, assigned but never referenced. This fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---