Re: [edk2] [PATCH 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature.

2019-01-27 Thread Wu, Hao A
Hello, A general-level comment: I saw the implementation of function FatFindGptPartitions() has been added in this patch. But unlike functions: FatFindMbrPartitions() FatFindEltoritoPartitions() I did not see FatFindGptPartitions() being called within the FatPei driver. Is it supposed to be

Re: [edk2] [PATCH 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature.

2019-01-23 Thread Chen, Chen A
Hi Ray and Hao Do you have any comments for this patch? -Original Message- From: Zhang, Chao B Sent: Wednesday, January 23, 2019 2:22 PM To: Chen, Chen A ; edk2-devel@lists.01.org Cc: Ni, Ray Subject: RE: [PATCH 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature.

Re: [edk2] [PATCH 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature.

2019-01-22 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: Chen, Chen A Sent: Thursday, January 17, 2019 10:03 AM To: edk2-devel@lists.01.org Cc: Chen, Chen A ; Ni, Ray ; Zhang, Chao B Subject: [PATCH 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature. BZ:

Re: [edk2] [PATCH 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature.

2019-01-22 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Wu, Hao A > Sent: Wednesday, January 23, 2019 9:25 AM > To: Ni, Ray; Chen, Chen A; edk2-devel@lists.01.org > Cc: Zhang, Chao B > Subject: Re: [edk2] [PATCH 3/3] FatPkg: Add GPT check in FatPei

[edk2] [PATCH 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature.

2019-01-16 Thread Chen A Chen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1470 This feature is used for finding GPT partition, follow the following step to check. 1) Check Protective MBR. 2) Check GPT primary/backup header. 3) Check GPT primary/backup entry array. Cc: Ruiyu Ni Cc: Zhang Chao B Contributed-under: