Re: [edk2] [PATCH 4/4] ArmPkg/Mmu: Increase PageLevel when table found at the targeted level

2015-09-07 Thread Ard Biesheuvel
On 6 September 2015 at 10:15, Heyi Guo wrote: > Below code has bug since *BlockEntrySize and *TableLevel are not > updated accordingly: > > if (IndexLevel == PageLevel) { > // And get the appropriate BlockEntry at the next level > BlockEntry = (UINT64*)TT_GET_ENTRY_FOR_ADDRESS (TranslationTabl

Re: [edk2] [PATCH 4/4] ArmPkg/Mmu: Increase PageLevel when table found at the targeted level

2015-09-07 Thread Ard Biesheuvel
On 7 September 2015 at 11:16, Heyi Guo wrote: > > > On 09/06/2015 09:42 PM, Ard Biesheuvel wrote: >> >> On 6 September 2015 at 10:15, Heyi Guo wrote: >>> >>> Below code has bug since *BlockEntrySize and *TableLevel are not >>> updated accordingly: >>> >>> if (IndexLevel == PageLevel) { >>>//

Re: [edk2] [PATCH 4/4] ArmPkg/Mmu: Increase PageLevel when table found at the targeted level

2015-09-07 Thread Heyi Guo
On 09/06/2015 09:42 PM, Ard Biesheuvel wrote: On 6 September 2015 at 10:15, Heyi Guo wrote: Below code has bug since *BlockEntrySize and *TableLevel are not updated accordingly: if (IndexLevel == PageLevel) { // And get the appropriate BlockEntry at the next level BlockEntry = (UINT64*

Re: [edk2] [PATCH 4/4] ArmPkg/Mmu: Increase PageLevel when table found at the targeted level

2015-09-06 Thread Ard Biesheuvel
On 6 September 2015 at 10:15, Heyi Guo wrote: > Below code has bug since *BlockEntrySize and *TableLevel are not > updated accordingly: > > if (IndexLevel == PageLevel) { > // And get the appropriate BlockEntry at the next level > BlockEntry = (UINT64*)TT_GET_ENTRY_FOR_ADDRESS (TranslationTabl

[edk2] [PATCH 4/4] ArmPkg/Mmu: Increase PageLevel when table found at the targeted level

2015-09-06 Thread Heyi Guo
Below code has bug since *BlockEntrySize and *TableLevel are not updated accordingly: if (IndexLevel == PageLevel) { // And get the appropriate BlockEntry at the next level BlockEntry = (UINT64*)TT_GET_ENTRY_FOR_ADDRESS (TranslationTable, \ IndexLevel + 1, RegionStart); // Set the las