Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs
Liming, We need to look at how to remove those dependencies now so the entire package can be retired. For example the only consumer of 8259 is the 8254 driver. The 8254 module can be replaced with the HPET driver that does not use 8259 at all. If we can convert all platforms that are currently using 8254 to use HPET instead, we can make a big step towards removing the entire package. Mike > -Original Message- > From: Gao, Liming > Sent: Sunday, November 18, 2018 9:16 PM > To: Kinney, Michael D ; > Zhang, Shenglei ; Ni, Ruiyu > ; edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: RE: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove > the redundant INFs > > Mike: > The long term goal is to remove IntelFrameworkPkg. I > propose to remove its contents step by step. Now, some > unused modules or header files are very clear. They can > be removed now. But, others (such as Legacy definitions) > are still consumed by LegacyBios and 8259/8254 drivers. > We have no solution or clear plan to drop legacy support. > They may still be kept for a while. > > Thanks > Liming > >-Original Message- > >From: Kinney, Michael D > >Sent: Wednesday, November 14, 2018 1:18 PM > >To: Zhang, Shenglei ; Ni, > Ruiyu > >; edk2-devel@lists.01.org; Kinney, > Michael D > > > >Cc: Gao, Liming > >Subject: RE: [edk2] [PATCH 6/8] IntelFrameworkPkg: > Remove the redundant > >INFs > > > >Shenglei, > > > >I would prefer we work towards the goal of removing > >the use of the Intel Framework Packages by all platforms > >so the entire packages can be removed from edk2/master. > > > >This would be better than trying to remove a few items > >at a time. > > > >Thanks, > > > >Mike > > > >> -----Original Message- > >> From: Zhang, Shenglei > >> Sent: Tuesday, November 13, 2018 7:32 PM > >> To: Ni, Ruiyu ; edk2- > >> de...@lists.01.org > >> Cc: Kinney, Michael D ; > >> Gao, Liming > >> Subject: RE: [edk2] [PATCH 6/8] IntelFrameworkPkg: > >> Remove the redundant INFs > >> > >> Ray > >> Thanks for your constructive comments. I'll improve it > >> in next version. > >> > >> Thanks, > >> Shenglei > >> > -Original Message- > >> > From: Ni, Ruiyu > >> > Sent: Wednesday, November 14, 2018 11:12 AM > >> > To: Zhang, Shenglei ; > edk2- > >> de...@lists.01.org > >> > Cc: Kinney, Michael D ; > >> Gao, Liming > >> > > >> > Subject: Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: > >> Remove the redundant > >> > INFs > >> > > >> > On 11/13/2018 4:35 PM, Shenglei Zhang wrote: > >> > > All INFs of unused Library instances in > >> IntelFrameworkPkg > >> > > are removed as they are not actually used. > >> > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1190 > >> > > > >> > > Cc: Liming Gao > >> > > Cc: Michael D Kinney > >> > > Contributed-under: TianoCore Contribution > Agreement > >> 1.1 > >> > > Signed-off-by: Shenglei Zhang > >> > >> > > --- > >> > > IntelFrameworkPkg/IntelFrameworkPkg.dsc | 7 > - > >> -- > >> > > 1 file changed, 7 deletions(-) > >> > > > >> > > diff --git > >> a/IntelFrameworkPkg/IntelFrameworkPkg.dsc > >> > b/IntelFrameworkPkg/IntelFrameworkPkg.dsc > >> > > index bd5df8c5d9..802a80e3eb 100644 > >> > > --- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc > >> > > +++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc > >> > > @@ -63,13 +63,6 @@ > >> > > # generated for it, but the binary will > not > >> be put into any firmware > >> > volume. > >> > > # > >> > > > >> > > >> > ### > >> ### > >> > # > >> > > -[Components] > >> > > - > >> > IntelFrameworkPkg/Library/DxeIoLibCpuIo/DxeIoLibCpuIo.i > >> nf > >> > > - > >> > IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUef > >> iLib.inf > >> > > - > >> > > >> > IntelFrameworkPkg/Library/DxeSmmDriverEntryPoint/DxeSmm > >> DriverEntryP > >> > oint.inf > >> > > - > >> > > >> > IntelFrameworkPkg/Library/PeiSmbusLibSmbusPpi/PeiSmbusL > >> ibSmbusPpi.in > >> > f > >> > > - > >> > > >> > IntelFrameworkPkg/Library/PeiHobLibFramework/PeiHobLibF > >> ramework.inf > >> > > - > >> > > [BuildOptions] > >> > > *_*_*_CC_FLAGS = -D > >> DISABLE_NEW_DEPRECATED_INTERFACES > >> > > > >> > > > >> > Shenglei, > >> > You cannot remove the INF in the separate patch like > >> this. > >> > You should either put this patch in the first patch > >> in your serial, > >> > or combine the DSC change with your library removal. > >> > The goal is the the build won't fail when committing > >> the patches one by one. > >> > > >> > -- > >> > Thanks, > >> > Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs
Mike: The long term goal is to remove IntelFrameworkPkg. I propose to remove its contents step by step. Now, some unused modules or header files are very clear. They can be removed now. But, others (such as Legacy definitions) are still consumed by LegacyBios and 8259/8254 drivers. We have no solution or clear plan to drop legacy support. They may still be kept for a while. Thanks Liming >-Original Message- >From: Kinney, Michael D >Sent: Wednesday, November 14, 2018 1:18 PM >To: Zhang, Shenglei ; Ni, Ruiyu >; edk2-devel@lists.01.org; Kinney, Michael D > >Cc: Gao, Liming >Subject: RE: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant >INFs > >Shenglei, > >I would prefer we work towards the goal of removing >the use of the Intel Framework Packages by all platforms >so the entire packages can be removed from edk2/master. > >This would be better than trying to remove a few items >at a time. > >Thanks, > >Mike > >> -Original Message- >> From: Zhang, Shenglei >> Sent: Tuesday, November 13, 2018 7:32 PM >> To: Ni, Ruiyu ; edk2- >> de...@lists.01.org >> Cc: Kinney, Michael D ; >> Gao, Liming >> Subject: RE: [edk2] [PATCH 6/8] IntelFrameworkPkg: >> Remove the redundant INFs >> >> Ray >> Thanks for your constructive comments. I'll improve it >> in next version. >> >> Thanks, >> Shenglei >> > -Original Message- >> > From: Ni, Ruiyu >> > Sent: Wednesday, November 14, 2018 11:12 AM >> > To: Zhang, Shenglei ; edk2- >> de...@lists.01.org >> > Cc: Kinney, Michael D ; >> Gao, Liming >> > >> > Subject: Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: >> Remove the redundant >> > INFs >> > >> > On 11/13/2018 4:35 PM, Shenglei Zhang wrote: >> > > All INFs of unused Library instances in >> IntelFrameworkPkg >> > > are removed as they are not actually used. >> > > https://bugzilla.tianocore.org/show_bug.cgi?id=1190 >> > > >> > > Cc: Liming Gao >> > > Cc: Michael D Kinney >> > > Contributed-under: TianoCore Contribution Agreement >> 1.1 >> > > Signed-off-by: Shenglei Zhang >> >> > > --- >> > > IntelFrameworkPkg/IntelFrameworkPkg.dsc | 7 - >> -- >> > > 1 file changed, 7 deletions(-) >> > > >> > > diff --git >> a/IntelFrameworkPkg/IntelFrameworkPkg.dsc >> > b/IntelFrameworkPkg/IntelFrameworkPkg.dsc >> > > index bd5df8c5d9..802a80e3eb 100644 >> > > --- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc >> > > +++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc >> > > @@ -63,13 +63,6 @@ >> > > # generated for it, but the binary will not >> be put into any firmware >> > volume. >> > > # >> > > >> > >> ### >> ### >> > # >> > > -[Components] >> > > - >> IntelFrameworkPkg/Library/DxeIoLibCpuIo/DxeIoLibCpuIo.i >> nf >> > > - >> IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUef >> iLib.inf >> > > - >> > >> IntelFrameworkPkg/Library/DxeSmmDriverEntryPoint/DxeSmm >> DriverEntryP >> > oint.inf >> > > - >> > >> IntelFrameworkPkg/Library/PeiSmbusLibSmbusPpi/PeiSmbusL >> ibSmbusPpi.in >> > f >> > > - >> > >> IntelFrameworkPkg/Library/PeiHobLibFramework/PeiHobLibF >> ramework.inf >> > > - >> > > [BuildOptions] >> > > *_*_*_CC_FLAGS = -D >> DISABLE_NEW_DEPRECATED_INTERFACES >> > > >> > > >> > Shenglei, >> > You cannot remove the INF in the separate patch like >> this. >> > You should either put this patch in the first patch >> in your serial, >> > or combine the DSC change with your library removal. >> > The goal is the the build won't fail when committing >> the patches one by one. >> > >> > -- >> > Thanks, >> > Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs
Shenglei, I would prefer we work towards the goal of removing the use of the Intel Framework Packages by all platforms so the entire packages can be removed from edk2/master. This would be better than trying to remove a few items at a time. Thanks, Mike > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, November 13, 2018 7:32 PM > To: Ni, Ruiyu ; edk2- > de...@lists.01.org > Cc: Kinney, Michael D ; > Gao, Liming > Subject: RE: [edk2] [PATCH 6/8] IntelFrameworkPkg: > Remove the redundant INFs > > Ray > Thanks for your constructive comments. I'll improve it > in next version. > > Thanks, > Shenglei > > -Original Message- > > From: Ni, Ruiyu > > Sent: Wednesday, November 14, 2018 11:12 AM > > To: Zhang, Shenglei ; edk2- > de...@lists.01.org > > Cc: Kinney, Michael D ; > Gao, Liming > > > > Subject: Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: > Remove the redundant > > INFs > > > > On 11/13/2018 4:35 PM, Shenglei Zhang wrote: > > > All INFs of unused Library instances in > IntelFrameworkPkg > > > are removed as they are not actually used. > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1190 > > > > > > Cc: Liming Gao > > > Cc: Michael D Kinney > > > Contributed-under: TianoCore Contribution Agreement > 1.1 > > > Signed-off-by: Shenglei Zhang > > > > --- > > > IntelFrameworkPkg/IntelFrameworkPkg.dsc | 7 - > -- > > > 1 file changed, 7 deletions(-) > > > > > > diff --git > a/IntelFrameworkPkg/IntelFrameworkPkg.dsc > > b/IntelFrameworkPkg/IntelFrameworkPkg.dsc > > > index bd5df8c5d9..802a80e3eb 100644 > > > --- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc > > > +++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc > > > @@ -63,13 +63,6 @@ > > > # generated for it, but the binary will not > be put into any firmware > > volume. > > > # > > > > > > ### > ### > > # > > > -[Components] > > > - > IntelFrameworkPkg/Library/DxeIoLibCpuIo/DxeIoLibCpuIo.i > nf > > > - > IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUef > iLib.inf > > > - > > > IntelFrameworkPkg/Library/DxeSmmDriverEntryPoint/DxeSmm > DriverEntryP > > oint.inf > > > - > > > IntelFrameworkPkg/Library/PeiSmbusLibSmbusPpi/PeiSmbusL > ibSmbusPpi.in > > f > > > - > > > IntelFrameworkPkg/Library/PeiHobLibFramework/PeiHobLibF > ramework.inf > > > - > > > [BuildOptions] > > > *_*_*_CC_FLAGS = -D > DISABLE_NEW_DEPRECATED_INTERFACES > > > > > > > > Shenglei, > > You cannot remove the INF in the separate patch like > this. > > You should either put this patch in the first patch > in your serial, > > or combine the DSC change with your library removal. > > The goal is the the build won't fail when committing > the patches one by one. > > > > -- > > Thanks, > > Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs
On 11/13/2018 4:35 PM, Shenglei Zhang wrote: All INFs of unused Library instances in IntelFrameworkPkg are removed as they are not actually used. https://bugzilla.tianocore.org/show_bug.cgi?id=1190 Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- IntelFrameworkPkg/IntelFrameworkPkg.dsc | 7 --- 1 file changed, 7 deletions(-) diff --git a/IntelFrameworkPkg/IntelFrameworkPkg.dsc b/IntelFrameworkPkg/IntelFrameworkPkg.dsc index bd5df8c5d9..802a80e3eb 100644 --- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc +++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc @@ -63,13 +63,6 @@ # generated for it, but the binary will not be put into any firmware volume. # ### -[Components] - IntelFrameworkPkg/Library/DxeIoLibCpuIo/DxeIoLibCpuIo.inf - IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUefiLib.inf - IntelFrameworkPkg/Library/DxeSmmDriverEntryPoint/DxeSmmDriverEntryPoint.inf - IntelFrameworkPkg/Library/PeiSmbusLibSmbusPpi/PeiSmbusLibSmbusPpi.inf - IntelFrameworkPkg/Library/PeiHobLibFramework/PeiHobLibFramework.inf - [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Shenglei, You cannot remove the INF in the separate patch like this. You should either put this patch in the first patch in your serial, or combine the DSC change with your library removal. The goal is the the build won't fail when committing the patches one by one. -- Thanks, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs
All INFs of unused Library instances in IntelFrameworkPkg are removed as they are not actually used. https://bugzilla.tianocore.org/show_bug.cgi?id=1190 Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- IntelFrameworkPkg/IntelFrameworkPkg.dsc | 7 --- 1 file changed, 7 deletions(-) diff --git a/IntelFrameworkPkg/IntelFrameworkPkg.dsc b/IntelFrameworkPkg/IntelFrameworkPkg.dsc index bd5df8c5d9..802a80e3eb 100644 --- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc +++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc @@ -63,13 +63,6 @@ # generated for it, but the binary will not be put into any firmware volume. # ### -[Components] - IntelFrameworkPkg/Library/DxeIoLibCpuIo/DxeIoLibCpuIo.inf - IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUefiLib.inf - IntelFrameworkPkg/Library/DxeSmmDriverEntryPoint/DxeSmmDriverEntryPoint.inf - IntelFrameworkPkg/Library/PeiSmbusLibSmbusPpi/PeiSmbusLibSmbusPpi.inf - IntelFrameworkPkg/Library/PeiHobLibFramework/PeiHobLibFramework.inf - [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES -- 2.18.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
