Reviewed-by: Erik Bjorge
> -Original Message-
> From: Leahy, Leroy P
> Sent: Friday, March 4, 2016 2:19 PM
> To: Kinney, Michael D ; Steele, Kelly
> ; edk2-devel@lists.01.org; Bjorge, Erik C
>
Reviewed-by: Kelly Steele
> -Original Message-
> From: Leahy, Leroy P
> Sent: March 04, 2016 14:19
> To: Kinney, Michael D ; Steele, Kelly
> ; edk2-devel@lists.01.org; Bjorge, Erik C
>
Move the baud rate setting to the top of the .dsc file. Use a single
setting for each board.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy
---
QuarkPlatformPkg/Quark.dsc| 25 -
QuarkPlatformPkg/QuarkMin.dsc
Hi Lee,
I like the idea of setting the BAUD rate in one place.
Do we really need the extra defines for GEN1_BAUD_RATE and GEN2_BAUD_RATE?
With BAUD_RATE define, I can set the GALILEO board type and the BAUD_RATE from
the command line using /D flags for just those two if I want to override. I
Reviewed-by: Kelly Steele
> -Original Message-
> From: Leahy, Leroy P
> Sent: March 04, 2016 09:03
> To: Kinney, Michael D ; Steele, Kelly
> ; edk2-devel@lists.01.org; Bjorge, Erik C
>
Reviewed-by: Erik Bjorge
> -Original Message-
> From: Leahy, Leroy P
> Sent: Friday, March 4, 2016 9:03 AM
> To: Kinney, Michael D ; Steele, Kelly
> ; edk2-devel@lists.01.org; Bjorge, Erik C
>
Move the baud rate setting to the top of the .dsc file. Use a single
setting for each board.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy
---
QuarkPlatformPkg/Quark.dsc | 28 +++-
1 file changed, 15
7 matches
Mail list logo