Re: [edk2] [PATCH edk2-platforms 0/4] Platform/ARM: import BdsLib and FdtPlatformDxe

2017-11-26 Thread Ard Biesheuvel 
On 25 November 2017 at 13:28, Leif Lindholm  wrote:
> On Mon, Nov 20, 2017 at 11:37:10AM +, Ard Biesheuvel wrote:
>> The only remnant of the deprecated ARM BDS in EDK2 is its BdsLib, which is
>> depended upon by FdtPlatformDxe in EmbeddedPkg, which itself is something
>> we'd prefer to get rid of. Since only TC2 and Juno actually use this driver,
>> let's move both FdtPlatformDxe and BdsLib under Platform/ARM, so that we can
>> remove it from the main EDK2 repository.
>
> I see no issue with this series as such (and agree with its intent).
> However, on the EDK2 side, we still have some users of BdsLib in the
> EmbeddedPkg Android loaders.
>
> (I have sent out a trivial series to get rid of these, but this move
> should be ordered against that set.)
>
> Once that's in, for the series:
> Reviewed-by: Leif Lindholm 
>

Thanks. Pushed as 4591a21d5a8e..9bf000f2bd38
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms 0/4] Platform/ARM: import BdsLib and FdtPlatformDxe

2017-11-25 Thread Leif Lindholm 
On Mon, Nov 20, 2017 at 11:37:10AM +, Ard Biesheuvel wrote:
> The only remnant of the deprecated ARM BDS in EDK2 is its BdsLib, which is
> depended upon by FdtPlatformDxe in EmbeddedPkg, which itself is something
> we'd prefer to get rid of. Since only TC2 and Juno actually use this driver,
> let's move both FdtPlatformDxe and BdsLib under Platform/ARM, so that we can
> remove it from the main EDK2 repository.

I see no issue with this series as such (and agree with its intent).
However, on the EDK2 side, we still have some users of BdsLib in the
EmbeddedPkg Android loaders.

(I have sent out a trivial series to get rid of these, but this move
should be ordered against that set.)

Once that's in, for the series:
Reviewed-by: Leif Lindholm 

/
Leif

> Ard Biesheuvel (4):
>   Platform/ARM: import BdsLib from ArmPkg
>   Platform/ARM: import FdtPlatformDxe driver from EDK2
>   Platform/ARM/Juno: move to migrated FdtPlatformDxe
>   Platform/TC2: move to private FdtPlatformDxe implementation
>
>  Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.c  |  461 +++
>  Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.h  |  174 +++
>  Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.dec |   31 +
>  Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf |   65 +
>  Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni |  109 ++
>  Platform/ARM/Drivers/FdtPlatformDxe/README.txt |   72 +
>  Platform/ARM/Drivers/FdtPlatformDxe/ShellDumpFdt.c |  279 
>  Platform/ARM/Drivers/FdtPlatformDxe/ShellSetFdt.c  |  468 +++
>  Platform/ARM/JunoPkg/ArmJuno.dsc   |6 +-
>  Platform/ARM/JunoPkg/ArmJuno.fdf   |2 +-
>  Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf |3 +-
>  Platform/ARM/Library/BdsLib/BdsAppLoader.c |  253 
>  Platform/ARM/Library/BdsLib/BdsFilePath.c  | 1413 
> 
>  Platform/ARM/Library/BdsLib/BdsHelper.c|  183 +++
>  Platform/ARM/Library/BdsLib/BdsInternal.h  |  111 ++
>  Platform/ARM/Library/BdsLib/BdsLib.inf |   62 +
>  Platform/ARM/Library/BdsLib/BdsLoadOption.c|  272 
>  Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc  |6 +-
>  Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf  |2 +-
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc   |5 +-
>  20 files changed, 3964 insertions(+), 13 deletions(-)
>  create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.c
>  create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.h
>  create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.dec
>  create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf
>  create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni
>  create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/README.txt
>  create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/ShellDumpFdt.c
>  create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/ShellSetFdt.c
>  create mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c
>  create mode 100644 Platform/ARM/Library/BdsLib/BdsFilePath.c
>  create mode 100644 Platform/ARM/Library/BdsLib/BdsHelper.c
>  create mode 100644 Platform/ARM/Library/BdsLib/BdsInternal.h
>  create mode 100644 Platform/ARM/Library/BdsLib/BdsLib.inf
>  create mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c
> 
> -- 
> 2.11.0
> 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH edk2-platforms 0/4] Platform/ARM: import BdsLib and FdtPlatformDxe

2017-11-20 Thread Ard Biesheuvel 
The only remnant of the deprecated ARM BDS in EDK2 is its BdsLib, which is
depended upon by FdtPlatformDxe in EmbeddedPkg, which itself is something
we'd prefer to get rid of. Since only TC2 and Juno actually use this driver,
let's move both FdtPlatformDxe and BdsLib under Platform/ARM, so that we can
remove it from the main EDK2 repository.

Ard Biesheuvel (4):
  Platform/ARM: import BdsLib from ArmPkg
  Platform/ARM: import FdtPlatformDxe driver from EDK2
  Platform/ARM/Juno: move to migrated FdtPlatformDxe
  Platform/TC2: move to private FdtPlatformDxe implementation

 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.c  |  461 +++
 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.h  |  174 +++
 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.dec |   31 +
 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf |   65 +
 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni |  109 ++
 Platform/ARM/Drivers/FdtPlatformDxe/README.txt |   72 +
 Platform/ARM/Drivers/FdtPlatformDxe/ShellDumpFdt.c |  279 
 Platform/ARM/Drivers/FdtPlatformDxe/ShellSetFdt.c  |  468 +++
 Platform/ARM/JunoPkg/ArmJuno.dsc   |6 +-
 Platform/ARM/JunoPkg/ArmJuno.fdf   |2 +-
 Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf |3 +-
 Platform/ARM/Library/BdsLib/BdsAppLoader.c |  253 
 Platform/ARM/Library/BdsLib/BdsFilePath.c  | 1413 

 Platform/ARM/Library/BdsLib/BdsHelper.c|  183 +++
 Platform/ARM/Library/BdsLib/BdsInternal.h  |  111 ++
 Platform/ARM/Library/BdsLib/BdsLib.inf |   62 +
 Platform/ARM/Library/BdsLib/BdsLoadOption.c|  272 
 Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc  |6 +-
 Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf  |2 +-
 Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc   |5 +-
 20 files changed, 3964 insertions(+), 13 deletions(-)
 create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.c
 create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.h
 create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.dec
 create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf
 create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni
 create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/README.txt
 create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/ShellDumpFdt.c
 create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/ShellSetFdt.c
 create mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c
 create mode 100644 Platform/ARM/Library/BdsLib/BdsFilePath.c
 create mode 100644 Platform/ARM/Library/BdsLib/BdsHelper.c
 create mode 100644 Platform/ARM/Library/BdsLib/BdsInternal.h
 create mode 100644 Platform/ARM/Library/BdsLib/BdsLib.inf
 create mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c

-- 
2.11.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel