Re: [edk2] [PATCH v1 12/18] StandaloneMmPkg/CpuMm: Add CPU driver suitable for ARM Platforms.

2018-05-04 Thread Supreeth Venkatesh
com; liming@intel.com; michael.d.kin...@intel.com Subject: Re: [edk2] [PATCH v1 12/18] StandaloneMmPkg/CpuMm: Add CPU driver suitable for ARM Platforms. Hi Supreeth, I am not sure how much it enforced in edk2 but in most of the cases, the driver's name matches its directory name. [Supr

Re: [edk2] [PATCH v1 12/18] StandaloneMmPkg/CpuMm: Add CPU driver suitable for ARM Platforms.

2018-05-04 Thread Supreeth Venkatesh
My response inline. -Original Message- From: Achin Gupta Sent: Monday, April 30, 2018 10:51 AM To: Supreeth Venkatesh Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com; jiewen@intel.com; leif.lindh...@linaro.org;

Re: [edk2] [PATCH v1 12/18] StandaloneMmPkg/CpuMm: Add CPU driver suitable for ARM Platforms.

2018-04-30 Thread Achin Gupta
Hi Supreeth, Usual comment about copyright years and invalid comments. I also noticed some TODOs and have provided comments for them. Please see inline On Fri, Apr 06, 2018 at 03:42:17PM +0100, Supreeth Venkatesh wrote: > This patch adds a simple CPU driver that exports the >

Re: [edk2] [PATCH v1 12/18] StandaloneMmPkg/CpuMm: Add CPU driver suitable for ARM Platforms.

2018-04-18 Thread Daniil Egranov
Hi Supreeth, I am not sure how much it enforced in edk2 but in most of the cases, the driver's name matches its directory name. Thanks, Daniil On 04/06/2018 09:42 AM, Supreeth Venkatesh wrote: This patch adds a simple CPU driver that exports the EFI_MM_CONFIGURATION_PROTOCOL to allow

[edk2] [PATCH v1 12/18] StandaloneMmPkg/CpuMm: Add CPU driver suitable for ARM Platforms.

2018-04-06 Thread Supreeth Venkatesh
This patch adds a simple CPU driver that exports the EFI_MM_CONFIGURATION_PROTOCOL to allow registration of the Standalone MM Foundation entry point. It preserves the existing notification mechanism for the configuration protocol. Contributed-under: TianoCore Contribution Agreement 1.1