Re: [edk2] [PATCH v2] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

2016-03-07 Thread Shia, Cinnamon
Hi Mike, Thanks for your feedbacks. It make sense to me. Will fix it in patch v3 and update the commit message for the new changes. Thanks, Cinnamon Shia -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, March 8, 2016 12:13 AM To: Shia,

Re: [edk2] [PATCH v2] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

2016-03-07 Thread Kinney, Michael D
Cinnamon, How about the following changes: 1) Use a PCD name of PcdMaxPeiPerformanceLogEntries16 to show it is 16-bits. Also allows for more expansion if we need more than 16-bits later. 2) Make the default value of PcdMaxPeiPerformanceLogEntries16 be 0, which is the disabled value. 3) Use

Re: [edk2] [PATCH v2] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

2016-03-07 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer EL-Haj-Mahmoud -Original Message- From: Shia, Cinnamon Sent: Monday, March 7, 2016 1:57 AM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer ; Shia, Cinnamon Subject: [PATCH v2] MdeModulePkg:

[edk2] [PATCH v2] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

2016-03-06 Thread Cinnamon Shia
Change the type of PcdMaxPeiPerformanceLogEntries from UINT8 to UINT16 to log more than 255 performance entries in PEI. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- .../DxeCorePerformanceLib/DxeCorePerformanceLib.c| 5 -