Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Ni, Ruiyu
On 3/7/2018 12:28 PM, Wu, Hao A wrote: Hi Ray, Below are the answers to your feedbacks: -Original Message- From: Yao, Jiewen Sent: Wednesday, March 07, 2018 12:14 PM To: Wang, Jian J; Ni, Ruiyu; Wu, Hao A; edk2-devel@lists.01.org Cc: Zeng, Star; Dong, Eric Subject: RE: [PATCH v2 0/2] R

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Wu, Hao A
Hi Ray, Below are the answers to your feedbacks: > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, March 07, 2018 12:14 PM > To: Wang, Jian J; Ni, Ruiyu; Wu, Hao A; edk2-devel@lists.01.org > Cc: Zeng, Star; Dong, Eric > Subject: RE: [PATCH v2 0/2] Resolve feature conflict betwee

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Yao, Jiewen
I think the original patch is fine. StackBase is already checked by using ASSERT before. > +ASSERT ((StackBase & EFI_PAGE_MASK) == 0); MemMap entry must be page aligned. No additional check is required here. Thank you Yao Jiewen > -Original Message- > From: Wang, Jian J > Sent

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Wang, Jian J
Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, March 07, 2018 11:17 AM > To: Wu, Hao A ; edk2-devel@lists.01.org > Cc: Wang, Jian J ; Zeng, Star ; > Dong, Eric ; Yao, Jiewen > Subject: Re: [PATCH v2 0/2] Resolve feature conflict between NX and Stack > guard >

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Ni, Ruiyu
On 3/6/2018 9:33 PM, Hao Wu wrote: V2 changes: A. Use Hoblib APIs to get the base of stack from Hob. B. Remove unnecessary local variable used in function InitializeDxeNxMemoryProtectionPolicy(). V1 history: If enabled, NX memory protection feature will mark some types of active memory as

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Wang, Jian J
Thanks for fixing the issue. For this patch series: Reviewed-by: Jian J Wang > -Original Message- > From: Wu, Hao A > Sent: Tuesday, March 06, 2018 9:33 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Zeng, Star ; Dong, Eric ; Yao, > Jiewen ; Ni, Ruiyu > Subject: [P

[edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Hao Wu
V2 changes: A. Use Hoblib APIs to get the base of stack from Hob. B. Remove unnecessary local variable used in function InitializeDxeNxMemoryProtectionPolicy(). V1 history: If enabled, NX memory protection feature will mark some types of active memory as NX (non-executable), which includes th