Re: [edk2] [PATCH v2 05/11] StandaloneMmPkg/StandaloneMmCoreEntryPoint: add missing SerialPortLib ref

2019-01-18 Thread Yao, Jiewen
That would be even better. Thanks Ard. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, January 18, 2019 7:32 AM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org; Achin Gupta ; > Supreeth Venkatesh ; Leif Lindholm > ; Jagadeesh Ujja ; > Thomas

Re: [edk2] [PATCH v2 05/11] StandaloneMmPkg/StandaloneMmCoreEntryPoint: add missing SerialPortLib ref

2019-01-18 Thread Ard Biesheuvel
On Fri, 18 Jan 2019 at 16:27, Yao, Jiewen wrote: > > Usually, we do not encourage to use SerialPortLib directly in a hardware > independent environment. > I do not suggest we bring an architecture dependency on the existence of > SerialPort in a common code. > > However, if ARCH64 has some

Re: [edk2] [PATCH v2 05/11] StandaloneMmPkg/StandaloneMmCoreEntryPoint: add missing SerialPortLib ref

2019-01-18 Thread Yao, Jiewen
Usually, we do not encourage to use SerialPortLib directly in a hardware independent environment. I do not suggest we bring an architecture dependency on the existence of SerialPort in a common code. However, if ARCH64 has some specific code that must use SerialPortLib explicitly, I am OK. Can

[edk2] [PATCH v2 05/11] StandaloneMmPkg/StandaloneMmCoreEntryPoint: add missing SerialPortLib ref

2019-01-16 Thread Ard Biesheuvel
StandaloneMmCoreEntryPoint calls SerialPortInitialize() explicitly, so add SerialPortLib to its list of LibraryClasses. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Supreeth Venkatesh ---